ethtool: cosmetic: Use ethtool ethtool_cmd_speed API

This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.

For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.

All drivers compiled with make allyesconfig ion x86_64 have been
updated.

Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 3 deletions

diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index 909cc4b2a2f3..a69331e06b8d 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
@@ -1807,8 +1807,8 @@ static int b44_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
         if (bp->flags & B44_FLAG_ADV_100FULL)
                 cmd->advertising |= ADVERTISED_100baseT_Full;
         cmd->advertising |= ADVERTISED_Pause | ADVERTISED_Asym_Pause;
-        cmd->speed = (bp->flags & B44_FLAG_100_BASE_T) ?
-                SPEED_100 : SPEED_10;
+        ethtool_cmd_speed_set(cmd, ((bp->flags & B44_FLAG_100_BASE_T) ?
+                                    SPEED_100 : SPEED_10));
         cmd->duplex = (bp->flags & B44_FLAG_FULL_DUPLEX) ?
                 DUPLEX_FULL : DUPLEX_HALF;
         cmd->port = 0;
@@ -1820,7 +1820,7 @@ static int b44_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
         if (cmd->autoneg == AUTONEG_ENABLE)
                 cmd->advertising |= ADVERTISED_Autoneg;
         if (!netif_running(dev)){
-                cmd->speed = 0;
+                ethtool_cmd_speed_set(cmd, 0);
                 cmd->duplex = 0xff;
         }
         cmd->maxtxpkt = 0;