diff options
author | David Decotigny <decot@google.com> | 2011-04-27 14:32:40 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-04-29 17:03:01 -0400 |
commit | 707394972093e2056e1e8cc39be19cf9bcb3e7b3 (patch) | |
tree | f6dc95219bca6895adf304b79241e9d60561f8f5 /drivers/net/atl1e | |
parent | 25db0338813a8915457636b1f6abe6a28fa73f8d (diff) |
ethtool: cosmetic: Use ethtool ethtool_cmd_speed API
This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.
For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.
All drivers compiled with make allyesconfig ion x86_64 have been
updated.
Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/atl1e')
-rw-r--r-- | drivers/net/atl1e/atl1e_ethtool.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c index 47783749d9fa..6269438d365f 100644 --- a/drivers/net/atl1e/atl1e_ethtool.c +++ b/drivers/net/atl1e/atl1e_ethtool.c | |||
@@ -51,13 +51,13 @@ static int atl1e_get_settings(struct net_device *netdev, | |||
51 | ecmd->transceiver = XCVR_INTERNAL; | 51 | ecmd->transceiver = XCVR_INTERNAL; |
52 | 52 | ||
53 | if (adapter->link_speed != SPEED_0) { | 53 | if (adapter->link_speed != SPEED_0) { |
54 | ecmd->speed = adapter->link_speed; | 54 | ethtool_cmd_speed_set(ecmd, adapter->link_speed); |
55 | if (adapter->link_duplex == FULL_DUPLEX) | 55 | if (adapter->link_duplex == FULL_DUPLEX) |
56 | ecmd->duplex = DUPLEX_FULL; | 56 | ecmd->duplex = DUPLEX_FULL; |
57 | else | 57 | else |
58 | ecmd->duplex = DUPLEX_HALF; | 58 | ecmd->duplex = DUPLEX_HALF; |
59 | } else { | 59 | } else { |
60 | ecmd->speed = -1; | 60 | ethtool_cmd_speed_set(ecmd, -1); |
61 | ecmd->duplex = -1; | 61 | ecmd->duplex = -1; |
62 | } | 62 | } |
63 | 63 | ||