diff options
author | Wang Chen <wangchen@cn.fujitsu.com> | 2008-11-13 02:37:49 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-11-13 02:37:49 -0500 |
commit | 454d7c9b14e20fd1949e2686e9de4a2926e01476 (patch) | |
tree | fae8bd1bfb5fd496977a0639ad71c54a2ee278ae /drivers/net/appletalk | |
parent | 7a12122c7a00347da9669cfcde82954c9e3d6f5e (diff) |
netdevice: safe convert to netdev_priv() #part-1
We have some reasons to kill netdev->priv:
1. netdev->priv is equal to netdev_priv().
2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
netdev_priv() is more flexible than netdev->priv.
But we cann't kill netdev->priv, because so many drivers reference to it
directly.
This patch is a safe convert for netdev->priv to netdev_priv(netdev).
Since all of the netdev->priv is only for read.
But it is too big to be sent in one mail.
I split it to 4 parts and make every part smaller than 100,000 bytes,
which is max size allowed by vger.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/appletalk')
-rw-r--r-- | drivers/net/appletalk/ipddp.c | 6 | ||||
-rw-r--r-- | drivers/net/appletalk/ltpc.c | 12 |
2 files changed, 11 insertions, 7 deletions
diff --git a/drivers/net/appletalk/ipddp.c b/drivers/net/appletalk/ipddp.c index 1071144edd66..9a0be9b2eaad 100644 --- a/drivers/net/appletalk/ipddp.c +++ b/drivers/net/appletalk/ipddp.c | |||
@@ -108,7 +108,7 @@ static struct net_device * __init ipddp_init(void) | |||
108 | */ | 108 | */ |
109 | static struct net_device_stats *ipddp_get_stats(struct net_device *dev) | 109 | static struct net_device_stats *ipddp_get_stats(struct net_device *dev) |
110 | { | 110 | { |
111 | return dev->priv; | 111 | return netdev_priv(dev); |
112 | } | 112 | } |
113 | 113 | ||
114 | /* | 114 | /* |
@@ -170,8 +170,8 @@ static int ipddp_xmit(struct sk_buff *skb, struct net_device *dev) | |||
170 | 170 | ||
171 | skb->protocol = htons(ETH_P_ATALK); /* Protocol has changed */ | 171 | skb->protocol = htons(ETH_P_ATALK); /* Protocol has changed */ |
172 | 172 | ||
173 | ((struct net_device_stats *) dev->priv)->tx_packets++; | 173 | ((struct net_device_stats *) netdev_priv(dev))->tx_packets++; |
174 | ((struct net_device_stats *) dev->priv)->tx_bytes+=skb->len; | 174 | ((struct net_device_stats *) netdev_priv(dev))->tx_bytes += skb->len; |
175 | 175 | ||
176 | if(aarp_send_ddp(rt->dev, skb, &rt->at, NULL) < 0) | 176 | if(aarp_send_ddp(rt->dev, skb, &rt->at, NULL) < 0) |
177 | dev_kfree_skb(skb); | 177 | dev_kfree_skb(skb); |
diff --git a/drivers/net/appletalk/ltpc.c b/drivers/net/appletalk/ltpc.c index 8d109a5f5571..dc4d49605603 100644 --- a/drivers/net/appletalk/ltpc.c +++ b/drivers/net/appletalk/ltpc.c | |||
@@ -726,7 +726,8 @@ static int sendup_buffer (struct net_device *dev) | |||
726 | int dnode, snode, llaptype, len; | 726 | int dnode, snode, llaptype, len; |
727 | int sklen; | 727 | int sklen; |
728 | struct sk_buff *skb; | 728 | struct sk_buff *skb; |
729 | struct net_device_stats *stats = &((struct ltpc_private *)dev->priv)->stats; | 729 | struct ltpc_private *ltpc_priv = netdev_priv(dev); |
730 | struct net_device_stats *stats = <pc_priv->stats; | ||
730 | struct lt_rcvlap *ltc = (struct lt_rcvlap *) ltdmacbuf; | 731 | struct lt_rcvlap *ltc = (struct lt_rcvlap *) ltdmacbuf; |
731 | 732 | ||
732 | if (ltc->command != LT_RCVLAP) { | 733 | if (ltc->command != LT_RCVLAP) { |
@@ -822,7 +823,8 @@ static int ltpc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) | |||
822 | { | 823 | { |
823 | struct sockaddr_at *sa = (struct sockaddr_at *) &ifr->ifr_addr; | 824 | struct sockaddr_at *sa = (struct sockaddr_at *) &ifr->ifr_addr; |
824 | /* we'll keep the localtalk node address in dev->pa_addr */ | 825 | /* we'll keep the localtalk node address in dev->pa_addr */ |
825 | struct atalk_addr *aa = &((struct ltpc_private *)dev->priv)->my_addr; | 826 | struct ltpc_private *ltpc_priv = netdev_priv(dev); |
827 | struct atalk_addr *aa = <pc_priv->my_addr; | ||
826 | struct lt_init c; | 828 | struct lt_init c; |
827 | int ltflags; | 829 | int ltflags; |
828 | 830 | ||
@@ -903,7 +905,8 @@ static int ltpc_xmit(struct sk_buff *skb, struct net_device *dev) | |||
903 | * and skb->len is the length of the ddp data + ddp header | 905 | * and skb->len is the length of the ddp data + ddp header |
904 | */ | 906 | */ |
905 | 907 | ||
906 | struct net_device_stats *stats = &((struct ltpc_private *)dev->priv)->stats; | 908 | struct ltpc_private *ltpc_priv = netdev_priv(dev); |
909 | struct net_device_stats *stats = <pc_priv->stats; | ||
907 | 910 | ||
908 | int i; | 911 | int i; |
909 | struct lt_sendlap cbuf; | 912 | struct lt_sendlap cbuf; |
@@ -942,7 +945,8 @@ static int ltpc_xmit(struct sk_buff *skb, struct net_device *dev) | |||
942 | 945 | ||
943 | static struct net_device_stats *ltpc_get_stats(struct net_device *dev) | 946 | static struct net_device_stats *ltpc_get_stats(struct net_device *dev) |
944 | { | 947 | { |
945 | struct net_device_stats *stats = &((struct ltpc_private *) dev->priv)->stats; | 948 | struct ltpc_private *ltpc_priv = netdev_priv(dev); |
949 | struct net_device_stats *stats = <pc_priv->stats; | ||
946 | return stats; | 950 | return stats; |
947 | } | 951 | } |
948 | 952 | ||