diff options
author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2006-03-25 06:07:19 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-25 11:22:53 -0500 |
commit | c2f6fabb2ed3b869bc254c6cdc73d6beaaaf700f (patch) | |
tree | 8744d970a801a64ac3cb64f47e735dc3d33c44b9 /drivers/net/3c59x.c | |
parent | e51c01b08474ea454a965a937fff0407ab6714c7 (diff) |
[PATCH] EISA: tidy-up driver_register() return value
Remove the assumption that driver_register() returns the number of devices
bound to the driver. In fact, it returns zero for success or a negative
error value.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-by: Jeff Garzik <jgarzik@pobox.com>
Acked-by: Marc Zyngier <maz@misterjones.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/net/3c59x.c')
-rw-r--r-- | drivers/net/3c59x.c | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c index 5d11a06ecb2c..d339308539fa 100644 --- a/drivers/net/3c59x.c +++ b/drivers/net/3c59x.c | |||
@@ -1096,14 +1096,18 @@ static int __init vortex_eisa_init (void) | |||
1096 | int orig_cards_found = vortex_cards_found; | 1096 | int orig_cards_found = vortex_cards_found; |
1097 | 1097 | ||
1098 | #ifdef CONFIG_EISA | 1098 | #ifdef CONFIG_EISA |
1099 | if (eisa_driver_register (&vortex_eisa_driver) >= 0) { | 1099 | int err; |
1100 | /* Because of the way EISA bus is probed, we cannot assume | 1100 | |
1101 | * any device have been found when we exit from | 1101 | err = eisa_driver_register (&vortex_eisa_driver); |
1102 | * eisa_driver_register (the bus root driver may not be | 1102 | if (!err) { |
1103 | * initialized yet). So we blindly assume something was | 1103 | /* |
1104 | * found, and let the sysfs magic happend... */ | 1104 | * Because of the way EISA bus is probed, we cannot assume |
1105 | 1105 | * any device have been found when we exit from | |
1106 | eisa_found = 1; | 1106 | * eisa_driver_register (the bus root driver may not be |
1107 | * initialized yet). So we blindly assume something was | ||
1108 | * found, and let the sysfs magic happend... | ||
1109 | */ | ||
1110 | eisa_found = 1; | ||
1107 | } | 1111 | } |
1108 | #endif | 1112 | #endif |
1109 | 1113 | ||