Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (32 commits)
  wimax: fix oops in wimax_dev_get_by_genl_info() when looking up non-wimax iface
  net: 4 bytes kernel memory disclosure in SO_BSDCOMPAT gsopt try #2
  netxen: fix compile waring "label ‘set_32_bit_mask’ defined but not used" on IA64 platform
  bnx2: Update version to 1.9.2 and copyright.
  bnx2: Fix jumbo frames error handling.
  bnx2: Update 5709 firmware.
  bnx2: Update 5706/5708 firmware.
  3c505: do not set pcb->data.raw beyond its size
  Documentation/connector/cn_test.c: don't use gfp_any()
  net: don't use in_atomic() in gfp_any()
  IRDA: cnt is off by 1
  netxen: remove pcie workaround
  sun3: print when lance_open() fails
  qlge: bugfix: Add missing rx buf clean index on early exit.
  qlge: bugfix: Fix RX scaling values.
  qlge: bugfix: Fix TSO breakage.
  qlge: bugfix: Add missing dev_kfree_skb_any() call.
  qlge: bugfix: Add missing put_page() call.
  qlge: bugfix: Fix fatal error recovery hang.
  qlge: bugfix: Use netif_receive_skb() and vlan_hwaccel_receive_skb().
  ...

1 files changed, 16 insertions, 10 deletions

diff --git a/drivers/net/3c505.c b/drivers/net/3c505.c
index 6124605bef05..a8107f992fb4 100644
--- a/drivers/net/3c505.c
+++ b/drivers/net/3c505.c
@@ -493,21 +493,27 @@ static bool receive_pcb(struct net_device *dev, pcb_struct * pcb)
         }
         /* read the data */
         spin_lock_irqsave(&adapter->lock, flags);
-        i = 0;
-        do {
-                j = 0;
-                while (((stat = get_status(dev->base_addr)) & ACRF) == 0 && j++ < 20000);
-                pcb->data.raw[i++] = inb_command(dev->base_addr);
-                if (i > MAX_PCB_DATA)
-                        INVALID_PCB_MSG(i);
-        } while ((stat & ASF_PCB_MASK) != ASF_PCB_END && j < 20000);
+        for (i = 0; i < MAX_PCB_DATA; i++) {
+                for (j = 0; j < 20000; j++) {
+                        stat = get_status(dev->base_addr);
+                        if (stat & ACRF)
+                                break;
+                }
+                pcb->data.raw[i] = inb_command(dev->base_addr);
+                if ((stat & ASF_PCB_MASK) == ASF_PCB_END || j >= 20000)
+                        break;
+        }
         spin_unlock_irqrestore(&adapter->lock, flags);
+        if (i >= MAX_PCB_DATA) {
+                INVALID_PCB_MSG(i);
+                return false;
+        }
         if (j >= 20000) {
                 TIMEOUT_MSG(__LINE__);
                 return false;
         }
-        /* woops, the last "data" byte was really the length! */
-        total_length = pcb->data.raw[--i];
+        /* the last "data" byte was really the length! */
+        total_length = pcb->data.raw[i];
 
         /* safety check total length vs data length */
         if (total_length != (pcb->length + 2)) {