Merge tag 'for-linus-3.3' of git://git.infradead.org/mtd-2.6

MTD pull for 3.3

* tag 'for-linus-3.3' of git://git.infradead.org/mtd-2.6: (113 commits)
  mtd: Fix dependency for MTD_DOC200x
  mtd: do not use mtd->block_markbad directly
  logfs: do not use 'mtd->block_isbad' directly
  mtd: introduce mtd_can_have_bb helper
  mtd: do not use mtd->suspend and mtd->resume directly
  mtd: do not use mtd->lock, unlock and is_locked directly
  mtd: do not use mtd->sync directly
  mtd: harmonize mtd_writev usage
  mtd: do not use mtd->lock_user_prot_reg directly
  mtd: mtd->write_user_prot_reg directly
  mtd: do not use mtd->read_*_prot_reg directly
  mtd: do not use mtd->get_*_prot_info directly
  mtd: do not use mtd->read_oob directly
  mtd: mtdoops: do not use mtd->panic_write directly
  romfs: do not use mtd->get_unmapped_area directly
  mtd: do not use mtd->get_unmapped_area directly
  mtd: do use mtd->point directly
  mtd: introduce mtd_has_oob helper
  mtd: mtdcore: export symbols cleanup
  mtd: clean-up the default_mtd_writev function
  ...

Fix up trivial edit/remove conflict in drivers/staging/spectra/lld_mtd.c

92 files changed, 2263 insertions, 1499 deletions

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 318a869286ab..1be621841400 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -140,6 +140,14 @@ config MTD_AR7_PARTS
         ---help---
           TI AR7 partitioning support
 
+config MTD_BCM63XX_PARTS
+        tristate "BCM63XX CFE partitioning support"
+        depends on BCM63XX
+        select CRC32
+        help
+          This provides partions parsing for BCM63xx devices with CFE
+          bootloaders.
+
 comment "User Modules And Translation Layers"
 
 config MTD_CHAR
diff --git a/drivers/mtd/Makefile b/drivers/mtd/Makefile
index 9aaac3ac89f3..f90135429dc7 100644
--- a/drivers/mtd/Makefile
+++ b/drivers/mtd/Makefile
@@ -11,6 +11,7 @@ obj-$(CONFIG_MTD_REDBOOT_PARTS) += redboot.o
 obj-$(CONFIG_MTD_CMDLINE_PARTS) += cmdlinepart.o
 obj-$(CONFIG_MTD_AFS_PARTS)     += afs.o
 obj-$(CONFIG_MTD_AR7_PARTS)     += ar7part.o
+obj-$(CONFIG_MTD_BCM63XX_PARTS) += bcm63xxpart.o
 
 # 'Users' - code which presents functionality to userspace.
 obj-$(CONFIG_MTD_CHAR)          += mtdchar.o
diff --git a/drivers/mtd/afs.c b/drivers/mtd/afs.c
index 89a02f6f65dc..5a3942bf109c 100644
--- a/drivers/mtd/afs.c
+++ b/drivers/mtd/afs.c
@@ -75,7 +75,7 @@ afs_read_footer(struct mtd_info *mtd, u_int *img_start, u_int *iis_start,
         size_t sz;
         int ret;
 
-        ret = mtd->read(mtd, ptr, sizeof(fs), &sz, (u_char *) &fs);
+        ret = mtd_read(mtd, ptr, sizeof(fs), &sz, (u_char *)&fs);
         if (ret >= 0 && sz != sizeof(fs))
                 ret = -EINVAL;
 
@@ -132,7 +132,7 @@ afs_read_iis(struct mtd_info *mtd, struct image_info_struct *iis, u_int ptr)
         int ret, i;
 
         memset(iis, 0, sizeof(*iis));
-        ret = mtd->read(mtd, ptr, sizeof(*iis), &sz, (u_char *) iis);
+        ret = mtd_read(mtd, ptr, sizeof(*iis), &sz, (u_char *)iis);
         if (ret < 0)
                 goto failed;
 
diff --git a/drivers/mtd/ar7part.c b/drivers/mtd/ar7part.c
index f40ea4547554..945393129952 100644
--- a/drivers/mtd/ar7part.c
+++ b/drivers/mtd/ar7part.c
@@ -73,8 +73,8 @@ static int create_mtd_partitions(struct mtd_info *master,
 
         do { /* Try 10 blocks starting from master->erasesize */
                 offset = pre_size;
-                master->read(master, offset,
-                             sizeof(header), &len, (uint8_t *)&header);
+                mtd_read(master, offset, sizeof(header), &len,
+                         (uint8_t *)&header);
                 if (!strncmp((char *)&header, "TIENV0.8", 8))
                         ar7_parts[1].offset = pre_size;
                 if (header.checksum == LOADER_MAGIC1)
@@ -95,16 +95,16 @@ static int create_mtd_partitions(struct mtd_info *master,
         case LOADER_MAGIC1:
                 while (header.length) {
                         offset += sizeof(header) + header.length;
-                        master->read(master, offset, sizeof(header),
-                                     &len, (uint8_t *)&header);
+                        mtd_read(master, offset, sizeof(header), &len,
+                                 (uint8_t *)&header);
                 }
                 root_offset = offset + sizeof(header) + 4;
                 break;
         case LOADER_MAGIC2:
                 while (header.length) {
                         offset += sizeof(header) + header.length;
-                        master->read(master, offset, sizeof(header),
-                                     &len, (uint8_t *)&header);
+                        mtd_read(master, offset, sizeof(header), &len,
+                                 (uint8_t *)&header);
                 }
                 root_offset = offset + sizeof(header) + 4 + 0xff;
                 root_offset &= ~(uint32_t)0xff;
@@ -114,8 +114,7 @@ static int create_mtd_partitions(struct mtd_info *master,
                 break;
         }
 
-        master->read(master, root_offset,
-                sizeof(header), &len, (u8 *)&header);
+        mtd_read(master, root_offset, sizeof(header), &len, (u8 *)&header);
         if (header.checksum != SQUASHFS_MAGIC) {
                 root_offset += master->erasesize - 1;
                 root_offset &= ~(master->erasesize - 1);
diff --git a/drivers/mtd/bcm63xxpart.c b/drivers/mtd/bcm63xxpart.c
new file mode 100644
index 000000000000..608321ee056e
--- /dev/null
+++ b/drivers/mtd/bcm63xxpart.c
@@ -0,0 +1,222 @@
+/*
+ * BCM63XX CFE image tag parser
+ *
+ * Copyright © 2006-2008  Florian Fainelli <florian@openwrt.org>
+ *                        Mike Albon <malbon@openwrt.org>
+ * Copyright © 2009-2010  Daniel Dickinson <openwrt@cshore.neomailbox.net>
+ * Copyright © 2011 Jonas Gorski <jonas.gorski@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/crc32.h>
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/slab.h>
+#include <linux/vmalloc.h>
+#include <linux/mtd/mtd.h>
+#include <linux/mtd/partitions.h>
+
+#include <asm/mach-bcm63xx/bcm963xx_tag.h>
+#include <asm/mach-bcm63xx/board_bcm963xx.h>
+
+#define BCM63XX_EXTENDED_SIZE   0xBFC00000      /* Extended flash address */
+
+#define BCM63XX_MIN_CFE_SIZE    0x10000         /* always at least 64KiB */
+#define BCM63XX_MIN_NVRAM_SIZE  0x10000         /* always at least 64KiB */
+
+#define BCM63XX_CFE_MAGIC_OFFSET 0x4e0
+
+static int bcm63xx_detect_cfe(struct mtd_info *master)
+{
+        char buf[9];
+        int ret;
+        size_t retlen;
+
+        ret = mtd_read(master, BCM963XX_CFE_VERSION_OFFSET, 5, &retlen,
+                       (void *)buf);
+        buf[retlen] = 0;
+
+        if (ret)
+                return ret;
+
+        if (strncmp("cfe-v", buf, 5) == 0)
+                return 0;
+
+        /* very old CFE's do not have the cfe-v string, so check for magic */
+        ret = mtd_read(master, BCM63XX_CFE_MAGIC_OFFSET, 8, &retlen,
+                       (void *)buf);
+        buf[retlen] = 0;
+
+        return strncmp("CFE1CFE1", buf, 8);
+}
+
+static int bcm63xx_parse_cfe_partitions(struct mtd_info *master,
+                                        struct mtd_partition **pparts,
+                                        struct mtd_part_parser_data *data)
+{
+        /* CFE, NVRAM and global Linux are always present */
+        int nrparts = 3, curpart = 0;
+        struct bcm_tag *buf;
+        struct mtd_partition *parts;
+        int ret;
+        size_t retlen;
+        unsigned int rootfsaddr, kerneladdr, spareaddr;
+        unsigned int rootfslen, kernellen, sparelen, totallen;
+        unsigned int cfelen, nvramlen;
+        int namelen = 0;
+        int i;
+        u32 computed_crc;
+
+        if (bcm63xx_detect_cfe(master))
+                return -EINVAL;
+
+        cfelen = max_t(uint32_t, master->erasesize, BCM63XX_MIN_CFE_SIZE);
+        nvramlen = max_t(uint32_t, master->erasesize, BCM63XX_MIN_NVRAM_SIZE);
+
+        /* Allocate memory for buffer */
+        buf = vmalloc(sizeof(struct bcm_tag));
+        if (!buf)
+                return -ENOMEM;
+
+        /* Get the tag */
+        ret = mtd_read(master, cfelen, sizeof(struct bcm_tag), &retlen,
+                       (void *)buf);
+
+        if (retlen != sizeof(struct bcm_tag)) {
+                vfree(buf);
+                return -EIO;
+        }
+
+        computed_crc = crc32_le(IMAGETAG_CRC_START, (u8 *)buf,
+                                offsetof(struct bcm_tag, header_crc));
+        if (computed_crc == buf->header_crc) {
+                char *boardid = &(buf->board_id[0]);
+                char *tagversion = &(buf->tag_version[0]);
+
+                sscanf(buf->kernel_address, "%u", &kerneladdr);
+                sscanf(buf->kernel_length, "%u", &kernellen);
+                sscanf(buf->total_length, "%u", &totallen);
+
+                pr_info("CFE boot tag found with version %s and board type %s\n",
+                        tagversion, boardid);
+
+                kerneladdr = kerneladdr - BCM63XX_EXTENDED_SIZE;
+                rootfsaddr = kerneladdr + kernellen;
+                spareaddr = roundup(totallen, master->erasesize) + cfelen;
+                sparelen = master->size - spareaddr - nvramlen;
+                rootfslen = spareaddr - rootfsaddr;
+        } else {
+                pr_warn("CFE boot tag CRC invalid (expected %08x, actual %08x)\n",
+                        buf->header_crc, computed_crc);
+                kernellen = 0;
+                rootfslen = 0;
+                rootfsaddr = 0;
+                spareaddr = cfelen;
+                sparelen = master->size - cfelen - nvramlen;
+        }
+
+        /* Determine number of partitions */
+        namelen = 8;
+        if (rootfslen > 0) {
+                nrparts++;
+                namelen += 6;
+        }
+        if (kernellen > 0) {
+                nrparts++;
+                namelen += 6;
+        }
+
+        /* Ask kernel for more memory */
+        parts = kzalloc(sizeof(*parts) * nrparts + 10 * nrparts, GFP_KERNEL);
+        if (!parts) {
+                vfree(buf);
+                return -ENOMEM;
+        }
+
+        /* Start building partition list */
+        parts[curpart].name = "CFE";
+        parts[curpart].offset = 0;
+        parts[curpart].size = cfelen;
+        curpart++;
+
+        if (kernellen > 0) {
+                parts[curpart].name = "kernel";
+                parts[curpart].offset = kerneladdr;
+                parts[curpart].size = kernellen;
+                curpart++;
+        }
+
+        if (rootfslen > 0) {
+                parts[curpart].name = "rootfs";
+                parts[curpart].offset = rootfsaddr;
+                parts[curpart].size = rootfslen;
+                if (sparelen > 0)
+                        parts[curpart].size += sparelen;
+                curpart++;
+        }
+
+        parts[curpart].name = "nvram";
+        parts[curpart].offset = master->size - nvramlen;
+        parts[curpart].size = nvramlen;
+
+        /* Global partition "linux" to make easy firmware upgrade */
+        curpart++;
+        parts[curpart].name = "linux";
+        parts[curpart].offset = cfelen;
+        parts[curpart].size = master->size - cfelen - nvramlen;
+
+        for (i = 0; i < nrparts; i++)
+                pr_info("Partition %d is %s offset %lx and length %lx\n", i,
+                        parts[i].name, (long unsigned int)(parts[i].offset),
+                        (long unsigned int)(parts[i].size));
+
+        pr_info("Spare partition is offset %x and length %x\n", spareaddr,
+                sparelen);
+
+        *pparts = parts;
+        vfree(buf);
+
+        return nrparts;
+};
+
+static struct mtd_part_parser bcm63xx_cfe_parser = {
+        .owner = THIS_MODULE,
+        .parse_fn = bcm63xx_parse_cfe_partitions,
+        .name = "bcm63xxpart",
+};
+
+static int __init bcm63xx_cfe_parser_init(void)
+{
+        return register_mtd_parser(&bcm63xx_cfe_parser);
+}
+
+static void __exit bcm63xx_cfe_parser_exit(void)
+{
+        deregister_mtd_parser(&bcm63xx_cfe_parser);
+}
+
+module_init(bcm63xx_cfe_parser_init);
+module_exit(bcm63xx_cfe_parser_exit);
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Daniel Dickinson <openwrt@cshore.neomailbox.net>");
+MODULE_AUTHOR("Florian Fainelli <florian@openwrt.org>");
+MODULE_AUTHOR("Mike Albon <malbon@openwrt.org>");
+MODULE_AUTHOR("Jonas Gorski <jonas.gorski@gmail.com");
+MODULE_DESCRIPTION("MTD partitioning for BCM63XX CFE bootloaders");
diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
index 179814a95f3a..85e80180b65b 100644
--- a/drivers/mtd/chips/cfi_cmdset_0020.c
+++ b/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -139,8 +139,9 @@ struct mtd_info *cfi_cmdset_0020(struct map_info *map, int primary)
                 }
 
                 /* Do some byteswapping if necessary */
-                extp->FeatureSupport = cfi32_to_cpu(extp->FeatureSupport);
-                extp->BlkStatusRegMask = cfi32_to_cpu(extp->BlkStatusRegMask);
+                extp->FeatureSupport = cfi32_to_cpu(map, extp->FeatureSupport);
+                extp->BlkStatusRegMask = cfi32_to_cpu(map,
+                                                extp->BlkStatusRegMask);
 
 #ifdef DEBUG_CFI_FEATURES
                 /* Tell the user about it in lots of lovely detail */
@@ -698,7 +699,8 @@ cfi_staa_writev(struct mtd_info *mtd, const struct kvec *vecs,
                                 continue;
                         }
                         memcpy(buffer+buflen, elem_base, ECCBUF_SIZE-buflen);
-                        ret = mtd->write(mtd, to, ECCBUF_SIZE, &thislen, buffer);
+                        ret = mtd_write(mtd, to, ECCBUF_SIZE, &thislen,
+                                        buffer);
                         totlen += thislen;
                         if (ret || thislen != ECCBUF_SIZE)
                                 goto write_error;
@@ -707,7 +709,8 @@ cfi_staa_writev(struct mtd_info *mtd, const struct kvec *vecs,
                         to += ECCBUF_SIZE;
                 }
                 if (ECCBUF_DIV(elem_len)) { /* write clean aligned data */
-                        ret = mtd->write(mtd, to, ECCBUF_DIV(elem_len), &thislen, elem_base);
+                        ret = mtd_write(mtd, to, ECCBUF_DIV(elem_len),
+                                        &thislen, elem_base);
                         totlen += thislen;
                         if (ret || thislen != ECCBUF_DIV(elem_len))
                                 goto write_error;
@@ -721,7 +724,7 @@ cfi_staa_writev(struct mtd_info *mtd, const struct kvec *vecs,
         }
         if (buflen) { /* flush last page, even if not full */
                 /* This is sometimes intended behaviour, really */
-                ret = mtd->write(mtd, to, buflen, &thislen, buffer);
+                ret = mtd_write(mtd, to, buflen, &thislen, buffer);
                 totlen += thislen;
                 if (ret || thislen != ECCBUF_SIZE)
                         goto write_error;
diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
index 283d887f7825..37b05c3f2792 100644
--- a/drivers/mtd/devices/Kconfig
+++ b/drivers/mtd/devices/Kconfig
@@ -191,6 +191,7 @@ comment "Disk-On-Chip Device Drivers"
 
 config MTD_DOC2000
         tristate "M-Systems Disk-On-Chip 2000 and Millennium (DEPRECATED)"
+        depends on MTD_NAND
         select MTD_DOCPROBE
         select MTD_NAND_IDS
         ---help---
@@ -213,6 +214,7 @@ config MTD_DOC2000
 
 config MTD_DOC2001
         tristate "M-Systems Disk-On-Chip Millennium-only alternative driver (DEPRECATED)"
+        depends on MTD_NAND
         select MTD_DOCPROBE
         select MTD_NAND_IDS
         ---help---
@@ -234,6 +236,7 @@ config MTD_DOC2001
 
 config MTD_DOC2001PLUS
         tristate "M-Systems Disk-On-Chip Millennium Plus"
+        depends on MTD_NAND
         select MTD_DOCPROBE
         select MTD_NAND_IDS
         ---help---
@@ -251,6 +254,8 @@ config MTD_DOC2001PLUS
 
 config MTD_DOCG3
         tristate "M-Systems Disk-On-Chip G3"
+        select BCH
+        select BCH_CONST_PARAMS
         ---help---
           This provides an MTD device driver for the M-Systems DiskOnChip
           G3 devices.
@@ -259,6 +264,13 @@ config MTD_DOCG3
           M-Systems and now Sandisk. The support is very experimental,
           and doesn't give access to any write operations.
 
+if MTD_DOCG3
+config BCH_CONST_M
+        default 14
+config BCH_CONST_T
+        default 4
+endif
+
 config MTD_DOCPROBE
         tristate
         select MTD_DOCECC
diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index ebeabc727f70..e7e46d1e7463 100644
--- a/drivers/mtd/devices/block2mtd.c
+++ b/drivers/mtd/devices/block2mtd.c
@@ -287,7 +287,7 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
         dev->mtd.flags = MTD_CAP_RAM;
         dev->mtd.erase = block2mtd_erase;
         dev->mtd.write = block2mtd_write;
-        dev->mtd.writev = default_mtd_writev;
+        dev->mtd.writev = mtd_writev;
         dev->mtd.sync = block2mtd_sync;
         dev->mtd.read = block2mtd_read;
         dev->mtd.priv = dev;
diff --git a/drivers/mtd/devices/doc2000.c b/drivers/mtd/devices/doc2000.c
index e9fad9151219..b1cdf6479019 100644
--- a/drivers/mtd/devices/doc2000.c
+++ b/drivers/mtd/devices/doc2000.c
@@ -562,23 +562,14 @@ void DoC2k_init(struct mtd_info *mtd)
 
         mtd->type = MTD_NANDFLASH;
         mtd->flags = MTD_CAP_NANDFLASH;
-        mtd->size = 0;
-        mtd->erasesize = 0;
         mtd->writesize = 512;
         mtd->oobsize = 16;
         mtd->owner = THIS_MODULE;
         mtd->erase = doc_erase;
-        mtd->point = NULL;
-        mtd->unpoint = NULL;
         mtd->read = doc_read;
         mtd->write = doc_write;
         mtd->read_oob = doc_read_oob;
         mtd->write_oob = doc_write_oob;
-        mtd->sync = NULL;
-
-        this->totlen = 0;
-        this->numchips = 0;
-
         this->curfloor = -1;
         this->curchip = -1;
         mutex_init(&this->lock);
diff --git a/drivers/mtd/devices/doc2001.c b/drivers/mtd/devices/doc2001.c
index a3f7a27499be..7543b98f46c4 100644
--- a/drivers/mtd/devices/doc2001.c
+++ b/drivers/mtd/devices/doc2001.c
@@ -343,25 +343,17 @@ void DoCMil_init(struct mtd_info *mtd)
 
         mtd->type = MTD_NANDFLASH;
         mtd->flags = MTD_CAP_NANDFLASH;
-        mtd->size = 0;
 
         /* FIXME: erase size is not always 8KiB */
         mtd->erasesize = 0x2000;
-
         mtd->writesize = 512;
         mtd->oobsize = 16;
         mtd->owner = THIS_MODULE;
         mtd->erase = doc_erase;
-        mtd->point = NULL;
-        mtd->unpoint = NULL;
         mtd->read = doc_read;
         mtd->write = doc_write;
         mtd->read_oob = doc_read_oob;
         mtd->write_oob = doc_write_oob;
-        mtd->sync = NULL;
-
-        this->totlen = 0;
-        this->numchips = 0;
         this->curfloor = -1;
         this->curchip = -1;
 
diff --git a/drivers/mtd/devices/doc2001plus.c b/drivers/mtd/devices/doc2001plus.c
index 99351bc3e0ed..177510d0e7ee 100644
--- a/drivers/mtd/devices/doc2001plus.c
+++ b/drivers/mtd/devices/doc2001plus.c
@@ -467,23 +467,14 @@ void DoCMilPlus_init(struct mtd_info *mtd)
 
         mtd->type = MTD_NANDFLASH;
         mtd->flags = MTD_CAP_NANDFLASH;
-        mtd->size = 0;
-
-        mtd->erasesize = 0;
         mtd->writesize = 512;
         mtd->oobsize = 16;
         mtd->owner = THIS_MODULE;
         mtd->erase = doc_erase;
-        mtd->point = NULL;
-        mtd->unpoint = NULL;
         mtd->read = doc_read;
         mtd->write = doc_write;
         mtd->read_oob = doc_read_oob;
         mtd->write_oob = doc_write_oob;
-        mtd->sync = NULL;
-
-        this->totlen = 0;
-        this->numchips = 0;
         this->curfloor = -1;
         this->curchip = -1;
 
diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index bdcf5df982e8..ad11ef0a81f4 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -29,6 +29,9 @@
 #include <linux/delay.h>
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/partitions.h>
+#include <linux/bitmap.h>
+#include <linux/bitrev.h>
+#include <linux/bch.h>
 
 #include <linux/debugfs.h>
 #include <linux/seq_file.h>
@@ -41,11 +44,7 @@
  *
  * As no specification is available from M-Systems/Sandisk, this drivers lacks
  * several functions available on the chip, as :
- *  - block erase
- *  - page write
  *  - IPL write
- *  - ECC fixing (lack of BCH algorith understanding)
- *  - powerdown / powerup
  *
  * The bus data width (8bits versus 16bits) is not handled (if_cfg flag), and
  * the driver assumes a 16bits data bus.
@@ -53,8 +52,7 @@
  * DocG3 relies on 2 ECC algorithms, which are handled in hardware :
  *  - a 1 byte Hamming code stored in the OOB for each page
  *  - a 7 bytes BCH code stored in the OOB for each page
- * The BCH part is only used for check purpose, no correction is available as
- * some information is missing. What is known is that :
+ * The BCH ECC is :
  *  - BCH is in GF(2^14)
  *  - BCH is over data of 520 bytes (512 page + 7 page_info bytes
  *                                   + 1 hamming byte)
@@ -63,6 +61,30 @@
  *
  */
 
+static unsigned int reliable_mode;
+module_param(reliable_mode, uint, 0);
+MODULE_PARM_DESC(reliable_mode, "Set the docg3 mode (0=normal MLC, 1=fast, "
+                 "2=reliable) : MLC normal operations are in normal mode");
+
+/**
+ * struct docg3_oobinfo - DiskOnChip G3 OOB layout
+ * @eccbytes: 8 bytes are used (1 for Hamming ECC, 7 for BCH ECC)
+ * @eccpos: ecc positions (byte 7 is Hamming ECC, byte 8-14 are BCH ECC)
+ * @oobfree: free pageinfo bytes (byte 0 until byte 6, byte 15
+ * @oobavail: 8 available bytes remaining after ECC toll
+ */
+static struct nand_ecclayout docg3_oobinfo = {
+        .eccbytes = 8,
+        .eccpos = {7, 8, 9, 10, 11, 12, 13, 14},
+        .oobfree = {{0, 7}, {15, 1} },
+        .oobavail = 8,
+};
+
+/**
+ * struct docg3_bch - BCH engine
+ */
+static struct bch_control *docg3_bch;
+
 static inline u8 doc_readb(struct docg3 *docg3, u16 reg)
 {
         u8 val = readb(docg3->base + reg);
@@ -82,7 +104,7 @@ static inline u16 doc_readw(struct docg3 *docg3, u16 reg)
 static inline void doc_writeb(struct docg3 *docg3, u8 val, u16 reg)
 {
         writeb(val, docg3->base + reg);
-        trace_docg3_io(1, 16, reg, val);
+        trace_docg3_io(1, 8, reg, val);
 }
 
 static inline void doc_writew(struct docg3 *docg3, u16 val, u16 reg)
@@ -143,7 +165,7 @@ static void doc_delay(struct docg3 *docg3, int nbNOPs)
 {
         int i;
 
-        doc_dbg("NOP x %d\n", nbNOPs);
+        doc_vdbg("NOP x %d\n", nbNOPs);
         for (i = 0; i < nbNOPs; i++)
                 doc_writeb(docg3, 0, DOC_NOP);
 }
@@ -196,8 +218,8 @@ static int doc_reset_seq(struct docg3 *docg3)
 /**
  * doc_read_data_area - Read data from data area
  * @docg3: the device
- * @buf: the buffer to fill in
- * @len: the lenght to read
+ * @buf: the buffer to fill in (might be NULL is dummy reads)
+ * @len: the length to read
  * @first: first time read, DOC_READADDRESS should be set
  *
  * Reads bytes from flash data. Handles the single byte / even bytes reads.
@@ -218,8 +240,10 @@ static void doc_read_data_area(struct docg3 *docg3, void *buf, int len,
         dst16 = buf;
         for (i = 0; i < len4; i += 2) {
                 data16 = doc_readw(docg3, DOC_IOSPACE_DATA);
-                *dst16 = data16;
-                dst16++;
+                if (dst16) {
+                        *dst16 = data16;
+                        dst16++;
+                }
         }
 
         if (cdr) {
@@ -229,26 +253,84 @@ static void doc_read_data_area(struct docg3 *docg3, void *buf, int len,
                 dst8 = (u8 *)dst16;
                 for (i = 0; i < cdr; i++) {
                         data8 = doc_readb(docg3, DOC_IOSPACE_DATA);
-                        *dst8 = data8;
-                        dst8++;
+                        if (dst8) {
+                                *dst8 = data8;
+                                dst8++;
+                        }
                 }
         }
 }
 
 /**
- * doc_set_data_mode - Sets the flash to reliable data mode
+ * doc_write_data_area - Write data into data area
+ * @docg3: the device
+ * @buf: the buffer to get input bytes from
+ * @len: the length to write
+ *
+ * Writes bytes into flash data. Handles the single byte / even bytes writes.
+ */
+static void doc_write_data_area(struct docg3 *docg3, const void *buf, int len)
+{
+        int i, cdr, len4;
+        u16 *src16;
+        u8 *src8;
+
+        doc_dbg("doc_write_data_area(buf=%p, len=%d)\n", buf, len);
+        cdr = len & 0x3;
+        len4 = len - cdr;
+
+        doc_writew(docg3, DOC_IOSPACE_DATA, DOC_READADDRESS);
+        src16 = (u16 *)buf;
+        for (i = 0; i < len4; i += 2) {
+                doc_writew(docg3, *src16, DOC_IOSPACE_DATA);
+                src16++;
+        }
+
+        src8 = (u8 *)src16;
+        for (i = 0; i < cdr; i++) {
+                doc_writew(docg3, DOC_IOSPACE_DATA | DOC_READADDR_ONE_BYTE,
+                           DOC_READADDRESS);
+                doc_writeb(docg3, *src8, DOC_IOSPACE_DATA);
+                src8++;
+        }
+}
+
+/**
+ * doc_set_data_mode - Sets the flash to normal or reliable data mode
  * @docg3: the device
  *
  * The reliable data mode is a bit slower than the fast mode, but less errors
  * occur.  Entering the reliable mode cannot be done without entering the fast
  * mode first.
+ *
+ * In reliable mode, pages 2*n and 2*n+1 are clones. Writing to page 0 of blocks
+ * (4,5) make the hardware write also to page 1 of blocks blocks(4,5). Reading
+ * from page 0 of blocks (4,5) or from page 1 of blocks (4,5) gives the same
+ * result, which is a logical and between bytes from page 0 and page 1 (which is
+ * consistent with the fact that writing to a page is _clearing_ bits of that
+ * page).
  */
 static void doc_set_reliable_mode(struct docg3 *docg3)
 {
-        doc_dbg("doc_set_reliable_mode()\n");
-        doc_flash_sequence(docg3, DOC_SEQ_SET_MODE);
-        doc_flash_command(docg3, DOC_CMD_FAST_MODE);
-        doc_flash_command(docg3, DOC_CMD_RELIABLE_MODE);
+        static char *strmode[] = { "normal", "fast", "reliable", "invalid" };
+
+        doc_dbg("doc_set_reliable_mode(%s)\n", strmode[docg3->reliable]);
+        switch (docg3->reliable) {
+        case 0:
+                break;
+        case 1:
+                doc_flash_sequence(docg3, DOC_SEQ_SET_FASTMODE);
+                doc_flash_command(docg3, DOC_CMD_FAST_MODE);
+                break;
+        case 2:
+                doc_flash_sequence(docg3, DOC_SEQ_SET_RELIABLEMODE);
+                doc_flash_command(docg3, DOC_CMD_FAST_MODE);
+                doc_flash_command(docg3, DOC_CMD_RELIABLE_MODE);
+                break;
+        default:
+                doc_err("doc_set_reliable_mode(): invalid mode\n");
+                break;
+        }
         doc_delay(docg3, 2);
 }
 
@@ -325,6 +407,37 @@ static int doc_set_extra_page_mode(struct docg3 *docg3)
 }
 
 /**
+ * doc_setup_addr_sector - Setup blocks/page/ofs address for one plane
+ * @docg3: the device
+ * @sector: the sector
+ */
+static void doc_setup_addr_sector(struct docg3 *docg3, int sector)
+{
+        doc_delay(docg3, 1);
+        doc_flash_address(docg3, sector & 0xff);
+        doc_flash_address(docg3, (sector >> 8) & 0xff);
+        doc_flash_address(docg3, (sector >> 16) & 0xff);
+        doc_delay(docg3, 1);
+}
+
+/**
+ * doc_setup_writeaddr_sector - Setup blocks/page/ofs address for one plane
+ * @docg3: the device
+ * @sector: the sector
+ * @ofs: the offset in the page, between 0 and (512 + 16 + 512)
+ */
+static void doc_setup_writeaddr_sector(struct docg3 *docg3, int sector, int ofs)
+{
+        ofs = ofs >> 2;
+        doc_delay(docg3, 1);
+        doc_flash_address(docg3, ofs & 0xff);
+        doc_flash_address(docg3, sector & 0xff);
+        doc_flash_address(docg3, (sector >> 8) & 0xff);
+        doc_flash_address(docg3, (sector >> 16) & 0xff);
+        doc_delay(docg3, 1);
+}
+
+/**
  * doc_seek - Set both flash planes to the specified block, page for reading
  * @docg3: the device
  * @block0: the first plane block index
@@ -360,34 +473,80 @@ static int doc_read_seek(struct docg3 *docg3, int block0, int block1, int page,
         if (ret)
                 goto out;
 
-        sector = (block0 << DOC_ADDR_BLOCK_SHIFT) + (page & DOC_ADDR_PAGE_MASK);
         doc_flash_sequence(docg3, DOC_SEQ_READ);
+        sector = (block0 << DOC_ADDR_BLOCK_SHIFT) + (page & DOC_ADDR_PAGE_MASK);
         doc_flash_command(docg3, DOC_CMD_PROG_BLOCK_ADDR);
-        doc_delay(docg3, 1);
-        doc_flash_address(docg3, sector & 0xff);
-        doc_flash_address(docg3, (sector >> 8) & 0xff);
-        doc_flash_address(docg3, (sector >> 16) & 0xff);
-        doc_delay(docg3, 1);
+        doc_setup_addr_sector(docg3, sector);
 
         sector = (block1 << DOC_ADDR_BLOCK_SHIFT) + (page & DOC_ADDR_PAGE_MASK);
         doc_flash_command(docg3, DOC_CMD_PROG_BLOCK_ADDR);
+        doc_setup_addr_sector(docg3, sector);
         doc_delay(docg3, 1);
-        doc_flash_address(docg3, sector & 0xff);
-        doc_flash_address(docg3, (sector >> 8) & 0xff);
-        doc_flash_address(docg3, (sector >> 16) & 0xff);
+
+out:
+        return ret;
+}
+
+/**
+ * doc_write_seek - Set both flash planes to the specified block, page for writing
+ * @docg3: the device
+ * @block0: the first plane block index
+ * @block1: the second plane block index
+ * @page: the page index within the block
+ * @ofs: offset in page to write
+ *
+ * Programs the flash even and odd planes to the specific block and page.
+ * Alternatively, programs the flash to the wear area of the specified page.
+ */
+static int doc_write_seek(struct docg3 *docg3, int block0, int block1, int page,
+                         int ofs)
+{
+        int ret = 0, sector;
+
+        doc_dbg("doc_write_seek(blocks=(%d,%d), page=%d, ofs=%d)\n",
+                block0, block1, page, ofs);
+
+        doc_set_reliable_mode(docg3);
+
+        if (ofs < 2 * DOC_LAYOUT_PAGE_SIZE) {
+                doc_flash_sequence(docg3, DOC_SEQ_SET_PLANE1);
+                doc_flash_command(docg3, DOC_CMD_READ_PLANE1);
+                doc_delay(docg3, 2);
+        } else {
+                doc_flash_sequence(docg3, DOC_SEQ_SET_PLANE2);
+                doc_flash_command(docg3, DOC_CMD_READ_PLANE2);
+                doc_delay(docg3, 2);
+        }
+
+        doc_flash_sequence(docg3, DOC_SEQ_PAGE_SETUP);
+        doc_flash_command(docg3, DOC_CMD_PROG_CYCLE1);
+
+        sector = (block0 << DOC_ADDR_BLOCK_SHIFT) + (page & DOC_ADDR_PAGE_MASK);
+        doc_setup_writeaddr_sector(docg3, sector, ofs);
+
+        doc_flash_command(docg3, DOC_CMD_PROG_CYCLE3);
         doc_delay(docg3, 2);
+        ret = doc_wait_ready(docg3);
+        if (ret)
+                goto out;
+
+        doc_flash_command(docg3, DOC_CMD_PROG_CYCLE1);
+        sector = (block1 << DOC_ADDR_BLOCK_SHIFT) + (page & DOC_ADDR_PAGE_MASK);
+        doc_setup_writeaddr_sector(docg3, sector, ofs);
+        doc_delay(docg3, 1);
 
 out:
         return ret;
 }
 
+
 /**
  * doc_read_page_ecc_init - Initialize hardware ECC engine
  * @docg3: the device
  * @len: the number of bytes covered by the ECC (BCH covered)
  *
  * The function does initialize the hardware ECC engine to compute the Hamming
- * ECC (on 1 byte) and the BCH Syndroms (on 7 bytes).
+ * ECC (on 1 byte) and the BCH hardware ECC (on 7 bytes).
  *
  * Return 0 if succeeded, -EIO on error
  */
@@ -403,6 +562,106 @@ static int doc_read_page_ecc_init(struct docg3 *docg3, int len)
 }
 
 /**
+ * doc_write_page_ecc_init - Initialize hardware BCH ECC engine
+ * @docg3: the device
+ * @len: the number of bytes covered by the ECC (BCH covered)
+ *
+ * The function does initialize the hardware ECC engine to compute the Hamming
+ * ECC (on 1 byte) and the BCH hardware ECC (on 7 bytes).
+ *
+ * Return 0 if succeeded, -EIO on error
+ */
+static int doc_write_page_ecc_init(struct docg3 *docg3, int len)
+{
+        doc_writew(docg3, DOC_ECCCONF0_WRITE_MODE
+                   | DOC_ECCCONF0_BCH_ENABLE | DOC_ECCCONF0_HAMMING_ENABLE
+                   | (len & DOC_ECCCONF0_DATA_BYTES_MASK),
+                   DOC_ECCCONF0);
+        doc_delay(docg3, 4);
+        doc_register_readb(docg3, DOC_FLASHCONTROL);
+        return doc_wait_ready(docg3);
+}
+
+/**
+ * doc_ecc_disable - Disable Hamming and BCH ECC hardware calculator
+ * @docg3: the device
+ *
+ * Disables the hardware ECC generator and checker, for unchecked reads (as when
+ * reading OOB only or write status byte).
+ */
+static void doc_ecc_disable(struct docg3 *docg3)
+{
+        doc_writew(docg3, DOC_ECCCONF0_READ_MODE, DOC_ECCCONF0);
+        doc_delay(docg3, 4);
+}
+
+/**
+ * doc_hamming_ecc_init - Initialize hardware Hamming ECC engine
+ * @docg3: the device
+ * @nb_bytes: the number of bytes covered by the ECC (Hamming covered)
+ *
+ * This function programs the ECC hardware to compute the hamming code on the
+ * last provided N bytes to the hardware generator.
+ */
+static void doc_hamming_ecc_init(struct docg3 *docg3, int nb_bytes)
+{
+        u8 ecc_conf1;
+
+        ecc_conf1 = doc_register_readb(docg3, DOC_ECCCONF1);
+        ecc_conf1 &= ~DOC_ECCCONF1_HAMMING_BITS_MASK;
+        ecc_conf1 |= (nb_bytes & DOC_ECCCONF1_HAMMING_BITS_MASK);
+        doc_writeb(docg3, ecc_conf1, DOC_ECCCONF1);
+}
+
+/**
+ * doc_ecc_bch_fix_data - Fix if need be read data from flash
+ * @docg3: the device
+ * @buf: the buffer of read data (512 + 7 + 1 bytes)
+ * @hwecc: the hardware calculated ECC.
+ *         It's in fact recv_ecc ^ calc_ecc, where recv_ecc was read from OOB
+ *         area data, and calc_ecc the ECC calculated by the hardware generator.
+ *
+ * Checks if the received data matches the ECC, and if an error is detected,
+ * tries to fix the bit flips (at most 4) in the buffer buf.  As the docg3
+ * understands the (data, ecc, syndroms) in an inverted order in comparison to
+ * the BCH library, the function reverses the order of bits (ie. bit7 and bit0,
+ * bit6 and bit 1, ...) for all ECC data.
+ *
+ * The hardware ecc unit produces oob_ecc ^ calc_ecc.  The kernel's bch
+ * algorithm is used to decode this.  However the hw operates on page
+ * data in a bit order that is the reverse of that of the bch alg,
+ * requiring that the bits be reversed on the result.  Thanks to Ivan
+ * Djelic for his analysis.
+ *
+ * Returns number of fixed bits (0, 1, 2, 3, 4) or -EBADMSG if too many bit
+ * errors were detected and cannot be fixed.
+ */
+static int doc_ecc_bch_fix_data(struct docg3 *docg3, void *buf, u8 *hwecc)
+{
+        u8 ecc[DOC_ECC_BCH_SIZE];
+        int errorpos[DOC_ECC_BCH_T], i, numerrs;
+
+        for (i = 0; i < DOC_ECC_BCH_SIZE; i++)
+                ecc[i] = bitrev8(hwecc[i]);
+        numerrs = decode_bch(docg3_bch, NULL, DOC_ECC_BCH_COVERED_BYTES,
+                             NULL, ecc, NULL, errorpos);
+        BUG_ON(numerrs == -EINVAL);
+        if (numerrs < 0)
+                goto out;
+
+        for (i = 0; i < numerrs; i++)
+                errorpos[i] = (errorpos[i] & ~7) | (7 - (errorpos[i] & 7));
+        for (i = 0; i < numerrs; i++)
+                if (errorpos[i] < DOC_ECC_BCH_COVERED_BYTES*8)
+                        /* error is located in data, correct it */
+                        change_bit(errorpos[i], buf);
+out:
+        doc_dbg("doc_ecc_bch_fix_data: flipped %d bits\n", numerrs);
+        return numerrs;
+}
+
+
+/**
  * doc_read_page_prepare - Prepares reading data from a flash page
  * @docg3: the device
  * @block0: the first plane block index on flash memory
@@ -488,16 +747,40 @@ static int doc_read_page_getbytes(struct docg3 *docg3, int len, u_char *buf,
 }
 
 /**
- * doc_get_hw_bch_syndroms - Get hardware calculated BCH syndroms
+ * doc_write_page_putbytes - Writes bytes into a prepared page
+ * @docg3: the device
+ * @len: the number of bytes to be written
+ * @buf: the buffer of input bytes
+ *
+ */
+static void doc_write_page_putbytes(struct docg3 *docg3, int len,
+                                    const u_char *buf)
+{
+        doc_write_data_area(docg3, buf, len);
+        doc_delay(docg3, 2);
+}
+
+/**
+ * doc_get_bch_hw_ecc - Get hardware calculated BCH ECC
  * @docg3: the device
- * @syns:  the array of 7 integers where the syndroms will be stored
+ * @hwecc:  the array of 7 integers where the hardware ecc will be stored
  */
-static void doc_get_hw_bch_syndroms(struct docg3 *docg3, int *syns)
+static void doc_get_bch_hw_ecc(struct docg3 *docg3, u8 *hwecc)
 {
         int i;
 
         for (i = 0; i < DOC_ECC_BCH_SIZE; i++)
-                syns[i] = doc_register_readb(docg3, DOC_BCH_SYNDROM(i));
+                hwecc[i] = doc_register_readb(docg3, DOC_BCH_HW_ECC(i));
+}
+
+/**
+ * doc_page_finish - Ends reading/writing of a flash page
+ * @docg3: the device
+ */
+static void doc_page_finish(struct docg3 *docg3)
+{
+        doc_writeb(docg3, 0, DOC_DATAEND);
+        doc_delay(docg3, 2);
 }
 
 /**
@@ -510,8 +793,7 @@ static void doc_get_hw_bch_syndroms(struct docg3 *docg3, int *syns)
  */
 static void doc_read_page_finish(struct docg3 *docg3)
 {
-        doc_writeb(docg3, 0, DOC_DATAEND);
-        doc_delay(docg3, 2);
+        doc_page_finish(docg3);
         doc_set_device_id(docg3, 0);
 }
 
@@ -523,18 +805,29 @@ static void doc_read_page_finish(struct docg3 *docg3)
  * @block1: second plane block index calculated
  * @page: page calculated
  * @ofs: offset in page
+ * @reliable: 0 if docg3 in normal mode, 1 if docg3 in fast mode, 2 if docg3 in
+ * reliable mode.
+ *
+ * The calculation is based on the reliable/normal mode. In normal mode, the 64
+ * pages of a block are available. In reliable mode, as pages 2*n and 2*n+1 are
+ * clones, only 32 pages per block are available.
  */
 static void calc_block_sector(loff_t from, int *block0, int *block1, int *page,
-                              int *ofs)
+                              int *ofs, int reliable)
 {
-        uint sector;
+        uint sector, pages_biblock;
+
+        pages_biblock = DOC_LAYOUT_PAGES_PER_BLOCK * DOC_LAYOUT_NBPLANES;
+        if (reliable == 1 || reliable == 2)
+                pages_biblock /= 2;
 
         sector = from / DOC_LAYOUT_PAGE_SIZE;
-        *block0 = sector / (DOC_LAYOUT_PAGES_PER_BLOCK * DOC_LAYOUT_NBPLANES)
-                * DOC_LAYOUT_NBPLANES;
+        *block0 = sector / pages_biblock * DOC_LAYOUT_NBPLANES;
         *block1 = *block0 + 1;
-        *page = sector % (DOC_LAYOUT_PAGES_PER_BLOCK * DOC_LAYOUT_NBPLANES);
+        *page = sector % pages_biblock;
         *page /= DOC_LAYOUT_NBPLANES;
+        if (reliable == 1 || reliable == 2)
+                *page *= 2;
         if (sector % 2)
                 *ofs = DOC_LAYOUT_PAGE_OOB_SIZE;
         else
@@ -542,99 +835,124 @@ static void calc_block_sector(loff_t from, int *block0, int *block1, int *page,
 }
 
 /**
- * doc_read - Read bytes from flash
+ * doc_read_oob - Read out of band bytes from flash
  * @mtd: the device
  * @from: the offset from first block and first page, in bytes, aligned on page
  *        size
- * @len: the number of bytes to read (must be a multiple of 4)
- * @retlen: the number of bytes actually read
- * @buf: the filled in buffer
+ * @ops: the mtd oob structure
  *
- * Reads flash memory pages. This function does not read the OOB chunk, but only
- * the page data.
+ * Reads flash memory OOB area of pages.
  *
  * Returns 0 if read successfull, of -EIO, -EINVAL if an error occured
  */
-static int doc_read(struct mtd_info *mtd, loff_t from, size_t len,
-             size_t *retlen, u_char *buf)
+static int doc_read_oob(struct mtd_info *mtd, loff_t from,
+                        struct mtd_oob_ops *ops)
 {
         struct docg3 *docg3 = mtd->priv;
-        int block0, block1, page, readlen, ret, ofs = 0;
-        int syn[DOC_ECC_BCH_SIZE], eccconf1;
-        u8 oob[DOC_LAYOUT_OOB_SIZE];
+        int block0, block1, page, ret, ofs = 0;
+        u8 *oobbuf = ops->oobbuf;
+        u8 *buf = ops->datbuf;
+        size_t len, ooblen, nbdata, nboob;
+        u8 hwecc[DOC_ECC_BCH_SIZE], eccconf1;
+
+        if (buf)
+                len = ops->len;
+        else
+                len = 0;
+        if (oobbuf)
+                ooblen = ops->ooblen;
+        else
+                ooblen = 0;
+
+        if (oobbuf && ops->mode == MTD_OPS_PLACE_OOB)
+                oobbuf += ops->ooboffs;
+
+        doc_dbg("doc_read_oob(from=%lld, mode=%d, data=(%p:%zu), oob=(%p:%zu))\n",
+                from, ops->mode, buf, len, oobbuf, ooblen);
+        if ((len % DOC_LAYOUT_PAGE_SIZE) || (ooblen % DOC_LAYOUT_OOB_SIZE) ||
+            (from % DOC_LAYOUT_PAGE_SIZE))
+                return -EINVAL;
 
         ret = -EINVAL;
-        doc_dbg("doc_read(from=%lld, len=%zu, buf=%p)\n", from, len, buf);
-        if (from % DOC_LAYOUT_PAGE_SIZE)
-                goto err;
-        if (len % 4)
-                goto err;
-        calc_block_sector(from, &block0, &block1, &page, &ofs);
+        calc_block_sector(from + len, &block0, &block1, &page, &ofs,
+                          docg3->reliable);
         if (block1 > docg3->max_block)
                 goto err;
 
-        *retlen = 0;
+        ops->oobretlen = 0;
+        ops->retlen = 0;
         ret = 0;
-        readlen = min_t(size_t, len, (size_t)DOC_LAYOUT_PAGE_SIZE);
-        while (!ret && len > 0) {
-                readlen = min_t(size_t, len, (size_t)DOC_LAYOUT_PAGE_SIZE);
+        while (!ret && (len > 0 || ooblen > 0)) {
+                calc_block_sector(from, &block0, &block1, &page, &ofs,
+                        docg3->reliable);
+                nbdata = min_t(size_t, len, (size_t)DOC_LAYOUT_PAGE_SIZE);
+                nboob = min_t(size_t, ooblen, (size_t)DOC_LAYOUT_OOB_SIZE);
                 ret = doc_read_page_prepare(docg3, block0, block1, page, ofs);
                 if (ret < 0)
                         goto err;
-                ret = doc_read_page_ecc_init(docg3, DOC_ECC_BCH_COVERED_BYTES);
+                ret = doc_read_page_ecc_init(docg3, DOC_ECC_BCH_TOTAL_BYTES);
                 if (ret < 0)
                         goto err_in_read;
-                ret = doc_read_page_getbytes(docg3, readlen, buf, 1);
-                if (ret < readlen)
+                ret = doc_read_page_getbytes(docg3, nbdata, buf, 1);
+                if (ret < nbdata)
                         goto err_in_read;
-                ret = doc_read_page_getbytes(docg3, DOC_LAYOUT_OOB_SIZE,
-                                             oob, 0);
-                if (ret < DOC_LAYOUT_OOB_SIZE)
+                doc_read_page_getbytes(docg3, DOC_LAYOUT_PAGE_SIZE - nbdata,
+                                       NULL, 0);
+                ret = doc_read_page_getbytes(docg3, nboob, oobbuf, 0);
+                if (ret < nboob)
                         goto err_in_read;
+                doc_read_page_getbytes(docg3, DOC_LAYOUT_OOB_SIZE - nboob,
+                                       NULL, 0);
 
-                *retlen += readlen;
-                buf += readlen;
-                len -= readlen;
-
-                ofs ^= DOC_LAYOUT_PAGE_OOB_SIZE;
-                if (ofs == 0)
-                        page += 2;
-                if (page > DOC_ADDR_PAGE_MASK) {
-                        page = 0;
-                        block0 += 2;
-                        block1 += 2;
-                }
-
-                /*
-                 * There should be a BCH bitstream fixing algorithm here ...
-                 * By now, a page read failure is triggered by BCH error
-                 */
-                doc_get_hw_bch_syndroms(docg3, syn);
+                doc_get_bch_hw_ecc(docg3, hwecc);
                 eccconf1 = doc_register_readb(docg3, DOC_ECCCONF1);
 
-                doc_dbg("OOB - INFO: %02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
-                         oob[0], oob[1], oob[2], oob[3], oob[4],
-                         oob[5], oob[6]);
-                doc_dbg("OOB - HAMMING: %02x\n", oob[7]);
-                doc_dbg("OOB - BCH_ECC: %02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
-                         oob[8], oob[9], oob[10], oob[11], oob[12],
-                         oob[13], oob[14]);
-                doc_dbg("OOB - UNUSED: %02x\n", oob[15]);
+                if (nboob >= DOC_LAYOUT_OOB_SIZE) {
+                        doc_dbg("OOB - INFO: %02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
+                                oobbuf[0], oobbuf[1], oobbuf[2], oobbuf[3],
+                                oobbuf[4], oobbuf[5], oobbuf[6]);
+                        doc_dbg("OOB - HAMMING: %02x\n", oobbuf[7]);
+                        doc_dbg("OOB - BCH_ECC: %02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
+                                oobbuf[8], oobbuf[9], oobbuf[10], oobbuf[11],
+                                oobbuf[12], oobbuf[13], oobbuf[14]);
+                        doc_dbg("OOB - UNUSED: %02x\n", oobbuf[15]);
+                }
                 doc_dbg("ECC checks: ECCConf1=%x\n", eccconf1);
-                doc_dbg("ECC BCH syndrom: %02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
-                        syn[0], syn[1], syn[2], syn[3], syn[4], syn[5], syn[6]);
-
-                ret = -EBADMSG;
-                if (block0 >= DOC_LAYOUT_BLOCK_FIRST_DATA) {
-                        if (eccconf1 & DOC_ECCCONF1_BCH_SYNDROM_ERR)
-                                goto err_in_read;
-                        if (is_prot_seq_error(docg3))
-                                goto err_in_read;
+                doc_dbg("ECC HW_ECC: %02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
+                        hwecc[0], hwecc[1], hwecc[2], hwecc[3], hwecc[4],
+                        hwecc[5], hwecc[6]);
+
+                ret = -EIO;
+                if (is_prot_seq_error(docg3))
+                        goto err_in_read;
+                ret = 0;
+                if ((block0 >= DOC_LAYOUT_BLOCK_FIRST_DATA) &&
+                    (eccconf1 & DOC_ECCCONF1_BCH_SYNDROM_ERR) &&
+                    (eccconf1 & DOC_ECCCONF1_PAGE_IS_WRITTEN) &&
+                    (ops->mode != MTD_OPS_RAW) &&
+                    (nbdata == DOC_LAYOUT_PAGE_SIZE)) {
+                        ret = doc_ecc_bch_fix_data(docg3, buf, hwecc);
+                        if (ret < 0) {
+                                mtd->ecc_stats.failed++;
+                                ret = -EBADMSG;
+                        }
+                        if (ret > 0) {
+                                mtd->ecc_stats.corrected += ret;
+                                ret = -EUCLEAN;
+                        }
                 }
+
                 doc_read_page_finish(docg3);
+                ops->retlen += nbdata;
+                ops->oobretlen += nboob;
+                buf += nbdata;
+                oobbuf += nboob;
+                len -= nbdata;
+                ooblen -= nboob;
+                from += DOC_LAYOUT_PAGE_SIZE;
         }
 
-        return 0;
+        return ret;
 err_in_read:
         doc_read_page_finish(docg3);
 err:
@@ -642,54 +960,33 @@ err:
 }
 
 /**
- * doc_read_oob - Read out of band bytes from flash
+ * doc_read - Read bytes from flash
  * @mtd: the device
  * @from: the offset from first block and first page, in bytes, aligned on page
  *        size
- * @ops: the mtd oob structure
+ * @len: the number of bytes to read (must be a multiple of 4)
+ * @retlen: the number of bytes actually read
+ * @buf: the filled in buffer
  *
- * Reads flash memory OOB area of pages.
+ * Reads flash memory pages. This function does not read the OOB chunk, but only
+ * the page data.
  *
  * Returns 0 if read successfull, of -EIO, -EINVAL if an error occured
  */
-static int doc_read_oob(struct mtd_info *mtd, loff_t from,
-                        struct mtd_oob_ops *ops)
+static int doc_read(struct mtd_info *mtd, loff_t from, size_t len,
+             size_t *retlen, u_char *buf)
 {
-        struct docg3 *docg3 = mtd->priv;
-        int block0, block1, page, ofs, ret;
-        u8 *buf = ops->oobbuf;
-        size_t len = ops->ooblen;
-
-        doc_dbg("doc_read_oob(from=%lld, buf=%p, len=%zu)\n", from, buf, len);
-        if (len != DOC_LAYOUT_OOB_SIZE)
-                return -EINVAL;
-
-        switch (ops->mode) {
-        case MTD_OPS_PLACE_OOB:
-                buf += ops->ooboffs;
-                break;
-        default:
-                break;
-        }
+        struct mtd_oob_ops ops;
+        size_t ret;
 
-        calc_block_sector(from, &block0, &block1, &page, &ofs);
-        if (block1 > docg3->max_block)
-                return -EINVAL;
-
-        ret = doc_read_page_prepare(docg3, block0, block1, page,
-                                    ofs + DOC_LAYOUT_PAGE_SIZE);
-        if (!ret)
-                ret = doc_read_page_ecc_init(docg3, DOC_LAYOUT_OOB_SIZE);
-        if (!ret)
-                ret = doc_read_page_getbytes(docg3, DOC_LAYOUT_OOB_SIZE,
-                                             buf, 1);
-        doc_read_page_finish(docg3);
+        memset(&ops, 0, sizeof(ops));
+        ops.datbuf = buf;
+        ops.len = len;
+        ops.mode = MTD_OPS_AUTO_OOB;
 
-        if (ret > 0)
-                ops->oobretlen = ret;
-        else
-                ops->oobretlen = 0;
-        return (ret > 0) ? 0 : ret;
+        ret = doc_read_oob(mtd, from, &ops);
+        *retlen = ops.retlen;
+        return ret;
 }
 
 static int doc_reload_bbt(struct docg3 *docg3)
@@ -726,7 +1023,8 @@ static int doc_block_isbad(struct mtd_info *mtd, loff_t from)
         struct docg3 *docg3 = mtd->priv;
         int block0, block1, page, ofs, is_good;
 
-        calc_block_sector(from, &block0, &block1, &page, &ofs);
+        calc_block_sector(from, &block0, &block1, &page, &ofs,
+                docg3->reliable);
         doc_dbg("doc_block_isbad(from=%lld) => block=(%d,%d), page=%d, ofs=%d\n",
                 from, block0, block1, page, ofs);
 
@@ -739,6 +1037,7 @@ static int doc_block_isbad(struct mtd_info *mtd, loff_t from)
         return !is_good;
 }
 
+#if 0
 /**
  * doc_get_erase_count - Get block erase count
  * @docg3: the device
@@ -758,7 +1057,7 @@ static int doc_get_erase_count(struct docg3 *docg3, loff_t from)
         doc_dbg("doc_get_erase_count(from=%lld, buf=%p)\n", from, buf);
         if (from % DOC_LAYOUT_PAGE_SIZE)
                 return -EINVAL;
-        calc_block_sector(from, &block0, &block1, &page, &ofs);
+        calc_block_sector(from, &block0, &block1, &page, &ofs, docg3->reliable);
         if (block1 > docg3->max_block)
                 return -EINVAL;
 
@@ -780,6 +1079,558 @@ static int doc_get_erase_count(struct docg3 *docg3, loff_t from)
 
         return max(plane1_erase_count, plane2_erase_count);
 }
+#endif
+
+/**
+ * doc_get_op_status - get erase/write operation status
+ * @docg3: the device
+ *
+ * Queries the status from the chip, and returns it
+ *
+ * Returns the status (bits DOC_PLANES_STATUS_*)
+ */
+static int doc_get_op_status(struct docg3 *docg3)
+{
+        u8 status;
+
+        doc_flash_sequence(docg3, DOC_SEQ_PLANES_STATUS);
+        doc_flash_command(docg3, DOC_CMD_PLANES_STATUS);
+        doc_delay(docg3, 5);
+
+        doc_ecc_disable(docg3);
+        doc_read_data_area(docg3, &status, 1, 1);
+        return status;
+}
+
+/**
+ * doc_write_erase_wait_status - wait for write or erase completion
+ * @docg3: the device
+ *
+ * Wait for the chip to be ready again after erase or write operation, and check
+ * erase/write status.
+ *
+ * Returns 0 if erase successfull, -EIO if erase/write issue, -ETIMEOUT if
+ * timeout
+ */
+static int doc_write_erase_wait_status(struct docg3 *docg3)
+{
+        int status, ret = 0;
+
+        if (!doc_is_ready(docg3))
+                usleep_range(3000, 3000);
+        if (!doc_is_ready(docg3)) {
+                doc_dbg("Timeout reached and the chip is still not ready\n");
+                ret = -EAGAIN;
+                goto out;
+        }
+
+        status = doc_get_op_status(docg3);
+        if (status & DOC_PLANES_STATUS_FAIL) {
+                doc_dbg("Erase/Write failed on (a) plane(s), status = %x\n",
+                        status);
+                ret = -EIO;
+        }
+
+out:
+        doc_page_finish(docg3);
+        return ret;
+}
+
+/**
+ * doc_erase_block - Erase a couple of blocks
+ * @docg3: the device
+ * @block0: the first block to erase (leftmost plane)
+ * @block1: the second block to erase (rightmost plane)
+ *
+ * Erase both blocks, and return operation status
+ *
+ * Returns 0 if erase successful, -EIO if erase issue, -ETIMEOUT if chip not
+ * ready for too long
+ */
+static int doc_erase_block(struct docg3 *docg3, int block0, int block1)
+{
+        int ret, sector;
+
+        doc_dbg("doc_erase_block(blocks=(%d,%d))\n", block0, block1);
+        ret = doc_reset_seq(docg3);
+        if (ret)
+                return -EIO;
+
+        doc_set_reliable_mode(docg3);
+        doc_flash_sequence(docg3, DOC_SEQ_ERASE);
+
+        sector = block0 << DOC_ADDR_BLOCK_SHIFT;
+        doc_flash_command(docg3, DOC_CMD_PROG_BLOCK_ADDR);
+        doc_setup_addr_sector(docg3, sector);
+        sector = block1 << DOC_ADDR_BLOCK_SHIFT;
+        doc_flash_command(docg3, DOC_CMD_PROG_BLOCK_ADDR);
+        doc_setup_addr_sector(docg3, sector);
+        doc_delay(docg3, 1);
+
+        doc_flash_command(docg3, DOC_CMD_ERASECYCLE2);
+        doc_delay(docg3, 2);
+
+        if (is_prot_seq_error(docg3)) {
+                doc_err("Erase blocks %d,%d error\n", block0, block1);
+                return -EIO;
+        }
+
+        return doc_write_erase_wait_status(docg3);
+}
+
+/**
+ * doc_erase - Erase a portion of the chip
+ * @mtd: the device
+ * @info: the erase info
+ *
+ * Erase a bunch of contiguous blocks, by pairs, as a "mtd" page of 1024 is
+ * split into 2 pages of 512 bytes on 2 contiguous blocks.
+ *
+ * Returns 0 if erase successful, -EINVAL if adressing error, -EIO if erase
+ * issue
+ */
+static int doc_erase(struct mtd_info *mtd, struct erase_info *info)
+{
+        struct docg3 *docg3 = mtd->priv;
+        uint64_t len;
+        int block0, block1, page, ret, ofs = 0;
+
+        doc_dbg("doc_erase(from=%lld, len=%lld\n", info->addr, info->len);
+        doc_set_device_id(docg3, docg3->device_id);
+
+        info->state = MTD_ERASE_PENDING;
+        calc_block_sector(info->addr + info->len, &block0, &block1, &page,
+                          &ofs, docg3->reliable);
+        ret = -EINVAL;
+        if (block1 > docg3->max_block || page || ofs)
+                goto reset_err;
+
+        ret = 0;
+        calc_block_sector(info->addr, &block0, &block1, &page, &ofs,
+                          docg3->reliable);
+        doc_set_reliable_mode(docg3);
+        for (len = info->len; !ret && len > 0; len -= mtd->erasesize) {
+                info->state = MTD_ERASING;
+                ret = doc_erase_block(docg3, block0, block1);
+                block0 += 2;
+                block1 += 2;
+        }
+
+        if (ret)
+                goto reset_err;
+
+        info->state = MTD_ERASE_DONE;
+        return 0;
+
+reset_err:
+        info->state = MTD_ERASE_FAILED;
+        return ret;
+}
+
+/**
+ * doc_write_page - Write a single page to the chip
+ * @docg3: the device
+ * @to: the offset from first block and first page, in bytes, aligned on page
+ *      size
+ * @buf: buffer to get bytes from
+ * @oob: buffer to get out of band bytes from (can be NULL if no OOB should be
+ *       written)
+ * @autoecc: if 0, all 16 bytes from OOB are taken, regardless of HW Hamming or
+ *           BCH computations. If 1, only bytes 0-7 and byte 15 are taken,
+ *           remaining ones are filled with hardware Hamming and BCH
+ *           computations. Its value is not meaningfull is oob == NULL.
+ *
+ * Write one full page (ie. 1 page split on two planes), of 512 bytes, with the
+ * OOB data. The OOB ECC is automatically computed by the hardware Hamming and
+ * BCH generator if autoecc is not null.
+ *
+ * Returns 0 if write successful, -EIO if write error, -EAGAIN if timeout
+ */
+static int doc_write_page(struct docg3 *docg3, loff_t to, const u_char *buf,
+                          const u_char *oob, int autoecc)
+{
+        int block0, block1, page, ret, ofs = 0;
+        u8 hwecc[DOC_ECC_BCH_SIZE], hamming;
+
+        doc_dbg("doc_write_page(to=%lld)\n", to);
+        calc_block_sector(to, &block0, &block1, &page, &ofs, docg3->reliable);
+
+        doc_set_device_id(docg3, docg3->device_id);
+        ret = doc_reset_seq(docg3);
+        if (ret)
+                goto err;
+
+        /* Program the flash address block and page */
+        ret = doc_write_seek(docg3, block0, block1, page, ofs);
+        if (ret)
+                goto err;
+
+        doc_write_page_ecc_init(docg3, DOC_ECC_BCH_TOTAL_BYTES);
+        doc_delay(docg3, 2);
+        doc_write_page_putbytes(docg3, DOC_LAYOUT_PAGE_SIZE, buf);
+
+        if (oob && autoecc) {
+                doc_write_page_putbytes(docg3, DOC_LAYOUT_OOB_PAGEINFO_SZ, oob);
+                doc_delay(docg3, 2);
+                oob += DOC_LAYOUT_OOB_UNUSED_OFS;
+
+                hamming = doc_register_readb(docg3, DOC_HAMMINGPARITY);
+                doc_delay(docg3, 2);
+                doc_write_page_putbytes(docg3, DOC_LAYOUT_OOB_HAMMING_SZ,
+                                        &hamming);
+                doc_delay(docg3, 2);
+
+                doc_get_bch_hw_ecc(docg3, hwecc);
+                doc_write_page_putbytes(docg3, DOC_LAYOUT_OOB_BCH_SZ, hwecc);
+                doc_delay(docg3, 2);
+
+                doc_write_page_putbytes(docg3, DOC_LAYOUT_OOB_UNUSED_SZ, oob);
+        }
+        if (oob && !autoecc)
+                doc_write_page_putbytes(docg3, DOC_LAYOUT_OOB_SIZE, oob);
+
+        doc_delay(docg3, 2);
+        doc_page_finish(docg3);
+        doc_delay(docg3, 2);
+        doc_flash_command(docg3, DOC_CMD_PROG_CYCLE2);
+        doc_delay(docg3, 2);
+
+        /*
+         * The wait status will perform another doc_page_finish() call, but that
+         * seems to please the docg3, so leave it.
+         */
+        ret = doc_write_erase_wait_status(docg3);
+        return ret;
+err:
+        doc_read_page_finish(docg3);
+        return ret;
+}
+
+/**
+ * doc_guess_autoecc - Guess autoecc mode from mbd_oob_ops
+ * @ops: the oob operations
+ *
+ * Returns 0 or 1 if success, -EINVAL if invalid oob mode
+ */
+static int doc_guess_autoecc(struct mtd_oob_ops *ops)
+{
+        int autoecc;
+
+        switch (ops->mode) {
+        case MTD_OPS_PLACE_OOB:
+        case MTD_OPS_AUTO_OOB:
+                autoecc = 1;
+                break;
+        case MTD_OPS_RAW:
+                autoecc = 0;
+                break;
+        default:
+                autoecc = -EINVAL;
+        }
+        return autoecc;
+}
+
+/**
+ * doc_fill_autooob - Fill a 16 bytes OOB from 8 non-ECC bytes
+ * @dst: the target 16 bytes OOB buffer
+ * @oobsrc: the source 8 bytes non-ECC OOB buffer
+ *
+ */
+static void doc_fill_autooob(u8 *dst, u8 *oobsrc)
+{
+        memcpy(dst, oobsrc, DOC_LAYOUT_OOB_PAGEINFO_SZ);
+        dst[DOC_LAYOUT_OOB_UNUSED_OFS] = oobsrc[DOC_LAYOUT_OOB_PAGEINFO_SZ];
+}
+
+/**
+ * doc_backup_oob - Backup OOB into docg3 structure
+ * @docg3: the device
+ * @to: the page offset in the chip
+ * @ops: the OOB size and buffer
+ *
+ * As the docg3 should write a page with its OOB in one pass, and some userland
+ * applications do write_oob() to setup the OOB and then write(), store the OOB
+ * into a temporary storage. This is very dangerous, as 2 concurrent
+ * applications could store an OOB, and then write their pages (which will
+ * result into one having its OOB corrupted).
+ *
+ * The only reliable way would be for userland to call doc_write_oob() with both
+ * the page data _and_ the OOB area.
+ *
+ * Returns 0 if success, -EINVAL if ops content invalid
+ */
+static int doc_backup_oob(struct docg3 *docg3, loff_t to,
+                          struct mtd_oob_ops *ops)
+{
+        int ooblen = ops->ooblen, autoecc;
+
+        if (ooblen != DOC_LAYOUT_OOB_SIZE)
+                return -EINVAL;
+        autoecc = doc_guess_autoecc(ops);
+        if (autoecc < 0)
+                return autoecc;
+
+        docg3->oob_write_ofs = to;
+        docg3->oob_autoecc = autoecc;
+        if (ops->mode == MTD_OPS_AUTO_OOB) {
+                doc_fill_autooob(docg3->oob_write_buf, ops->oobbuf);
+                ops->oobretlen = 8;
+        } else {
+                memcpy(docg3->oob_write_buf, ops->oobbuf, DOC_LAYOUT_OOB_SIZE);
+                ops->oobretlen = DOC_LAYOUT_OOB_SIZE;
+        }
+        return 0;
+}
+
+/**
+ * doc_write_oob - Write out of band bytes to flash
+ * @mtd: the device
+ * @ofs: the offset from first block and first page, in bytes, aligned on page
+ *       size
+ * @ops: the mtd oob structure
+ *
+ * Either write OOB data into a temporary buffer, for the subsequent write
+ * page. The provided OOB should be 16 bytes long. If a data buffer is provided
+ * as well, issue the page write.
+ * Or provide data without OOB, and then a all zeroed OOB will be used (ECC will
+ * still be filled in if asked for).
+ *
+ * Returns 0 is successfull, EINVAL if length is not 14 bytes
+ */
+static int doc_write_oob(struct mtd_info *mtd, loff_t ofs,
+                         struct mtd_oob_ops *ops)
+{
+        struct docg3 *docg3 = mtd->priv;
+        int block0, block1, page, ret, pofs = 0, autoecc, oobdelta;
+        u8 *oobbuf = ops->oobbuf;
+        u8 *buf = ops->datbuf;
+        size_t len, ooblen;
+        u8 oob[DOC_LAYOUT_OOB_SIZE];
+
+        if (buf)
+                len = ops->len;
+        else
+                len = 0;
+        if (oobbuf)
+                ooblen = ops->ooblen;
+        else
+                ooblen = 0;
+
+        if (oobbuf && ops->mode == MTD_OPS_PLACE_OOB)
+                oobbuf += ops->ooboffs;
+
+        doc_dbg("doc_write_oob(from=%lld, mode=%d, data=(%p:%zu), oob=(%p:%zu))\n",
+                ofs, ops->mode, buf, len, oobbuf, ooblen);
+        switch (ops->mode) {
+        case MTD_OPS_PLACE_OOB:
+        case MTD_OPS_RAW:
+                oobdelta = mtd->oobsize;
+                break;
+        case MTD_OPS_AUTO_OOB:
+                oobdelta = mtd->ecclayout->oobavail;
+                break;
+        default:
+                oobdelta = 0;
+        }
+        if ((len % DOC_LAYOUT_PAGE_SIZE) || (ooblen % oobdelta) ||
+            (ofs % DOC_LAYOUT_PAGE_SIZE))
+                return -EINVAL;
+        if (len && ooblen &&
+            (len / DOC_LAYOUT_PAGE_SIZE) != (ooblen / oobdelta))
+                return -EINVAL;
+
+        ret = -EINVAL;
+        calc_block_sector(ofs + len, &block0, &block1, &page, &pofs,
+                          docg3->reliable);
+        if (block1 > docg3->max_block)
+                goto err;
+
+        ops->oobretlen = 0;
+        ops->retlen = 0;
+        ret = 0;
+        if (len == 0 && ooblen == 0)
+                return -EINVAL;
+        if (len == 0 && ooblen > 0)
+                return doc_backup_oob(docg3, ofs, ops);
+
+        autoecc = doc_guess_autoecc(ops);
+        if (autoecc < 0)
+                return autoecc;
+
+        while (!ret && len > 0) {
+                memset(oob, 0, sizeof(oob));
+                if (ofs == docg3->oob_write_ofs)
+                        memcpy(oob, docg3->oob_write_buf, DOC_LAYOUT_OOB_SIZE);
+                else if (ooblen > 0 && ops->mode == MTD_OPS_AUTO_OOB)
+                        doc_fill_autooob(oob, oobbuf);
+                else if (ooblen > 0)
+                        memcpy(oob, oobbuf, DOC_LAYOUT_OOB_SIZE);
+                ret = doc_write_page(docg3, ofs, buf, oob, autoecc);
+
+                ofs += DOC_LAYOUT_PAGE_SIZE;
+                len -= DOC_LAYOUT_PAGE_SIZE;
+                buf += DOC_LAYOUT_PAGE_SIZE;
+                if (ooblen) {
+                        oobbuf += oobdelta;
+                        ooblen -= oobdelta;
+                        ops->oobretlen += oobdelta;
+                }
+                ops->retlen += DOC_LAYOUT_PAGE_SIZE;
+        }
+err:
+        doc_set_device_id(docg3, 0);
+        return ret;
+}
+
+/**
+ * doc_write - Write a buffer to the chip
+ * @mtd: the device
+ * @to: the offset from first block and first page, in bytes, aligned on page
+ *      size
+ * @len: the number of bytes to write (must be a full page size, ie. 512)
+ * @retlen: the number of bytes actually written (0 or 512)
+ * @buf: the buffer to get bytes from
+ *
+ * Writes data to the chip.
+ *
+ * Returns 0 if write successful, -EIO if write error
+ */
+static int doc_write(struct mtd_info *mtd, loff_t to, size_t len,
+                     size_t *retlen, const u_char *buf)
+{
+        struct docg3 *docg3 = mtd->priv;
+        int ret;
+        struct mtd_oob_ops ops;
+
+        doc_dbg("doc_write(to=%lld, len=%zu)\n", to, len);
+        ops.datbuf = (char *)buf;
+        ops.len = len;
+        ops.mode = MTD_OPS_PLACE_OOB;
+        ops.oobbuf = NULL;
+        ops.ooblen = 0;
+        ops.ooboffs = 0;
+
+        ret = doc_write_oob(mtd, to, &ops);
+        *retlen = ops.retlen;
+        return ret;
+}
+
+static struct docg3 *sysfs_dev2docg3(struct device *dev,
+                                     struct device_attribute *attr)
+{
+        int floor;
+        struct platform_device *pdev = to_platform_device(dev);
+        struct mtd_info **docg3_floors = platform_get_drvdata(pdev);
+
+        floor = attr->attr.name[1] - '0';
+        if (floor < 0 || floor >= DOC_MAX_NBFLOORS)
+                return NULL;
+        else
+                return docg3_floors[floor]->priv;
+}
+
+static ssize_t dps0_is_key_locked(struct device *dev,
+                                  struct device_attribute *attr, char *buf)
+{
+        struct docg3 *docg3 = sysfs_dev2docg3(dev, attr);
+        int dps0;
+
+        doc_set_device_id(docg3, docg3->device_id);
+        dps0 = doc_register_readb(docg3, DOC_DPS0_STATUS);
+        doc_set_device_id(docg3, 0);
+
+        return sprintf(buf, "%d\n", !(dps0 & DOC_DPS_KEY_OK));
+}
+
+static ssize_t dps1_is_key_locked(struct device *dev,
+                                  struct device_attribute *attr, char *buf)
+{
+        struct docg3 *docg3 = sysfs_dev2docg3(dev, attr);
+        int dps1;
+
+        doc_set_device_id(docg3, docg3->device_id);
+        dps1 = doc_register_readb(docg3, DOC_DPS1_STATUS);
+        doc_set_device_id(docg3, 0);
+
+        return sprintf(buf, "%d\n", !(dps1 & DOC_DPS_KEY_OK));
+}
+
+static ssize_t dps0_insert_key(struct device *dev,
+                               struct device_attribute *attr,
+                               const char *buf, size_t count)
+{
+        struct docg3 *docg3 = sysfs_dev2docg3(dev, attr);
+        int i;
+
+        if (count != DOC_LAYOUT_DPS_KEY_LENGTH)
+                return -EINVAL;
+
+        doc_set_device_id(docg3, docg3->device_id);
+        for (i = 0; i < DOC_LAYOUT_DPS_KEY_LENGTH; i++)
+                doc_writeb(docg3, buf[i], DOC_DPS0_KEY);
+        doc_set_device_id(docg3, 0);
+        return count;
+}
+
+static ssize_t dps1_insert_key(struct device *dev,
+                               struct device_attribute *attr,
+                               const char *buf, size_t count)
+{
+        struct docg3 *docg3 = sysfs_dev2docg3(dev, attr);
+        int i;
+
+        if (count != DOC_LAYOUT_DPS_KEY_LENGTH)
+                return -EINVAL;
+
+        doc_set_device_id(docg3, docg3->device_id);
+        for (i = 0; i < DOC_LAYOUT_DPS_KEY_LENGTH; i++)
+                doc_writeb(docg3, buf[i], DOC_DPS1_KEY);
+        doc_set_device_id(docg3, 0);
+        return count;
+}
+
+#define FLOOR_SYSFS(id) { \
+        __ATTR(f##id##_dps0_is_keylocked, S_IRUGO, dps0_is_key_locked, NULL), \
+        __ATTR(f##id##_dps1_is_keylocked, S_IRUGO, dps1_is_key_locked, NULL), \
+        __ATTR(f##id##_dps0_protection_key, S_IWUGO, NULL, dps0_insert_key), \
+        __ATTR(f##id##_dps1_protection_key, S_IWUGO, NULL, dps1_insert_key), \
+}
+
+static struct device_attribute doc_sys_attrs[DOC_MAX_NBFLOORS][4] = {
+        FLOOR_SYSFS(0), FLOOR_SYSFS(1), FLOOR_SYSFS(2), FLOOR_SYSFS(3)
+};
+
+static int doc_register_sysfs(struct platform_device *pdev,
+                              struct mtd_info **floors)
+{
+        int ret = 0, floor, i = 0;
+        struct device *dev = &pdev->dev;
+
+        for (floor = 0; !ret && floor < DOC_MAX_NBFLOORS && floors[floor];
+             floor++)
+                for (i = 0; !ret && i < 4; i++)
+                        ret = device_create_file(dev, &doc_sys_attrs[floor][i]);
+        if (!ret)
+                return 0;
+        do {
+                while (--i >= 0)
+                        device_remove_file(dev, &doc_sys_attrs[floor][i]);
+                i = 4;
+        } while (--floor >= 0);
+        return ret;
+}
+
+static void doc_unregister_sysfs(struct platform_device *pdev,
+                                 struct mtd_info **floors)
+{
+        struct device *dev = &pdev->dev;
+        int floor, i;
+
+        for (floor = 0; floor < DOC_MAX_NBFLOORS && floors[floor];
+             floor++)
+                for (i = 0; i < 4; i++)
+                        device_remove_file(dev, &doc_sys_attrs[floor][i]);
+}
 
 /*
  * Debug sysfs entries
@@ -852,13 +1703,15 @@ static int dbg_protection_show(struct seq_file *s, void *p)
 {
         struct docg3 *docg3 = (struct docg3 *)s->private;
         int pos = 0;
-        int protect = doc_register_readb(docg3, DOC_PROTECTION);
-        int dps0 = doc_register_readb(docg3, DOC_DPS0_STATUS);
-        int dps0_low = doc_register_readb(docg3, DOC_DPS0_ADDRLOW);
-        int dps0_high = doc_register_readb(docg3, DOC_DPS0_ADDRHIGH);
-        int dps1 = doc_register_readb(docg3, DOC_DPS1_STATUS);
-        int dps1_low = doc_register_readb(docg3, DOC_DPS1_ADDRLOW);
-        int dps1_high = doc_register_readb(docg3, DOC_DPS1_ADDRHIGH);
+        int protect, dps0, dps0_low, dps0_high, dps1, dps1_low, dps1_high;
+
+        protect = doc_register_readb(docg3, DOC_PROTECTION);
+        dps0 = doc_register_readb(docg3, DOC_DPS0_STATUS);
+        dps0_low = doc_register_readw(docg3, DOC_DPS0_ADDRLOW);
+        dps0_high = doc_register_readw(docg3, DOC_DPS0_ADDRHIGH);
+        dps1 = doc_register_readb(docg3, DOC_DPS1_STATUS);
+        dps1_low = doc_register_readw(docg3, DOC_DPS1_ADDRLOW);
+        dps1_high = doc_register_readw(docg3, DOC_DPS1_ADDRHIGH);
 
         pos += seq_printf(s, "Protection = 0x%02x (",
                          protect);
@@ -947,52 +1800,54 @@ static void __init doc_set_driver_info(int chip_id, struct mtd_info *mtd)
 
         cfg = doc_register_readb(docg3, DOC_CONFIGURATION);
         docg3->if_cfg = (cfg & DOC_CONF_IF_CFG ? 1 : 0);
+        docg3->reliable = reliable_mode;
 
         switch (chip_id) {
         case DOC_CHIPID_G3:
-                mtd->name = "DiskOnChip G3";
+                mtd->name = kasprintf(GFP_KERNEL, "DiskOnChip G3 floor %d",
+                                      docg3->device_id);
                 docg3->max_block = 2047;
                 break;
         }
         mtd->type = MTD_NANDFLASH;
-        /*
-         * Once write methods are added, the correct flags will be set.
-         * mtd->flags = MTD_CAP_NANDFLASH;
-         */
-        mtd->flags = MTD_CAP_ROM;
+        mtd->flags = MTD_CAP_NANDFLASH;
         mtd->size = (docg3->max_block + 1) * DOC_LAYOUT_BLOCK_SIZE;
+        if (docg3->reliable == 2)
+                mtd->size /= 2;
         mtd->erasesize = DOC_LAYOUT_BLOCK_SIZE * DOC_LAYOUT_NBPLANES;
+        if (docg3->reliable == 2)
+                mtd->erasesize /= 2;
         mtd->writesize = DOC_LAYOUT_PAGE_SIZE;
         mtd->oobsize = DOC_LAYOUT_OOB_SIZE;
         mtd->owner = THIS_MODULE;
-        mtd->erase = NULL;
-        mtd->point = NULL;
-        mtd->unpoint = NULL;
+        mtd->erase = doc_erase;
         mtd->read = doc_read;
-        mtd->write = NULL;
+        mtd->write = doc_write;
         mtd->read_oob = doc_read_oob;
-        mtd->write_oob = NULL;
-        mtd->sync = NULL;
+        mtd->write_oob = doc_write_oob;
         mtd->block_isbad = doc_block_isbad;
+        mtd->ecclayout = &docg3_oobinfo;
 }
 
 /**
- * doc_probe - Probe the IO space for a DiskOnChip G3 chip
- * @pdev: platform device
+ * doc_probe_device - Check if a device is available
+ * @base: the io space where the device is probed
+ * @floor: the floor of the probed device
+ * @dev: the device
  *
- * Probes for a G3 chip at the specified IO space in the platform data
- * ressources.
+ * Checks whether a device at the specified IO range, and floor is available.
  *
- * Returns 0 on success, -ENOMEM, -ENXIO on error
+ * Returns a mtd_info struct if there is a device, ENODEV if none found, ENOMEM
+ * if a memory allocation failed. If floor 0 is checked, a reset of the ASIC is
+ * launched.
  */
-static int __init docg3_probe(struct platform_device *pdev)
+static struct mtd_info *doc_probe_device(void __iomem *base, int floor,
+                                         struct device *dev)
 {
-        struct device *dev = &pdev->dev;
-        struct docg3 *docg3;
-        struct mtd_info *mtd;
-        struct resource *ress;
         int ret, bbt_nbpages;
         u16 chip_id, chip_id_inv;
+        struct docg3 *docg3;
+        struct mtd_info *mtd;
 
         ret = -ENOMEM;
         docg3 = kzalloc(sizeof(struct docg3), GFP_KERNEL);
@@ -1002,69 +1857,218 @@ static int __init docg3_probe(struct platform_device *pdev)
         if (!mtd)
                 goto nomem2;
         mtd->priv = docg3;
+        bbt_nbpages = DIV_ROUND_UP(docg3->max_block + 1,
+                                   8 * DOC_LAYOUT_PAGE_SIZE);
+        docg3->bbt = kzalloc(bbt_nbpages * DOC_LAYOUT_PAGE_SIZE, GFP_KERNEL);
+        if (!docg3->bbt)
+                goto nomem3;
 
-        ret = -ENXIO;
-        ress = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-        if (!ress) {
-                dev_err(dev, "No I/O memory resource defined\n");
-                goto noress;
-        }
-        docg3->base = ioremap(ress->start, DOC_IOSPACE_SIZE);
-
-        docg3->dev = &pdev->dev;
-        docg3->device_id = 0;
+        docg3->dev = dev;
+        docg3->device_id = floor;
+        docg3->base = base;
         doc_set_device_id(docg3, docg3->device_id);
-        doc_set_asic_mode(docg3, DOC_ASICMODE_RESET);
+        if (!floor)
+                doc_set_asic_mode(docg3, DOC_ASICMODE_RESET);
         doc_set_asic_mode(docg3, DOC_ASICMODE_NORMAL);
 
         chip_id = doc_register_readw(docg3, DOC_CHIPID);
         chip_id_inv = doc_register_readw(docg3, DOC_CHIPID_INV);
 
-        ret = -ENODEV;
+        ret = 0;
         if (chip_id != (u16)(~chip_id_inv)) {
-                doc_info("No device found at IO addr %p\n",
-                         (void *)ress->start);
-                goto nochipfound;
+                goto nomem3;
         }
 
         switch (chip_id) {
         case DOC_CHIPID_G3:
-                doc_info("Found a G3 DiskOnChip at addr %p\n",
-                         (void *)ress->start);
+                doc_info("Found a G3 DiskOnChip at addr %p, floor %d\n",
+                         base, floor);
                 break;
         default:
                 doc_err("Chip id %04x is not a DiskOnChip G3 chip\n", chip_id);
-                goto nochipfound;
+                goto nomem3;
         }
 
         doc_set_driver_info(chip_id, mtd);
-        platform_set_drvdata(pdev, mtd);
 
-        ret = -ENOMEM;
-        bbt_nbpages = DIV_ROUND_UP(docg3->max_block + 1,
-                                   8 * DOC_LAYOUT_PAGE_SIZE);
-        docg3->bbt = kzalloc(bbt_nbpages * DOC_LAYOUT_PAGE_SIZE, GFP_KERNEL);
-        if (!docg3->bbt)
-                goto nochipfound;
+        doc_hamming_ecc_init(docg3, DOC_LAYOUT_OOB_PAGEINFO_SZ);
         doc_reload_bbt(docg3);
+        return mtd;
 
-        ret = mtd_device_parse_register(mtd, part_probes,
-                                        NULL, NULL, 0);
-        if (ret)
-                goto register_error;
+nomem3:
+        kfree(mtd);
+nomem2:
+        kfree(docg3);
+nomem1:
+        return ERR_PTR(ret);
+}
 
-        doc_dbg_register(docg3);
-        return 0;
+/**
+ * doc_release_device - Release a docg3 floor
+ * @mtd: the device
+ */
+static void doc_release_device(struct mtd_info *mtd)
+{
+        struct docg3 *docg3 = mtd->priv;
 
-register_error:
+        mtd_device_unregister(mtd);
         kfree(docg3->bbt);
-nochipfound:
-        iounmap(docg3->base);
-noress:
+        kfree(docg3);
+        kfree(mtd->name);
         kfree(mtd);
+}
+
+/**
+ * docg3_resume - Awakens docg3 floor
+ * @pdev: platfrom device
+ *
+ * Returns 0 (always successfull)
+ */
+static int docg3_resume(struct platform_device *pdev)
+{
+        int i;
+        struct mtd_info **docg3_floors, *mtd;
+        struct docg3 *docg3;
+
+        docg3_floors = platform_get_drvdata(pdev);
+        mtd = docg3_floors[0];
+        docg3 = mtd->priv;
+
+        doc_dbg("docg3_resume()\n");
+        for (i = 0; i < 12; i++)
+                doc_readb(docg3, DOC_IOSPACE_IPL);
+        return 0;
+}
+
+/**
+ * docg3_suspend - Put in low power mode the docg3 floor
+ * @pdev: platform device
+ * @state: power state
+ *
+ * Shuts off most of docg3 circuitery to lower power consumption.
+ *
+ * Returns 0 if suspend succeeded, -EIO if chip refused suspend
+ */
+static int docg3_suspend(struct platform_device *pdev, pm_message_t state)
+{
+        int floor, i;
+        struct mtd_info **docg3_floors, *mtd;
+        struct docg3 *docg3;
+        u8 ctrl, pwr_down;
+
+        docg3_floors = platform_get_drvdata(pdev);
+        for (floor = 0; floor < DOC_MAX_NBFLOORS; floor++) {
+                mtd = docg3_floors[floor];
+                if (!mtd)
+                        continue;
+                docg3 = mtd->priv;
+
+                doc_writeb(docg3, floor, DOC_DEVICESELECT);
+                ctrl = doc_register_readb(docg3, DOC_FLASHCONTROL);
+                ctrl &= ~DOC_CTRL_VIOLATION & ~DOC_CTRL_CE;
+                doc_writeb(docg3, ctrl, DOC_FLASHCONTROL);
+
+                for (i = 0; i < 10; i++) {
+                        usleep_range(3000, 4000);
+                        pwr_down = doc_register_readb(docg3, DOC_POWERMODE);
+                        if (pwr_down & DOC_POWERDOWN_READY)
+                                break;
+                }
+                if (pwr_down & DOC_POWERDOWN_READY) {
+                        doc_dbg("docg3_suspend(): floor %d powerdown ok\n",
+                                floor);
+                } else {
+                        doc_err("docg3_suspend(): floor %d powerdown failed\n",
+                                floor);
+                        return -EIO;
+                }
+        }
+
+        mtd = docg3_floors[0];
+        docg3 = mtd->priv;
+        doc_set_asic_mode(docg3, DOC_ASICMODE_POWERDOWN);
+        return 0;
+}
+
+/**
+ * doc_probe - Probe the IO space for a DiskOnChip G3 chip
+ * @pdev: platform device
+ *
+ * Probes for a G3 chip at the specified IO space in the platform data
+ * ressources. The floor 0 must be available.
+ *
+ * Returns 0 on success, -ENOMEM, -ENXIO on error
+ */
+static int __init docg3_probe(struct platform_device *pdev)
+{
+        struct device *dev = &pdev->dev;
+        struct mtd_info *mtd;
+        struct resource *ress;
+        void __iomem *base;
+        int ret, floor, found = 0;
+        struct mtd_info **docg3_floors;
+
+        ret = -ENXIO;
+        ress = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+        if (!ress) {
+                dev_err(dev, "No I/O memory resource defined\n");
+                goto noress;
+        }
+        base = ioremap(ress->start, DOC_IOSPACE_SIZE);
+
+        ret = -ENOMEM;
+        docg3_floors = kzalloc(sizeof(*docg3_floors) * DOC_MAX_NBFLOORS,
+                               GFP_KERNEL);
+        if (!docg3_floors)
+                goto nomem1;
+        docg3_bch = init_bch(DOC_ECC_BCH_M, DOC_ECC_BCH_T,
+                             DOC_ECC_BCH_PRIMPOLY);
+        if (!docg3_bch)
+                goto nomem2;
+
+        for (floor = 0; floor < DOC_MAX_NBFLOORS; floor++) {
+                mtd = doc_probe_device(base, floor, dev);
+                if (IS_ERR(mtd)) {
+                        ret = PTR_ERR(mtd);
+                        goto err_probe;
+                }
+                if (!mtd) {
+                        if (floor == 0)
+                                goto notfound;
+                        else
+                                continue;
+                }
+                docg3_floors[floor] = mtd;
+                ret = mtd_device_parse_register(mtd, part_probes, NULL, NULL,
+                                                0);
+                if (ret)
+                        goto err_probe;
+                found++;
+        }
+
+        ret = doc_register_sysfs(pdev, docg3_floors);
+        if (ret)
+                goto err_probe;
+        if (!found)
+                goto notfound;
+
+        platform_set_drvdata(pdev, docg3_floors);
+        doc_dbg_register(docg3_floors[0]->priv);
+        return 0;
+
+notfound:
+        ret = -ENODEV;
+        dev_info(dev, "No supported DiskOnChip found\n");
+err_probe:
+        free_bch(docg3_bch);
+        for (floor = 0; floor < DOC_MAX_NBFLOORS; floor++)
+                if (docg3_floors[floor])
+                        doc_release_device(docg3_floors[floor]);
 nomem2:
-        kfree(docg3);
+        kfree(docg3_floors);
 nomem1:
+        iounmap(base);
+noress:
         return ret;
 }
 
@@ -1076,15 +2080,20 @@ nomem1:
  */
 static int __exit docg3_release(struct platform_device *pdev)
 {
-        struct mtd_info *mtd = platform_get_drvdata(pdev);
-        struct docg3 *docg3 = mtd->priv;
+        struct mtd_info **docg3_floors = platform_get_drvdata(pdev);
+        struct docg3 *docg3 = docg3_floors[0]->priv;
+        void __iomem *base = docg3->base;
+        int floor;
 
+        doc_unregister_sysfs(pdev, docg3_floors);
         doc_dbg_unregister(docg3);
-        mtd_device_unregister(mtd);
-        iounmap(docg3->base);
-        kfree(docg3->bbt);
-        kfree(docg3);
-        kfree(mtd);
+        for (floor = 0; floor < DOC_MAX_NBFLOORS; floor++)
+                if (docg3_floors[floor])
+                        doc_release_device(docg3_floors[floor]);
+
+        kfree(docg3_floors);
+        free_bch(docg3_bch);
+        iounmap(base);
         return 0;
 }
 
@@ -1093,6 +2102,8 @@ static struct platform_driver g3_driver = {
                 .name   = "docg3",
                 .owner  = THIS_MODULE,
         },
+        .suspend        = docg3_suspend,
+        .resume         = docg3_resume,
         .remove         = __exit_p(docg3_release),
 };
 
diff --git a/drivers/mtd/devices/docg3.h b/drivers/mtd/devices/docg3.h
index 0d407be24594..db0da436b493 100644
--- a/drivers/mtd/devices/docg3.h
+++ b/drivers/mtd/devices/docg3.h
@@ -51,10 +51,19 @@
 #define DOC_LAYOUT_WEAR_OFFSET          (DOC_LAYOUT_PAGE_OOB_SIZE * 2)
 #define DOC_LAYOUT_BLOCK_SIZE                                   \
         (DOC_LAYOUT_PAGES_PER_BLOCK * DOC_LAYOUT_PAGE_SIZE)
+
+/*
+ * ECC related constants
+ */
+#define DOC_ECC_BCH_M                   14
+#define DOC_ECC_BCH_T                   4
+#define DOC_ECC_BCH_PRIMPOLY            0x4443
 #define DOC_ECC_BCH_SIZE                7
 #define DOC_ECC_BCH_COVERED_BYTES                               \
         (DOC_LAYOUT_PAGE_SIZE + DOC_LAYOUT_OOB_PAGEINFO_SZ +    \
-         DOC_LAYOUT_OOB_HAMMING_SZ + DOC_LAYOUT_OOB_BCH_SZ)
+         DOC_LAYOUT_OOB_HAMMING_SZ)
+#define DOC_ECC_BCH_TOTAL_BYTES                                 \
+        (DOC_ECC_BCH_COVERED_BYTES + DOC_LAYOUT_OOB_BCH_SZ)
 
 /*
  * Blocks distribution
@@ -80,6 +89,7 @@
 
 #define DOC_CHIPID_G3                   0x200
 #define DOC_ERASE_MARK                  0xaa
+#define DOC_MAX_NBFLOORS                4
 /*
  * Flash registers
  */
@@ -105,9 +115,11 @@
 #define DOC_ECCCONF1                    0x1042
 #define DOC_ECCPRESET                   0x1044
 #define DOC_HAMMINGPARITY               0x1046
-#define DOC_BCH_SYNDROM(idx)            (0x1048 + (idx << 1))
+#define DOC_BCH_HW_ECC(idx)             (0x1048 + idx)
 
 #define DOC_PROTECTION                  0x1056
+#define DOC_DPS0_KEY                    0x105c
+#define DOC_DPS1_KEY                    0x105e
 #define DOC_DPS0_ADDRLOW                0x1060
 #define DOC_DPS0_ADDRHIGH               0x1062
 #define DOC_DPS1_ADDRLOW                0x1064
@@ -117,6 +129,7 @@
 
 #define DOC_ASICMODECONFIRM             0x1072
 #define DOC_CHIPID_INV                  0x1074
+#define DOC_POWERMODE                   0x107c
 
 /*
  * Flash sequences
@@ -124,11 +137,14 @@
  */
 #define DOC_SEQ_RESET                   0x00
 #define DOC_SEQ_PAGE_SIZE_532           0x03
-#define DOC_SEQ_SET_MODE                0x09
+#define DOC_SEQ_SET_FASTMODE            0x05
+#define DOC_SEQ_SET_RELIABLEMODE        0x09
 #define DOC_SEQ_READ                    0x12
 #define DOC_SEQ_SET_PLANE1              0x0e
 #define DOC_SEQ_SET_PLANE2              0x10
 #define DOC_SEQ_PAGE_SETUP              0x1d
+#define DOC_SEQ_ERASE                   0x27
+#define DOC_SEQ_PLANES_STATUS           0x31
 
 /*
  * Flash commands
@@ -143,7 +159,10 @@
 #define DOC_CMD_PROG_BLOCK_ADDR         0x60
 #define DOC_CMD_PROG_CYCLE1             0x80
 #define DOC_CMD_PROG_CYCLE2             0x10
+#define DOC_CMD_PROG_CYCLE3             0x11
 #define DOC_CMD_ERASECYCLE2             0xd0
+#define DOC_CMD_READ_STATUS             0x70
+#define DOC_CMD_PLANES_STATUS           0x71
 
 #define DOC_CMD_RELIABLE_MODE           0x22
 #define DOC_CMD_FAST_MODE               0xa2
@@ -174,6 +193,7 @@
 /*
  * Flash register : DOC_ECCCONF0
  */
+#define DOC_ECCCONF0_WRITE_MODE         0x0000
 #define DOC_ECCCONF0_READ_MODE          0x8000
 #define DOC_ECCCONF0_AUTO_ECC_ENABLE    0x4000
 #define DOC_ECCCONF0_HAMMING_ENABLE     0x1000
@@ -185,7 +205,7 @@
  */
 #define DOC_ECCCONF1_BCH_SYNDROM_ERR    0x80
 #define DOC_ECCCONF1_UNKOWN1            0x40
-#define DOC_ECCCONF1_UNKOWN2            0x20
+#define DOC_ECCCONF1_PAGE_IS_WRITTEN    0x20
 #define DOC_ECCCONF1_UNKOWN3            0x10
 #define DOC_ECCCONF1_HAMMING_BITS_MASK  0x0f
 
@@ -223,13 +243,46 @@
 #define DOC_READADDR_ONE_BYTE           0x4000
 #define DOC_READADDR_ADDR_MASK          0x1fff
 
+/*
+ * Flash register : DOC_POWERMODE
+ */
+#define DOC_POWERDOWN_READY             0x80
+
+/*
+ * Status of erase and write operation
+ */
+#define DOC_PLANES_STATUS_FAIL          0x01
+#define DOC_PLANES_STATUS_PLANE0_KO     0x02
+#define DOC_PLANES_STATUS_PLANE1_KO     0x04
+
+/*
+ * DPS key management
+ *
+ * Each floor of docg3 has 2 protection areas: DPS0 and DPS1. These areas span
+ * across block boundaries, and define whether these blocks can be read or
+ * written.
+ * The definition is dynamically stored in page 0 of blocks (2,3) for DPS0, and
+ * page 0 of blocks (4,5) for DPS1.
+ */
+#define DOC_LAYOUT_DPS_KEY_LENGTH       8
+
 /**
  * struct docg3 - DiskOnChip driver private data
  * @dev: the device currently under control
  * @base: mapped IO space
  * @device_id: number of the cascaded DoCG3 device (0, 1, 2 or 3)
  * @if_cfg: if true, reads are on 16bits, else reads are on 8bits
+
+ * @reliable: if 0, docg3 in normal mode, if 1 docg3 in fast mode, if 2 in
+ *            reliable mode
+ *            Fast mode implies more errors than normal mode.
+ *            Reliable mode implies that page 2*n and 2*n+1 are clones.
  * @bbt: bad block table cache
+ * @oob_write_ofs: offset of the MTD where this OOB should belong (ie. in next
+ *                 page_write)
+ * @oob_autoecc: if 1, use only bytes 0-7, 15, and fill the others with HW ECC
+ *               if 0, use all the 16 bytes.
+ * @oob_write_buf: prepared OOB for next page_write
  * @debugfs_root: debugfs root node
  */
 struct docg3 {
@@ -237,8 +290,12 @@ struct docg3 {
         void __iomem *base;
         unsigned int device_id:4;
         unsigned int if_cfg:1;
+        unsigned int reliable:2;
         int max_block;
         u8 *bbt;
+        loff_t oob_write_ofs;
+        int oob_autoecc;
+        u8 oob_write_buf[DOC_LAYOUT_OOB_SIZE];
         struct dentry *debugfs_root;
 };
 
diff --git a/drivers/mtd/devices/docprobe.c b/drivers/mtd/devices/docprobe.c
index 45116bb30297..706b847b46b3 100644
--- a/drivers/mtd/devices/docprobe.c
+++ b/drivers/mtd/devices/docprobe.c
@@ -241,8 +241,7 @@ static void __init DoC_Probe(unsigned long physadr)
                         return;
                 }
                 docfound = 1;
-                mtd = kmalloc(sizeof(struct DiskOnChip) + sizeof(struct mtd_info), GFP_KERNEL);
-
+                mtd = kzalloc(sizeof(struct DiskOnChip) + sizeof(struct mtd_info), GFP_KERNEL);
                 if (!mtd) {
                         printk(KERN_WARNING "Cannot allocate memory for data structures. Dropping.\n");
                         iounmap(docptr);
@@ -250,10 +249,6 @@ static void __init DoC_Probe(unsigned long physadr)
                 }
 
                 this = (struct DiskOnChip *)(&mtd[1]);
-
-                memset((char *)mtd,0, sizeof(struct mtd_info));
-                memset((char *)this, 0, sizeof(struct DiskOnChip));
-
                 mtd->priv = this;
                 this->virtadr = docptr;
                 this->physadr = physadr;
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 884904d3f9d2..7c60dddbefc0 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -992,7 +992,6 @@ static int __devexit m25p_remove(struct spi_device *spi)
 static struct spi_driver m25p80_driver = {
         .driver = {
                 .name   = "m25p80",
-                .bus    = &spi_bus_type,
                 .owner  = THIS_MODULE,
         },
         .id_table       = m25p_ids,
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index d75c7af18a63..236057ead0d2 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -936,7 +936,6 @@ static int __devexit dataflash_remove(struct spi_device *spi)
 static struct spi_driver dataflash_driver = {
         .driver = {
                 .name           = "mtd_dataflash",
-                .bus            = &spi_bus_type,
                 .owner          = THIS_MODULE,
                 .of_match_table = dataflash_dt_ids,
         },
diff --git a/drivers/mtd/devices/sst25l.c b/drivers/mtd/devices/sst25l.c
index d38ef3bffe8d..5fc198350b94 100644
--- a/drivers/mtd/devices/sst25l.c
+++ b/drivers/mtd/devices/sst25l.c
@@ -378,7 +378,7 @@ static int __devinit sst25l_probe(struct spi_device *spi)
         struct flash_info *flash_info;
         struct sst25l_flash *flash;
         struct flash_platform_data *data;
-        int ret, i;
+        int ret;
 
         flash_info = sst25l_match_device(spi);
         if (!flash_info)
@@ -444,7 +444,6 @@ static int __devexit sst25l_remove(struct spi_device *spi)
 static struct spi_driver sst25l_driver = {
         .driver = {
                 .name   = "sst25l",
-                .bus    = &spi_bus_type,
                 .owner  = THIS_MODULE,
         },
         .probe          = sst25l_probe,
diff --git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c
index c7382bb686c6..19d637266fcd 100644
--- a/drivers/mtd/ftl.c
+++ b/drivers/mtd/ftl.c
@@ -168,8 +168,8 @@ static int scan_header(partition_t *part)
          (offset + sizeof(header)) < max_offset;
          offset += part->mbd.mtd->erasesize ? : 0x2000) {
 
-        err = part->mbd.mtd->read(part->mbd.mtd, offset, sizeof(header), &ret,
-                              (unsigned char *)&header);
+        err = mtd_read(part->mbd.mtd, offset, sizeof(header), &ret,
+                       (unsigned char *)&header);
 
         if (err)
             return err;
@@ -224,8 +224,8 @@ static int build_maps(partition_t *part)
     for (i = 0; i < le16_to_cpu(part->header.NumEraseUnits); i++) {
         offset = ((i + le16_to_cpu(part->header.FirstPhysicalEUN))
                       << part->header.EraseUnitSize);
-        ret = part->mbd.mtd->read(part->mbd.mtd, offset, sizeof(header), &retval,
-                              (unsigned char *)&header);
+        ret = mtd_read(part->mbd.mtd, offset, sizeof(header), &retval,
+                       (unsigned char *)&header);
 
         if (ret)
             goto out_XferInfo;
@@ -289,9 +289,9 @@ static int build_maps(partition_t *part)
         part->EUNInfo[i].Deleted = 0;
         offset = part->EUNInfo[i].Offset + le32_to_cpu(header.BAMOffset);
 
-        ret = part->mbd.mtd->read(part->mbd.mtd, offset,
-                              part->BlocksPerUnit * sizeof(uint32_t), &retval,
-                              (unsigned char *)part->bam_cache);
+        ret = mtd_read(part->mbd.mtd, offset,
+                       part->BlocksPerUnit * sizeof(uint32_t), &retval,
+                       (unsigned char *)part->bam_cache);
 
         if (ret)
                 goto out_bam_cache;
@@ -355,7 +355,7 @@ static int erase_xfer(partition_t *part,
     erase->len = 1 << part->header.EraseUnitSize;
     erase->priv = (u_long)part;
 
-    ret = part->mbd.mtd->erase(part->mbd.mtd, erase);
+    ret = mtd_erase(part->mbd.mtd, erase);
 
     if (!ret)
             xfer->EraseCount++;
@@ -422,8 +422,8 @@ static int prepare_xfer(partition_t *part, int i)
     header.LogicalEUN = cpu_to_le16(0xffff);
     header.EraseCount = cpu_to_le32(xfer->EraseCount);
 
-    ret = part->mbd.mtd->write(part->mbd.mtd, xfer->Offset, sizeof(header),
-                           &retlen, (u_char *)&header);
+    ret = mtd_write(part->mbd.mtd, xfer->Offset, sizeof(header), &retlen,
+                    (u_char *)&header);
 
     if (ret) {
         return ret;
@@ -438,8 +438,8 @@ static int prepare_xfer(partition_t *part, int i)
 
     for (i = 0; i < nbam; i++, offset += sizeof(uint32_t)) {
 
-        ret = part->mbd.mtd->write(part->mbd.mtd, offset, sizeof(uint32_t),
-                               &retlen, (u_char *)&ctl);
+        ret = mtd_write(part->mbd.mtd, offset, sizeof(uint32_t), &retlen,
+                        (u_char *)&ctl);
 
         if (ret)
             return ret;
@@ -485,9 +485,9 @@ static int copy_erase_unit(partition_t *part, uint16_t srcunit,
 
         offset = eun->Offset + le32_to_cpu(part->header.BAMOffset);
 
-        ret = part->mbd.mtd->read(part->mbd.mtd, offset,
-                              part->BlocksPerUnit * sizeof(uint32_t),
-                              &retlen, (u_char *) (part->bam_cache));
+        ret = mtd_read(part->mbd.mtd, offset,
+                       part->BlocksPerUnit * sizeof(uint32_t), &retlen,
+                       (u_char *)(part->bam_cache));
 
         /* mark the cache bad, in case we get an error later */
         part->bam_index = 0xffff;
@@ -503,8 +503,8 @@ static int copy_erase_unit(partition_t *part, uint16_t srcunit,
     offset = xfer->Offset + 20; /* Bad! */
     unit = cpu_to_le16(0x7fff);
 
-    ret = part->mbd.mtd->write(part->mbd.mtd, offset, sizeof(uint16_t),
-                           &retlen, (u_char *) &unit);
+    ret = mtd_write(part->mbd.mtd, offset, sizeof(uint16_t), &retlen,
+                    (u_char *)&unit);
 
     if (ret) {
         printk( KERN_WARNING "ftl: Failed to write back to BAM cache in copy_erase_unit()!\n");
@@ -523,16 +523,16 @@ static int copy_erase_unit(partition_t *part, uint16_t srcunit,
             break;
         case BLOCK_DATA:
         case BLOCK_REPLACEMENT:
-            ret = part->mbd.mtd->read(part->mbd.mtd, src, SECTOR_SIZE,
-                        &retlen, (u_char *) buf);
+            ret = mtd_read(part->mbd.mtd, src, SECTOR_SIZE, &retlen,
+                           (u_char *)buf);
             if (ret) {
                 printk(KERN_WARNING "ftl: Error reading old xfer unit in copy_erase_unit\n");
                 return ret;
             }
 
 
-            ret = part->mbd.mtd->write(part->mbd.mtd, dest, SECTOR_SIZE,
-                        &retlen, (u_char *) buf);
+            ret = mtd_write(part->mbd.mtd, dest, SECTOR_SIZE, &retlen,
+                            (u_char *)buf);
             if (ret)  {
                 printk(KERN_WARNING "ftl: Error writing new xfer unit in copy_erase_unit\n");
                 return ret;
@@ -550,9 +550,11 @@ static int copy_erase_unit(partition_t *part, uint16_t srcunit,
     }
 
     /* Write the BAM to the transfer unit */
-    ret = part->mbd.mtd->write(part->mbd.mtd, xfer->Offset + le32_to_cpu(part->header.BAMOffset),
-                    part->BlocksPerUnit * sizeof(int32_t), &retlen,
-                    (u_char *)part->bam_cache);
+    ret = mtd_write(part->mbd.mtd,
+                    xfer->Offset + le32_to_cpu(part->header.BAMOffset),
+                    part->BlocksPerUnit * sizeof(int32_t),
+                    &retlen,
+                    (u_char *)part->bam_cache);
     if (ret) {
         printk( KERN_WARNING "ftl: Error writing BAM in copy_erase_unit\n");
         return ret;
@@ -560,8 +562,8 @@ static int copy_erase_unit(partition_t *part, uint16_t srcunit,
 
 
     /* All clear? Then update the LogicalEUN again */
-    ret = part->mbd.mtd->write(part->mbd.mtd, xfer->Offset + 20, sizeof(uint16_t),
-                           &retlen, (u_char *)&srcunitswap);
+    ret = mtd_write(part->mbd.mtd, xfer->Offset + 20, sizeof(uint16_t),
+                    &retlen, (u_char *)&srcunitswap);
 
     if (ret) {
         printk(KERN_WARNING "ftl: Error writing new LogicalEUN in copy_erase_unit\n");
@@ -648,8 +650,7 @@ static int reclaim_block(partition_t *part)
             if (queued) {
                 pr_debug("ftl_cs: waiting for transfer "
                       "unit to be prepared...\n");
-                if (part->mbd.mtd->sync)
-                        part->mbd.mtd->sync(part->mbd.mtd);
+                mtd_sync(part->mbd.mtd);
             } else {
                 static int ne = 0;
                 if (++ne < 5)
@@ -747,10 +748,11 @@ static uint32_t find_free(partition_t *part)
         /* Invalidate cache */
         part->bam_index = 0xffff;
 
-        ret = part->mbd.mtd->read(part->mbd.mtd,
-                       part->EUNInfo[eun].Offset + le32_to_cpu(part->header.BAMOffset),
-                       part->BlocksPerUnit * sizeof(uint32_t),
-                       &retlen, (u_char *) (part->bam_cache));
+        ret = mtd_read(part->mbd.mtd,
+                       part->EUNInfo[eun].Offset + le32_to_cpu(part->header.BAMOffset),
+                       part->BlocksPerUnit * sizeof(uint32_t),
+                       &retlen,
+                       (u_char *)(part->bam_cache));
 
         if (ret) {
             printk(KERN_WARNING"ftl: Error reading BAM in find_free\n");
@@ -810,8 +812,8 @@ static int ftl_read(partition_t *part, caddr_t buffer,
         else {
             offset = (part->EUNInfo[log_addr / bsize].Offset
                           + (log_addr % bsize));
-            ret = part->mbd.mtd->read(part->mbd.mtd, offset, SECTOR_SIZE,
-                           &retlen, (u_char *) buffer);
+            ret = mtd_read(part->mbd.mtd, offset, SECTOR_SIZE, &retlen,
+                           (u_char *)buffer);
 
             if (ret) {
                 printk(KERN_WARNING "Error reading MTD device in ftl_read()\n");
@@ -849,8 +851,8 @@ static int set_bam_entry(partition_t *part, uint32_t log_addr,
                   le32_to_cpu(part->header.BAMOffset));
 
 #ifdef PSYCHO_DEBUG
-    ret = part->mbd.mtd->read(part->mbd.mtd, offset, sizeof(uint32_t),
-                        &retlen, (u_char *)&old_addr);
+    ret = mtd_read(part->mbd.mtd, offset, sizeof(uint32_t), &retlen,
+                   (u_char *)&old_addr);
     if (ret) {
         printk(KERN_WARNING"ftl: Error reading old_addr in set_bam_entry: %d\n",ret);
         return ret;
@@ -886,8 +888,8 @@ static int set_bam_entry(partition_t *part, uint32_t log_addr,
 #endif
         part->bam_cache[blk] = le_virt_addr;
     }
-    ret = part->mbd.mtd->write(part->mbd.mtd, offset, sizeof(uint32_t),
-                            &retlen, (u_char *)&le_virt_addr);
+    ret = mtd_write(part->mbd.mtd, offset, sizeof(uint32_t), &retlen,
+                    (u_char *)&le_virt_addr);
 
     if (ret) {
         printk(KERN_NOTICE "ftl_cs: set_bam_entry() failed!\n");
@@ -946,8 +948,7 @@ static int ftl_write(partition_t *part, caddr_t buffer,
         part->EUNInfo[part->bam_index].Deleted++;
         offset = (part->EUNInfo[part->bam_index].Offset +
                       blk * SECTOR_SIZE);
-        ret = part->mbd.mtd->write(part->mbd.mtd, offset, SECTOR_SIZE, &retlen,
-                                     buffer);
+        ret = mtd_write(part->mbd.mtd, offset, SECTOR_SIZE, &retlen, buffer);
 
         if (ret) {
             printk(KERN_NOTICE "ftl_cs: block write failed!\n");
diff --git a/drivers/mtd/inftlcore.c b/drivers/mtd/inftlcore.c
index dd034efd1875..28646c95cfb8 100644
--- a/drivers/mtd/inftlcore.c
+++ b/drivers/mtd/inftlcore.c
@@ -158,7 +158,7 @@ int inftl_read_oob(struct mtd_info *mtd, loff_t offs, size_t len,
         ops.oobbuf = buf;
         ops.datbuf = NULL;
 
-        res = mtd->read_oob(mtd, offs & ~(mtd->writesize - 1), &ops);
+        res = mtd_read_oob(mtd, offs & ~(mtd->writesize - 1), &ops);
         *retlen = ops.oobretlen;
         return res;
 }
@@ -178,7 +178,7 @@ int inftl_write_oob(struct mtd_info *mtd, loff_t offs, size_t len,
         ops.oobbuf = buf;
         ops.datbuf = NULL;
 
-        res = mtd->write_oob(mtd, offs & ~(mtd->writesize - 1), &ops);
+        res = mtd_write_oob(mtd, offs & ~(mtd->writesize - 1), &ops);
         *retlen = ops.oobretlen;
         return res;
 }
@@ -199,7 +199,7 @@ static int inftl_write(struct mtd_info *mtd, loff_t offs, size_t len,
         ops.datbuf = buf;
         ops.len = len;
 
-        res = mtd->write_oob(mtd, offs & ~(mtd->writesize - 1), &ops);
+        res = mtd_write_oob(mtd, offs & ~(mtd->writesize - 1), &ops);
         *retlen = ops.retlen;
         return res;
 }
@@ -343,14 +343,17 @@ static u16 INFTL_foldchain(struct INFTLrecord *inftl, unsigned thisVUC, unsigned
                 if (BlockMap[block] == BLOCK_NIL)
                         continue;
 
-                ret = mtd->read(mtd, (inftl->EraseSize * BlockMap[block]) +
-                                (block * SECTORSIZE), SECTORSIZE, &retlen,
-                                movebuf);
+                ret = mtd_read(mtd,
+                               (inftl->EraseSize * BlockMap[block]) + (block * SECTORSIZE),
+                               SECTORSIZE,
+                               &retlen,
+                               movebuf);
                 if (ret < 0 && !mtd_is_bitflip(ret)) {
-                        ret = mtd->read(mtd,
-                                        (inftl->EraseSize * BlockMap[block]) +
-                                        (block * SECTORSIZE), SECTORSIZE,
-                                        &retlen, movebuf);
+                        ret = mtd_read(mtd,
+                                       (inftl->EraseSize * BlockMap[block]) + (block * SECTORSIZE),
+                                       SECTORSIZE,
+                                       &retlen,
+                                       movebuf);
                         if (ret != -EIO)
                                 pr_debug("INFTL: error went away on retry?\n");
                 }
@@ -914,7 +917,7 @@ foundit:
         } else {
                 size_t retlen;
                 loff_t ptr = (thisEUN * inftl->EraseSize) + blockofs;
-                int ret = mtd->read(mtd, ptr, SECTORSIZE, &retlen, buffer);
+                int ret = mtd_read(mtd, ptr, SECTORSIZE, &retlen, buffer);
 
                 /* Handle corrected bit flips gracefully */
                 if (ret < 0 && !mtd_is_bitflip(ret))
diff --git a/drivers/mtd/inftlmount.c b/drivers/mtd/inftlmount.c
index 2ff601f816ce..4adc0374fb6b 100644
--- a/drivers/mtd/inftlmount.c
+++ b/drivers/mtd/inftlmount.c
@@ -73,8 +73,8 @@ static int find_boot_record(struct INFTLrecord *inftl)
                  * Check for BNAND header first. Then whinge if it's found
                  * but later checks fail.
                  */
-                ret = mtd->read(mtd, block * inftl->EraseSize,
-                                SECTORSIZE, &retlen, buf);
+                ret = mtd_read(mtd, block * inftl->EraseSize, SECTORSIZE,
+                               &retlen, buf);
                 /* We ignore ret in case the ECC of the MediaHeader is invalid
                    (which is apparently acceptable) */
                 if (retlen != SECTORSIZE) {
@@ -118,8 +118,8 @@ static int find_boot_record(struct INFTLrecord *inftl)
                 memcpy(mh, buf, sizeof(struct INFTLMediaHeader));
 
                 /* Read the spare media header at offset 4096 */
-                mtd->read(mtd, block * inftl->EraseSize + 4096,
-                          SECTORSIZE, &retlen, buf);
+                mtd_read(mtd, block * inftl->EraseSize + 4096, SECTORSIZE,
+                         &retlen, buf);
                 if (retlen != SECTORSIZE) {
                         printk(KERN_WARNING "INFTL: Unable to read spare "
                                "Media Header\n");
@@ -220,7 +220,7 @@ static int find_boot_record(struct INFTLrecord *inftl)
                                  */
                                 instr->addr = ip->Reserved0 * inftl->EraseSize;
                                 instr->len = inftl->EraseSize;
-                                mtd->erase(mtd, instr);
+                                mtd_erase(mtd, instr);
                         }
                         if ((ip->lastUnit - ip->firstUnit + 1) < ip->virtualUnits) {
                                 printk(KERN_WARNING "INFTL: Media Header "
@@ -306,7 +306,8 @@ static int find_boot_record(struct INFTLrecord *inftl)
                         /* If any of the physical eraseblocks are bad, don't
                            use the unit. */
                         for (physblock = 0; physblock < inftl->EraseSize; physblock += inftl->mbd.mtd->erasesize) {
-                                if (inftl->mbd.mtd->block_isbad(inftl->mbd.mtd, i * inftl->EraseSize + physblock))
+                                if (mtd_block_isbad(inftl->mbd.mtd,
+                                                    i * inftl->EraseSize + physblock))
                                         inftl->PUtable[i] = BLOCK_RESERVED;
                         }
                 }
@@ -342,7 +343,7 @@ static int check_free_sectors(struct INFTLrecord *inftl, unsigned int address,
         int i;
 
         for (i = 0; i < len; i += SECTORSIZE) {
-                if (mtd->read(mtd, address, SECTORSIZE, &retlen, buf))
+                if (mtd_read(mtd, address, SECTORSIZE, &retlen, buf))
                         return -1;
                 if (memcmpb(buf, 0xff, SECTORSIZE) != 0)
                         return -1;
@@ -393,7 +394,7 @@ int INFTL_formatblock(struct INFTLrecord *inftl, int block)
            mark only the failed block in the bbt. */
         for (physblock = 0; physblock < inftl->EraseSize;
              physblock += instr->len, instr->addr += instr->len) {
-                mtd->erase(inftl->mbd.mtd, instr);
+                mtd_erase(inftl->mbd.mtd, instr);
 
                 if (instr->state == MTD_ERASE_FAILED) {
                         printk(KERN_WARNING "INFTL: error while formatting block %d\n",
@@ -423,7 +424,7 @@ int INFTL_formatblock(struct INFTLrecord *inftl, int block)
 fail:
         /* could not format, update the bad block table (caller is responsible
            for setting the PUtable to BLOCK_RESERVED on failure) */
-        inftl->mbd.mtd->block_markbad(inftl->mbd.mtd, instr->addr);
+        mtd_block_markbad(inftl->mbd.mtd, instr->addr);
         return -1;
 }
 
diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c
index 1dca31d9a8b3..536bbceaeaad 100644
--- a/drivers/mtd/lpddr/lpddr_cmds.c
+++ b/drivers/mtd/lpddr/lpddr_cmds.c
@@ -70,19 +70,12 @@ struct mtd_info *lpddr_cmdset(struct map_info *map)
         mtd->erase = lpddr_erase;
         mtd->write = lpddr_write_buffers;
         mtd->writev = lpddr_writev;
-        mtd->read_oob = NULL;
-        mtd->write_oob = NULL;
-        mtd->sync = NULL;
         mtd->lock = lpddr_lock;
         mtd->unlock = lpddr_unlock;
-        mtd->suspend = NULL;
-        mtd->resume = NULL;
         if (map_is_linear(map)) {
                 mtd->point = lpddr_point;
                 mtd->unpoint = lpddr_unpoint;
         }
-        mtd->block_isbad = NULL;
-        mtd->block_markbad = NULL;
         mtd->size = 1 << lpddr->qinfo->DevSizeShift;
         mtd->erasesize = 1 << lpddr->qinfo->UniformBlockSizeShift;
         mtd->writesize = 1 << lpddr->qinfo->BufSizeShift;
diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig
index 8e0c4bf9f7fb..6c5c431c64af 100644
--- a/drivers/mtd/maps/Kconfig
+++ b/drivers/mtd/maps/Kconfig
@@ -242,15 +242,6 @@ config MTD_NETtel
         help
           Support for flash chips on NETtel/SecureEdge/SnapGear boards.
 
-config MTD_BCM963XX
-        tristate "Map driver for Broadcom BCM963xx boards"
-        depends on BCM63XX
-        select MTD_MAP_BANK_WIDTH_2
-        select MTD_CFI_I1
-        help
-          Support for parsing CFE image tag and creating MTD partitions on
-          Broadcom BCM63xx boards.
-
 config MTD_LANTIQ
         tristate "Lantiq SoC NOR support"
         depends on LANTIQ
diff --git a/drivers/mtd/maps/Makefile b/drivers/mtd/maps/Makefile
index 45dcb8b14f22..68a9a91d344f 100644
--- a/drivers/mtd/maps/Makefile
+++ b/drivers/mtd/maps/Makefile
@@ -55,6 +55,5 @@ obj-$(CONFIG_MTD_BFIN_ASYNC)	+= bfin-async-flash.o
 obj-$(CONFIG_MTD_RBTX4939)      += rbtx4939-flash.o
 obj-$(CONFIG_MTD_VMU)           += vmu-flash.o
 obj-$(CONFIG_MTD_GPIO_ADDR)     += gpio-addr-flash.o
-obj-$(CONFIG_MTD_BCM963XX)      += bcm963xx-flash.o
 obj-$(CONFIG_MTD_LATCH_ADDR)    += latch-addr-flash.o
 obj-$(CONFIG_MTD_LANTIQ)        += lantiq-flash.o
diff --git a/drivers/mtd/maps/bcm963xx-flash.c b/drivers/mtd/maps/bcm963xx-flash.c
deleted file mode 100644
index 736ca10ca9f1..000000000000
--- a/drivers/mtd/maps/bcm963xx-flash.c
+++ /dev/null
@@ -1,277 +0,0 @@
-/*
- * Copyright © 2006-2008  Florian Fainelli <florian@openwrt.org>
- *                        Mike Albon <malbon@openwrt.org>
- * Copyright © 2009-2010  Daniel Dickinson <openwrt@cshore.neomailbox.net>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
- */
-
-#include <linux/init.h>
-#include <linux/kernel.h>
-#include <linux/slab.h>
-#include <linux/module.h>
-#include <linux/mtd/map.h>
-#include <linux/mtd/mtd.h>
-#include <linux/mtd/partitions.h>
-#include <linux/vmalloc.h>
-#include <linux/platform_device.h>
-#include <linux/io.h>
-
-#include <asm/mach-bcm63xx/bcm963xx_tag.h>
-
-#define BCM63XX_BUSWIDTH        2               /* Buswidth */
-#define BCM63XX_EXTENDED_SIZE   0xBFC00000      /* Extended flash address */
-
-#define PFX KBUILD_MODNAME ": "
-
-static struct mtd_partition *parsed_parts;
-
-static struct mtd_info *bcm963xx_mtd_info;
-
-static struct map_info bcm963xx_map = {
-        .name           = "bcm963xx",
-        .bankwidth      = BCM63XX_BUSWIDTH,
-};
-
-static int parse_cfe_partitions(struct mtd_info *master,
-                                                struct mtd_partition **pparts)
-{
-        /* CFE, NVRAM and global Linux are always present */
-        int nrparts = 3, curpart = 0;
-        struct bcm_tag *buf;
-        struct mtd_partition *parts;
-        int ret;
-        size_t retlen;
-        unsigned int rootfsaddr, kerneladdr, spareaddr;
-        unsigned int rootfslen, kernellen, sparelen, totallen;
-        int namelen = 0;
-        int i;
-        char *boardid;
-        char *tagversion;
-
-        /* Allocate memory for buffer */
-        buf = vmalloc(sizeof(struct bcm_tag));
-        if (!buf)
-                return -ENOMEM;
-
-        /* Get the tag */
-        ret = master->read(master, master->erasesize, sizeof(struct bcm_tag),
-                                                        &retlen, (void *)buf);
-        if (retlen != sizeof(struct bcm_tag)) {
-                vfree(buf);
-                return -EIO;
-        }
-
-        sscanf(buf->kernel_address, "%u", &kerneladdr);
-        sscanf(buf->kernel_length, "%u", &kernellen);
-        sscanf(buf->total_length, "%u", &totallen);
-        tagversion = &(buf->tag_version[0]);
-        boardid = &(buf->board_id[0]);
-
-        printk(KERN_INFO PFX "CFE boot tag found with version %s "
-                                "and board type %s\n", tagversion, boardid);
-
-        kerneladdr = kerneladdr - BCM63XX_EXTENDED_SIZE;
-        rootfsaddr = kerneladdr + kernellen;
-        spareaddr = roundup(totallen, master->erasesize) + master->erasesize;
-        sparelen = master->size - spareaddr - master->erasesize;
-        rootfslen = spareaddr - rootfsaddr;
-
-        /* Determine number of partitions */
-        namelen = 8;
-        if (rootfslen > 0) {
-                nrparts++;
-                namelen += 6;
-        };
-        if (kernellen > 0) {
-                nrparts++;
-                namelen += 6;
-        };
-
-        /* Ask kernel for more memory */
-        parts = kzalloc(sizeof(*parts) * nrparts + 10 * nrparts, GFP_KERNEL);
-        if (!parts) {
-                vfree(buf);
-                return -ENOMEM;
-        };
-
-        /* Start building partition list */
-        parts[curpart].name = "CFE";
-        parts[curpart].offset = 0;
-        parts[curpart].size = master->erasesize;
-        curpart++;
-
-        if (kernellen > 0) {
-                parts[curpart].name = "kernel";
-                parts[curpart].offset = kerneladdr;
-                parts[curpart].size = kernellen;
-                curpart++;
-        };
-
-        if (rootfslen > 0) {
-                parts[curpart].name = "rootfs";
-                parts[curpart].offset = rootfsaddr;
-                parts[curpart].size = rootfslen;
-                if (sparelen > 0)
-                        parts[curpart].size += sparelen;
-                curpart++;
-        };
-
-        parts[curpart].name = "nvram";
-        parts[curpart].offset = master->size - master->erasesize;
-        parts[curpart].size = master->erasesize;
-
-        /* Global partition "linux" to make easy firmware upgrade */
-        curpart++;
-        parts[curpart].name = "linux";
-        parts[curpart].offset = parts[0].size;
-        parts[curpart].size = master->size - parts[0].size - parts[3].size;
-
-        for (i = 0; i < nrparts; i++)
-                printk(KERN_INFO PFX "Partition %d is %s offset %lx and "
-                                        "length %lx\n", i, parts[i].name,
-                                        (long unsigned int)(parts[i].offset),
-                                        (long unsigned int)(parts[i].size));
-
-        printk(KERN_INFO PFX "Spare partition is %x offset and length %x\n",
-                                                        spareaddr, sparelen);
-        *pparts = parts;
-        vfree(buf);
-
-        return nrparts;
-};
-
-static int bcm963xx_detect_cfe(struct mtd_info *master)
-{
-        int idoffset = 0x4e0;
-        static char idstring[8] = "CFE1CFE1";
-        char buf[9];
-        int ret;
-        size_t retlen;
-
-        ret = master->read(master, idoffset, 8, &retlen, (void *)buf);
-        buf[retlen] = 0;
-        printk(KERN_INFO PFX "Read Signature value of %s\n", buf);
-
-        return strncmp(idstring, buf, 8);
-}
-
-static int bcm963xx_probe(struct platform_device *pdev)
-{
-        int err = 0;
-        int parsed_nr_parts = 0;
-        char *part_type;
-        struct resource *r;
-
-        r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-        if (!r) {
-                dev_err(&pdev->dev, "no resource supplied\n");
-                return -ENODEV;
-        }
-
-        bcm963xx_map.phys = r->start;
-        bcm963xx_map.size = resource_size(r);
-        bcm963xx_map.virt = ioremap(r->start, resource_size(r));
-        if (!bcm963xx_map.virt) {
-                dev_err(&pdev->dev, "failed to ioremap\n");
-                return -EIO;
-        }
-
-        dev_info(&pdev->dev, "0x%08lx at 0x%08x\n",
-                                        bcm963xx_map.size, bcm963xx_map.phys);
-
-        simple_map_init(&bcm963xx_map);
-
-        bcm963xx_mtd_info = do_map_probe("cfi_probe", &bcm963xx_map);
-        if (!bcm963xx_mtd_info) {
-                dev_err(&pdev->dev, "failed to probe using CFI\n");
-                bcm963xx_mtd_info = do_map_probe("jedec_probe", &bcm963xx_map);
-                if (bcm963xx_mtd_info)
-                        goto probe_ok;
-                dev_err(&pdev->dev, "failed to probe using JEDEC\n");
-                err = -EIO;
-                goto err_probe;
-        }
-
-probe_ok:
-        bcm963xx_mtd_info->owner = THIS_MODULE;
-
-        /* This is mutually exclusive */
-        if (bcm963xx_detect_cfe(bcm963xx_mtd_info) == 0) {
-                dev_info(&pdev->dev, "CFE bootloader detected\n");
-                if (parsed_nr_parts == 0) {
-                        int ret = parse_cfe_partitions(bcm963xx_mtd_info,
-                                                        &parsed_parts);
-                        if (ret > 0) {
-                                part_type = "CFE";
-                                parsed_nr_parts = ret;
-                        }
-                }
-        } else {
-                dev_info(&pdev->dev, "unsupported bootloader\n");
-                err = -ENODEV;
-                goto err_probe;
-        }
-
-        return mtd_device_register(bcm963xx_mtd_info, parsed_parts,
-                                   parsed_nr_parts);
-
-err_probe:
-        iounmap(bcm963xx_map.virt);
-        return err;
-}
-
-static int bcm963xx_remove(struct platform_device *pdev)
-{
-        if (bcm963xx_mtd_info) {
-                mtd_device_unregister(bcm963xx_mtd_info);
-                map_destroy(bcm963xx_mtd_info);
-        }
-
-        if (bcm963xx_map.virt) {
-                iounmap(bcm963xx_map.virt);
-                bcm963xx_map.virt = 0;
-        }
-
-        return 0;
-}
-
-static struct platform_driver bcm63xx_mtd_dev = {
-        .probe  = bcm963xx_probe,
-        .remove = bcm963xx_remove,
-        .driver = {
-                .name   = "bcm963xx-flash",
-                .owner  = THIS_MODULE,
-        },
-};
-
-static int __init bcm963xx_mtd_init(void)
-{
-        return platform_driver_register(&bcm63xx_mtd_dev);
-}
-
-static void __exit bcm963xx_mtd_exit(void)
-{
-        platform_driver_unregister(&bcm63xx_mtd_dev);
-}
-
-module_init(bcm963xx_mtd_init);
-module_exit(bcm963xx_mtd_exit);
-
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("Broadcom BCM63xx MTD driver for CFE and RedBoot");
-MODULE_AUTHOR("Daniel Dickinson <openwrt@cshore.neomailbox.net>");
-MODULE_AUTHOR("Florian Fainelli <florian@openwrt.org>");
-MODULE_AUTHOR("Mike Albon <malbon@openwrt.org>");
diff --git a/drivers/mtd/maps/bfin-async-flash.c b/drivers/mtd/maps/bfin-async-flash.c
index 6d6b2b5674ee..650126c361f1 100644
--- a/drivers/mtd/maps/bfin-async-flash.c
+++ b/drivers/mtd/maps/bfin-async-flash.c
@@ -190,17 +190,7 @@ static struct platform_driver bfin_flash_driver = {
         },
 };
 
-static int __init bfin_flash_init(void)
-{
-        return platform_driver_register(&bfin_flash_driver);
-}
-module_init(bfin_flash_init);
-
-static void __exit bfin_flash_exit(void)
-{
-        platform_driver_unregister(&bfin_flash_driver);
-}
-module_exit(bfin_flash_exit);
+module_platform_driver(bfin_flash_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("MTD map driver for Blackfins with flash/ethernet on same async bank");
diff --git a/drivers/mtd/maps/gpio-addr-flash.c b/drivers/mtd/maps/gpio-addr-flash.c
index 1ec66f031c51..33cce895859f 100644
--- a/drivers/mtd/maps/gpio-addr-flash.c
+++ b/drivers/mtd/maps/gpio-addr-flash.c
@@ -279,17 +279,7 @@ static struct platform_driver gpio_flash_driver = {
         },
 };
 
-static int __init gpio_flash_init(void)
-{
-        return platform_driver_register(&gpio_flash_driver);
-}
-module_init(gpio_flash_init);
-
-static void __exit gpio_flash_exit(void)
-{
-        platform_driver_unregister(&gpio_flash_driver);
-}
-module_exit(gpio_flash_exit);
+module_platform_driver(gpio_flash_driver);
 
 MODULE_AUTHOR("Mike Frysinger <vapier@gentoo.org>");
 MODULE_DESCRIPTION("MTD map driver for flashes addressed physically and with gpios");
diff --git a/drivers/mtd/maps/ixp2000.c b/drivers/mtd/maps/ixp2000.c
index 437fcd2f352f..fc7d4d0d9a4e 100644
--- a/drivers/mtd/maps/ixp2000.c
+++ b/drivers/mtd/maps/ixp2000.c
@@ -246,18 +246,8 @@ static struct platform_driver ixp2000_flash_driver = {
         },
 };
 
-static int __init ixp2000_flash_init(void)
-{
-        return platform_driver_register(&ixp2000_flash_driver);
-}
-
-static void __exit ixp2000_flash_exit(void)
-{
-        platform_driver_unregister(&ixp2000_flash_driver);
-}
+module_platform_driver(ixp2000_flash_driver);
 
-module_init(ixp2000_flash_init);
-module_exit(ixp2000_flash_exit);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Deepak Saxena <dsaxena@plexity.net>");
 MODULE_ALIAS("platform:IXP2000-Flash");
diff --git a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
index 30409015a3de..8b5410162d70 100644
--- a/drivers/mtd/maps/ixp4xx.c
+++ b/drivers/mtd/maps/ixp4xx.c
@@ -270,19 +270,7 @@ static struct platform_driver ixp4xx_flash_driver = {
         },
 };
 
-static int __init ixp4xx_flash_init(void)
-{
-        return platform_driver_register(&ixp4xx_flash_driver);
-}
-
-static void __exit ixp4xx_flash_exit(void)
-{
-        platform_driver_unregister(&ixp4xx_flash_driver);
-}
-
-
-module_init(ixp4xx_flash_init);
-module_exit(ixp4xx_flash_exit);
+module_platform_driver(ixp4xx_flash_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("MTD map driver for Intel IXP4xx systems");
diff --git a/drivers/mtd/maps/lantiq-flash.c b/drivers/mtd/maps/lantiq-flash.c
index 4f10e27ada55..7b889de9477b 100644
--- a/drivers/mtd/maps/lantiq-flash.c
+++ b/drivers/mtd/maps/lantiq-flash.c
@@ -159,7 +159,7 @@ ltq_mtd_probe(struct platform_device *pdev)
         if (!ltq_mtd->mtd) {
                 dev_err(&pdev->dev, "probing failed\n");
                 err = -ENXIO;
-                goto err_unmap;
+                goto err_free;
         }
 
         ltq_mtd->mtd->owner = THIS_MODULE;
@@ -179,8 +179,6 @@ ltq_mtd_probe(struct platform_device *pdev)
 
 err_destroy:
         map_destroy(ltq_mtd->mtd);
-err_unmap:
-        iounmap(ltq_mtd->map->virt);
 err_free:
         kfree(ltq_mtd->map);
 err_out:
@@ -198,8 +196,6 @@ ltq_mtd_remove(struct platform_device *pdev)
                         mtd_device_unregister(ltq_mtd->mtd);
                         map_destroy(ltq_mtd->mtd);
                 }
-                if (ltq_mtd->map->virt)
-                        iounmap(ltq_mtd->map->virt);
                 kfree(ltq_mtd->map);
                 kfree(ltq_mtd);
         }
diff --git a/drivers/mtd/maps/latch-addr-flash.c b/drivers/mtd/maps/latch-addr-flash.c
index 119baa7d7477..8fed58e3a4a8 100644
--- a/drivers/mtd/maps/latch-addr-flash.c
+++ b/drivers/mtd/maps/latch-addr-flash.c
@@ -223,17 +223,7 @@ static struct platform_driver latch_addr_flash_driver = {
         },
 };
 
-static int __init latch_addr_flash_init(void)
-{
-        return platform_driver_register(&latch_addr_flash_driver);
-}
-module_init(latch_addr_flash_init);
-
-static void __exit latch_addr_flash_exit(void)
-{
-        platform_driver_unregister(&latch_addr_flash_driver);
-}
-module_exit(latch_addr_flash_exit);
+module_platform_driver(latch_addr_flash_driver);
 
 MODULE_AUTHOR("David Griego <dgriego@mvista.com>");
 MODULE_DESCRIPTION("MTD map driver for flashes addressed physically with upper "
diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index 66e8200079c2..abc562653b31 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -85,6 +85,7 @@ static int physmap_flash_probe(struct platform_device *dev)
         struct physmap_flash_data *physmap_data;
         struct physmap_flash_info *info;
         const char **probe_type;
+        const char **part_types;
         int err = 0;
         int i;
         int devices_found = 0;
@@ -171,7 +172,9 @@ static int physmap_flash_probe(struct platform_device *dev)
         if (err)
                 goto err_out;
 
-        mtd_device_parse_register(info->cmtd, part_probe_types, 0,
+        part_types = physmap_data->part_probe_types ? : part_probe_types;
+
+        mtd_device_parse_register(info->cmtd, part_types, 0,
                                   physmap_data->parts, physmap_data->nr_parts);
         return 0;
 
@@ -187,9 +190,8 @@ static void physmap_flash_shutdown(struct platform_device *dev)
         int i;
 
         for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
-                if (info->mtd[i]->suspend && info->mtd[i]->resume)
-                        if (info->mtd[i]->suspend(info->mtd[i]) == 0)
-                                info->mtd[i]->resume(info->mtd[i]);
+                if (mtd_suspend(info->mtd[i]) == 0)
+                        mtd_resume(info->mtd[i]);
 }
 #else
 #define physmap_flash_shutdown NULL
diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
index 7d65f9d3e690..2e6fb6831d55 100644
--- a/drivers/mtd/maps/physmap_of.c
+++ b/drivers/mtd/maps/physmap_of.c
@@ -338,18 +338,7 @@ static struct platform_driver of_flash_driver = {
         .remove         = of_flash_remove,
 };
 
-static int __init of_flash_init(void)
-{
-        return platform_driver_register(&of_flash_driver);
-}
-
-static void __exit of_flash_exit(void)
-{
-        platform_driver_unregister(&of_flash_driver);
-}
-
-module_init(of_flash_init);
-module_exit(of_flash_exit);
+module_platform_driver(of_flash_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Vitaly Wool <vwool@ru.mvista.com>");
diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
index 2a25b6789af4..436d121185b1 100644
--- a/drivers/mtd/maps/pxa2xx-flash.c
+++ b/drivers/mtd/maps/pxa2xx-flash.c
@@ -125,8 +125,8 @@ static void pxa2xx_flash_shutdown(struct platform_device *dev)
 {
         struct pxa2xx_flash_info *info = platform_get_drvdata(dev);
 
-        if (info && info->mtd->suspend(info->mtd) == 0)
-                info->mtd->resume(info->mtd);
+        if (info && mtd_suspend(info->mtd) == 0)
+                mtd_resume(info->mtd);
 }
 #else
 #define pxa2xx_flash_shutdown NULL
@@ -142,18 +142,7 @@ static struct platform_driver pxa2xx_flash_driver = {
         .shutdown       = pxa2xx_flash_shutdown,
 };
 
-static int __init init_pxa2xx_flash(void)
-{
-        return platform_driver_register(&pxa2xx_flash_driver);
-}
-
-static void __exit cleanup_pxa2xx_flash(void)
-{
-        platform_driver_unregister(&pxa2xx_flash_driver);
-}
-
-module_init(init_pxa2xx_flash);
-module_exit(cleanup_pxa2xx_flash);
+module_platform_driver(pxa2xx_flash_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Nicolas Pitre <nico@fluxnic.net>");
diff --git a/drivers/mtd/maps/rbtx4939-flash.c b/drivers/mtd/maps/rbtx4939-flash.c
index 0237f197fd12..3da63fc6f16e 100644
--- a/drivers/mtd/maps/rbtx4939-flash.c
+++ b/drivers/mtd/maps/rbtx4939-flash.c
@@ -119,9 +119,8 @@ static void rbtx4939_flash_shutdown(struct platform_device *dev)
 {
         struct rbtx4939_flash_info *info = platform_get_drvdata(dev);
 
-        if (info->mtd->suspend && info->mtd->resume)
-                if (info->mtd->suspend(info->mtd) == 0)
-                        info->mtd->resume(info->mtd);
+        if (mtd_suspend(info->mtd) == 0)
+                mtd_resume(info->mtd);
 }
 #else
 #define rbtx4939_flash_shutdown NULL
@@ -137,18 +136,7 @@ static struct platform_driver rbtx4939_flash_driver = {
         },
 };
 
-static int __init rbtx4939_flash_init(void)
-{
-        return platform_driver_register(&rbtx4939_flash_driver);
-}
-
-static void __exit rbtx4939_flash_exit(void)
-{
-        platform_driver_unregister(&rbtx4939_flash_driver);
-}
-
-module_init(rbtx4939_flash_init);
-module_exit(rbtx4939_flash_exit);
+module_platform_driver(rbtx4939_flash_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("RBTX4939 MTD map driver");
diff --git a/drivers/mtd/maps/sa1100-flash.c b/drivers/mtd/maps/sa1100-flash.c
index fa9c0a9670cd..502821997707 100644
--- a/drivers/mtd/maps/sa1100-flash.c
+++ b/drivers/mtd/maps/sa1100-flash.c
@@ -377,8 +377,8 @@ static int __exit sa1100_mtd_remove(struct platform_device *pdev)
 static void sa1100_mtd_shutdown(struct platform_device *dev)
 {
         struct sa_info *info = platform_get_drvdata(dev);
-        if (info && info->mtd->suspend(info->mtd) == 0)
-                info->mtd->resume(info->mtd);
+        if (info && mtd_suspend(info->mtd) == 0)
+                mtd_resume(info->mtd);
 }
 #else
 #define sa1100_mtd_shutdown NULL
@@ -394,18 +394,7 @@ static struct platform_driver sa1100_mtd_driver = {
         },
 };
 
-static int __init sa1100_mtd_init(void)
-{
-        return platform_driver_register(&sa1100_mtd_driver);
-}
-
-static void __exit sa1100_mtd_exit(void)
-{
-        platform_driver_unregister(&sa1100_mtd_driver);
-}
-
-module_init(sa1100_mtd_init);
-module_exit(sa1100_mtd_exit);
+module_platform_driver(sa1100_mtd_driver);
 
 MODULE_AUTHOR("Nicolas Pitre");
 MODULE_DESCRIPTION("SA1100 CFI map driver");
diff --git a/drivers/mtd/maps/scb2_flash.c b/drivers/mtd/maps/scb2_flash.c
index d88c8426bb0f..934a72c80078 100644
--- a/drivers/mtd/maps/scb2_flash.c
+++ b/drivers/mtd/maps/scb2_flash.c
@@ -204,8 +204,7 @@ scb2_flash_remove(struct pci_dev *dev)
                 return;
 
         /* disable flash writes */
-        if (scb2_mtd->lock)
-                scb2_mtd->lock(scb2_mtd, 0, scb2_mtd->size);
+        mtd_lock(scb2_mtd, 0, scb2_mtd->size);
 
         mtd_device_unregister(scb2_mtd);
         map_destroy(scb2_mtd);
diff --git a/drivers/mtd/maps/sun_uflash.c b/drivers/mtd/maps/sun_uflash.c
index 2d66234f57cb..175e537b444f 100644
--- a/drivers/mtd/maps/sun_uflash.c
+++ b/drivers/mtd/maps/sun_uflash.c
@@ -158,15 +158,4 @@ static struct platform_driver uflash_driver = {
         .remove         = __devexit_p(uflash_remove),
 };
 
-static int __init uflash_init(void)
-{
-        return platform_driver_register(&uflash_driver);
-}
-
-static void __exit uflash_exit(void)
-{
-        platform_driver_unregister(&uflash_driver);
-}
-
-module_init(uflash_init);
-module_exit(uflash_exit);
+module_platform_driver(uflash_driver);
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index ed8b5e744b12..424ca5f93c6c 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -215,7 +215,7 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode)
 
         mutex_lock(&dev->lock);
 
-        if (dev->open++)
+        if (dev->open)
                 goto unlock;
 
         kref_get(&dev->ref);
@@ -235,6 +235,7 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode)
                 goto error_release;
 
 unlock:
+        dev->open++;
         mutex_unlock(&dev->lock);
         blktrans_dev_put(dev);
         return ret;
diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
index 7c1dc908a174..af6591237b9b 100644
--- a/drivers/mtd/mtdblock.c
+++ b/drivers/mtd/mtdblock.c
@@ -85,7 +85,7 @@ static int erase_write (struct mtd_info *mtd, unsigned long pos,
         set_current_state(TASK_INTERRUPTIBLE);
         add_wait_queue(&wait_q, &wait);
 
-        ret = mtd->erase(mtd, &erase);
+        ret = mtd_erase(mtd, &erase);
         if (ret) {
                 set_current_state(TASK_RUNNING);
                 remove_wait_queue(&wait_q, &wait);
@@ -102,7 +102,7 @@ static int erase_write (struct mtd_info *mtd, unsigned long pos,
          * Next, write the data to flash.
          */
 
-        ret = mtd->write(mtd, pos, len, &retlen, buf);
+        ret = mtd_write(mtd, pos, len, &retlen, buf);
         if (ret)
                 return ret;
         if (retlen != len)
@@ -152,7 +152,7 @@ static int do_cached_write (struct mtdblk_dev *mtdblk, unsigned long pos,
                 mtd->name, pos, len);
 
         if (!sect_size)
-                return mtd->write(mtd, pos, len, &retlen, buf);
+                return mtd_write(mtd, pos, len, &retlen, buf);
 
         while (len > 0) {
                 unsigned long sect_start = (pos/sect_size)*sect_size;
@@ -184,8 +184,8 @@ static int do_cached_write (struct mtdblk_dev *mtdblk, unsigned long pos,
                             mtdblk->cache_offset != sect_start) {
                                 /* fill the cache with the current sector */
                                 mtdblk->cache_state = STATE_EMPTY;
-                                ret = mtd->read(mtd, sect_start, sect_size,
-                                                &retlen, mtdblk->cache_data);
+                                ret = mtd_read(mtd, sect_start, sect_size,
+                                               &retlen, mtdblk->cache_data);
                                 if (ret)
                                         return ret;
                                 if (retlen != sect_size)
@@ -222,7 +222,7 @@ static int do_cached_read (struct mtdblk_dev *mtdblk, unsigned long pos,
                         mtd->name, pos, len);
 
         if (!sect_size)
-                return mtd->read(mtd, pos, len, &retlen, buf);
+                return mtd_read(mtd, pos, len, &retlen, buf);
 
         while (len > 0) {
                 unsigned long sect_start = (pos/sect_size)*sect_size;
@@ -241,7 +241,7 @@ static int do_cached_read (struct mtdblk_dev *mtdblk, unsigned long pos,
                     mtdblk->cache_offset == sect_start) {
                         memcpy (buf, mtdblk->cache_data + offset, size);
                 } else {
-                        ret = mtd->read(mtd, pos, size, &retlen, buf);
+                        ret = mtd_read(mtd, pos, size, &retlen, buf);
                         if (ret)
                                 return ret;
                         if (retlen != size)
@@ -322,8 +322,7 @@ static int mtdblock_release(struct mtd_blktrans_dev *mbd)
 
         if (!--mtdblk->count) {
                 /* It was the last usage. Free the cache */
-                if (mbd->mtd->sync)
-                        mbd->mtd->sync(mbd->mtd);
+                mtd_sync(mbd->mtd);
                 vfree(mtdblk->cache_data);
         }
 
@@ -341,9 +340,7 @@ static int mtdblock_flush(struct mtd_blktrans_dev *dev)
         mutex_lock(&mtdblk->cache_mutex);
         write_cached_data(mtdblk);
         mutex_unlock(&mtdblk->cache_mutex);
-
-        if (dev->mtd->sync)
-                dev->mtd->sync(dev->mtd);
+        mtd_sync(dev->mtd);
         return 0;
 }
 
diff --git a/drivers/mtd/mtdblock_ro.c b/drivers/mtd/mtdblock_ro.c
index 0470a6e86309..92759a9d2985 100644
--- a/drivers/mtd/mtdblock_ro.c
+++ b/drivers/mtd/mtdblock_ro.c
@@ -30,7 +30,7 @@ static int mtdblock_readsect(struct mtd_blktrans_dev *dev,
 {
         size_t retlen;
 
-        if (dev->mtd->read(dev->mtd, (block * 512), 512, &retlen, buf))
+        if (mtd_read(dev->mtd, (block * 512), 512, &retlen, buf))
                 return 1;
         return 0;
 }
@@ -40,7 +40,7 @@ static int mtdblock_writesect(struct mtd_blktrans_dev *dev,
 {
         size_t retlen;
 
-        if (dev->mtd->write(dev->mtd, (block * 512), 512, &retlen, buf))
+        if (mtd_write(dev->mtd, (block * 512), 512, &retlen, buf))
                 return 1;
         return 0;
 }
diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index e7dc732ddabc..50c6a1e7f675 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -51,7 +51,7 @@ struct mtd_file_info {
         enum mtd_file_modes mode;
 };
 
-static loff_t mtd_lseek (struct file *file, loff_t offset, int orig)
+static loff_t mtdchar_lseek(struct file *file, loff_t offset, int orig)
 {
         struct mtd_file_info *mfi = file->private_data;
         struct mtd_info *mtd = mfi->mtd;
@@ -77,7 +77,7 @@ static loff_t mtd_lseek (struct file *file, loff_t offset, int orig)
 
 
 
-static int mtd_open(struct inode *inode, struct file *file)
+static int mtdchar_open(struct inode *inode, struct file *file)
 {
         int minor = iminor(inode);
         int devnum = minor >> 1;
@@ -142,11 +142,11 @@ static int mtd_open(struct inode *inode, struct file *file)
 out:
         mutex_unlock(&mtd_mutex);
         return ret;
-} /* mtd_open */
+} /* mtdchar_open */
 
 /*====================================================================*/
 
-static int mtd_close(struct inode *inode, struct file *file)
+static int mtdchar_close(struct inode *inode, struct file *file)
 {
         struct mtd_file_info *mfi = file->private_data;
         struct mtd_info *mtd = mfi->mtd;
@@ -154,8 +154,8 @@ static int mtd_close(struct inode *inode, struct file *file)
         pr_debug("MTD_close\n");
 
         /* Only sync if opened RW */
-        if ((file->f_mode & FMODE_WRITE) && mtd->sync)
-                mtd->sync(mtd);
+        if ((file->f_mode & FMODE_WRITE))
+                mtd_sync(mtd);
 
         iput(mfi->ino);
 
@@ -164,7 +164,7 @@ static int mtd_close(struct inode *inode, struct file *file)
         kfree(mfi);
 
         return 0;
-} /* mtd_close */
+} /* mtdchar_close */
 
 /* Back in June 2001, dwmw2 wrote:
  *
@@ -184,11 +184,12 @@ static int mtd_close(struct inode *inode, struct file *file)
  * alignment requirements are not met in the NAND subdriver.
  */
 
-static ssize_t mtd_read(struct file *file, char __user *buf, size_t count,loff_t *ppos)
+static ssize_t mtdchar_read(struct file *file, char __user *buf, size_t count,
+                        loff_t *ppos)
 {
         struct mtd_file_info *mfi = file->private_data;
         struct mtd_info *mtd = mfi->mtd;
-        size_t retlen=0;
+        size_t retlen;
         size_t total_retlen=0;
         int ret=0;
         int len;
@@ -212,10 +213,12 @@ static ssize_t mtd_read(struct file *file, char __user *buf, size_t count,loff_t
 
                 switch (mfi->mode) {
                 case MTD_FILE_MODE_OTP_FACTORY:
-                        ret = mtd->read_fact_prot_reg(mtd, *ppos, len, &retlen, kbuf);
+                        ret = mtd_read_fact_prot_reg(mtd, *ppos, len,
+                                                     &retlen, kbuf);
                         break;
                 case MTD_FILE_MODE_OTP_USER:
-                        ret = mtd->read_user_prot_reg(mtd, *ppos, len, &retlen, kbuf);
+                        ret = mtd_read_user_prot_reg(mtd, *ppos, len,
+                                                     &retlen, kbuf);
                         break;
                 case MTD_FILE_MODE_RAW:
                 {
@@ -226,12 +229,12 @@ static ssize_t mtd_read(struct file *file, char __user *buf, size_t count,loff_t
                         ops.oobbuf = NULL;
                         ops.len = len;
 
-                        ret = mtd->read_oob(mtd, *ppos, &ops);
+                        ret = mtd_read_oob(mtd, *ppos, &ops);
                         retlen = ops.retlen;
                         break;
                 }
                 default:
-                        ret = mtd->read(mtd, *ppos, len, &retlen, kbuf);
+                        ret = mtd_read(mtd, *ppos, len, &retlen, kbuf);
                 }
                 /* Nand returns -EBADMSG on ECC errors, but it returns
                  * the data. For our userspace tools it is important
@@ -265,9 +268,10 @@ static ssize_t mtd_read(struct file *file, char __user *buf, size_t count,loff_t
 
         kfree(kbuf);
         return total_retlen;
-} /* mtd_read */
+} /* mtdchar_read */
 
-static ssize_t mtd_write(struct file *file, const char __user *buf, size_t count,loff_t *ppos)
+static ssize_t mtdchar_write(struct file *file, const char __user *buf, size_t count,
+                        loff_t *ppos)
 {
         struct mtd_file_info *mfi = file->private_data;
         struct mtd_info *mtd = mfi->mtd;
@@ -306,11 +310,8 @@ static ssize_t mtd_write(struct file *file, const char __user *buf, size_t count
                         ret = -EROFS;
                         break;
                 case MTD_FILE_MODE_OTP_USER:
-                        if (!mtd->write_user_prot_reg) {
-                                ret = -EOPNOTSUPP;
-                                break;
-                        }
-                        ret = mtd->write_user_prot_reg(mtd, *ppos, len, &retlen, kbuf);
+                        ret = mtd_write_user_prot_reg(mtd, *ppos, len,
+                                                      &retlen, kbuf);
                         break;
 
                 case MTD_FILE_MODE_RAW:
@@ -323,13 +324,13 @@ static ssize_t mtd_write(struct file *file, const char __user *buf, size_t count
                         ops.ooboffs = 0;
                         ops.len = len;
 
-                        ret = mtd->write_oob(mtd, *ppos, &ops);
+                        ret = mtd_write_oob(mtd, *ppos, &ops);
                         retlen = ops.retlen;
                         break;
                 }
 
                 default:
-                        ret = (*(mtd->write))(mtd, *ppos, len, &retlen, kbuf);
+                        ret = mtd_write(mtd, *ppos, len, &retlen, kbuf);
                 }
                 if (!ret) {
                         *ppos += retlen;
@@ -345,7 +346,7 @@ static ssize_t mtd_write(struct file *file, const char __user *buf, size_t count
 
         kfree(kbuf);
         return total_retlen;
-} /* mtd_write */
+} /* mtdchar_write */
 
 /*======================================================================
 
@@ -361,20 +362,22 @@ static void mtdchar_erase_callback (struct erase_info *instr)
 static int otp_select_filemode(struct mtd_file_info *mfi, int mode)
 {
         struct mtd_info *mtd = mfi->mtd;
+        size_t retlen;
         int ret = 0;
 
+        /*
+         * Make a fake call to mtd_read_fact_prot_reg() to check if OTP
+         * operations are supported.
+         */
+        if (mtd_read_fact_prot_reg(mtd, -1, -1, &retlen, NULL) == -EOPNOTSUPP)
+                return -EOPNOTSUPP;
+
         switch (mode) {
         case MTD_OTP_FACTORY:
-                if (!mtd->read_fact_prot_reg)
-                        ret = -EOPNOTSUPP;
-                else
-                        mfi->mode = MTD_FILE_MODE_OTP_FACTORY;
+                mfi->mode = MTD_FILE_MODE_OTP_FACTORY;
                 break;
         case MTD_OTP_USER:
-                if (!mtd->read_fact_prot_reg)
-                        ret = -EOPNOTSUPP;
-                else
-                        mfi->mode = MTD_FILE_MODE_OTP_USER;
+                mfi->mode = MTD_FILE_MODE_OTP_USER;
                 break;
         default:
                 ret = -EINVAL;
@@ -387,7 +390,7 @@ static int otp_select_filemode(struct mtd_file_info *mfi, int mode)
 # define otp_select_filemode(f,m)       -EOPNOTSUPP
 #endif
 
-static int mtd_do_writeoob(struct file *file, struct mtd_info *mtd,
+static int mtdchar_writeoob(struct file *file, struct mtd_info *mtd,
         uint64_t start, uint32_t length, void __user *ptr,
         uint32_t __user *retp)
 {
@@ -424,7 +427,7 @@ static int mtd_do_writeoob(struct file *file, struct mtd_info *mtd,
                 return PTR_ERR(ops.oobbuf);
 
         start &= ~((uint64_t)mtd->writesize - 1);
-        ret = mtd->write_oob(mtd, start, &ops);
+        ret = mtd_write_oob(mtd, start, &ops);
 
         if (ops.oobretlen > 0xFFFFFFFFU)
                 ret = -EOVERFLOW;
@@ -436,7 +439,7 @@ static int mtd_do_writeoob(struct file *file, struct mtd_info *mtd,
         return ret;
 }
 
-static int mtd_do_readoob(struct file *file, struct mtd_info *mtd,
+static int mtdchar_readoob(struct file *file, struct mtd_info *mtd,
         uint64_t start, uint32_t length, void __user *ptr,
         uint32_t __user *retp)
 {
@@ -447,13 +450,8 @@ static int mtd_do_readoob(struct file *file, struct mtd_info *mtd,
         if (length > 4096)
                 return -EINVAL;
 
-        if (!mtd->read_oob)
-                ret = -EOPNOTSUPP;
-        else
-                ret = access_ok(VERIFY_WRITE, ptr,
-                                length) ? 0 : -EFAULT;
-        if (ret)
-                return ret;
+        if (!access_ok(VERIFY_WRITE, ptr, length))
+                return -EFAULT;
 
         ops.ooblen = length;
         ops.ooboffs = start & (mtd->writesize - 1);
@@ -469,7 +467,7 @@ static int mtd_do_readoob(struct file *file, struct mtd_info *mtd,
                 return -ENOMEM;
 
         start &= ~((uint64_t)mtd->writesize - 1);
-        ret = mtd->read_oob(mtd, start, &ops);
+        ret = mtd_read_oob(mtd, start, &ops);
 
         if (put_user(ops.oobretlen, retp))
                 ret = -EFAULT;
@@ -530,7 +528,7 @@ static int shrink_ecclayout(const struct nand_ecclayout *from,
         return 0;
 }
 
-static int mtd_blkpg_ioctl(struct mtd_info *mtd,
+static int mtdchar_blkpg_ioctl(struct mtd_info *mtd,
                            struct blkpg_ioctl_arg __user *arg)
 {
         struct blkpg_ioctl_arg a;
@@ -566,7 +564,7 @@ static int mtd_blkpg_ioctl(struct mtd_info *mtd,
         }
 }
 
-static int mtd_write_ioctl(struct mtd_info *mtd,
+static int mtdchar_write_ioctl(struct mtd_info *mtd,
                 struct mtd_write_req __user *argp)
 {
         struct mtd_write_req req;
@@ -607,7 +605,7 @@ static int mtd_write_ioctl(struct mtd_info *mtd,
                 ops.oobbuf = NULL;
         }
 
-        ret = mtd->write_oob(mtd, (loff_t)req.start, &ops);
+        ret = mtd_write_oob(mtd, (loff_t)req.start, &ops);
 
         kfree(ops.datbuf);
         kfree(ops.oobbuf);
@@ -615,7 +613,7 @@ static int mtd_write_ioctl(struct mtd_info *mtd,
         return ret;
 }
 
-static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
+static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
 {
         struct mtd_file_info *mfi = file->private_data;
         struct mtd_info *mtd = mfi->mtd;
@@ -729,7 +727,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                           wq_head is no longer there when the
                           callback routine tries to wake us up.
                         */
-                        ret = mtd->erase(mtd, erase);
+                        ret = mtd_erase(mtd, erase);
                         if (!ret) {
                                 set_current_state(TASK_UNINTERRUPTIBLE);
                                 add_wait_queue(&waitq, &wait);
@@ -755,7 +753,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                 if (copy_from_user(&buf, argp, sizeof(buf)))
                         ret = -EFAULT;
                 else
-                        ret = mtd_do_writeoob(file, mtd, buf.start, buf.length,
+                        ret = mtdchar_writeoob(file, mtd, buf.start, buf.length,
                                 buf.ptr, &buf_user->length);
                 break;
         }
@@ -769,7 +767,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                 if (copy_from_user(&buf, argp, sizeof(buf)))
                         ret = -EFAULT;
                 else
-                        ret = mtd_do_readoob(file, mtd, buf.start, buf.length,
+                        ret = mtdchar_readoob(file, mtd, buf.start, buf.length,
                                 buf.ptr, &buf_user->start);
                 break;
         }
@@ -782,7 +780,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                 if (copy_from_user(&buf, argp, sizeof(buf)))
                         ret = -EFAULT;
                 else
-                        ret = mtd_do_writeoob(file, mtd, buf.start, buf.length,
+                        ret = mtdchar_writeoob(file, mtd, buf.start, buf.length,
                                 (void __user *)(uintptr_t)buf.usr_ptr,
                                 &buf_user->length);
                 break;
@@ -796,7 +794,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                 if (copy_from_user(&buf, argp, sizeof(buf)))
                         ret = -EFAULT;
                 else
-                        ret = mtd_do_readoob(file, mtd, buf.start, buf.length,
+                        ret = mtdchar_readoob(file, mtd, buf.start, buf.length,
                                 (void __user *)(uintptr_t)buf.usr_ptr,
                                 &buf_user->length);
                 break;
@@ -804,7 +802,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
 
         case MEMWRITE:
         {
-                ret = mtd_write_ioctl(mtd,
+                ret = mtdchar_write_ioctl(mtd,
                       (struct mtd_write_req __user *)arg);
                 break;
         }
@@ -816,10 +814,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                 if (copy_from_user(&einfo, argp, sizeof(einfo)))
                         return -EFAULT;
 
-                if (!mtd->lock)
-                        ret = -EOPNOTSUPP;
-                else
-                        ret = mtd->lock(mtd, einfo.start, einfo.length);
+                ret = mtd_lock(mtd, einfo.start, einfo.length);
                 break;
         }
 
@@ -830,10 +825,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                 if (copy_from_user(&einfo, argp, sizeof(einfo)))
                         return -EFAULT;
 
-                if (!mtd->unlock)
-                        ret = -EOPNOTSUPP;
-                else
-                        ret = mtd->unlock(mtd, einfo.start, einfo.length);
+                ret = mtd_unlock(mtd, einfo.start, einfo.length);
                 break;
         }
 
@@ -844,10 +836,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                 if (copy_from_user(&einfo, argp, sizeof(einfo)))
                         return -EFAULT;
 
-                if (!mtd->is_locked)
-                        ret = -EOPNOTSUPP;
-                else
-                        ret = mtd->is_locked(mtd, einfo.start, einfo.length);
+                ret = mtd_is_locked(mtd, einfo.start, einfo.length);
                 break;
         }
 
@@ -878,10 +867,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
 
                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
                         return -EFAULT;
-                if (!mtd->block_isbad)
-                        ret = -EOPNOTSUPP;
-                else
-                        return mtd->block_isbad(mtd, offs);
+                return mtd_block_isbad(mtd, offs);
                 break;
         }
 
@@ -891,10 +877,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
 
                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
                         return -EFAULT;
-                if (!mtd->block_markbad)
-                        ret = -EOPNOTSUPP;
-                else
-                        return mtd->block_markbad(mtd, offs);
+                return mtd_block_markbad(mtd, offs);
                 break;
         }
 
@@ -919,17 +902,15 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                 struct otp_info *buf = kmalloc(4096, GFP_KERNEL);
                 if (!buf)
                         return -ENOMEM;
-                ret = -EOPNOTSUPP;
                 switch (mfi->mode) {
                 case MTD_FILE_MODE_OTP_FACTORY:
-                        if (mtd->get_fact_prot_info)
-                                ret = mtd->get_fact_prot_info(mtd, buf, 4096);
+                        ret = mtd_get_fact_prot_info(mtd, buf, 4096);
                         break;
                 case MTD_FILE_MODE_OTP_USER:
-                        if (mtd->get_user_prot_info)
-                                ret = mtd->get_user_prot_info(mtd, buf, 4096);
+                        ret = mtd_get_user_prot_info(mtd, buf, 4096);
                         break;
                 default:
+                        ret = -EINVAL;
                         break;
                 }
                 if (ret >= 0) {
@@ -953,9 +934,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                         return -EINVAL;
                 if (copy_from_user(&oinfo, argp, sizeof(oinfo)))
                         return -EFAULT;
-                if (!mtd->lock_user_prot_reg)
-                        return -EOPNOTSUPP;
-                ret = mtd->lock_user_prot_reg(mtd, oinfo.start, oinfo.length);
+                ret = mtd_lock_user_prot_reg(mtd, oinfo.start, oinfo.length);
                 break;
         }
 #endif
@@ -999,7 +978,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
                         break;
 
                 case MTD_FILE_MODE_RAW:
-                        if (!mtd->read_oob || !mtd->write_oob)
+                        if (!mtd_has_oob(mtd))
                                 return -EOPNOTSUPP;
                         mfi->mode = arg;
 
@@ -1014,7 +993,7 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
 
         case BLKPG:
         {
-                ret = mtd_blkpg_ioctl(mtd,
+                ret = mtdchar_blkpg_ioctl(mtd,
                       (struct blkpg_ioctl_arg __user *)arg);
                 break;
         }
@@ -1033,12 +1012,12 @@ static int mtd_ioctl(struct file *file, u_int cmd, u_long arg)
         return ret;
 } /* memory_ioctl */
 
-static long mtd_unlocked_ioctl(struct file *file, u_int cmd, u_long arg)
+static long mtdchar_unlocked_ioctl(struct file *file, u_int cmd, u_long arg)
 {
         int ret;
 
         mutex_lock(&mtd_mutex);
-        ret = mtd_ioctl(file, cmd, arg);
+        ret = mtdchar_ioctl(file, cmd, arg);
         mutex_unlock(&mtd_mutex);
 
         return ret;
@@ -1055,7 +1034,7 @@ struct mtd_oob_buf32 {
 #define MEMWRITEOOB32           _IOWR('M', 3, struct mtd_oob_buf32)
 #define MEMREADOOB32            _IOWR('M', 4, struct mtd_oob_buf32)
 
-static long mtd_compat_ioctl(struct file *file, unsigned int cmd,
+static long mtdchar_compat_ioctl(struct file *file, unsigned int cmd,
         unsigned long arg)
 {
         struct mtd_file_info *mfi = file->private_data;
@@ -1074,7 +1053,7 @@ static long mtd_compat_ioctl(struct file *file, unsigned int cmd,
                 if (copy_from_user(&buf, argp, sizeof(buf)))
                         ret = -EFAULT;
                 else
-                        ret = mtd_do_writeoob(file, mtd, buf.start,
+                        ret = mtdchar_writeoob(file, mtd, buf.start,
                                 buf.length, compat_ptr(buf.ptr),
                                 &buf_user->length);
                 break;
@@ -1089,13 +1068,13 @@ static long mtd_compat_ioctl(struct file *file, unsigned int cmd,
                 if (copy_from_user(&buf, argp, sizeof(buf)))
                         ret = -EFAULT;
                 else
-                        ret = mtd_do_readoob(file, mtd, buf.start,
+                        ret = mtdchar_readoob(file, mtd, buf.start,
                                 buf.length, compat_ptr(buf.ptr),
                                 &buf_user->start);
                 break;
         }
         default:
-                ret = mtd_ioctl(file, cmd, (unsigned long)argp);
+                ret = mtdchar_ioctl(file, cmd, (unsigned long)argp);
         }
 
         mutex_unlock(&mtd_mutex);
@@ -1111,7 +1090,7 @@ static long mtd_compat_ioctl(struct file *file, unsigned int cmd,
  *   mappings)
  */
 #ifndef CONFIG_MMU
-static unsigned long mtd_get_unmapped_area(struct file *file,
+static unsigned long mtdchar_get_unmapped_area(struct file *file,
                                            unsigned long addr,
                                            unsigned long len,
                                            unsigned long pgoff,
@@ -1119,32 +1098,28 @@ static unsigned long mtd_get_unmapped_area(struct file *file,
 {
         struct mtd_file_info *mfi = file->private_data;
         struct mtd_info *mtd = mfi->mtd;
+        unsigned long offset;
+        int ret;
 
-        if (mtd->get_unmapped_area) {
-                unsigned long offset;
-
-                if (addr != 0)
-                        return (unsigned long) -EINVAL;
-
-                if (len > mtd->size || pgoff >= (mtd->size >> PAGE_SHIFT))
-                        return (unsigned long) -EINVAL;
+        if (addr != 0)
+                return (unsigned long) -EINVAL;
 
-                offset = pgoff << PAGE_SHIFT;
-                if (offset > mtd->size - len)
-                        return (unsigned long) -EINVAL;
+        if (len > mtd->size || pgoff >= (mtd->size >> PAGE_SHIFT))
+                return (unsigned long) -EINVAL;
 
-                return mtd->get_unmapped_area(mtd, len, offset, flags);
-        }
+        offset = pgoff << PAGE_SHIFT;
+        if (offset > mtd->size - len)
+                return (unsigned long) -EINVAL;
 
-        /* can't map directly */
-        return (unsigned long) -ENOSYS;
+        ret = mtd_get_unmapped_area(mtd, len, offset, flags);
+        return ret == -EOPNOTSUPP ? -ENOSYS : ret;
 }
 #endif
 
 /*
  * set up a mapping for shared memory segments
  */
-static int mtd_mmap(struct file *file, struct vm_area_struct *vma)
+static int mtdchar_mmap(struct file *file, struct vm_area_struct *vma)
 {
 #ifdef CONFIG_MMU
         struct mtd_file_info *mfi = file->private_data;
@@ -1185,18 +1160,18 @@ static int mtd_mmap(struct file *file, struct vm_area_struct *vma)
 
 static const struct file_operations mtd_fops = {
         .owner          = THIS_MODULE,
-        .llseek         = mtd_lseek,
-        .read           = mtd_read,
-        .write          = mtd_write,
-        .unlocked_ioctl = mtd_unlocked_ioctl,
+        .llseek         = mtdchar_lseek,
+        .read           = mtdchar_read,
+        .write          = mtdchar_write,
+        .unlocked_ioctl = mtdchar_unlocked_ioctl,
 #ifdef CONFIG_COMPAT
-        .compat_ioctl   = mtd_compat_ioctl,
+        .compat_ioctl   = mtdchar_compat_ioctl,
 #endif
-        .open           = mtd_open,
-        .release        = mtd_close,
-        .mmap           = mtd_mmap,
+        .open           = mtdchar_open,
+        .release        = mtdchar_close,
+        .mmap           = mtdchar_mmap,
 #ifndef CONFIG_MMU
-        .get_unmapped_area = mtd_get_unmapped_area,
+        .get_unmapped_area = mtdchar_get_unmapped_area,
 #endif
 };
 
diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
index 6df4d4d4eb92..1ed5103b219b 100644
--- a/drivers/mtd/mtdconcat.c
+++ b/drivers/mtd/mtdconcat.c
@@ -91,7 +91,7 @@ concat_read(struct mtd_info *mtd, loff_t from, size_t len,
                         /* Entire transaction goes into this subdev */
                         size = len;
 
-                err = subdev->read(subdev, from, size, &retsize, buf);
+                err = mtd_read(subdev, from, size, &retsize, buf);
 
                 /* Save information about bitflips! */
                 if (unlikely(err)) {
@@ -148,7 +148,7 @@ concat_write(struct mtd_info *mtd, loff_t to, size_t len,
                 if (!(subdev->flags & MTD_WRITEABLE))
                         err = -EROFS;
                 else
-                        err = subdev->write(subdev, to, size, &retsize, buf);
+                        err = mtd_write(subdev, to, size, &retsize, buf);
 
                 if (err)
                         break;
@@ -227,8 +227,9 @@ concat_writev(struct mtd_info *mtd, const struct kvec *vecs,
                 if (!(subdev->flags & MTD_WRITEABLE))
                         err = -EROFS;
                 else
-                        err = subdev->writev(subdev, &vecs_copy[entry_low],
-                                entry_high - entry_low + 1, to, &retsize);
+                        err = mtd_writev(subdev, &vecs_copy[entry_low],
+                                         entry_high - entry_low + 1, to,
+                                         &retsize);
 
                 vecs_copy[entry_high].iov_len = old_iov_len - size;
                 vecs_copy[entry_high].iov_base += size;
@@ -273,7 +274,7 @@ concat_read_oob(struct mtd_info *mtd, loff_t from, struct mtd_oob_ops *ops)
                 if (from + devops.len > subdev->size)
                         devops.len = subdev->size - from;
 
-                err = subdev->read_oob(subdev, from, &devops);
+                err = mtd_read_oob(subdev, from, &devops);
                 ops->retlen += devops.retlen;
                 ops->oobretlen += devops.oobretlen;
 
@@ -333,7 +334,7 @@ concat_write_oob(struct mtd_info *mtd, loff_t to, struct mtd_oob_ops *ops)
                 if (to + devops.len > subdev->size)
                         devops.len = subdev->size - to;
 
-                err = subdev->write_oob(subdev, to, &devops);
+                err = mtd_write_oob(subdev, to, &devops);
                 ops->retlen += devops.oobretlen;
                 if (err)
                         return err;
@@ -379,7 +380,7 @@ static int concat_dev_erase(struct mtd_info *mtd, struct erase_info *erase)
          * FIXME: Allow INTERRUPTIBLE. Which means
          * not having the wait_queue head on the stack.
          */
-        err = mtd->erase(mtd, erase);
+        err = mtd_erase(mtd, erase);
         if (!err) {
                 set_current_state(TASK_UNINTERRUPTIBLE);
                 add_wait_queue(&waitq, &wait);
@@ -554,12 +555,9 @@ static int concat_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
                 else
                         size = len;
 
-                if (subdev->lock) {
-                        err = subdev->lock(subdev, ofs, size);
-                        if (err)
-                                break;
-                } else
-                        err = -EOPNOTSUPP;
+                err = mtd_lock(subdev, ofs, size);
+                if (err)
+                        break;
 
                 len -= size;
                 if (len == 0)
@@ -594,12 +592,9 @@ static int concat_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
                 else
                         size = len;
 
-                if (subdev->unlock) {
-                        err = subdev->unlock(subdev, ofs, size);
-                        if (err)
-                                break;
-                } else
-                        err = -EOPNOTSUPP;
+                err = mtd_unlock(subdev, ofs, size);
+                if (err)
+                        break;
 
                 len -= size;
                 if (len == 0)
@@ -619,7 +614,7 @@ static void concat_sync(struct mtd_info *mtd)
 
         for (i = 0; i < concat->num_subdev; i++) {
                 struct mtd_info *subdev = concat->subdev[i];
-                subdev->sync(subdev);
+                mtd_sync(subdev);
         }
 }
 
@@ -630,7 +625,7 @@ static int concat_suspend(struct mtd_info *mtd)
 
         for (i = 0; i < concat->num_subdev; i++) {
                 struct mtd_info *subdev = concat->subdev[i];
-                if ((rc = subdev->suspend(subdev)) < 0)
+                if ((rc = mtd_suspend(subdev)) < 0)
                         return rc;
         }
         return rc;
@@ -643,7 +638,7 @@ static void concat_resume(struct mtd_info *mtd)
 
         for (i = 0; i < concat->num_subdev; i++) {
                 struct mtd_info *subdev = concat->subdev[i];
-                subdev->resume(subdev);
+                mtd_resume(subdev);
         }
 }
 
@@ -652,7 +647,7 @@ static int concat_block_isbad(struct mtd_info *mtd, loff_t ofs)
         struct mtd_concat *concat = CONCAT(mtd);
         int i, res = 0;
 
-        if (!concat->subdev[0]->block_isbad)
+        if (!mtd_can_have_bb(concat->subdev[0]))
                 return res;
 
         if (ofs > mtd->size)
@@ -666,7 +661,7 @@ static int concat_block_isbad(struct mtd_info *mtd, loff_t ofs)
                         continue;
                 }
 
-                res = subdev->block_isbad(subdev, ofs);
+                res = mtd_block_isbad(subdev, ofs);
                 break;
         }
 
@@ -678,7 +673,7 @@ static int concat_block_markbad(struct mtd_info *mtd, loff_t ofs)
         struct mtd_concat *concat = CONCAT(mtd);
         int i, err = -EINVAL;
 
-        if (!concat->subdev[0]->block_markbad)
+        if (!mtd_can_have_bb(concat->subdev[0]))
                 return 0;
 
         if (ofs > mtd->size)
@@ -692,7 +687,7 @@ static int concat_block_markbad(struct mtd_info *mtd, loff_t ofs)
                         continue;
                 }
 
-                err = subdev->block_markbad(subdev, ofs);
+                err = mtd_block_markbad(subdev, ofs);
                 if (!err)
                         mtd->ecc_stats.badblocks++;
                 break;
@@ -725,11 +720,7 @@ static unsigned long concat_get_unmapped_area(struct mtd_info *mtd,
                 if (offset + len > subdev->size)
                         return (unsigned long) -EINVAL;
 
-                if (subdev->get_unmapped_area)
-                        return subdev->get_unmapped_area(subdev, len, offset,
-                                                         flags);
-
-                break;
+                return mtd_get_unmapped_area(subdev, len, offset, flags);
         }
 
         return (unsigned long) -ENOSYS;
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index b01993ea260e..6ae9ca01388b 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -107,7 +107,8 @@ static LIST_HEAD(mtd_notifiers);
  */
 static void mtd_release(struct device *dev)
 {
-        dev_t index = MTD_DEVT(dev_to_mtd(dev)->index);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
+        dev_t index = MTD_DEVT(mtd->index);
 
         /* remove /dev/mtdXro node if needed */
         if (index)
@@ -116,27 +117,24 @@ static void mtd_release(struct device *dev)
 
 static int mtd_cls_suspend(struct device *dev, pm_message_t state)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
 
-        if (mtd && mtd->suspend)
-                return mtd->suspend(mtd);
-        else
-                return 0;
+        return mtd_suspend(mtd);
 }
 
 static int mtd_cls_resume(struct device *dev)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
-        
+        struct mtd_info *mtd = dev_get_drvdata(dev);
+
         if (mtd && mtd->resume)
-                mtd->resume(mtd);
+                mtd_resume(mtd);
         return 0;
 }
 
 static ssize_t mtd_type_show(struct device *dev,
                 struct device_attribute *attr, char *buf)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
         char *type;
 
         switch (mtd->type) {
@@ -172,7 +170,7 @@ static DEVICE_ATTR(type, S_IRUGO, mtd_type_show, NULL);
 static ssize_t mtd_flags_show(struct device *dev,
                 struct device_attribute *attr, char *buf)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
 
         return snprintf(buf, PAGE_SIZE, "0x%lx\n", (unsigned long)mtd->flags);
 
@@ -182,7 +180,7 @@ static DEVICE_ATTR(flags, S_IRUGO, mtd_flags_show, NULL);
 static ssize_t mtd_size_show(struct device *dev,
                 struct device_attribute *attr, char *buf)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
 
         return snprintf(buf, PAGE_SIZE, "%llu\n",
                 (unsigned long long)mtd->size);
@@ -193,7 +191,7 @@ static DEVICE_ATTR(size, S_IRUGO, mtd_size_show, NULL);
 static ssize_t mtd_erasesize_show(struct device *dev,
                 struct device_attribute *attr, char *buf)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
 
         return snprintf(buf, PAGE_SIZE, "%lu\n", (unsigned long)mtd->erasesize);
 
@@ -203,7 +201,7 @@ static DEVICE_ATTR(erasesize, S_IRUGO, mtd_erasesize_show, NULL);
 static ssize_t mtd_writesize_show(struct device *dev,
                 struct device_attribute *attr, char *buf)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
 
         return snprintf(buf, PAGE_SIZE, "%lu\n", (unsigned long)mtd->writesize);
 
@@ -213,7 +211,7 @@ static DEVICE_ATTR(writesize, S_IRUGO, mtd_writesize_show, NULL);
 static ssize_t mtd_subpagesize_show(struct device *dev,
                 struct device_attribute *attr, char *buf)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
         unsigned int subpagesize = mtd->writesize >> mtd->subpage_sft;
 
         return snprintf(buf, PAGE_SIZE, "%u\n", subpagesize);
@@ -224,7 +222,7 @@ static DEVICE_ATTR(subpagesize, S_IRUGO, mtd_subpagesize_show, NULL);
 static ssize_t mtd_oobsize_show(struct device *dev,
                 struct device_attribute *attr, char *buf)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
 
         return snprintf(buf, PAGE_SIZE, "%lu\n", (unsigned long)mtd->oobsize);
 
@@ -234,7 +232,7 @@ static DEVICE_ATTR(oobsize, S_IRUGO, mtd_oobsize_show, NULL);
 static ssize_t mtd_numeraseregions_show(struct device *dev,
                 struct device_attribute *attr, char *buf)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
 
         return snprintf(buf, PAGE_SIZE, "%u\n", mtd->numeraseregions);
 
@@ -245,7 +243,7 @@ static DEVICE_ATTR(numeraseregions, S_IRUGO, mtd_numeraseregions_show,
 static ssize_t mtd_name_show(struct device *dev,
                 struct device_attribute *attr, char *buf)
 {
-        struct mtd_info *mtd = dev_to_mtd(dev);
+        struct mtd_info *mtd = dev_get_drvdata(dev);
 
         return snprintf(buf, PAGE_SIZE, "%s\n", mtd->name);
 
@@ -338,9 +336,9 @@ int add_mtd_device(struct mtd_info *mtd)
         mtd->writesize_mask = (1 << mtd->writesize_shift) - 1;
 
         /* Some chips always power up locked. Unlock them now */
-        if ((mtd->flags & MTD_WRITEABLE)
-            && (mtd->flags & MTD_POWERUP_LOCK) && mtd->unlock) {
-                if (mtd->unlock(mtd, 0, mtd->size))
+        if ((mtd->flags & MTD_WRITEABLE) && (mtd->flags & MTD_POWERUP_LOCK)) {
+                error = mtd_unlock(mtd, 0, mtd->size);
+                if (error && error != -EOPNOTSUPP)
                         printk(KERN_WARNING
                                "%s: unlock failed, writes may not work\n",
                                mtd->name);
@@ -516,7 +514,6 @@ EXPORT_SYMBOL_GPL(mtd_device_unregister);
  *      or removal of MTD devices. Causes the 'add' callback to be immediately
  *      invoked for each MTD device currently present in the system.
  */
-
 void register_mtd_user (struct mtd_notifier *new)
 {
         struct mtd_info *mtd;
@@ -532,6 +529,7 @@ void register_mtd_user (struct mtd_notifier *new)
 
         mutex_unlock(&mtd_table_mutex);
 }
+EXPORT_SYMBOL_GPL(register_mtd_user);
 
 /**
  *      unregister_mtd_user - unregister a 'user' of MTD devices.
@@ -542,7 +540,6 @@ void register_mtd_user (struct mtd_notifier *new)
  *      'remove' callback to be immediately invoked for each MTD device
  *      currently present in the system.
  */
-
 int unregister_mtd_user (struct mtd_notifier *old)
 {
         struct mtd_info *mtd;
@@ -558,7 +555,7 @@ int unregister_mtd_user (struct mtd_notifier *old)
         mutex_unlock(&mtd_table_mutex);
         return 0;
 }
-
+EXPORT_SYMBOL_GPL(unregister_mtd_user);
 
 /**
  *      get_mtd_device - obtain a validated handle for an MTD device
@@ -571,7 +568,6 @@ int unregister_mtd_user (struct mtd_notifier *old)
  *      both, return the num'th driver only if its address matches. Return
  *      error code if not.
  */
-
 struct mtd_info *get_mtd_device(struct mtd_info *mtd, int num)
 {
         struct mtd_info *ret = NULL, *other;
@@ -604,6 +600,7 @@ out:
         mutex_unlock(&mtd_table_mutex);
         return ret;
 }
+EXPORT_SYMBOL_GPL(get_mtd_device);
 
 
 int __get_mtd_device(struct mtd_info *mtd)
@@ -624,6 +621,7 @@ int __get_mtd_device(struct mtd_info *mtd)
         mtd->usecount++;
         return 0;
 }
+EXPORT_SYMBOL_GPL(__get_mtd_device);
 
 /**
  *      get_mtd_device_nm - obtain a validated handle for an MTD device by
@@ -633,7 +631,6 @@ int __get_mtd_device(struct mtd_info *mtd)
  *      This function returns MTD device description structure in case of
  *      success and an error code in case of failure.
  */
-
 struct mtd_info *get_mtd_device_nm(const char *name)
 {
         int err = -ENODEV;
@@ -662,6 +659,7 @@ out_unlock:
         mutex_unlock(&mtd_table_mutex);
         return ERR_PTR(err);
 }
+EXPORT_SYMBOL_GPL(get_mtd_device_nm);
 
 void put_mtd_device(struct mtd_info *mtd)
 {
@@ -670,6 +668,7 @@ void put_mtd_device(struct mtd_info *mtd)
         mutex_unlock(&mtd_table_mutex);
 
 }
+EXPORT_SYMBOL_GPL(put_mtd_device);
 
 void __put_mtd_device(struct mtd_info *mtd)
 {
@@ -681,39 +680,65 @@ void __put_mtd_device(struct mtd_info *mtd)
 
         module_put(mtd->owner);
 }
+EXPORT_SYMBOL_GPL(__put_mtd_device);
 
-/* default_mtd_writev - default mtd writev method for MTD devices that
- *                      don't implement their own
+/*
+ * default_mtd_writev - the default writev method
+ * @mtd: mtd device description object pointer
+ * @vecs: the vectors to write
+ * @count: count of vectors in @vecs
+ * @to: the MTD device offset to write to
+ * @retlen: on exit contains the count of bytes written to the MTD device.
+ *
+ * This function returns zero in case of success and a negative error code in
+ * case of failure.
  */
-
-int default_mtd_writev(struct mtd_info *mtd, const struct kvec *vecs,
-                       unsigned long count, loff_t to, size_t *retlen)
+static int default_mtd_writev(struct mtd_info *mtd, const struct kvec *vecs,
+                              unsigned long count, loff_t to, size_t *retlen)
 {
         unsigned long i;
         size_t totlen = 0, thislen;
         int ret = 0;
 
-        if(!mtd->write) {
-                ret = -EROFS;
-        } else {
-                for (i=0; i<count; i++) {
-                        if (!vecs[i].iov_len)
-                                continue;
-                        ret = mtd->write(mtd, to, vecs[i].iov_len, &thislen, vecs[i].iov_base);
-                        totlen += thislen;
-                        if (ret || thislen != vecs[i].iov_len)
-                                break;
-                        to += vecs[i].iov_len;
-                }
+        for (i = 0; i < count; i++) {
+                if (!vecs[i].iov_len)
+                        continue;
+                ret = mtd_write(mtd, to, vecs[i].iov_len, &thislen,
+                                vecs[i].iov_base);
+                totlen += thislen;
+                if (ret || thislen != vecs[i].iov_len)
+                        break;
+                to += vecs[i].iov_len;
         }
-        if (retlen)
-                *retlen = totlen;
+        *retlen = totlen;
         return ret;
 }
 
+/*
+ * mtd_writev - the vector-based MTD write method
+ * @mtd: mtd device description object pointer
+ * @vecs: the vectors to write
+ * @count: count of vectors in @vecs
+ * @to: the MTD device offset to write to
+ * @retlen: on exit contains the count of bytes written to the MTD device.
+ *
+ * This function returns zero in case of success and a negative error code in
+ * case of failure.
+ */
+int mtd_writev(struct mtd_info *mtd, const struct kvec *vecs,
+               unsigned long count, loff_t to, size_t *retlen)
+{
+        *retlen = 0;
+        if (!mtd->writev)
+                return default_mtd_writev(mtd, vecs, count, to, retlen);
+        return mtd->writev(mtd, vecs, count, to, retlen);
+}
+EXPORT_SYMBOL_GPL(mtd_writev);
+
 /**
  * mtd_kmalloc_up_to - allocate a contiguous buffer up to the specified size
- * @size: A pointer to the ideal or maximum size of the allocation. Points
+ * @mtd: mtd device description object pointer
+ * @size: a pointer to the ideal or maximum size of the allocation, points
  *        to the actual allocation size on success.
  *
  * This routine attempts to allocate a contiguous kernel buffer up to
@@ -758,15 +783,6 @@ void *mtd_kmalloc_up_to(const struct mtd_info *mtd, size_t *size)
          */
         return kmalloc(*size, GFP_KERNEL);
 }
-
-EXPORT_SYMBOL_GPL(get_mtd_device);
-EXPORT_SYMBOL_GPL(get_mtd_device_nm);
-EXPORT_SYMBOL_GPL(__get_mtd_device);
-EXPORT_SYMBOL_GPL(put_mtd_device);
-EXPORT_SYMBOL_GPL(__put_mtd_device);
-EXPORT_SYMBOL_GPL(register_mtd_user);
-EXPORT_SYMBOL_GPL(unregister_mtd_user);
-EXPORT_SYMBOL_GPL(default_mtd_writev);
 EXPORT_SYMBOL_GPL(mtd_kmalloc_up_to);
 
 #ifdef CONFIG_PROC_FS
diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
index 1e2fa6236705..db8e8272d69b 100644
--- a/drivers/mtd/mtdoops.c
+++ b/drivers/mtd/mtdoops.c
@@ -112,7 +112,7 @@ static int mtdoops_erase_block(struct mtdoops_context *cxt, int offset)
         set_current_state(TASK_INTERRUPTIBLE);
         add_wait_queue(&wait_q, &wait);
 
-        ret = mtd->erase(mtd, &erase);
+        ret = mtd_erase(mtd, &erase);
         if (ret) {
                 set_current_state(TASK_RUNNING);
                 remove_wait_queue(&wait_q, &wait);
@@ -169,8 +169,8 @@ static void mtdoops_workfunc_erase(struct work_struct *work)
                         cxt->nextpage = 0;
         }
 
-        while (mtd->block_isbad) {
-                ret = mtd->block_isbad(mtd, cxt->nextpage * record_size);
+        while (mtd_can_have_bb(mtd)) {
+                ret = mtd_block_isbad(mtd, cxt->nextpage * record_size);
                 if (!ret)
                         break;
                 if (ret < 0) {
@@ -199,8 +199,8 @@ badblock:
                 return;
         }
 
-        if (mtd->block_markbad && ret == -EIO) {
-                ret = mtd->block_markbad(mtd, cxt->nextpage * record_size);
+        if (mtd_can_have_bb(mtd) && ret == -EIO) {
+                ret = mtd_block_markbad(mtd, cxt->nextpage * record_size);
                 if (ret < 0) {
                         printk(KERN_ERR "mtdoops: block_markbad failed, aborting\n");
                         return;
@@ -221,12 +221,16 @@ static void mtdoops_write(struct mtdoops_context *cxt, int panic)
         hdr[0] = cxt->nextcount;
         hdr[1] = MTDOOPS_KERNMSG_MAGIC;
 
-        if (panic)
-                ret = mtd->panic_write(mtd, cxt->nextpage * record_size,
-                                        record_size, &retlen, cxt->oops_buf);
-        else
-                ret = mtd->write(mtd, cxt->nextpage * record_size,
-                                        record_size, &retlen, cxt->oops_buf);
+        if (panic) {
+                ret = mtd_panic_write(mtd, cxt->nextpage * record_size,
+                                      record_size, &retlen, cxt->oops_buf);
+                if (ret == -EOPNOTSUPP) {
+                        printk(KERN_ERR "mtdoops: Cannot write from panic without panic_write\n");
+                        return;
+                }
+        } else
+                ret = mtd_write(mtd, cxt->nextpage * record_size,
+                                record_size, &retlen, cxt->oops_buf);
 
         if (retlen != record_size || ret < 0)
                 printk(KERN_ERR "mtdoops: write failure at %ld (%td of %ld written), error %d\n",
@@ -253,10 +257,13 @@ static void find_next_position(struct mtdoops_context *cxt)
         size_t retlen;
 
         for (page = 0; page < cxt->oops_pages; page++) {
+                if (mtd_can_have_bb(mtd) &&
+                    mtd_block_isbad(mtd, page * record_size))
+                        continue;
                 /* Assume the page is used */
                 mark_page_used(cxt, page);
-                ret = mtd->read(mtd, page * record_size, MTDOOPS_HEADER_SIZE,
-                                &retlen, (u_char *) &count[0]);
+                ret = mtd_read(mtd, page * record_size, MTDOOPS_HEADER_SIZE,
+                               &retlen, (u_char *)&count[0]);
                 if (retlen != MTDOOPS_HEADER_SIZE ||
                                 (ret < 0 && !mtd_is_bitflip(ret))) {
                         printk(KERN_ERR "mtdoops: read failure at %ld (%td of %d read), err %d\n",
@@ -327,13 +334,8 @@ static void mtdoops_do_dump(struct kmsg_dumper *dumper,
         memcpy(dst + l1_cpy, s2 + s2_start, l2_cpy);
 
         /* Panics must be written immediately */
-        if (reason != KMSG_DUMP_OOPS) {
-                if (!cxt->mtd->panic_write)
-                        printk(KERN_ERR "mtdoops: Cannot write from panic without panic_write\n");
-                else
-                        mtdoops_write(cxt, 1);
-                return;
-        }
+        if (reason != KMSG_DUMP_OOPS)
+                mtdoops_write(cxt, 1);
 
         /* For other cases, schedule work to write it "nicely" */
         schedule_work(&cxt->work_write);
@@ -369,7 +371,7 @@ static void mtdoops_notify_add(struct mtd_info *mtd)
 
         /* oops_page_used is a bit field */
         cxt->oops_page_used = vmalloc(DIV_ROUND_UP(mtdoops_pages,
-                        BITS_PER_LONG));
+                        BITS_PER_LONG) * sizeof(unsigned long));
         if (!cxt->oops_page_used) {
                 printk(KERN_ERR "mtdoops: could not allocate page array\n");
                 return;
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index a0bd2de4752b..a3d44c3416b4 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -70,8 +70,7 @@ static int part_read(struct mtd_info *mtd, loff_t from, size_t len,
                 len = 0;
         else if (from + len > mtd->size)
                 len = mtd->size - from;
-        res = part->master->read(part->master, from + part->offset,
-                                   len, retlen, buf);
+        res = mtd_read(part->master, from + part->offset, len, retlen, buf);
         if (unlikely(res)) {
                 if (mtd_is_bitflip(res))
                         mtd->ecc_stats.corrected += part->master->ecc_stats.corrected - stats.corrected;
@@ -89,15 +88,15 @@ static int part_point(struct mtd_info *mtd, loff_t from, size_t len,
                 len = 0;
         else if (from + len > mtd->size)
                 len = mtd->size - from;
-        return part->master->point (part->master, from + part->offset,
-                                    len, retlen, virt, phys);
+        return mtd_point(part->master, from + part->offset, len, retlen,
+                         virt, phys);
 }
 
 static void part_unpoint(struct mtd_info *mtd, loff_t from, size_t len)
 {
         struct mtd_part *part = PART(mtd);
 
-        part->master->unpoint(part->master, from + part->offset, len);
+        mtd_unpoint(part->master, from + part->offset, len);
 }
 
 static unsigned long part_get_unmapped_area(struct mtd_info *mtd,
@@ -108,8 +107,7 @@ static unsigned long part_get_unmapped_area(struct mtd_info *mtd,
         struct mtd_part *part = PART(mtd);
 
         offset += part->offset;
-        return part->master->get_unmapped_area(part->master, len, offset,
-                                               flags);
+        return mtd_get_unmapped_area(part->master, len, offset, flags);
 }
 
 static int part_read_oob(struct mtd_info *mtd, loff_t from,
@@ -140,7 +138,7 @@ static int part_read_oob(struct mtd_info *mtd, loff_t from,
                         return -EINVAL;
         }
 
-        res = part->master->read_oob(part->master, from + part->offset, ops);
+        res = mtd_read_oob(part->master, from + part->offset, ops);
         if (unlikely(res)) {
                 if (mtd_is_bitflip(res))
                         mtd->ecc_stats.corrected++;
@@ -154,30 +152,28 @@ static int part_read_user_prot_reg(struct mtd_info *mtd, loff_t from,
                 size_t len, size_t *retlen, u_char *buf)
 {
         struct mtd_part *part = PART(mtd);
-        return part->master->read_user_prot_reg(part->master, from,
-                                        len, retlen, buf);
+        return mtd_read_user_prot_reg(part->master, from, len, retlen, buf);
 }
 
 static int part_get_user_prot_info(struct mtd_info *mtd,
                 struct otp_info *buf, size_t len)
 {
         struct mtd_part *part = PART(mtd);
-        return part->master->get_user_prot_info(part->master, buf, len);
+        return mtd_get_user_prot_info(part->master, buf, len);
 }
 
 static int part_read_fact_prot_reg(struct mtd_info *mtd, loff_t from,
                 size_t len, size_t *retlen, u_char *buf)
 {
         struct mtd_part *part = PART(mtd);
-        return part->master->read_fact_prot_reg(part->master, from,
-                                        len, retlen, buf);
+        return mtd_read_fact_prot_reg(part->master, from, len, retlen, buf);
 }
 
 static int part_get_fact_prot_info(struct mtd_info *mtd, struct otp_info *buf,
                 size_t len)
 {
         struct mtd_part *part = PART(mtd);
-        return part->master->get_fact_prot_info(part->master, buf, len);
+        return mtd_get_fact_prot_info(part->master, buf, len);
 }
 
 static int part_write(struct mtd_info *mtd, loff_t to, size_t len,
@@ -190,8 +186,7 @@ static int part_write(struct mtd_info *mtd, loff_t to, size_t len,
                 len = 0;
         else if (to + len > mtd->size)
                 len = mtd->size - to;
-        return part->master->write(part->master, to + part->offset,
-                                    len, retlen, buf);
+        return mtd_write(part->master, to + part->offset, len, retlen, buf);
 }
 
 static int part_panic_write(struct mtd_info *mtd, loff_t to, size_t len,
@@ -204,8 +199,8 @@ static int part_panic_write(struct mtd_info *mtd, loff_t to, size_t len,
                 len = 0;
         else if (to + len > mtd->size)
                 len = mtd->size - to;
-        return part->master->panic_write(part->master, to + part->offset,
-                                    len, retlen, buf);
+        return mtd_panic_write(part->master, to + part->offset, len, retlen,
+                               buf);
 }
 
 static int part_write_oob(struct mtd_info *mtd, loff_t to,
@@ -220,22 +215,21 @@ static int part_write_oob(struct mtd_info *mtd, loff_t to,
                 return -EINVAL;
         if (ops->datbuf && to + ops->len > mtd->size)
                 return -EINVAL;
-        return part->master->write_oob(part->master, to + part->offset, ops);
+        return mtd_write_oob(part->master, to + part->offset, ops);
 }
 
 static int part_write_user_prot_reg(struct mtd_info *mtd, loff_t from,
                 size_t len, size_t *retlen, u_char *buf)
 {
         struct mtd_part *part = PART(mtd);
-        return part->master->write_user_prot_reg(part->master, from,
-                                        len, retlen, buf);
+        return mtd_write_user_prot_reg(part->master, from, len, retlen, buf);
 }
 
 static int part_lock_user_prot_reg(struct mtd_info *mtd, loff_t from,
                 size_t len)
 {
         struct mtd_part *part = PART(mtd);
-        return part->master->lock_user_prot_reg(part->master, from, len);
+        return mtd_lock_user_prot_reg(part->master, from, len);
 }
 
 static int part_writev(struct mtd_info *mtd, const struct kvec *vecs,
@@ -244,8 +238,8 @@ static int part_writev(struct mtd_info *mtd, const struct kvec *vecs,
         struct mtd_part *part = PART(mtd);
         if (!(mtd->flags & MTD_WRITEABLE))
                 return -EROFS;
-        return part->master->writev(part->master, vecs, count,
-                                        to + part->offset, retlen);
+        return mtd_writev(part->master, vecs, count, to + part->offset,
+                          retlen);
 }
 
 static int part_erase(struct mtd_info *mtd, struct erase_info *instr)
@@ -257,7 +251,7 @@ static int part_erase(struct mtd_info *mtd, struct erase_info *instr)
         if (instr->addr >= mtd->size)
                 return -EINVAL;
         instr->addr += part->offset;
-        ret = part->master->erase(part->master, instr);
+        ret = mtd_erase(part->master, instr);
         if (ret) {
                 if (instr->fail_addr != MTD_FAIL_ADDR_UNKNOWN)
                         instr->fail_addr -= part->offset;
@@ -285,7 +279,7 @@ static int part_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
         struct mtd_part *part = PART(mtd);
         if ((len + ofs) > mtd->size)
                 return -EINVAL;
-        return part->master->lock(part->master, ofs + part->offset, len);
+        return mtd_lock(part->master, ofs + part->offset, len);
 }
 
 static int part_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
@@ -293,7 +287,7 @@ static int part_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
         struct mtd_part *part = PART(mtd);
         if ((len + ofs) > mtd->size)
                 return -EINVAL;
-        return part->master->unlock(part->master, ofs + part->offset, len);
+        return mtd_unlock(part->master, ofs + part->offset, len);
 }
 
 static int part_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
@@ -301,25 +295,25 @@ static int part_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
         struct mtd_part *part = PART(mtd);
         if ((len + ofs) > mtd->size)
                 return -EINVAL;
-        return part->master->is_locked(part->master, ofs + part->offset, len);
+        return mtd_is_locked(part->master, ofs + part->offset, len);
 }
 
 static void part_sync(struct mtd_info *mtd)
 {
         struct mtd_part *part = PART(mtd);
-        part->master->sync(part->master);
+        mtd_sync(part->master);
 }
 
 static int part_suspend(struct mtd_info *mtd)
 {
         struct mtd_part *part = PART(mtd);
-        return part->master->suspend(part->master);
+        return mtd_suspend(part->master);
 }
 
 static void part_resume(struct mtd_info *mtd)
 {
         struct mtd_part *part = PART(mtd);
-        part->master->resume(part->master);
+        mtd_resume(part->master);
 }
 
 static int part_block_isbad(struct mtd_info *mtd, loff_t ofs)
@@ -328,7 +322,7 @@ static int part_block_isbad(struct mtd_info *mtd, loff_t ofs)
         if (ofs >= mtd->size)
                 return -EINVAL;
         ofs += part->offset;
-        return part->master->block_isbad(part->master, ofs);
+        return mtd_block_isbad(part->master, ofs);
 }
 
 static int part_block_markbad(struct mtd_info *mtd, loff_t ofs)
@@ -341,7 +335,7 @@ static int part_block_markbad(struct mtd_info *mtd, loff_t ofs)
         if (ofs >= mtd->size)
                 return -EINVAL;
         ofs += part->offset;
-        res = part->master->block_markbad(part->master, ofs);
+        res = mtd_block_markbad(part->master, ofs);
         if (!res)
                 mtd->ecc_stats.badblocks++;
         return res;
@@ -559,8 +553,7 @@ static struct mtd_part *allocate_partition(struct mtd_info *master,
                 uint64_t offs = 0;
 
                 while (offs < slave->mtd.size) {
-                        if (master->block_isbad(master,
-                                                offs + slave->offset))
+                        if (mtd_block_isbad(master, offs + slave->offset))
                                 slave->mtd.ecc_stats.badblocks++;
                         offs += slave->mtd.erasesize;
                 }
diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
index bd9590c723e4..c92f0f6bc130 100644
--- a/drivers/mtd/mtdswap.c
+++ b/drivers/mtd/mtdswap.c
@@ -274,12 +274,12 @@ static int mtdswap_handle_badblock(struct mtdswap_dev *d, struct swap_eb *eb)
         eb->root = NULL;
 
         /* badblocks not supported */
-        if (!d->mtd->block_markbad)
+        if (!mtd_can_have_bb(d->mtd))
                 return 1;
 
         offset = mtdswap_eb_offset(d, eb);
         dev_warn(d->dev, "Marking bad block at %08llx\n", offset);
-        ret = d->mtd->block_markbad(d->mtd, offset);
+        ret = mtd_block_markbad(d->mtd, offset);
 
         if (ret) {
                 dev_warn(d->dev, "Mark block bad failed for block at %08llx "
@@ -312,7 +312,7 @@ static int mtdswap_handle_write_error(struct mtdswap_dev *d, struct swap_eb *eb)
 static int mtdswap_read_oob(struct mtdswap_dev *d, loff_t from,
                         struct mtd_oob_ops *ops)
 {
-        int ret = d->mtd->read_oob(d->mtd, from, ops);
+        int ret = mtd_read_oob(d->mtd, from, ops);
 
         if (mtd_is_bitflip(ret))
                 return ret;
@@ -343,7 +343,7 @@ static int mtdswap_read_markers(struct mtdswap_dev *d, struct swap_eb *eb)
         offset = mtdswap_eb_offset(d, eb);
 
         /* Check first if the block is bad. */
-        if (d->mtd->block_isbad && d->mtd->block_isbad(d->mtd, offset))
+        if (mtd_can_have_bb(d->mtd) && mtd_block_isbad(d->mtd, offset))
                 return MTDSWAP_SCANNED_BAD;
 
         ops.ooblen = 2 * d->mtd->ecclayout->oobavail;
@@ -403,7 +403,7 @@ static int mtdswap_write_marker(struct mtdswap_dev *d, struct swap_eb *eb,
                 offset = mtdswap_eb_offset(d, eb) + d->mtd->writesize;
         }
 
-        ret = d->mtd->write_oob(d->mtd, offset , &ops);
+        ret = mtd_write_oob(d->mtd, offset, &ops);
 
         if (ret) {
                 dev_warn(d->dev, "Write OOB failed for block at %08llx "
@@ -567,7 +567,7 @@ retry:
         erase.len       = mtd->erasesize;
         erase.priv      = (u_long)&wq;
 
-        ret = mtd->erase(mtd, &erase);
+        ret = mtd_erase(mtd, &erase);
         if (ret) {
                 if (retries++ < MTDSWAP_ERASE_RETRIES) {
                         dev_warn(d->dev,
@@ -689,7 +689,7 @@ retry:
                 return ret;
 
         writepos = (loff_t)*bp << PAGE_SHIFT;
-        ret =  mtd->write(mtd, writepos, PAGE_SIZE, &retlen, buf);
+        ret =  mtd_write(mtd, writepos, PAGE_SIZE, &retlen, buf);
         if (ret == -EIO || mtd_is_eccerr(ret)) {
                 d->curr_write_pos--;
                 eb->active_count--;
@@ -736,7 +736,7 @@ static int mtdswap_move_block(struct mtdswap_dev *d, unsigned int oldblock,
         retries = 0;
 
 retry:
-        ret = mtd->read(mtd, readpos, PAGE_SIZE, &retlen, d->page_buf);
+        ret = mtd_read(mtd, readpos, PAGE_SIZE, &retlen, d->page_buf);
 
         if (ret < 0 && !mtd_is_bitflip(ret)) {
                 oldeb = d->eb_data + oldblock / d->pages_per_eblk;
@@ -946,7 +946,7 @@ static unsigned int mtdswap_eblk_passes(struct mtdswap_dev *d,
                         patt = mtdswap_test_patt(test + i);
                         memset(d->page_buf, patt, mtd->writesize);
                         memset(d->oob_buf, patt, mtd->ecclayout->oobavail);
-                        ret = mtd->write_oob(mtd, pos, &ops);
+                        ret = mtd_write_oob(mtd, pos, &ops);
                         if (ret)
                                 goto error;
 
@@ -955,7 +955,7 @@ static unsigned int mtdswap_eblk_passes(struct mtdswap_dev *d,
 
                 pos = base;
                 for (i = 0; i < mtd_pages; i++) {
-                        ret = mtd->read_oob(mtd, pos, &ops);
+                        ret = mtd_read_oob(mtd, pos, &ops);
                         if (ret)
                                 goto error;
 
@@ -1047,8 +1047,7 @@ static int mtdswap_flush(struct mtd_blktrans_dev *dev)
 {
         struct mtdswap_dev *d = MTDSWAP_MBD_TO_MTDSWAP(dev);
 
-        if (d->mtd->sync)
-                d->mtd->sync(d->mtd);
+        mtd_sync(d->mtd);
         return 0;
 }
 
@@ -1059,9 +1058,9 @@ static unsigned int mtdswap_badblocks(struct mtd_info *mtd, uint64_t size)
 
         badcnt = 0;
 
-        if (mtd->block_isbad)
+        if (mtd_can_have_bb(mtd))
                 for (offset = 0; offset < size; offset += mtd->erasesize)
-                        if (mtd->block_isbad(mtd, offset))
+                        if (mtd_block_isbad(mtd, offset))
                                 badcnt++;
 
         return badcnt;
@@ -1161,7 +1160,7 @@ static int mtdswap_readsect(struct mtd_blktrans_dev *dev,
         retries = 0;
 
 retry:
-        ret = mtd->read(mtd, readpos, PAGE_SIZE, &retlen, buf);
+        ret = mtd_read(mtd, readpos, PAGE_SIZE, &retlen, buf);
 
         d->mtd_read_count++;
         if (mtd_is_bitflip(ret)) {
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index dd0279249bf4..31b034b7eba3 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -110,7 +110,7 @@ config MTD_NAND_AMS_DELTA
 
 config MTD_NAND_OMAP2
         tristate "NAND Flash device on OMAP2, OMAP3 and OMAP4"
-        depends on ARM && (ARCH_OMAP2 || ARCH_OMAP3 || ARCH_OMAP4)
+        depends on ARCH_OMAP2PLUS
         help
           Support for NAND flash on Texas Instruments OMAP2, OMAP3 and OMAP4
           platforms.
diff --git a/drivers/mtd/nand/ams-delta.c b/drivers/mtd/nand/ams-delta.c
index 9e6b498c9beb..3197e9764fcd 100644
--- a/drivers/mtd/nand/ams-delta.c
+++ b/drivers/mtd/nand/ams-delta.c
@@ -280,17 +280,7 @@ static struct platform_driver ams_delta_nand_driver = {
         },
 };
 
-static int __init ams_delta_nand_init(void)
-{
-        return platform_driver_register(&ams_delta_nand_driver);
-}
-module_init(ams_delta_nand_init);
-
-static void __exit ams_delta_nand_exit(void)
-{
-        platform_driver_unregister(&ams_delta_nand_driver);
-}
-module_exit(ams_delta_nand_exit);
+module_platform_driver(ams_delta_nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Jonathan McDowell <noodles@earth.li>");
diff --git a/drivers/mtd/nand/bcm_umi_nand.c b/drivers/mtd/nand/bcm_umi_nand.c
index 46b58d672847..50387fd4009b 100644
--- a/drivers/mtd/nand/bcm_umi_nand.c
+++ b/drivers/mtd/nand/bcm_umi_nand.c
@@ -546,18 +546,7 @@ static struct platform_driver nand_driver = {
         .resume = bcm_umi_nand_resume,
 };
 
-static int __init nand_init(void)
-{
-        return platform_driver_register(&nand_driver);
-}
-
-static void __exit nand_exit(void)
-{
-        platform_driver_unregister(&nand_driver);
-}
-
-module_init(nand_init);
-module_exit(nand_exit);
+module_platform_driver(nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Broadcom");
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index c153e1f77f90..6e566156956f 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -675,7 +675,9 @@ static int __init nand_davinci_probe(struct platform_device *pdev)
 
         davinci_nand_writel(info, A1CR_OFFSET + info->core_chipsel * 4, val);
 
-        ret = davinci_aemif_setup_timing(info->timing, info->base,
+        ret = 0;
+        if (info->timing)
+                ret = davinci_aemif_setup_timing(info->timing, info->base,
                                                         info->core_chipsel);
         if (ret < 0) {
                 dev_dbg(&pdev->dev, "NAND timing values setup fail\n");
diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c
index 5780dbab6113..df921e7a496c 100644
--- a/drivers/mtd/nand/diskonchip.c
+++ b/drivers/mtd/nand/diskonchip.c
@@ -1072,7 +1072,7 @@ static int __init find_media_headers(struct mtd_info *mtd, u_char *buf, const ch
         size_t retlen;
 
         for (offs = 0; offs < mtd->size; offs += mtd->erasesize) {
-                ret = mtd->read(mtd, offs, mtd->writesize, &retlen, buf);
+                ret = mtd_read(mtd, offs, mtd->writesize, &retlen, buf);
                 if (retlen != mtd->writesize)
                         continue;
                 if (ret) {
@@ -1097,7 +1097,7 @@ static int __init find_media_headers(struct mtd_info *mtd, u_char *buf, const ch
         /* Only one mediaheader was found.  We want buf to contain a
            mediaheader on return, so we'll have to re-read the one we found. */
         offs = doc->mh0_page << this->page_shift;
-        ret = mtd->read(mtd, offs, mtd->writesize, &retlen, buf);
+        ret = mtd_read(mtd, offs, mtd->writesize, &retlen, buf);
         if (retlen != mtd->writesize) {
                 /* Insanity.  Give up. */
                 printk(KERN_ERR "Read DiskOnChip Media Header once, but can't reread it???\n");
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index eedd8ee2c9ac..7195ee6efe12 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -166,15 +166,22 @@ static void set_addr(struct mtd_info *mtd, int column, int page_addr, int oob)
 
         elbc_fcm_ctrl->page = page_addr;
 
-        out_be32(&lbc->fbar,
-                 page_addr >> (chip->phys_erase_shift - chip->page_shift));
-
         if (priv->page_size) {
+                /*
+                 * large page size chip : FPAR[PI] save the lowest 6 bits,
+                 *                        FBAR[BLK] save the other bits.
+                 */
+                out_be32(&lbc->fbar, page_addr >> 6);
                 out_be32(&lbc->fpar,
                          ((page_addr << FPAR_LP_PI_SHIFT) & FPAR_LP_PI) |
                          (oob ? FPAR_LP_MS : 0) | column);
                 buf_num = (page_addr & 1) << 2;
         } else {
+                /*
+                 * small page size chip : FPAR[PI] save the lowest 5 bits,
+                 *                        FBAR[BLK] save the other bits.
+                 */
+                out_be32(&lbc->fbar, page_addr >> 5);
                 out_be32(&lbc->fpar,
                          ((page_addr << FPAR_SP_PI_SHIFT) & FPAR_SP_PI) |
                          (oob ? FPAR_SP_MS : 0) | column);
@@ -349,20 +356,22 @@ static void fsl_elbc_cmdfunc(struct mtd_info *mtd, unsigned int command,
                 fsl_elbc_run_command(mtd);
                 return;
 
-        /* READID must read all 5 possible bytes while CEB is active */
         case NAND_CMD_READID:
-                dev_vdbg(priv->dev, "fsl_elbc_cmdfunc: NAND_CMD_READID.\n");
+        case NAND_CMD_PARAM:
+                dev_vdbg(priv->dev, "fsl_elbc_cmdfunc: NAND_CMD %x\n", command);
 
                 out_be32(&lbc->fir, (FIR_OP_CM0 << FIR_OP0_SHIFT) |
                                     (FIR_OP_UA  << FIR_OP1_SHIFT) |
                                     (FIR_OP_RBW << FIR_OP2_SHIFT));
-                out_be32(&lbc->fcr, NAND_CMD_READID << FCR_CMD0_SHIFT);
-                /* nand_get_flash_type() reads 8 bytes of entire ID string */
-                out_be32(&lbc->fbcr, 8);
-                elbc_fcm_ctrl->read_bytes = 8;
+                out_be32(&lbc->fcr, command << FCR_CMD0_SHIFT);
+                /*
+                 * although currently it's 8 bytes for READID, we always read
+                 * the maximum 256 bytes(for PARAM)
+                 */
+                out_be32(&lbc->fbcr, 256);
+                elbc_fcm_ctrl->read_bytes = 256;
                 elbc_fcm_ctrl->use_mdr = 1;
-                elbc_fcm_ctrl->mdr = 0;
-
+                elbc_fcm_ctrl->mdr = column;
                 set_addr(mtd, 0, 0, 0);
                 fsl_elbc_run_command(mtd);
                 return;
@@ -407,9 +416,17 @@ static void fsl_elbc_cmdfunc(struct mtd_info *mtd, unsigned int command,
                          page_addr, column);
 
                 elbc_fcm_ctrl->column = column;
-                elbc_fcm_ctrl->oob = 0;
                 elbc_fcm_ctrl->use_mdr = 1;
 
+                if (column >= mtd->writesize) {
+                        /* OOB area */
+                        column -= mtd->writesize;
+                        elbc_fcm_ctrl->oob = 1;
+                } else {
+                        WARN_ON(column != 0);
+                        elbc_fcm_ctrl->oob = 0;
+                }
+
                 fcr = (NAND_CMD_STATUS   << FCR_CMD1_SHIFT) |
                       (NAND_CMD_SEQIN    << FCR_CMD2_SHIFT) |
                       (NAND_CMD_PAGEPROG << FCR_CMD3_SHIFT);
@@ -434,16 +451,12 @@ static void fsl_elbc_cmdfunc(struct mtd_info *mtd, unsigned int command,
                                  (FIR_OP_CW1 << FIR_OP6_SHIFT) |
                                  (FIR_OP_RS  << FIR_OP7_SHIFT));
 
-                        if (column >= mtd->writesize) {
+                        if (elbc_fcm_ctrl->oob)
                                 /* OOB area --> READOOB */
-                                column -= mtd->writesize;
                                 fcr |= NAND_CMD_READOOB << FCR_CMD0_SHIFT;
-                                elbc_fcm_ctrl->oob = 1;
-                        } else {
-                                WARN_ON(column != 0);
+                        else
                                 /* First 256 bytes --> READ0 */
                                 fcr |= NAND_CMD_READ0 << FCR_CMD0_SHIFT;
-                        }
                 }
 
                 out_be32(&lbc->fcr, fcr);
@@ -463,7 +476,8 @@ static void fsl_elbc_cmdfunc(struct mtd_info *mtd, unsigned int command,
                  */
                 if (elbc_fcm_ctrl->oob || elbc_fcm_ctrl->column != 0 ||
                     elbc_fcm_ctrl->index != mtd->writesize + mtd->oobsize)
-                        out_be32(&lbc->fbcr, elbc_fcm_ctrl->index);
+                        out_be32(&lbc->fbcr,
+                                elbc_fcm_ctrl->index - elbc_fcm_ctrl->column);
                 else
                         out_be32(&lbc->fbcr, 0);
 
@@ -659,9 +673,7 @@ static int fsl_elbc_chip_init_tail(struct mtd_info *mtd)
         if (chip->pagemask & 0xff000000)
                 al++;
 
-        /* add to ECCM mode set in fsl_elbc_init */
-        priv->fmr |= (12 << FMR_CWTO_SHIFT) |  /* Timeout > 12 ms */
-                     (al << FMR_AL_SHIFT);
+        priv->fmr |= al << FMR_AL_SHIFT;
 
         dev_dbg(priv->dev, "fsl_elbc_init: nand->numchips = %d\n",
                 chip->numchips);
@@ -764,8 +776,10 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv)
         priv->mtd.priv = chip;
         priv->mtd.owner = THIS_MODULE;
 
-        /* Set the ECCM according to the settings in bootloader.*/
-        priv->fmr = in_be32(&lbc->fmr) & FMR_ECCM;
+        /* set timeout to maximum */
+        priv->fmr = 15 << FMR_CWTO_SHIFT;
+        if (in_be32(&lbc->bank[priv->bank].or) & OR_FCM_PGS)
+                priv->fmr |= FMR_ECCM;
 
         /* fill in nand_chip structure */
         /* set up function call table */
@@ -971,18 +985,7 @@ static struct platform_driver fsl_elbc_nand_driver = {
         .remove = fsl_elbc_nand_remove,
 };
 
-static int __init fsl_elbc_nand_init(void)
-{
-        return platform_driver_register(&fsl_elbc_nand_driver);
-}
-
-static void __exit fsl_elbc_nand_exit(void)
-{
-        platform_driver_unregister(&fsl_elbc_nand_driver);
-}
-
-module_init(fsl_elbc_nand_init);
-module_exit(fsl_elbc_nand_exit);
+module_platform_driver(fsl_elbc_nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Freescale");
diff --git a/drivers/mtd/nand/fsl_upm.c b/drivers/mtd/nand/fsl_upm.c
index b4f3cc9f32fb..45df542b9c61 100644
--- a/drivers/mtd/nand/fsl_upm.c
+++ b/drivers/mtd/nand/fsl_upm.c
@@ -353,17 +353,7 @@ static struct platform_driver of_fun_driver = {
         .remove         = __devexit_p(fun_remove),
 };
 
-static int __init fun_module_init(void)
-{
-        return platform_driver_register(&of_fun_driver);
-}
-module_init(fun_module_init);
-
-static void __exit fun_module_exit(void)
-{
-        platform_driver_unregister(&of_fun_driver);
-}
-module_exit(fun_module_exit);
+module_platform_driver(of_fun_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Anton Vorontsov <avorontsov@ru.mvista.com>");
diff --git a/drivers/mtd/nand/gpio.c b/drivers/mtd/nand/gpio.c
index 2c2060b2800e..27000a5f5f47 100644
--- a/drivers/mtd/nand/gpio.c
+++ b/drivers/mtd/nand/gpio.c
@@ -27,6 +27,9 @@
 #include <linux/mtd/nand.h>
 #include <linux/mtd/partitions.h>
 #include <linux/mtd/nand-gpio.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_gpio.h>
 
 struct gpiomtd {
         void __iomem            *io_sync;
@@ -171,6 +174,96 @@ static int gpio_nand_devready(struct mtd_info *mtd)
         return gpio_get_value(gpiomtd->plat.gpio_rdy);
 }
 
+#ifdef CONFIG_OF
+static const struct of_device_id gpio_nand_id_table[] = {
+        { .compatible = "gpio-control-nand" },
+        {}
+};
+MODULE_DEVICE_TABLE(of, gpio_nand_id_table);
+
+static int gpio_nand_get_config_of(const struct device *dev,
+                                   struct gpio_nand_platdata *plat)
+{
+        u32 val;
+
+        if (!of_property_read_u32(dev->of_node, "bank-width", &val)) {
+                if (val == 2) {
+                        plat->options |= NAND_BUSWIDTH_16;
+                } else if (val != 1) {
+                        dev_err(dev, "invalid bank-width %u\n", val);
+                        return -EINVAL;
+                }
+        }
+
+        plat->gpio_rdy = of_get_gpio(dev->of_node, 0);
+        plat->gpio_nce = of_get_gpio(dev->of_node, 1);
+        plat->gpio_ale = of_get_gpio(dev->of_node, 2);
+        plat->gpio_cle = of_get_gpio(dev->of_node, 3);
+        plat->gpio_nwp = of_get_gpio(dev->of_node, 4);
+
+        if (!of_property_read_u32(dev->of_node, "chip-delay", &val))
+                plat->chip_delay = val;
+
+        return 0;
+}
+
+static struct resource *gpio_nand_get_io_sync_of(struct platform_device *pdev)
+{
+        struct resource *r = devm_kzalloc(&pdev->dev, sizeof(*r), GFP_KERNEL);
+        u64 addr;
+
+        if (!r || of_property_read_u64(pdev->dev.of_node,
+                                       "gpio-control-nand,io-sync-reg", &addr))
+                return NULL;
+
+        r->start = addr;
+        r->end = r->start + 0x3;
+        r->flags = IORESOURCE_MEM;
+
+        return r;
+}
+#else /* CONFIG_OF */
+#define gpio_nand_id_table NULL
+static inline int gpio_nand_get_config_of(const struct device *dev,
+                                          struct gpio_nand_platdata *plat)
+{
+        return -ENOSYS;
+}
+
+static inline struct resource *
+gpio_nand_get_io_sync_of(struct platform_device *pdev)
+{
+        return NULL;
+}
+#endif /* CONFIG_OF */
+
+static inline int gpio_nand_get_config(const struct device *dev,
+                                       struct gpio_nand_platdata *plat)
+{
+        int ret = gpio_nand_get_config_of(dev, plat);
+
+        if (!ret)
+                return ret;
+
+        if (dev->platform_data) {
+                memcpy(plat, dev->platform_data, sizeof(*plat));
+                return 0;
+        }
+
+        return -EINVAL;
+}
+
+static inline struct resource *
+gpio_nand_get_io_sync(struct platform_device *pdev)
+{
+        struct resource *r = gpio_nand_get_io_sync_of(pdev);
+
+        if (r)
+                return r;
+
+        return platform_get_resource(pdev, IORESOURCE_MEM, 1);
+}
+
 static int __devexit gpio_nand_remove(struct platform_device *dev)
 {
         struct gpiomtd *gpiomtd = platform_get_drvdata(dev);
@@ -178,7 +271,7 @@ static int __devexit gpio_nand_remove(struct platform_device *dev)
 
         nand_release(&gpiomtd->mtd_info);
 
-        res = platform_get_resource(dev, IORESOURCE_MEM, 1);
+        res = gpio_nand_get_io_sync(dev);
         iounmap(gpiomtd->io_sync);
         if (res)
                 release_mem_region(res->start, resource_size(res));
@@ -226,9 +319,10 @@ static int __devinit gpio_nand_probe(struct platform_device *dev)
         struct gpiomtd *gpiomtd;
         struct nand_chip *this;
         struct resource *res0, *res1;
-        int ret;
+        struct mtd_part_parser_data ppdata = {};
+        int ret = 0;
 
-        if (!dev->dev.platform_data)
+        if (!dev->dev.of_node && !dev->dev.platform_data)
                 return -EINVAL;
 
         res0 = platform_get_resource(dev, IORESOURCE_MEM, 0);
@@ -248,7 +342,7 @@ static int __devinit gpio_nand_probe(struct platform_device *dev)
                 goto err_map;
         }
 
-        res1 = platform_get_resource(dev, IORESOURCE_MEM, 1);
+        res1 = gpio_nand_get_io_sync(dev);
         if (res1) {
                 gpiomtd->io_sync = request_and_remap(res1, 4, "NAND sync", &ret);
                 if (!gpiomtd->io_sync) {
@@ -257,7 +351,9 @@ static int __devinit gpio_nand_probe(struct platform_device *dev)
                 }
         }
 
-        memcpy(&gpiomtd->plat, dev->dev.platform_data, sizeof(gpiomtd->plat));
+        ret = gpio_nand_get_config(&dev->dev, &gpiomtd->plat);
+        if (ret)
+                goto err_nce;
 
         ret = gpio_request(gpiomtd->plat.gpio_nce, "NAND NCE");
         if (ret)
@@ -316,8 +412,12 @@ static int __devinit gpio_nand_probe(struct platform_device *dev)
                 gpiomtd->plat.adjust_parts(&gpiomtd->plat,
                                            gpiomtd->mtd_info.size);
 
-        mtd_device_register(&gpiomtd->mtd_info, gpiomtd->plat.parts,
-                            gpiomtd->plat.num_parts);
+        ppdata.of_node = dev->dev.of_node;
+        ret = mtd_device_parse_register(&gpiomtd->mtd_info, NULL, &ppdata,
+                                        gpiomtd->plat.parts,
+                                        gpiomtd->plat.num_parts);
+        if (ret)
+                goto err_wp;
         platform_set_drvdata(dev, gpiomtd);
 
         return 0;
@@ -352,6 +452,7 @@ static struct platform_driver gpio_nand_driver = {
         .remove         = gpio_nand_remove,
         .driver         = {
                 .name   = "gpio-nand",
+                .of_match_table = gpio_nand_id_table,
         },
 };
 
diff --git a/drivers/mtd/nand/jz4740_nand.c b/drivers/mtd/nand/jz4740_nand.c
index e2664073a89b..ac3b9f255e00 100644
--- a/drivers/mtd/nand/jz4740_nand.c
+++ b/drivers/mtd/nand/jz4740_nand.c
@@ -423,17 +423,7 @@ static struct platform_driver jz_nand_driver = {
         },
 };
 
-static int __init jz_nand_init(void)
-{
-        return platform_driver_register(&jz_nand_driver);
-}
-module_init(jz_nand_init);
-
-static void __exit jz_nand_exit(void)
-{
-        platform_driver_unregister(&jz_nand_driver);
-}
-module_exit(jz_nand_exit);
+module_platform_driver(jz_nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c
index 5ede64706346..c240cf1af961 100644
--- a/drivers/mtd/nand/mpc5121_nfc.c
+++ b/drivers/mtd/nand/mpc5121_nfc.c
@@ -879,19 +879,7 @@ static struct platform_driver mpc5121_nfc_driver = {
         },
 };
 
-static int __init mpc5121_nfc_init(void)
-{
-        return platform_driver_register(&mpc5121_nfc_driver);
-}
-
-module_init(mpc5121_nfc_init);
-
-static void __exit mpc5121_nfc_cleanup(void)
-{
-        platform_driver_unregister(&mpc5121_nfc_driver);
-}
-
-module_exit(mpc5121_nfc_cleanup);
+module_platform_driver(mpc5121_nfc_driver);
 
 MODULE_AUTHOR("Freescale Semiconductor, Inc.");
 MODULE_DESCRIPTION("MPC5121 NAND MTD driver");
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 3ed9c5e4d34e..35b4565050f1 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -3132,8 +3132,8 @@ ident_done:
          * Bad block marker is stored in the last page of each block
          * on Samsung and Hynix MLC devices; stored in first two pages
          * of each block on Micron devices with 2KiB pages and on
-         * SLC Samsung, Hynix, Toshiba and AMD/Spansion. All others scan
-         * only the first page.
+         * SLC Samsung, Hynix, Toshiba, AMD/Spansion, and Macronix.
+         * All others scan only the first page.
          */
         if ((chip->cellinfo & NAND_CI_CELLTYPE_MSK) &&
                         (*maf_id == NAND_MFR_SAMSUNG ||
@@ -3143,7 +3143,8 @@ ident_done:
                                 (*maf_id == NAND_MFR_SAMSUNG ||
                                  *maf_id == NAND_MFR_HYNIX ||
                                  *maf_id == NAND_MFR_TOSHIBA ||
-                                 *maf_id == NAND_MFR_AMD)) ||
+                                 *maf_id == NAND_MFR_AMD ||
+                                 *maf_id == NAND_MFR_MACRONIX)) ||
                         (mtd->writesize == 2048 &&
                          *maf_id == NAND_MFR_MICRON))
                 chip->bbt_options |= NAND_BBT_SCAN2NDPAGE;
diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
index 69148ae3bf58..20a112f591fe 100644
--- a/drivers/mtd/nand/nand_bbt.c
+++ b/drivers/mtd/nand/nand_bbt.c
@@ -201,7 +201,7 @@ static int read_bbt(struct mtd_info *mtd, uint8_t *buf, int page, int num,
                         from += marker_len;
                         marker_len = 0;
                 }
-                res = mtd->read(mtd, from, len, &retlen, buf);
+                res = mtd_read(mtd, from, len, &retlen, buf);
                 if (res < 0) {
                         if (mtd_is_eccerr(res)) {
                                 pr_info("nand_bbt: ECC error in BBT at "
@@ -298,7 +298,7 @@ static int scan_read_raw_data(struct mtd_info *mtd, uint8_t *buf, loff_t offs,
         if (td->options & NAND_BBT_VERSION)
                 len++;
 
-        return mtd->read(mtd, offs, len, &retlen, buf);
+        return mtd_read(mtd, offs, len, &retlen, buf);
 }
 
 /* Scan read raw data from flash */
@@ -317,7 +317,7 @@ static int scan_read_raw_oob(struct mtd_info *mtd, uint8_t *buf, loff_t offs,
                 ops.len = min(len, (size_t)mtd->writesize);
                 ops.oobbuf = buf + ops.len;
 
-                res = mtd->read_oob(mtd, offs, &ops);
+                res = mtd_read_oob(mtd, offs, &ops);
 
                 if (res)
                         return res;
@@ -350,7 +350,7 @@ static int scan_write_bbt(struct mtd_info *mtd, loff_t offs, size_t len,
         ops.oobbuf = oob;
         ops.len = len;
 
-        return mtd->write_oob(mtd, offs, &ops);
+        return mtd_write_oob(mtd, offs, &ops);
 }
 
 static u32 bbt_get_ver_offs(struct mtd_info *mtd, struct nand_bbt_descr *td)
@@ -434,7 +434,7 @@ static int scan_block_fast(struct mtd_info *mtd, struct nand_bbt_descr *bd,
                  * Read the full oob until read_oob is fixed to handle single
                  * byte reads for 16 bit buswidth.
                  */
-                ret = mtd->read_oob(mtd, offs, &ops);
+                ret = mtd_read_oob(mtd, offs, &ops);
                 /* Ignore ECC errors when checking for BBM */
                 if (ret && !mtd_is_bitflip_or_eccerr(ret))
                         return ret;
@@ -756,7 +756,7 @@ static int write_bbt(struct mtd_info *mtd, uint8_t *buf,
                         /* Make it block aligned */
                         to &= ~((loff_t)((1 << this->bbt_erase_shift) - 1));
                         len = 1 << this->bbt_erase_shift;
-                        res = mtd->read(mtd, to, len, &retlen, buf);
+                        res = mtd_read(mtd, to, len, &retlen, buf);
                         if (res < 0) {
                                 if (retlen != len) {
                                         pr_info("nand_bbt: error reading block "
@@ -769,7 +769,7 @@ static int write_bbt(struct mtd_info *mtd, uint8_t *buf,
                         /* Read oob data */
                         ops.ooblen = (len >> this->page_shift) * mtd->oobsize;
                         ops.oobbuf = &buf[len];
-                        res = mtd->read_oob(mtd, to + mtd->writesize, &ops);
+                        res = mtd_read_oob(mtd, to + mtd->writesize, &ops);
                         if (res < 0 || ops.oobretlen != ops.ooblen)
                                 goto outerr;
 
diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
index 00cf1b0d6053..af4fe8ca7b5e 100644
--- a/drivers/mtd/nand/nand_ids.c
+++ b/drivers/mtd/nand/nand_ids.c
@@ -73,11 +73,12 @@ struct nand_flash_dev nand_flash_ids[] = {
 #define LP_OPTIONS (NAND_SAMSUNG_LP_OPTIONS | NAND_NO_READRDY | NAND_NO_AUTOINCR)
 #define LP_OPTIONS16 (LP_OPTIONS | NAND_BUSWIDTH_16)
 
-        /*512 Megabit */
+        /* 512 Megabit */
         {"NAND 64MiB 1,8V 8-bit",       0xA2, 0,  64, 0, LP_OPTIONS},
         {"NAND 64MiB 1,8V 8-bit",       0xA0, 0,  64, 0, LP_OPTIONS},
         {"NAND 64MiB 3,3V 8-bit",       0xF2, 0,  64, 0, LP_OPTIONS},
         {"NAND 64MiB 3,3V 8-bit",       0xD0, 0,  64, 0, LP_OPTIONS},
+        {"NAND 64MiB 3,3V 8-bit",       0xF0, 0,  64, 0, LP_OPTIONS},
         {"NAND 64MiB 1,8V 16-bit",      0xB2, 0,  64, 0, LP_OPTIONS16},
         {"NAND 64MiB 1,8V 16-bit",      0xB0, 0,  64, 0, LP_OPTIONS16},
         {"NAND 64MiB 3,3V 16-bit",      0xC2, 0,  64, 0, LP_OPTIONS16},
@@ -176,6 +177,7 @@ struct nand_manufacturers nand_manuf_ids[] = {
         {NAND_MFR_HYNIX, "Hynix"},
         {NAND_MFR_MICRON, "Micron"},
         {NAND_MFR_AMD, "AMD"},
+        {NAND_MFR_MACRONIX, "Macronix"},
         {0x0, "Unknown"}
 };
 
diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
index 34c03be77301..261f478f8cc3 100644
--- a/drivers/mtd/nand/nandsim.c
+++ b/drivers/mtd/nand/nandsim.c
@@ -737,7 +737,7 @@ static int parse_badblocks(struct nandsim *ns, struct mtd_info *mtd)
                         return -EINVAL;
                 }
                 offset = erase_block_no * ns->geom.secsz;
-                if (mtd->block_markbad(mtd, offset)) {
+                if (mtd_block_markbad(mtd, offset)) {
                         NS_ERR("invalid badblocks.\n");
                         return -EINVAL;
                 }
diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c
index f8aacf48ecdd..ec688548c880 100644
--- a/drivers/mtd/nand/ndfc.c
+++ b/drivers/mtd/nand/ndfc.c
@@ -294,18 +294,7 @@ static struct platform_driver ndfc_driver = {
         .remove = __devexit_p(ndfc_remove),
 };
 
-static int __init ndfc_nand_init(void)
-{
-        return platform_driver_register(&ndfc_driver);
-}
-
-static void __exit ndfc_nand_exit(void)
-{
-        platform_driver_unregister(&ndfc_driver);
-}
-
-module_init(ndfc_nand_init);
-module_exit(ndfc_nand_exit);
+module_platform_driver(ndfc_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Thomas Gleixner <tglx@linutronix.de>");
diff --git a/drivers/mtd/nand/nomadik_nand.c b/drivers/mtd/nand/nomadik_nand.c
index b463ecfb4c1a..a86aa812ca13 100644
--- a/drivers/mtd/nand/nomadik_nand.c
+++ b/drivers/mtd/nand/nomadik_nand.c
@@ -201,7 +201,7 @@ static int nomadik_nand_suspend(struct device *dev)
         struct nomadik_nand_host *host = dev_get_drvdata(dev);
         int ret = 0;
         if (host)
-                ret = host->mtd.suspend(&host->mtd);
+                ret = mtd_suspend(&host->mtd);
         return ret;
 }
 
@@ -209,7 +209,7 @@ static int nomadik_nand_resume(struct device *dev)
 {
         struct nomadik_nand_host *host = dev_get_drvdata(dev);
         if (host)
-                host->mtd.resume(&host->mtd);
+                mtd_resume(&host->mtd);
         return 0;
 }
 
@@ -228,19 +228,7 @@ static struct platform_driver nomadik_nand_driver = {
         },
 };
 
-static int __init nand_nomadik_init(void)
-{
-        pr_info("Nomadik NAND driver\n");
-        return platform_driver_register(&nomadik_nand_driver);
-}
-
-static void __exit nand_nomadik_exit(void)
-{
-        platform_driver_unregister(&nomadik_nand_driver);
-}
-
-module_init(nand_nomadik_init);
-module_exit(nand_nomadik_exit);
+module_platform_driver(nomadik_nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("ST Microelectronics (sachin.verma@st.com)");
diff --git a/drivers/mtd/nand/nuc900_nand.c b/drivers/mtd/nand/nuc900_nand.c
index fa8faedfad6e..8febe46e1105 100644
--- a/drivers/mtd/nand/nuc900_nand.c
+++ b/drivers/mtd/nand/nuc900_nand.c
@@ -364,18 +364,7 @@ static struct platform_driver nuc900_nand_driver = {
         },
 };
 
-static int __init nuc900_nand_init(void)
-{
-        return platform_driver_register(&nuc900_nand_driver);
-}
-
-static void __exit nuc900_nand_exit(void)
-{
-        platform_driver_unregister(&nuc900_nand_driver);
-}
-
-module_init(nuc900_nand_init);
-module_exit(nuc900_nand_exit);
+module_platform_driver(nuc900_nand_driver);
 
 MODULE_AUTHOR("Wan ZongShun <mcuos.com@gmail.com>");
 MODULE_DESCRIPTION("w90p910/NUC9xx nand driver!");
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index f745f00f3167..b3a883e2a22f 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1145,20 +1145,7 @@ static struct platform_driver omap_nand_driver = {
         },
 };
 
-static int __init omap_nand_init(void)
-{
-        pr_info("%s driver initializing\n", DRIVER_NAME);
-
-        return platform_driver_register(&omap_nand_driver);
-}
-
-static void __exit omap_nand_exit(void)
-{
-        platform_driver_unregister(&omap_nand_driver);
-}
-
-module_init(omap_nand_init);
-module_exit(omap_nand_exit);
+module_platform_driver(omap_nand_driver);
 
 MODULE_ALIAS("platform:" DRIVER_NAME);
 MODULE_LICENSE("GPL");
diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
index a97264ececdb..974dbf8251c9 100644
--- a/drivers/mtd/nand/pasemi_nand.c
+++ b/drivers/mtd/nand/pasemi_nand.c
@@ -230,17 +230,7 @@ static struct platform_driver pasemi_nand_driver =
         .remove         = pasemi_nand_remove,
 };
 
-static int __init pasemi_nand_init(void)
-{
-        return platform_driver_register(&pasemi_nand_driver);
-}
-module_init(pasemi_nand_init);
-
-static void __exit pasemi_nand_exit(void)
-{
-        platform_driver_unregister(&pasemi_nand_driver);
-}
-module_exit(pasemi_nand_exit);
+module_platform_driver(pasemi_nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Egor Martovetsky <egor@pasemi.com>");
diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c
index ea8e1234e0e2..7f2da6953357 100644
--- a/drivers/mtd/nand/plat_nand.c
+++ b/drivers/mtd/nand/plat_nand.c
@@ -148,18 +148,7 @@ static struct platform_driver plat_nand_driver = {
         },
 };
 
-static int __init plat_nand_init(void)
-{
-        return platform_driver_register(&plat_nand_driver);
-}
-
-static void __exit plat_nand_exit(void)
-{
-        platform_driver_unregister(&plat_nand_driver);
-}
-
-module_init(plat_nand_init);
-module_exit(plat_nand_exit);
+module_platform_driver(plat_nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Vitaly Wool");
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index 9eb7f879969e..8544d6bf50a0 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -1258,7 +1258,7 @@ static int pxa3xx_nand_suspend(struct platform_device *pdev, pm_message_t state)
 
         for (cs = 0; cs < pdata->num_cs; cs++) {
                 mtd = info->host[cs]->mtd;
-                mtd->suspend(mtd);
+                mtd_suspend(mtd);
         }
 
         return 0;
@@ -1291,7 +1291,7 @@ static int pxa3xx_nand_resume(struct platform_device *pdev)
         nand_writel(info, NDSR, NDSR_MASK);
         for (cs = 0; cs < pdata->num_cs; cs++) {
                 mtd = info->host[cs]->mtd;
-                mtd->resume(mtd);
+                mtd_resume(mtd);
         }
 
         return 0;
@@ -1311,17 +1311,7 @@ static struct platform_driver pxa3xx_nand_driver = {
         .resume         = pxa3xx_nand_resume,
 };
 
-static int __init pxa3xx_nand_init(void)
-{
-        return platform_driver_register(&pxa3xx_nand_driver);
-}
-module_init(pxa3xx_nand_init);
-
-static void __exit pxa3xx_nand_exit(void)
-{
-        platform_driver_unregister(&pxa3xx_nand_driver);
-}
-module_exit(pxa3xx_nand_exit);
+module_platform_driver(pxa3xx_nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("PXA3xx NAND controller driver");
diff --git a/drivers/mtd/nand/sharpsl.c b/drivers/mtd/nand/sharpsl.c
index 619d2a504788..b175c0fd8b93 100644
--- a/drivers/mtd/nand/sharpsl.c
+++ b/drivers/mtd/nand/sharpsl.c
@@ -230,17 +230,7 @@ static struct platform_driver sharpsl_nand_driver = {
         .remove         = __devexit_p(sharpsl_nand_remove),
 };
 
-static int __init sharpsl_nand_init(void)
-{
-        return platform_driver_register(&sharpsl_nand_driver);
-}
-module_init(sharpsl_nand_init);
-
-static void __exit sharpsl_nand_exit(void)
-{
-        platform_driver_unregister(&sharpsl_nand_driver);
-}
-module_exit(sharpsl_nand_exit);
+module_platform_driver(sharpsl_nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Richard Purdie <rpurdie@rpsys.net>");
diff --git a/drivers/mtd/nand/sm_common.c b/drivers/mtd/nand/sm_common.c
index 32ae5af7444f..774c3c266713 100644
--- a/drivers/mtd/nand/sm_common.c
+++ b/drivers/mtd/nand/sm_common.c
@@ -55,7 +55,7 @@ static int sm_block_markbad(struct mtd_info *mtd, loff_t ofs)
         ops.datbuf = NULL;
 
 
-        ret = mtd->write_oob(mtd, ofs, &ops);
+        ret = mtd_write_oob(mtd, ofs, &ops);
         if (ret < 0 || ops.oobretlen != SM_OOB_SIZE) {
                 printk(KERN_NOTICE
                         "sm_common: can't mark sector at %i as bad\n",
diff --git a/drivers/mtd/nand/socrates_nand.c b/drivers/mtd/nand/socrates_nand.c
index 0fb24f9c2327..e02b08bcf0c0 100644
--- a/drivers/mtd/nand/socrates_nand.c
+++ b/drivers/mtd/nand/socrates_nand.c
@@ -273,18 +273,7 @@ static struct platform_driver socrates_nand_driver = {
         .remove         = __devexit_p(socrates_nand_remove),
 };
 
-static int __init socrates_nand_init(void)
-{
-        return platform_driver_register(&socrates_nand_driver);
-}
-
-static void __exit socrates_nand_exit(void)
-{
-        platform_driver_unregister(&socrates_nand_driver);
-}
-
-module_init(socrates_nand_init);
-module_exit(socrates_nand_exit);
+module_platform_driver(socrates_nand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Ilya Yanok");
diff --git a/drivers/mtd/nand/tmio_nand.c b/drivers/mtd/nand/tmio_nand.c
index beebd95f7690..6caa0cd9d6a7 100644
--- a/drivers/mtd/nand/tmio_nand.c
+++ b/drivers/mtd/nand/tmio_nand.c
@@ -533,18 +533,7 @@ static struct platform_driver tmio_driver = {
         .resume         = tmio_resume,
 };
 
-static int __init tmio_init(void)
-{
-        return platform_driver_register(&tmio_driver);
-}
-
-static void __exit tmio_exit(void)
-{
-        platform_driver_unregister(&tmio_driver);
-}
-
-module_init(tmio_init);
-module_exit(tmio_exit);
+module_platform_driver(tmio_driver);
 
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Ian Molton, Dirk Opfer, Chris Humbert, Dmitry Baryshkov");
diff --git a/drivers/mtd/nand/txx9ndfmc.c b/drivers/mtd/nand/txx9ndfmc.c
index ace46fdaef58..c7c4f1d11c77 100644
--- a/drivers/mtd/nand/txx9ndfmc.c
+++ b/drivers/mtd/nand/txx9ndfmc.c
@@ -298,11 +298,7 @@ static int __init txx9ndfmc_probe(struct platform_device *dev)
         drvdata = devm_kzalloc(&dev->dev, sizeof(*drvdata), GFP_KERNEL);
         if (!drvdata)
                 return -ENOMEM;
-        if (!devm_request_mem_region(&dev->dev, res->start,
-                                     resource_size(res), dev_name(&dev->dev)))
-                return -EBUSY;
-        drvdata->base = devm_ioremap(&dev->dev, res->start,
-                                     resource_size(res));
+        drvdata->base = devm_request_and_ioremap(&dev->dev, res);
         if (!drvdata->base)
                 return -EBUSY;
 
diff --git a/drivers/mtd/nftlcore.c b/drivers/mtd/nftlcore.c
index cda77b562ad4..a75382aff5f6 100644
--- a/drivers/mtd/nftlcore.c
+++ b/drivers/mtd/nftlcore.c
@@ -56,7 +56,7 @@ static void nftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
         if (memcmp(mtd->name, "DiskOnChip", 10))
                 return;
 
-        if (!mtd->block_isbad) {
+        if (!mtd_can_have_bb(mtd)) {
                 printk(KERN_ERR
 "NFTL no longer supports the old DiskOnChip drivers loaded via docprobe.\n"
 "Please use the new diskonchip driver under the NAND subsystem.\n");
@@ -153,7 +153,7 @@ int nftl_read_oob(struct mtd_info *mtd, loff_t offs, size_t len,
         ops.oobbuf = buf;
         ops.datbuf = NULL;
 
-        res = mtd->read_oob(mtd, offs & ~mask, &ops);
+        res = mtd_read_oob(mtd, offs & ~mask, &ops);
         *retlen = ops.oobretlen;
         return res;
 }
@@ -174,7 +174,7 @@ int nftl_write_oob(struct mtd_info *mtd, loff_t offs, size_t len,
         ops.oobbuf = buf;
         ops.datbuf = NULL;
 
-        res = mtd->write_oob(mtd, offs & ~mask, &ops);
+        res = mtd_write_oob(mtd, offs & ~mask, &ops);
         *retlen = ops.oobretlen;
         return res;
 }
@@ -198,7 +198,7 @@ static int nftl_write(struct mtd_info *mtd, loff_t offs, size_t len,
         ops.datbuf = buf;
         ops.len = len;
 
-        res = mtd->write_oob(mtd, offs & ~mask, &ops);
+        res = mtd_write_oob(mtd, offs & ~mask, &ops);
         *retlen = ops.retlen;
         return res;
 }
@@ -423,12 +423,17 @@ static u16 NFTL_foldchain (struct NFTLrecord *nftl, unsigned thisVUC, unsigned p
                 if (BlockMap[block] == BLOCK_NIL)
                         continue;
 
-                ret = mtd->read(mtd, (nftl->EraseSize * BlockMap[block]) + (block * 512),
-                                512, &retlen, movebuf);
+                ret = mtd_read(mtd,
+                               (nftl->EraseSize * BlockMap[block]) + (block * 512),
+                               512,
+                               &retlen,
+                               movebuf);
                 if (ret < 0 && !mtd_is_bitflip(ret)) {
-                        ret = mtd->read(mtd, (nftl->EraseSize * BlockMap[block])
-                                        + (block * 512), 512, &retlen,
-                                        movebuf);
+                        ret = mtd_read(mtd,
+                                       (nftl->EraseSize * BlockMap[block]) + (block * 512),
+                                       512,
+                                       &retlen,
+                                       movebuf);
                         if (ret != -EIO)
                                 printk("Error went away on retry.\n");
                 }
@@ -771,7 +776,7 @@ static int nftl_readblock(struct mtd_blktrans_dev *mbd, unsigned long block,
         } else {
                 loff_t ptr = (lastgoodEUN * nftl->EraseSize) + blockofs;
                 size_t retlen;
-                int res = mtd->read(mtd, ptr, 512, &retlen, buffer);
+                int res = mtd_read(mtd, ptr, 512, &retlen, buffer);
 
                 if (res < 0 && !mtd_is_bitflip(res))
                         return -EIO;
diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
index ac4092591aea..51b9d6af307f 100644
--- a/drivers/mtd/nftlmount.c
+++ b/drivers/mtd/nftlmount.c
@@ -63,8 +63,8 @@ static int find_boot_record(struct NFTLrecord *nftl)
 
                 /* Check for ANAND header first. Then can whinge if it's found but later
                    checks fail */
-                ret = mtd->read(mtd, block * nftl->EraseSize, SECTORSIZE,
-                                &retlen, buf);
+                ret = mtd_read(mtd, block * nftl->EraseSize, SECTORSIZE,
+                               &retlen, buf);
                 /* We ignore ret in case the ECC of the MediaHeader is invalid
                    (which is apparently acceptable) */
                 if (retlen != SECTORSIZE) {
@@ -242,7 +242,8 @@ The new DiskOnChip driver already scanned the bad block table.  Just query it.
                         if (buf[i & (SECTORSIZE - 1)] != 0xff)
                                 nftl->ReplUnitTable[i] = BLOCK_RESERVED;
 #endif
-                        if (nftl->mbd.mtd->block_isbad(nftl->mbd.mtd, i * nftl->EraseSize))
+                        if (mtd_block_isbad(nftl->mbd.mtd,
+                                            i * nftl->EraseSize))
                                 nftl->ReplUnitTable[i] = BLOCK_RESERVED;
                 }
 
@@ -274,7 +275,7 @@ static int check_free_sectors(struct NFTLrecord *nftl, unsigned int address, int
         int i;
 
         for (i = 0; i < len; i += SECTORSIZE) {
-                if (mtd->read(mtd, address, SECTORSIZE, &retlen, buf))
+                if (mtd_read(mtd, address, SECTORSIZE, &retlen, buf))
                         return -1;
                 if (memcmpb(buf, 0xff, SECTORSIZE) != 0)
                         return -1;
@@ -326,7 +327,7 @@ int NFTL_formatblock(struct NFTLrecord *nftl, int block)
         instr->mtd = nftl->mbd.mtd;
         instr->addr = block * nftl->EraseSize;
         instr->len = nftl->EraseSize;
-        mtd->erase(mtd, instr);
+        mtd_erase(mtd, instr);
 
         if (instr->state == MTD_ERASE_FAILED) {
                 printk("Error while formatting block %d\n", block);
@@ -355,7 +356,7 @@ int NFTL_formatblock(struct NFTLrecord *nftl, int block)
 fail:
         /* could not format, update the bad block table (caller is responsible
            for setting the ReplUnitTable to BLOCK_RESERVED on failure) */
-        nftl->mbd.mtd->block_markbad(nftl->mbd.mtd, instr->addr);
+        mtd_block_markbad(nftl->mbd.mtd, instr->addr);
         return -1;
 }
 
diff --git a/drivers/mtd/onenand/generic.c b/drivers/mtd/onenand/generic.c
index 7813095264a5..0ccd5bff2544 100644
--- a/drivers/mtd/onenand/generic.c
+++ b/drivers/mtd/onenand/generic.c
@@ -115,21 +115,9 @@ static struct platform_driver generic_onenand_driver = {
         .remove         = __devexit_p(generic_onenand_remove),
 };
 
-MODULE_ALIAS("platform:" DRIVER_NAME);
-
-static int __init generic_onenand_init(void)
-{
-        return platform_driver_register(&generic_onenand_driver);
-}
-
-static void __exit generic_onenand_exit(void)
-{
-        platform_driver_unregister(&generic_onenand_driver);
-}
-
-module_init(generic_onenand_init);
-module_exit(generic_onenand_exit);
+module_platform_driver(generic_onenand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Kyungmin Park <kyungmin.park@samsung.com>");
 MODULE_DESCRIPTION("Glue layer for OneNAND flash on generic boards");
+MODULE_ALIAS("platform:" DRIVER_NAME);
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index a8394730b4b6..a061bc163da2 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -2633,7 +2633,6 @@ static int onenand_default_block_markbad(struct mtd_info *mtd, loff_t ofs)
  */
 static int onenand_block_markbad(struct mtd_info *mtd, loff_t ofs)
 {
-        struct onenand_chip *this = mtd->priv;
         int ret;
 
         ret = onenand_block_isbad(mtd, ofs);
@@ -2645,7 +2644,7 @@ static int onenand_block_markbad(struct mtd_info *mtd, loff_t ofs)
         }
 
         onenand_get_device(mtd, FL_WRITING);
-        ret = this->block_markbad(mtd, ofs);
+        ret = mtd_block_markbad(mtd, ofs);
         onenand_release_device(mtd);
         return ret;
 }
diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c
index 5474547eafc2..fa1ee43f735b 100644
--- a/drivers/mtd/onenand/samsung.c
+++ b/drivers/mtd/onenand/samsung.c
@@ -1133,18 +1133,7 @@ static struct platform_driver s3c_onenand_driver = {
         .remove         = __devexit_p(s3c_onenand_remove),
 };
 
-static int __init s3c_onenand_init(void)
-{
-        return platform_driver_register(&s3c_onenand_driver);
-}
-
-static void __exit s3c_onenand_exit(void)
-{
-        platform_driver_unregister(&s3c_onenand_driver);
-}
-
-module_init(s3c_onenand_init);
-module_exit(s3c_onenand_exit);
+module_platform_driver(s3c_onenand_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Kyungmin Park <kyungmin.park@samsung.com>");
diff --git a/drivers/mtd/redboot.c b/drivers/mtd/redboot.c
index e366b1d84ead..48970c14beff 100644
--- a/drivers/mtd/redboot.c
+++ b/drivers/mtd/redboot.c
@@ -78,8 +78,8 @@ static int parse_redboot_partitions(struct mtd_info *master,
 
         if ( directory < 0 ) {
                 offset = master->size + directory * master->erasesize;
-                while (master->block_isbad && 
-                       master->block_isbad(master, offset)) {
+                while (mtd_can_have_bb(master) &&
+                       mtd_block_isbad(master, offset)) {
                         if (!offset) {
                         nogood:
                                 printk(KERN_NOTICE "Failed to find a non-bad block to check for RedBoot partition table\n");
@@ -89,8 +89,8 @@ static int parse_redboot_partitions(struct mtd_info *master,
                 }
         } else {
                 offset = directory * master->erasesize;
-                while (master->block_isbad && 
-                       master->block_isbad(master, offset)) {
+                while (mtd_can_have_bb(master) &&
+                       mtd_block_isbad(master, offset)) {
                         offset += master->erasesize;
                         if (offset == master->size)
                                 goto nogood;
@@ -104,8 +104,8 @@ static int parse_redboot_partitions(struct mtd_info *master,
         printk(KERN_NOTICE "Searching for RedBoot partition table in %s at offset 0x%lx\n",
                master->name, offset);
 
-        ret = master->read(master, offset,
-                           master->erasesize, &retlen, (void *)buf);
+        ret = mtd_read(master, offset, master->erasesize, &retlen,
+                       (void *)buf);
 
         if (ret)
                 goto out;
diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c
index 73ae217a4252..233b946e5d66 100644
--- a/drivers/mtd/rfd_ftl.c
+++ b/drivers/mtd/rfd_ftl.c
@@ -200,9 +200,9 @@ static int scan_header(struct partition *part)
                 part->sector_map[i] = -1;
 
         for (i=0, blocks_found=0; i<part->total_blocks; i++) {
-                rc = part->mbd.mtd->read(part->mbd.mtd,
-                                i * part->block_size, part->header_size,
-                                &retlen, (u_char*)part->header_cache);
+                rc = mtd_read(part->mbd.mtd, i * part->block_size,
+                              part->header_size, &retlen,
+                              (u_char *)part->header_cache);
 
                 if (!rc && retlen != part->header_size)
                         rc = -EIO;
@@ -250,8 +250,8 @@ static int rfd_ftl_readsect(struct mtd_blktrans_dev *dev, u_long sector, char *b
 
         addr = part->sector_map[sector];
         if (addr != -1) {
-                rc = part->mbd.mtd->read(part->mbd.mtd, addr, SECTOR_SIZE,
-                                                &retlen, (u_char*)buf);
+                rc = mtd_read(part->mbd.mtd, addr, SECTOR_SIZE, &retlen,
+                              (u_char *)buf);
                 if (!rc && retlen != SECTOR_SIZE)
                         rc = -EIO;
 
@@ -304,9 +304,8 @@ static void erase_callback(struct erase_info *erase)
         part->blocks[i].used_sectors = 0;
         part->blocks[i].erases++;
 
-        rc = part->mbd.mtd->write(part->mbd.mtd,
-                part->blocks[i].offset, sizeof(magic), &retlen,
-                (u_char*)&magic);
+        rc = mtd_write(part->mbd.mtd, part->blocks[i].offset, sizeof(magic),
+                       &retlen, (u_char *)&magic);
 
         if (!rc && retlen != sizeof(magic))
                 rc = -EIO;
@@ -342,7 +341,7 @@ static int erase_block(struct partition *part, int block)
         part->blocks[block].state = BLOCK_ERASING;
         part->blocks[block].free_sectors = 0;
 
-        rc = part->mbd.mtd->erase(part->mbd.mtd, erase);
+        rc = mtd_erase(part->mbd.mtd, erase);
 
         if (rc) {
                 printk(KERN_ERR PREFIX "erase of region %llx,%llx on '%s' "
@@ -372,9 +371,8 @@ static int move_block_contents(struct partition *part, int block_no, u_long *old
         if (!map)
                 goto err2;
 
-        rc = part->mbd.mtd->read(part->mbd.mtd,
-                part->blocks[block_no].offset, part->header_size,
-                &retlen, (u_char*)map);
+        rc = mtd_read(part->mbd.mtd, part->blocks[block_no].offset,
+                      part->header_size, &retlen, (u_char *)map);
 
         if (!rc && retlen != part->header_size)
                 rc = -EIO;
@@ -413,8 +411,8 @@ static int move_block_contents(struct partition *part, int block_no, u_long *old
                         }
                         continue;
                 }
-                rc = part->mbd.mtd->read(part->mbd.mtd, addr,
-                        SECTOR_SIZE, &retlen, sector_data);
+                rc = mtd_read(part->mbd.mtd, addr, SECTOR_SIZE, &retlen,
+                              sector_data);
 
                 if (!rc && retlen != SECTOR_SIZE)
                         rc = -EIO;
@@ -450,8 +448,7 @@ static int reclaim_block(struct partition *part, u_long *old_sector)
         int rc;
 
         /* we have a race if sync doesn't exist */
-        if (part->mbd.mtd->sync)
-                part->mbd.mtd->sync(part->mbd.mtd);
+        mtd_sync(part->mbd.mtd);
 
         score = 0x7fffffff; /* MAX_INT */
         best_block = -1;
@@ -563,8 +560,9 @@ static int find_writable_block(struct partition *part, u_long *old_sector)
                 }
         }
 
-        rc = part->mbd.mtd->read(part->mbd.mtd, part->blocks[block].offset,
-                part->header_size, &retlen, (u_char*)part->header_cache);
+        rc = mtd_read(part->mbd.mtd, part->blocks[block].offset,
+                      part->header_size, &retlen,
+                      (u_char *)part->header_cache);
 
         if (!rc && retlen != part->header_size)
                 rc = -EIO;
@@ -595,8 +593,8 @@ static int mark_sector_deleted(struct partition *part, u_long old_addr)
 
         addr = part->blocks[block].offset +
                         (HEADER_MAP_OFFSET + offset) * sizeof(u16);
-        rc = part->mbd.mtd->write(part->mbd.mtd, addr,
-                sizeof(del), &retlen, (u_char*)&del);
+        rc = mtd_write(part->mbd.mtd, addr, sizeof(del), &retlen,
+                       (u_char *)&del);
 
         if (!rc && retlen != sizeof(del))
                 rc = -EIO;
@@ -668,8 +666,8 @@ static int do_writesect(struct mtd_blktrans_dev *dev, u_long sector, char *buf,
 
         addr = (i + part->header_sectors_per_block) * SECTOR_SIZE +
                 block->offset;
-        rc = part->mbd.mtd->write(part->mbd.mtd,
-                addr, SECTOR_SIZE, &retlen, (u_char*)buf);
+        rc = mtd_write(part->mbd.mtd, addr, SECTOR_SIZE, &retlen,
+                       (u_char *)buf);
 
         if (!rc && retlen != SECTOR_SIZE)
                 rc = -EIO;
@@ -688,8 +686,8 @@ static int do_writesect(struct mtd_blktrans_dev *dev, u_long sector, char *buf,
         part->header_cache[i + HEADER_MAP_OFFSET] = entry;
 
         addr = block->offset + (HEADER_MAP_OFFSET + i) * sizeof(u16);
-        rc = part->mbd.mtd->write(part->mbd.mtd, addr,
-                        sizeof(entry), &retlen, (u_char*)&entry);
+        rc = mtd_write(part->mbd.mtd, addr, sizeof(entry), &retlen,
+                       (u_char *)&entry);
 
         if (!rc && retlen != sizeof(entry))
                 rc = -EIO;
diff --git a/drivers/mtd/sm_ftl.c b/drivers/mtd/sm_ftl.c
index fddb714e323c..072ed5970e2f 100644
--- a/drivers/mtd/sm_ftl.c
+++ b/drivers/mtd/sm_ftl.c
@@ -25,7 +25,7 @@
 struct workqueue_struct *cache_flush_workqueue;
 
 static int cache_timeout = 1000;
-module_param(cache_timeout, bool, S_IRUGO);
+module_param(cache_timeout, int, S_IRUGO);
 MODULE_PARM_DESC(cache_timeout,
         "Timeout (in ms) for cache flush (1000 ms default");
 
@@ -278,7 +278,7 @@ again:
 
         /* Unfortunately, oob read will _always_ succeed,
                 despite card removal..... */
-        ret = mtd->read_oob(mtd, sm_mkoffset(ftl, zone, block, boffset), &ops);
+        ret = mtd_read_oob(mtd, sm_mkoffset(ftl, zone, block, boffset), &ops);
 
         /* Test for unknown errors */
         if (ret != 0 && !mtd_is_bitflip_or_eccerr(ret)) {
@@ -343,7 +343,7 @@ static int sm_write_sector(struct sm_ftl *ftl,
         ops.ooblen = SM_OOB_SIZE;
         ops.oobbuf = (void *)oob;
 
-        ret = mtd->write_oob(mtd, sm_mkoffset(ftl, zone, block, boffset), &ops);
+        ret = mtd_write_oob(mtd, sm_mkoffset(ftl, zone, block, boffset), &ops);
 
         /* Now we assume that hardware will catch write bitflip errors */
         /* If you are paranoid, use CONFIG_MTD_NAND_VERIFY_WRITE */
@@ -479,7 +479,7 @@ static int sm_erase_block(struct sm_ftl *ftl, int zone_num, uint16_t block,
                 return -EIO;
         }
 
-        if (mtd->erase(mtd, &erase)) {
+        if (mtd_erase(mtd, &erase)) {
                 sm_printk("erase of block %d in zone %d failed",
                                                         block, zone_num);
                 goto error;
@@ -645,8 +645,8 @@ int sm_get_media_info(struct sm_ftl *ftl, struct mtd_info *mtd)
         if (!ftl->smallpagenand && mtd->oobsize < SM_OOB_SIZE)
                 return -ENODEV;
 
-        /* We use these functions for IO */
-        if (!mtd->read_oob || !mtd->write_oob)
+        /* We use OOB */
+        if (!mtd_has_oob(mtd))
                 return -ENODEV;
 
         /* Find geometry information */
diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
index 976e3d28b962..ab2a52a039c3 100644
--- a/drivers/mtd/ssfdc.c
+++ b/drivers/mtd/ssfdc.c
@@ -122,9 +122,9 @@ static int get_valid_cis_sector(struct mtd_info *mtd)
          * is not SSFDC formatted
          */
         for (k = 0, offset = 0; k < 4; k++, offset += mtd->erasesize) {
-                if (!mtd->block_isbad(mtd, offset)) {
-                        ret = mtd->read(mtd, offset, SECTOR_SIZE, &retlen,
-                                sect_buf);
+                if (mtd_block_isbad(mtd, offset)) {
+                        ret = mtd_read(mtd, offset, SECTOR_SIZE, &retlen,
+                                       sect_buf);
 
                         /* CIS pattern match on the sector buffer */
                         if (ret < 0 || retlen != SECTOR_SIZE) {
@@ -156,7 +156,7 @@ static int read_physical_sector(struct mtd_info *mtd, uint8_t *sect_buf,
         size_t retlen;
         loff_t offset = (loff_t)sect_no << SECTOR_SHIFT;
 
-        ret = mtd->read(mtd, offset, SECTOR_SIZE, &retlen, sect_buf);
+        ret = mtd_read(mtd, offset, SECTOR_SIZE, &retlen, sect_buf);
         if (ret < 0 || retlen != SECTOR_SIZE)
                 return -1;
 
@@ -175,7 +175,7 @@ static int read_raw_oob(struct mtd_info *mtd, loff_t offs, uint8_t *buf)
         ops.oobbuf = buf;
         ops.datbuf = NULL;
 
-        ret = mtd->read_oob(mtd, offs, &ops);
+        ret = mtd_read_oob(mtd, offs, &ops);
         if (ret < 0 || ops.oobretlen != OOB_SIZE)
                 return -1;
 
@@ -255,7 +255,7 @@ static int build_logical_block_map(struct ssfdcr_record *ssfdc)
         for (phys_block = ssfdc->cis_block + 1; phys_block < ssfdc->map_len;
                         phys_block++) {
                 offset = (unsigned long)phys_block * ssfdc->erase_size;
-                if (mtd->block_isbad(mtd, offset))
+                if (mtd_block_isbad(mtd, offset))
                         continue;       /* skip bad blocks */
 
                 ret = read_raw_oob(mtd, offset, oob_buf);
diff --git a/drivers/mtd/tests/mtd_oobtest.c b/drivers/mtd/tests/mtd_oobtest.c
index 933f7e5f32d3..ed9b62827f1b 100644
--- a/drivers/mtd/tests/mtd_oobtest.c
+++ b/drivers/mtd/tests/mtd_oobtest.c
@@ -78,7 +78,7 @@ static int erase_eraseblock(int ebnum)
         ei.addr = addr;
         ei.len  = mtd->erasesize;
 
-        err = mtd->erase(mtd, &ei);
+        err = mtd_erase(mtd, &ei);
         if (err) {
                 printk(PRINT_PREF "error %d while erasing EB %d\n", err, ebnum);
                 return err;
@@ -139,7 +139,7 @@ static int write_eraseblock(int ebnum)
                 ops.ooboffs   = use_offset;
                 ops.datbuf    = NULL;
                 ops.oobbuf    = writebuf;
-                err = mtd->write_oob(mtd, addr, &ops);
+                err = mtd_write_oob(mtd, addr, &ops);
                 if (err || ops.oobretlen != use_len) {
                         printk(PRINT_PREF "error: writeoob failed at %#llx\n",
                                (long long)addr);
@@ -192,7 +192,7 @@ static int verify_eraseblock(int ebnum)
                 ops.ooboffs   = use_offset;
                 ops.datbuf    = NULL;
                 ops.oobbuf    = readbuf;
-                err = mtd->read_oob(mtd, addr, &ops);
+                err = mtd_read_oob(mtd, addr, &ops);
                 if (err || ops.oobretlen != use_len) {
                         printk(PRINT_PREF "error: readoob failed at %#llx\n",
                                (long long)addr);
@@ -219,7 +219,7 @@ static int verify_eraseblock(int ebnum)
                         ops.ooboffs   = 0;
                         ops.datbuf    = NULL;
                         ops.oobbuf    = readbuf;
-                        err = mtd->read_oob(mtd, addr, &ops);
+                        err = mtd_read_oob(mtd, addr, &ops);
                         if (err || ops.oobretlen != mtd->ecclayout->oobavail) {
                                 printk(PRINT_PREF "error: readoob failed at "
                                        "%#llx\n", (long long)addr);
@@ -284,7 +284,7 @@ static int verify_eraseblock_in_one_go(int ebnum)
         ops.ooboffs   = 0;
         ops.datbuf    = NULL;
         ops.oobbuf    = readbuf;
-        err = mtd->read_oob(mtd, addr, &ops);
+        err = mtd_read_oob(mtd, addr, &ops);
         if (err || ops.oobretlen != len) {
                 printk(PRINT_PREF "error: readoob failed at %#llx\n",
                        (long long)addr);
@@ -329,7 +329,7 @@ static int is_block_bad(int ebnum)
         int ret;
         loff_t addr = ebnum * mtd->erasesize;
 
-        ret = mtd->block_isbad(mtd, addr);
+        ret = mtd_block_isbad(mtd, addr);
         if (ret)
                 printk(PRINT_PREF "block %d is bad\n", ebnum);
         return ret;
@@ -524,7 +524,7 @@ static int __init mtd_oobtest_init(void)
         ops.oobbuf    = writebuf;
         printk(PRINT_PREF "attempting to start write past end of OOB\n");
         printk(PRINT_PREF "an error is expected...\n");
-        err = mtd->write_oob(mtd, addr0, &ops);
+        err = mtd_write_oob(mtd, addr0, &ops);
         if (err) {
                 printk(PRINT_PREF "error occurred as expected\n");
                 err = 0;
@@ -544,7 +544,7 @@ static int __init mtd_oobtest_init(void)
         ops.oobbuf    = readbuf;
         printk(PRINT_PREF "attempting to start read past end of OOB\n");
         printk(PRINT_PREF "an error is expected...\n");
-        err = mtd->read_oob(mtd, addr0, &ops);
+        err = mtd_read_oob(mtd, addr0, &ops);
         if (err) {
                 printk(PRINT_PREF "error occurred as expected\n");
                 err = 0;
@@ -568,7 +568,7 @@ static int __init mtd_oobtest_init(void)
                 ops.oobbuf    = writebuf;
                 printk(PRINT_PREF "attempting to write past end of device\n");
                 printk(PRINT_PREF "an error is expected...\n");
-                err = mtd->write_oob(mtd, mtd->size - mtd->writesize, &ops);
+                err = mtd_write_oob(mtd, mtd->size - mtd->writesize, &ops);
                 if (err) {
                         printk(PRINT_PREF "error occurred as expected\n");
                         err = 0;
@@ -588,7 +588,7 @@ static int __init mtd_oobtest_init(void)
                 ops.oobbuf    = readbuf;
                 printk(PRINT_PREF "attempting to read past end of device\n");
                 printk(PRINT_PREF "an error is expected...\n");
-                err = mtd->read_oob(mtd, mtd->size - mtd->writesize, &ops);
+                err = mtd_read_oob(mtd, mtd->size - mtd->writesize, &ops);
                 if (err) {
                         printk(PRINT_PREF "error occurred as expected\n");
                         err = 0;
@@ -612,7 +612,7 @@ static int __init mtd_oobtest_init(void)
                 ops.oobbuf    = writebuf;
                 printk(PRINT_PREF "attempting to write past end of device\n");
                 printk(PRINT_PREF "an error is expected...\n");
-                err = mtd->write_oob(mtd, mtd->size - mtd->writesize, &ops);
+                err = mtd_write_oob(mtd, mtd->size - mtd->writesize, &ops);
                 if (err) {
                         printk(PRINT_PREF "error occurred as expected\n");
                         err = 0;
@@ -632,7 +632,7 @@ static int __init mtd_oobtest_init(void)
                 ops.oobbuf    = readbuf;
                 printk(PRINT_PREF "attempting to read past end of device\n");
                 printk(PRINT_PREF "an error is expected...\n");
-                err = mtd->read_oob(mtd, mtd->size - mtd->writesize, &ops);
+                err = mtd_read_oob(mtd, mtd->size - mtd->writesize, &ops);
                 if (err) {
                         printk(PRINT_PREF "error occurred as expected\n");
                         err = 0;
@@ -670,7 +670,7 @@ static int __init mtd_oobtest_init(void)
                         ops.ooboffs   = 0;
                         ops.datbuf    = NULL;
                         ops.oobbuf    = writebuf;
-                        err = mtd->write_oob(mtd, addr, &ops);
+                        err = mtd_write_oob(mtd, addr, &ops);
                         if (err)
                                 goto out;
                         if (i % 256 == 0)
@@ -698,7 +698,7 @@ static int __init mtd_oobtest_init(void)
                 ops.ooboffs   = 0;
                 ops.datbuf    = NULL;
                 ops.oobbuf    = readbuf;
-                err = mtd->read_oob(mtd, addr, &ops);
+                err = mtd_read_oob(mtd, addr, &ops);
                 if (err)
                         goto out;
                 if (memcmp(readbuf, writebuf, mtd->ecclayout->oobavail * 2)) {
diff --git a/drivers/mtd/tests/mtd_pagetest.c b/drivers/mtd/tests/mtd_pagetest.c
index afafb6935fd0..252ddb092fb2 100644
--- a/drivers/mtd/tests/mtd_pagetest.c
+++ b/drivers/mtd/tests/mtd_pagetest.c
@@ -77,7 +77,7 @@ static int erase_eraseblock(int ebnum)
         ei.addr = addr;
         ei.len  = mtd->erasesize;
 
-        err = mtd->erase(mtd, &ei);
+        err = mtd_erase(mtd, &ei);
         if (err) {
                 printk(PRINT_PREF "error %d while erasing EB %d\n", err, ebnum);
                 return err;
@@ -95,12 +95,12 @@ static int erase_eraseblock(int ebnum)
 static int write_eraseblock(int ebnum)
 {
         int err = 0;
-        size_t written = 0;
+        size_t written;
         loff_t addr = ebnum * mtd->erasesize;
 
         set_random_data(writebuf, mtd->erasesize);
         cond_resched();
-        err = mtd->write(mtd, addr, mtd->erasesize, &written, writebuf);
+        err = mtd_write(mtd, addr, mtd->erasesize, &written, writebuf);
         if (err || written != mtd->erasesize)
                 printk(PRINT_PREF "error: write failed at %#llx\n",
                        (long long)addr);
@@ -111,7 +111,7 @@ static int write_eraseblock(int ebnum)
 static int verify_eraseblock(int ebnum)
 {
         uint32_t j;
-        size_t read = 0;
+        size_t read;
         int err = 0, i;
         loff_t addr0, addrn;
         loff_t addr = ebnum * mtd->erasesize;
@@ -127,7 +127,7 @@ static int verify_eraseblock(int ebnum)
         set_random_data(writebuf, mtd->erasesize);
         for (j = 0; j < pgcnt - 1; ++j, addr += pgsize) {
                 /* Do a read to set the internal dataRAMs to different data */
-                err = mtd->read(mtd, addr0, bufsize, &read, twopages);
+                err = mtd_read(mtd, addr0, bufsize, &read, twopages);
                 if (mtd_is_bitflip(err))
                         err = 0;
                 if (err || read != bufsize) {
@@ -135,7 +135,7 @@ static int verify_eraseblock(int ebnum)
                                (long long)addr0);
                         return err;
                 }
-                err = mtd->read(mtd, addrn - bufsize, bufsize, &read, twopages);
+                err = mtd_read(mtd, addrn - bufsize, bufsize, &read, twopages);
                 if (mtd_is_bitflip(err))
                         err = 0;
                 if (err || read != bufsize) {
@@ -144,8 +144,7 @@ static int verify_eraseblock(int ebnum)
                         return err;
                 }
                 memset(twopages, 0, bufsize);
-                read = 0;
-                err = mtd->read(mtd, addr, bufsize, &read, twopages);
+                err = mtd_read(mtd, addr, bufsize, &read, twopages);
                 if (mtd_is_bitflip(err))
                         err = 0;
                 if (err || read != bufsize) {
@@ -163,7 +162,7 @@ static int verify_eraseblock(int ebnum)
         if (addr <= addrn - pgsize - pgsize && !bbt[ebnum + 1]) {
                 unsigned long oldnext = next;
                 /* Do a read to set the internal dataRAMs to different data */
-                err = mtd->read(mtd, addr0, bufsize, &read, twopages);
+                err = mtd_read(mtd, addr0, bufsize, &read, twopages);
                 if (mtd_is_bitflip(err))
                         err = 0;
                 if (err || read != bufsize) {
@@ -171,7 +170,7 @@ static int verify_eraseblock(int ebnum)
                                (long long)addr0);
                         return err;
                 }
-                err = mtd->read(mtd, addrn - bufsize, bufsize, &read, twopages);
+                err = mtd_read(mtd, addrn - bufsize, bufsize, &read, twopages);
                 if (mtd_is_bitflip(err))
                         err = 0;
                 if (err || read != bufsize) {
@@ -180,8 +179,7 @@ static int verify_eraseblock(int ebnum)
                         return err;
                 }
                 memset(twopages, 0, bufsize);
-                read = 0;
-                err = mtd->read(mtd, addr, bufsize, &read, twopages);
+                err = mtd_read(mtd, addr, bufsize, &read, twopages);
                 if (mtd_is_bitflip(err))
                         err = 0;
                 if (err || read != bufsize) {
@@ -203,7 +201,7 @@ static int verify_eraseblock(int ebnum)
 
 static int crosstest(void)
 {
-        size_t read = 0;
+        size_t read;
         int err = 0, i;
         loff_t addr, addr0, addrn;
         unsigned char *pp1, *pp2, *pp3, *pp4;
@@ -228,9 +226,8 @@ static int crosstest(void)
                 addrn -= mtd->erasesize;
 
         /* Read 2nd-to-last page to pp1 */
-        read = 0;
         addr = addrn - pgsize - pgsize;
-        err = mtd->read(mtd, addr, pgsize, &read, pp1);
+        err = mtd_read(mtd, addr, pgsize, &read, pp1);
         if (mtd_is_bitflip(err))
                 err = 0;
         if (err || read != pgsize) {
@@ -241,9 +238,8 @@ static int crosstest(void)
         }
 
         /* Read 3rd-to-last page to pp1 */
-        read = 0;
         addr = addrn - pgsize - pgsize - pgsize;
-        err = mtd->read(mtd, addr, pgsize, &read, pp1);
+        err = mtd_read(mtd, addr, pgsize, &read, pp1);
         if (mtd_is_bitflip(err))
                 err = 0;
         if (err || read != pgsize) {
@@ -254,10 +250,9 @@ static int crosstest(void)
         }
 
         /* Read first page to pp2 */
-        read = 0;
         addr = addr0;
         printk(PRINT_PREF "reading page at %#llx\n", (long long)addr);
-        err = mtd->read(mtd, addr, pgsize, &read, pp2);
+        err = mtd_read(mtd, addr, pgsize, &read, pp2);
         if (mtd_is_bitflip(err))
                 err = 0;
         if (err || read != pgsize) {
@@ -268,10 +263,9 @@ static int crosstest(void)
         }
 
         /* Read last page to pp3 */
-        read = 0;
         addr = addrn - pgsize;
         printk(PRINT_PREF "reading page at %#llx\n", (long long)addr);
-        err = mtd->read(mtd, addr, pgsize, &read, pp3);
+        err = mtd_read(mtd, addr, pgsize, &read, pp3);
         if (mtd_is_bitflip(err))
                 err = 0;
         if (err || read != pgsize) {
@@ -282,10 +276,9 @@ static int crosstest(void)
         }
 
         /* Read first page again to pp4 */
-        read = 0;
         addr = addr0;
         printk(PRINT_PREF "reading page at %#llx\n", (long long)addr);
-        err = mtd->read(mtd, addr, pgsize, &read, pp4);
+        err = mtd_read(mtd, addr, pgsize, &read, pp4);
         if (mtd_is_bitflip(err))
                 err = 0;
         if (err || read != pgsize) {
@@ -309,7 +302,7 @@ static int crosstest(void)
 
 static int erasecrosstest(void)
 {
-        size_t read = 0, written = 0;
+        size_t read, written;
         int err = 0, i, ebnum, ebnum2;
         loff_t addr0;
         char *readbuf = twopages;
@@ -335,7 +328,7 @@ static int erasecrosstest(void)
         printk(PRINT_PREF "writing 1st page of block %d\n", ebnum);
         set_random_data(writebuf, pgsize);
         strcpy(writebuf, "There is no data like this!");
-        err = mtd->write(mtd, addr0, pgsize, &written, writebuf);
+        err = mtd_write(mtd, addr0, pgsize, &written, writebuf);
         if (err || written != pgsize) {
                 printk(PRINT_PREF "error: write failed at %#llx\n",
                        (long long)addr0);
@@ -344,7 +337,7 @@ static int erasecrosstest(void)
 
         printk(PRINT_PREF "reading 1st page of block %d\n", ebnum);
         memset(readbuf, 0, pgsize);
-        err = mtd->read(mtd, addr0, pgsize, &read, readbuf);
+        err = mtd_read(mtd, addr0, pgsize, &read, readbuf);
         if (mtd_is_bitflip(err))
                 err = 0;
         if (err || read != pgsize) {
@@ -368,7 +361,7 @@ static int erasecrosstest(void)
         printk(PRINT_PREF "writing 1st page of block %d\n", ebnum);
         set_random_data(writebuf, pgsize);
         strcpy(writebuf, "There is no data like this!");
-        err = mtd->write(mtd, addr0, pgsize, &written, writebuf);
+        err = mtd_write(mtd, addr0, pgsize, &written, writebuf);
         if (err || written != pgsize) {
                 printk(PRINT_PREF "error: write failed at %#llx\n",
                        (long long)addr0);
@@ -382,7 +375,7 @@ static int erasecrosstest(void)
 
         printk(PRINT_PREF "reading 1st page of block %d\n", ebnum);
         memset(readbuf, 0, pgsize);
-        err = mtd->read(mtd, addr0, pgsize, &read, readbuf);
+        err = mtd_read(mtd, addr0, pgsize, &read, readbuf);
         if (mtd_is_bitflip(err))
                 err = 0;
         if (err || read != pgsize) {
@@ -405,7 +398,7 @@ static int erasecrosstest(void)
 
 static int erasetest(void)
 {
-        size_t read = 0, written = 0;
+        size_t read, written;
         int err = 0, i, ebnum, ok = 1;
         loff_t addr0;
 
@@ -425,7 +418,7 @@ static int erasetest(void)
 
         printk(PRINT_PREF "writing 1st page of block %d\n", ebnum);
         set_random_data(writebuf, pgsize);
-        err = mtd->write(mtd, addr0, pgsize, &written, writebuf);
+        err = mtd_write(mtd, addr0, pgsize, &written, writebuf);
         if (err || written != pgsize) {
                 printk(PRINT_PREF "error: write failed at %#llx\n",
                        (long long)addr0);
@@ -438,7 +431,7 @@ static int erasetest(void)
                 return err;
 
         printk(PRINT_PREF "reading 1st page of block %d\n", ebnum);
-        err = mtd->read(mtd, addr0, pgsize, &read, twopages);
+        err = mtd_read(mtd, addr0, pgsize, &read, twopages);
         if (mtd_is_bitflip(err))
                 err = 0;
         if (err || read != pgsize) {
@@ -469,7 +462,7 @@ static int is_block_bad(int ebnum)
         loff_t addr = ebnum * mtd->erasesize;
         int ret;
 
-        ret = mtd->block_isbad(mtd, addr);
+        ret = mtd_block_isbad(mtd, addr);
         if (ret)
                 printk(PRINT_PREF "block %d is bad\n", ebnum);
         return ret;
diff --git a/drivers/mtd/tests/mtd_readtest.c b/drivers/mtd/tests/mtd_readtest.c
index 550fe51225a7..121aba189cec 100644
--- a/drivers/mtd/tests/mtd_readtest.c
+++ b/drivers/mtd/tests/mtd_readtest.c
@@ -44,7 +44,7 @@ static int pgcnt;
 
 static int read_eraseblock_by_page(int ebnum)
 {
-        size_t read = 0;
+        size_t read;
         int i, ret, err = 0;
         loff_t addr = ebnum * mtd->erasesize;
         void *buf = iobuf;
@@ -52,7 +52,7 @@ static int read_eraseblock_by_page(int ebnum)
 
         for (i = 0; i < pgcnt; i++) {
                 memset(buf, 0 , pgcnt);
-                ret = mtd->read(mtd, addr, pgsize, &read, buf);
+                ret = mtd_read(mtd, addr, pgsize, &read, buf);
                 if (ret == -EUCLEAN)
                         ret = 0;
                 if (ret || read != pgsize) {
@@ -74,7 +74,7 @@ static int read_eraseblock_by_page(int ebnum)
                         ops.ooboffs   = 0;
                         ops.datbuf    = NULL;
                         ops.oobbuf    = oobbuf;
-                        ret = mtd->read_oob(mtd, addr, &ops);
+                        ret = mtd_read_oob(mtd, addr, &ops);
                         if ((ret && !mtd_is_bitflip(ret)) ||
                                         ops.oobretlen != mtd->oobsize) {
                                 printk(PRINT_PREF "error: read oob failed at "
@@ -132,7 +132,7 @@ static int is_block_bad(int ebnum)
         loff_t addr = ebnum * mtd->erasesize;
         int ret;
 
-        ret = mtd->block_isbad(mtd, addr);
+        ret = mtd_block_isbad(mtd, addr);
         if (ret)
                 printk(PRINT_PREF "block %d is bad\n", ebnum);
         return ret;
@@ -148,8 +148,7 @@ static int scan_for_bad_eraseblocks(void)
                 return -ENOMEM;
         }
 
-        /* NOR flash does not implement block_isbad */
-        if (mtd->block_isbad == NULL)
+        if (!mtd_can_have_bb(mtd))
                 return 0;
 
         printk(PRINT_PREF "scanning for bad eraseblocks\n");
diff --git a/drivers/mtd/tests/mtd_speedtest.c b/drivers/mtd/tests/mtd_speedtest.c
index 493b367bdd35..2aec4f3b72be 100644
--- a/drivers/mtd/tests/mtd_speedtest.c
+++ b/drivers/mtd/tests/mtd_speedtest.c
@@ -79,7 +79,7 @@ static int erase_eraseblock(int ebnum)
         ei.addr = addr;
         ei.len  = mtd->erasesize;
 
-        err = mtd->erase(mtd, &ei);
+        err = mtd_erase(mtd, &ei);
         if (err) {
                 printk(PRINT_PREF "error %d while erasing EB %d\n", err, ebnum);
                 return err;
@@ -105,7 +105,7 @@ static int multiblock_erase(int ebnum, int blocks)
         ei.addr = addr;
         ei.len  = mtd->erasesize * blocks;
 
-        err = mtd->erase(mtd, &ei);
+        err = mtd_erase(mtd, &ei);
         if (err) {
                 printk(PRINT_PREF "error %d while erasing EB %d, blocks %d\n",
                        err, ebnum, blocks);
@@ -139,11 +139,11 @@ static int erase_whole_device(void)
 
 static int write_eraseblock(int ebnum)
 {
-        size_t written = 0;
+        size_t written;
         int err = 0;
         loff_t addr = ebnum * mtd->erasesize;
 
-        err = mtd->write(mtd, addr, mtd->erasesize, &written, iobuf);
+        err = mtd_write(mtd, addr, mtd->erasesize, &written, iobuf);
         if (err || written != mtd->erasesize) {
                 printk(PRINT_PREF "error: write failed at %#llx\n", addr);
                 if (!err)
@@ -155,13 +155,13 @@ static int write_eraseblock(int ebnum)
 
 static int write_eraseblock_by_page(int ebnum)
 {
-        size_t written = 0;
+        size_t written;
         int i, err = 0;
         loff_t addr = ebnum * mtd->erasesize;
         void *buf = iobuf;
 
         for (i = 0; i < pgcnt; i++) {
-                err = mtd->write(mtd, addr, pgsize, &written, buf);
+                err = mtd_write(mtd, addr, pgsize, &written, buf);
                 if (err || written != pgsize) {
                         printk(PRINT_PREF "error: write failed at %#llx\n",
                                addr);
@@ -178,13 +178,13 @@ static int write_eraseblock_by_page(int ebnum)
 
 static int write_eraseblock_by_2pages(int ebnum)
 {
-        size_t written = 0, sz = pgsize * 2;
+        size_t written, sz = pgsize * 2;
         int i, n = pgcnt / 2, err = 0;
         loff_t addr = ebnum * mtd->erasesize;
         void *buf = iobuf;
 
         for (i = 0; i < n; i++) {
-                err = mtd->write(mtd, addr, sz, &written, buf);
+                err = mtd_write(mtd, addr, sz, &written, buf);
                 if (err || written != sz) {
                         printk(PRINT_PREF "error: write failed at %#llx\n",
                                addr);
@@ -196,7 +196,7 @@ static int write_eraseblock_by_2pages(int ebnum)
                 buf += sz;
         }
         if (pgcnt % 2) {
-                err = mtd->write(mtd, addr, pgsize, &written, buf);
+                err = mtd_write(mtd, addr, pgsize, &written, buf);
                 if (err || written != pgsize) {
                         printk(PRINT_PREF "error: write failed at %#llx\n",
                                addr);
@@ -210,11 +210,11 @@ static int write_eraseblock_by_2pages(int ebnum)
 
 static int read_eraseblock(int ebnum)
 {
-        size_t read = 0;
+        size_t read;
         int err = 0;
         loff_t addr = ebnum * mtd->erasesize;
 
-        err = mtd->read(mtd, addr, mtd->erasesize, &read, iobuf);
+        err = mtd_read(mtd, addr, mtd->erasesize, &read, iobuf);
         /* Ignore corrected ECC errors */
         if (mtd_is_bitflip(err))
                 err = 0;
@@ -229,13 +229,13 @@ static int read_eraseblock(int ebnum)
 
 static int read_eraseblock_by_page(int ebnum)
 {
-        size_t read = 0;
+        size_t read;
         int i, err = 0;
         loff_t addr = ebnum * mtd->erasesize;
         void *buf = iobuf;
 
         for (i = 0; i < pgcnt; i++) {
-                err = mtd->read(mtd, addr, pgsize, &read, buf);
+                err = mtd_read(mtd, addr, pgsize, &read, buf);
                 /* Ignore corrected ECC errors */
                 if (mtd_is_bitflip(err))
                         err = 0;
@@ -255,13 +255,13 @@ static int read_eraseblock_by_page(int ebnum)
 
 static int read_eraseblock_by_2pages(int ebnum)
 {
-        size_t read = 0, sz = pgsize * 2;
+        size_t read, sz = pgsize * 2;
         int i, n = pgcnt / 2, err = 0;
         loff_t addr = ebnum * mtd->erasesize;
         void *buf = iobuf;
 
         for (i = 0; i < n; i++) {
-                err = mtd->read(mtd, addr, sz, &read, buf);
+                err = mtd_read(mtd, addr, sz, &read, buf);
                 /* Ignore corrected ECC errors */
                 if (mtd_is_bitflip(err))
                         err = 0;
@@ -276,7 +276,7 @@ static int read_eraseblock_by_2pages(int ebnum)
                 buf += sz;
         }
         if (pgcnt % 2) {
-                err = mtd->read(mtd, addr, pgsize, &read, buf);
+                err = mtd_read(mtd, addr, pgsize, &read, buf);
                 /* Ignore corrected ECC errors */
                 if (mtd_is_bitflip(err))
                         err = 0;
@@ -296,7 +296,7 @@ static int is_block_bad(int ebnum)
         loff_t addr = ebnum * mtd->erasesize;
         int ret;
 
-        ret = mtd->block_isbad(mtd, addr);
+        ret = mtd_block_isbad(mtd, addr);
         if (ret)
                 printk(PRINT_PREF "block %d is bad\n", ebnum);
         return ret;
@@ -336,8 +336,7 @@ static int scan_for_bad_eraseblocks(void)
                 return -ENOMEM;
         }
 
-        /* NOR flash does not implement block_isbad */
-        if (mtd->block_isbad == NULL)
+        if (!mtd_can_have_bb(mtd))
                 goto out;
 
         printk(PRINT_PREF "scanning for bad eraseblocks\n");
diff --git a/drivers/mtd/tests/mtd_stresstest.c b/drivers/mtd/tests/mtd_stresstest.c
index 52ffd9120e0d..7b33f22d0b58 100644
--- a/drivers/mtd/tests/mtd_stresstest.c
+++ b/drivers/mtd/tests/mtd_stresstest.c
@@ -112,7 +112,7 @@ static int erase_eraseblock(int ebnum)
         ei.addr = addr;
         ei.len  = mtd->erasesize;
 
-        err = mtd->erase(mtd, &ei);
+        err = mtd_erase(mtd, &ei);
         if (unlikely(err)) {
                 printk(PRINT_PREF "error %d while erasing EB %d\n", err, ebnum);
                 return err;
@@ -132,7 +132,7 @@ static int is_block_bad(int ebnum)
         loff_t addr = ebnum * mtd->erasesize;
         int ret;
 
-        ret = mtd->block_isbad(mtd, addr);
+        ret = mtd_block_isbad(mtd, addr);
         if (ret)
                 printk(PRINT_PREF "block %d is bad\n", ebnum);
         return ret;
@@ -140,7 +140,7 @@ static int is_block_bad(int ebnum)
 
 static int do_read(void)
 {
-        size_t read = 0;
+        size_t read;
         int eb = rand_eb();
         int offs = rand_offs();
         int len = rand_len(offs), err;
@@ -153,7 +153,7 @@ static int do_read(void)
                         len = mtd->erasesize - offs;
         }
         addr = eb * mtd->erasesize + offs;
-        err = mtd->read(mtd, addr, len, &read, readbuf);
+        err = mtd_read(mtd, addr, len, &read, readbuf);
         if (mtd_is_bitflip(err))
                 err = 0;
         if (unlikely(err || read != len)) {
@@ -169,7 +169,7 @@ static int do_read(void)
 static int do_write(void)
 {
         int eb = rand_eb(), offs, err, len;
-        size_t written = 0;
+        size_t written;
         loff_t addr;
 
         offs = offsets[eb];
@@ -192,7 +192,7 @@ static int do_write(void)
                 }
         }
         addr = eb * mtd->erasesize + offs;
-        err = mtd->write(mtd, addr, len, &written, writebuf);
+        err = mtd_write(mtd, addr, len, &written, writebuf);
         if (unlikely(err || written != len)) {
                 printk(PRINT_PREF "error: write failed at 0x%llx\n",
                        (long long)addr);
@@ -227,8 +227,7 @@ static int scan_for_bad_eraseblocks(void)
                 return -ENOMEM;
         }
 
-        /* NOR flash does not implement block_isbad */
-        if (mtd->block_isbad == NULL)
+        if (!mtd_can_have_bb(mtd))
                 return 0;
 
         printk(PRINT_PREF "scanning for bad eraseblocks\n");
@@ -284,6 +283,12 @@ static int __init mtd_stresstest_init(void)
                (unsigned long long)mtd->size, mtd->erasesize,
                pgsize, ebcnt, pgcnt, mtd->oobsize);
 
+        if (ebcnt < 2) {
+                printk(PRINT_PREF "error: need at least 2 eraseblocks\n");
+                err = -ENOSPC;
+                goto out_put_mtd;
+        }
+
         /* Read or write up 2 eraseblocks at a time */
         bufsize = mtd->erasesize * 2;
 
@@ -322,6 +327,7 @@ out:
         kfree(bbt);
         vfree(writebuf);
         vfree(readbuf);
+out_put_mtd:
         put_mtd_device(mtd);
         if (err)
                 printk(PRINT_PREF "error %d occurred\n", err);
diff --git a/drivers/mtd/tests/mtd_subpagetest.c b/drivers/mtd/tests/mtd_subpagetest.c
index 1a05bfac4eee..9667bf535282 100644
--- a/drivers/mtd/tests/mtd_subpagetest.c
+++ b/drivers/mtd/tests/mtd_subpagetest.c
@@ -80,7 +80,7 @@ static int erase_eraseblock(int ebnum)
         ei.addr = addr;
         ei.len  = mtd->erasesize;
 
-        err = mtd->erase(mtd, &ei);
+        err = mtd_erase(mtd, &ei);
         if (err) {
                 printk(PRINT_PREF "error %d while erasing EB %d\n", err, ebnum);
                 return err;
@@ -115,12 +115,12 @@ static int erase_whole_device(void)
 
 static int write_eraseblock(int ebnum)
 {
-        size_t written = 0;
+        size_t written;
         int err = 0;
         loff_t addr = ebnum * mtd->erasesize;
 
         set_random_data(writebuf, subpgsize);
-        err = mtd->write(mtd, addr, subpgsize, &written, writebuf);
+        err = mtd_write(mtd, addr, subpgsize, &written, writebuf);
         if (unlikely(err || written != subpgsize)) {
                 printk(PRINT_PREF "error: write failed at %#llx\n",
                        (long long)addr);
@@ -134,7 +134,7 @@ static int write_eraseblock(int ebnum)
         addr += subpgsize;
 
         set_random_data(writebuf, subpgsize);
-        err = mtd->write(mtd, addr, subpgsize, &written, writebuf);
+        err = mtd_write(mtd, addr, subpgsize, &written, writebuf);
         if (unlikely(err || written != subpgsize)) {
                 printk(PRINT_PREF "error: write failed at %#llx\n",
                        (long long)addr);
@@ -150,7 +150,7 @@ static int write_eraseblock(int ebnum)
 
 static int write_eraseblock2(int ebnum)
 {
-        size_t written = 0;
+        size_t written;
         int err = 0, k;
         loff_t addr = ebnum * mtd->erasesize;
 
@@ -158,7 +158,7 @@ static int write_eraseblock2(int ebnum)
                 if (addr + (subpgsize * k) > (ebnum + 1) * mtd->erasesize)
                         break;
                 set_random_data(writebuf, subpgsize * k);
-                err = mtd->write(mtd, addr, subpgsize * k, &written, writebuf);
+                err = mtd_write(mtd, addr, subpgsize * k, &written, writebuf);
                 if (unlikely(err || written != subpgsize * k)) {
                         printk(PRINT_PREF "error: write failed at %#llx\n",
                                (long long)addr);
@@ -189,14 +189,13 @@ static void print_subpage(unsigned char *p)
 
 static int verify_eraseblock(int ebnum)
 {
-        size_t read = 0;
+        size_t read;
         int err = 0;
         loff_t addr = ebnum * mtd->erasesize;
 
         set_random_data(writebuf, subpgsize);
         clear_data(readbuf, subpgsize);
-        read = 0;
-        err = mtd->read(mtd, addr, subpgsize, &read, readbuf);
+        err = mtd_read(mtd, addr, subpgsize, &read, readbuf);
         if (unlikely(err || read != subpgsize)) {
                 if (mtd_is_bitflip(err) && read == subpgsize) {
                         printk(PRINT_PREF "ECC correction at %#llx\n",
@@ -223,8 +222,7 @@ static int verify_eraseblock(int ebnum)
 
         set_random_data(writebuf, subpgsize);
         clear_data(readbuf, subpgsize);
-        read = 0;
-        err = mtd->read(mtd, addr, subpgsize, &read, readbuf);
+        err = mtd_read(mtd, addr, subpgsize, &read, readbuf);
         if (unlikely(err || read != subpgsize)) {
                 if (mtd_is_bitflip(err) && read == subpgsize) {
                         printk(PRINT_PREF "ECC correction at %#llx\n",
@@ -252,7 +250,7 @@ static int verify_eraseblock(int ebnum)
 
 static int verify_eraseblock2(int ebnum)
 {
-        size_t read = 0;
+        size_t read;
         int err = 0, k;
         loff_t addr = ebnum * mtd->erasesize;
 
@@ -261,8 +259,7 @@ static int verify_eraseblock2(int ebnum)
                         break;
                 set_random_data(writebuf, subpgsize * k);
                 clear_data(readbuf, subpgsize * k);
-                read = 0;
-                err = mtd->read(mtd, addr, subpgsize * k, &read, readbuf);
+                err = mtd_read(mtd, addr, subpgsize * k, &read, readbuf);
                 if (unlikely(err || read != subpgsize * k)) {
                         if (mtd_is_bitflip(err) && read == subpgsize * k) {
                                 printk(PRINT_PREF "ECC correction at %#llx\n",
@@ -288,15 +285,14 @@ static int verify_eraseblock2(int ebnum)
 static int verify_eraseblock_ff(int ebnum)
 {
         uint32_t j;
-        size_t read = 0;
+        size_t read;
         int err = 0;
         loff_t addr = ebnum * mtd->erasesize;
 
         memset(writebuf, 0xff, subpgsize);
         for (j = 0; j < mtd->erasesize / subpgsize; ++j) {
                 clear_data(readbuf, subpgsize);
-                read = 0;
-                err = mtd->read(mtd, addr, subpgsize, &read, readbuf);
+                err = mtd_read(mtd, addr, subpgsize, &read, readbuf);
                 if (unlikely(err || read != subpgsize)) {
                         if (mtd_is_bitflip(err) && read == subpgsize) {
                                 printk(PRINT_PREF "ECC correction at %#llx\n",
@@ -344,7 +340,7 @@ static int is_block_bad(int ebnum)
         loff_t addr = ebnum * mtd->erasesize;
         int ret;
 
-        ret = mtd->block_isbad(mtd, addr);
+        ret = mtd_block_isbad(mtd, addr);
         if (ret)
                 printk(PRINT_PREF "block %d is bad\n", ebnum);
         return ret;
diff --git a/drivers/mtd/tests/mtd_torturetest.c b/drivers/mtd/tests/mtd_torturetest.c
index 03ab649a6964..b65861bc7b8e 100644
--- a/drivers/mtd/tests/mtd_torturetest.c
+++ b/drivers/mtd/tests/mtd_torturetest.c
@@ -105,7 +105,7 @@ static inline int erase_eraseblock(int ebnum)
         ei.addr = addr;
         ei.len  = mtd->erasesize;
 
-        err = mtd->erase(mtd, &ei);
+        err = mtd_erase(mtd, &ei);
         if (err) {
                 printk(PRINT_PREF "error %d while erasing EB %d\n", err, ebnum);
                 return err;
@@ -127,7 +127,7 @@ static inline int erase_eraseblock(int ebnum)
 static inline int check_eraseblock(int ebnum, unsigned char *buf)
 {
         int err, retries = 0;
-        size_t read = 0;
+        size_t read;
         loff_t addr = ebnum * mtd->erasesize;
         size_t len = mtd->erasesize;
 
@@ -137,7 +137,7 @@ static inline int check_eraseblock(int ebnum, unsigned char *buf)
         }
 
 retry:
-        err = mtd->read(mtd, addr, len, &read, check_buf);
+        err = mtd_read(mtd, addr, len, &read, check_buf);
         if (mtd_is_bitflip(err))
                 printk(PRINT_PREF "single bit flip occurred at EB %d "
                        "MTD reported that it was fixed.\n", ebnum);
@@ -181,7 +181,7 @@ retry:
 static inline int write_pattern(int ebnum, void *buf)
 {
         int err;
-        size_t written = 0;
+        size_t written;
         loff_t addr = ebnum * mtd->erasesize;
         size_t len = mtd->erasesize;
 
@@ -189,7 +189,7 @@ static inline int write_pattern(int ebnum, void *buf)
                 addr = (ebnum + 1) * mtd->erasesize - pgcnt * pgsize;
                 len = pgcnt * pgsize;
         }
-        err = mtd->write(mtd, addr, len, &written, buf);
+        err = mtd_write(mtd, addr, len, &written, buf);
         if (err) {
                 printk(PRINT_PREF "error %d while writing EB %d, written %zd"
                       " bytes\n", err, ebnum, written);
@@ -290,10 +290,9 @@ static int __init tort_init(void)
          * Check if there is a bad eraseblock among those we are going to test.
          */
         memset(&bad_ebs[0], 0, sizeof(int) * ebcnt);
-        if (mtd->block_isbad) {
+        if (mtd_can_have_bb(mtd)) {
                 for (i = eb; i < eb + ebcnt; i++) {
-                        err = mtd->block_isbad(mtd,
-                                               (loff_t)i * mtd->erasesize);
+                        err = mtd_block_isbad(mtd, (loff_t)i * mtd->erasesize);
 
                         if (err < 0) {
                                 printk(PRINT_PREF "block_isbad() returned %d "
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 6c3fb5ab20f5..115749f20f9e 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -664,7 +664,7 @@ static int io_init(struct ubi_device *ubi)
         ubi->peb_count  = mtd_div_by_eb(ubi->mtd->size, ubi->mtd);
         ubi->flash_size = ubi->mtd->size;
 
-        if (ubi->mtd->block_isbad && ubi->mtd->block_markbad)
+        if (mtd_can_have_bb(ubi->mtd))
                 ubi->bad_allowed = 1;
 
         if (ubi->mtd->type == MTD_NORFLASH) {
diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c
index ab80c0debac8..e2cdebf40840 100644
--- a/drivers/mtd/ubi/debug.c
+++ b/drivers/mtd/ubi/debug.c
@@ -216,7 +216,7 @@ void ubi_dbg_dump_flash(struct ubi_device *ubi, int pnum, int offset, int len)
         buf = vmalloc(len);
         if (!buf)
                 return;
-        err = ubi->mtd->read(ubi->mtd, addr, len, &read, buf);
+        err = mtd_read(ubi->mtd, addr, len, &read, buf);
         if (err && err != -EUCLEAN) {
                 ubi_err("error %d while reading %d bytes from PEB %d:%d, "
                         "read %zd bytes", err, len, pnum, offset, read);
diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
index f20b6f22f240..5cde4e5ca3e5 100644
--- a/drivers/mtd/ubi/io.c
+++ b/drivers/mtd/ubi/io.c
@@ -170,7 +170,7 @@ int ubi_io_read(const struct ubi_device *ubi, void *buf, int pnum, int offset,
 
         addr = (loff_t)pnum * ubi->peb_size + offset;
 retry:
-        err = ubi->mtd->read(ubi->mtd, addr, len, &read, buf);
+        err = mtd_read(ubi->mtd, addr, len, &read, buf);
         if (err) {
                 const char *errstr = mtd_is_eccerr(err) ? " (ECC error)" : "";
 
@@ -289,7 +289,7 @@ int ubi_io_write(struct ubi_device *ubi, const void *buf, int pnum, int offset,
         }
 
         addr = (loff_t)pnum * ubi->peb_size + offset;
-        err = ubi->mtd->write(ubi->mtd, addr, len, &written, buf);
+        err = mtd_write(ubi->mtd, addr, len, &written, buf);
         if (err) {
                 ubi_err("error %d while writing %d bytes to PEB %d:%d, written "
                         "%zd bytes", err, len, pnum, offset, written);
@@ -361,7 +361,7 @@ retry:
         ei.callback = erase_callback;
         ei.priv     = (unsigned long)&wq;
 
-        err = ubi->mtd->erase(ubi->mtd, &ei);
+        err = mtd_erase(ubi->mtd, &ei);
         if (err) {
                 if (retries++ < UBI_IO_RETRIES) {
                         dbg_io("error %d while erasing PEB %d, retry",
@@ -525,11 +525,10 @@ static int nor_erase_prepare(struct ubi_device *ubi, int pnum)
          * the header comment in scan.c for more information).
          */
         addr = (loff_t)pnum * ubi->peb_size;
-        err = ubi->mtd->write(ubi->mtd, addr, 4, &written, (void *)&data);
+        err = mtd_write(ubi->mtd, addr, 4, &written, (void *)&data);
         if (!err) {
                 addr += ubi->vid_hdr_aloffset;
-                err = ubi->mtd->write(ubi->mtd, addr, 4, &written,
-                                      (void *)&data);
+                err = mtd_write(ubi->mtd, addr, 4, &written, (void *)&data);
                 if (!err)
                         return 0;
         }
@@ -635,7 +634,7 @@ int ubi_io_is_bad(const struct ubi_device *ubi, int pnum)
         if (ubi->bad_allowed) {
                 int ret;
 
-                ret = mtd->block_isbad(mtd, (loff_t)pnum * ubi->peb_size);
+                ret = mtd_block_isbad(mtd, (loff_t)pnum * ubi->peb_size);
                 if (ret < 0)
                         ubi_err("error %d while checking if PEB %d is bad",
                                 ret, pnum);
@@ -670,7 +669,7 @@ int ubi_io_mark_bad(const struct ubi_device *ubi, int pnum)
         if (!ubi->bad_allowed)
                 return 0;
 
-        err = mtd->block_markbad(mtd, (loff_t)pnum * ubi->peb_size);
+        err = mtd_block_markbad(mtd, (loff_t)pnum * ubi->peb_size);
         if (err)
                 ubi_err("cannot mark PEB %d bad, error %d", pnum, err);
         return err;
@@ -1357,7 +1356,7 @@ int ubi_dbg_check_write(struct ubi_device *ubi, const void *buf, int pnum,
                 return 0;
         }
 
-        err = ubi->mtd->read(ubi->mtd, addr, len, &read, buf1);
+        err = mtd_read(ubi->mtd, addr, len, &read, buf1);
         if (err && !mtd_is_bitflip(err))
                 goto out_free;
 
@@ -1421,7 +1420,7 @@ int ubi_dbg_check_all_ff(struct ubi_device *ubi, int pnum, int offset, int len)
                 return 0;
         }
 
-        err = ubi->mtd->read(ubi->mtd, addr, len, &read, buf);
+        err = mtd_read(ubi->mtd, addr, len, &read, buf);
         if (err && !mtd_is_bitflip(err)) {
                 ubi_err("error %d while reading %d bytes from PEB %d:%d, "
                         "read %zd bytes", err, len, pnum, offset, read);
diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c
index 1a35fc5e3b40..9fdb35367fe0 100644
--- a/drivers/mtd/ubi/kapi.c
+++ b/drivers/mtd/ubi/kapi.c
@@ -714,9 +714,7 @@ int ubi_sync(int ubi_num)
         if (!ubi)
                 return -ENODEV;
 
-        if (ubi->mtd->sync)
-                ubi->mtd->sync(ubi->mtd);
-
+        mtd_sync(ubi->mtd);
         ubi_put_device(ubi);
         return 0;
 }