mtd: do not use mtd->sync directly

This patch teaches 'mtd_sync()' to do nothing when the MTD driver does
not have the '->sync()' method, which allows us to remove all direct
'mtd->sync' accesses.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

6 files changed, 7 insertions, 15 deletions

diff --git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c
index c9c90299c9e2..19d637266fcd 100644
--- a/drivers/mtd/ftl.c
+++ b/drivers/mtd/ftl.c
@@ -650,8 +650,7 @@ static int reclaim_block(partition_t *part)
             if (queued) {
                 pr_debug("ftl_cs: waiting for transfer "
                       "unit to be prepared...\n");
-                if (part->mbd.mtd->sync)
-                        mtd_sync(part->mbd.mtd);
+                mtd_sync(part->mbd.mtd);
             } else {
                 static int ne = 0;
                 if (++ne < 5)
diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
index 496e1a6e8029..af6591237b9b 100644
--- a/drivers/mtd/mtdblock.c
+++ b/drivers/mtd/mtdblock.c
@@ -322,8 +322,7 @@ static int mtdblock_release(struct mtd_blktrans_dev *mbd)
 
         if (!--mtdblk->count) {
                 /* It was the last usage. Free the cache */
-                if (mbd->mtd->sync)
-                        mtd_sync(mbd->mtd);
+                mtd_sync(mbd->mtd);
                 vfree(mtdblk->cache_data);
         }
 
@@ -341,9 +340,7 @@ static int mtdblock_flush(struct mtd_blktrans_dev *dev)
         mutex_lock(&mtdblk->cache_mutex);
         write_cached_data(mtdblk);
         mutex_unlock(&mtdblk->cache_mutex);
-
-        if (dev->mtd->sync)
-                mtd_sync(dev->mtd);
+        mtd_sync(dev->mtd);
         return 0;
 }
 
diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index 2020a169ed9c..23a51104aeb5 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -154,7 +154,7 @@ static int mtdchar_close(struct inode *inode, struct file *file)
         pr_debug("MTD_close\n");
 
         /* Only sync if opened RW */
-        if ((file->f_mode & FMODE_WRITE) && mtd->sync)
+        if ((file->f_mode & FMODE_WRITE))
                 mtd_sync(mtd);
 
         iput(mfi->ino);
diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
index 4441c08b082d..fe4426c1c736 100644
--- a/drivers/mtd/mtdswap.c
+++ b/drivers/mtd/mtdswap.c
@@ -1047,8 +1047,7 @@ static int mtdswap_flush(struct mtd_blktrans_dev *dev)
 {
         struct mtdswap_dev *d = MTDSWAP_MBD_TO_MTDSWAP(dev);
 
-        if (d->mtd->sync)
-                mtd_sync(d->mtd);
+        mtd_sync(d->mtd);
         return 0;
 }
 
diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c
index 5426d42cdea7..233b946e5d66 100644
--- a/drivers/mtd/rfd_ftl.c
+++ b/drivers/mtd/rfd_ftl.c
@@ -448,8 +448,7 @@ static int reclaim_block(struct partition *part, u_long *old_sector)
         int rc;
 
         /* we have a race if sync doesn't exist */
-        if (part->mbd.mtd->sync)
-                mtd_sync(part->mbd.mtd);
+        mtd_sync(part->mbd.mtd);
 
         score = 0x7fffffff; /* MAX_INT */
         best_block = -1;
diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c
index 9f265cc1a0d3..9fdb35367fe0 100644
--- a/drivers/mtd/ubi/kapi.c
+++ b/drivers/mtd/ubi/kapi.c
@@ -714,9 +714,7 @@ int ubi_sync(int ubi_num)
         if (!ubi)
                 return -ENODEV;
 
-        if (ubi->mtd->sync)
-                mtd_sync(ubi->mtd);
-
+        mtd_sync(ubi->mtd);
         ubi_put_device(ubi);
         return 0;
 }