aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mtd
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2015-05-18 13:01:54 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2015-05-18 13:01:54 -0400
commit7cf7d424c309457b21318b05963ff3fd723d5bcd (patch)
treef24ae5b0bc01978761b285ae546f2076ca705747 /drivers/mtd
parentc0655fe9b0901a968800f56687be3c62b4cce5d2 (diff)
parent8947e396a8296c5297928b60043f35dfa56baa05 (diff)
Merge tag 'for-linus-20150516' of git://git.infradead.org/linux-mtd
Pull MTD fixes from Brian Norris: "Two MTD fixes for 4.1: - readtest: the signal-handling code was clobbering the error codes we should be handling/reporting in this test, rendering it useless. Noticed by Coverity. - the common SPI NOR flash DT binding (merged for 4.1-rc1) is being revised, so let's change that before 4.1 is minted" * tag 'for-linus-20150516' of git://git.infradead.org/linux-mtd: Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" mtd: readtest: don't clobber error reports
Diffstat (limited to 'drivers/mtd')
-rw-r--r--drivers/mtd/devices/m25p80.c6
-rw-r--r--drivers/mtd/tests/readtest.c6
2 files changed, 7 insertions, 5 deletions
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 7c8b1694a134..3af137f49ac9 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -223,7 +223,7 @@ static int m25p_probe(struct spi_device *spi)
223 */ 223 */
224 if (data && data->type) 224 if (data && data->type)
225 flash_name = data->type; 225 flash_name = data->type;
226 else if (!strcmp(spi->modalias, "nor-jedec")) 226 else if (!strcmp(spi->modalias, "spi-nor"))
227 flash_name = NULL; /* auto-detect */ 227 flash_name = NULL; /* auto-detect */
228 else 228 else
229 flash_name = spi->modalias; 229 flash_name = spi->modalias;
@@ -255,7 +255,7 @@ static int m25p_remove(struct spi_device *spi)
255 * since most of these flash are compatible to some extent, and their 255 * since most of these flash are compatible to some extent, and their
256 * differences can often be differentiated by the JEDEC read-ID command, we 256 * differences can often be differentiated by the JEDEC read-ID command, we
257 * encourage new users to add support to the spi-nor library, and simply bind 257 * encourage new users to add support to the spi-nor library, and simply bind
258 * against a generic string here (e.g., "nor-jedec"). 258 * against a generic string here (e.g., "jedec,spi-nor").
259 * 259 *
260 * Many flash names are kept here in this list (as well as in spi-nor.c) to 260 * Many flash names are kept here in this list (as well as in spi-nor.c) to
261 * keep them available as module aliases for existing platforms. 261 * keep them available as module aliases for existing platforms.
@@ -305,7 +305,7 @@ static const struct spi_device_id m25p_ids[] = {
305 * Generic support for SPI NOR that can be identified by the JEDEC READ 305 * Generic support for SPI NOR that can be identified by the JEDEC READ
306 * ID opcode (0x9F). Use this, if possible. 306 * ID opcode (0x9F). Use this, if possible.
307 */ 307 */
308 {"nor-jedec"}, 308 {"spi-nor"},
309 { }, 309 { },
310}; 310};
311MODULE_DEVICE_TABLE(spi, m25p_ids); 311MODULE_DEVICE_TABLE(spi, m25p_ids);
diff --git a/drivers/mtd/tests/readtest.c b/drivers/mtd/tests/readtest.c
index a3196b750a22..58df07acdbdb 100644
--- a/drivers/mtd/tests/readtest.c
+++ b/drivers/mtd/tests/readtest.c
@@ -191,9 +191,11 @@ static int __init mtd_readtest_init(void)
191 err = ret; 191 err = ret;
192 } 192 }
193 193
194 err = mtdtest_relax(); 194 ret = mtdtest_relax();
195 if (err) 195 if (ret) {
196 err = ret;
196 goto out; 197 goto out;
198 }
197 } 199 }
198 200
199 if (err) 201 if (err)