Merge branch 'omap2-upstream' into devel

5 files changed, 15 insertions, 14 deletions

diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
index 47794d23a42e..0080452531d6 100644
--- a/drivers/mtd/chips/cfi_cmdset_0001.c
+++ b/drivers/mtd/chips/cfi_cmdset_0001.c
@@ -718,7 +718,7 @@ static int chip_ready (struct map_info *map, struct flchip *chip, unsigned long
                         /* Someone else might have been playing with it. */
                         return -EAGAIN;
                 }
-
+                /* Fall through */
         case FL_READY:
         case FL_CFI_QUERY:
         case FL_JEDEC_QUERY:
@@ -778,14 +778,14 @@ static int chip_ready (struct map_info *map, struct flchip *chip, unsigned long
                 chip->state = FL_READY;
                 return 0;
 
+        case FL_SHUTDOWN:
+                /* The machine is rebooting now,so no one can get chip anymore */
+                return -EIO;
         case FL_POINT:
                 /* Only if there's no operation suspended... */
                 if (mode == FL_READY && chip->oldstate == FL_READY)
                         return 0;
-
-        case FL_SHUTDOWN:
-                /* The machine is rebooting now,so no one can get chip anymore */
-                return -EIO;
+                /* Fall through */
         default:
         sleep:
                 set_current_state(TASK_UNINTERRUPTIBLE);
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index d072e87ce4e2..458d477614d6 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1763,6 +1763,7 @@ static void cfi_amdstd_sync (struct mtd_info *mtd)
 
                 default:
                         /* Not an idle state */
+                        set_current_state(TASK_UNINTERRUPTIBLE);
                         add_wait_queue(&chip->wq, &wait);
 
                         spin_unlock(chip->mutex);
diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
index b344ff858b2d..492e2ab27420 100644
--- a/drivers/mtd/chips/cfi_cmdset_0020.c
+++ b/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -1015,6 +1015,7 @@ static void cfi_staa_sync (struct mtd_info *mtd)
 
                 default:
                         /* Not an idle state */
+                        set_current_state(TASK_UNINTERRUPTIBLE);
                         add_wait_queue(&chip->wq, &wait);
 
                         spin_unlock_bh(chip->mutex);
diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index f00e04efbe28..bc4649a17b9d 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -202,9 +202,8 @@ static int physmap_flash_suspend(struct platform_device *dev, pm_message_t state
         int ret = 0;
         int i;
 
-        if (info)
-                for (i = 0; i < MAX_RESOURCES; i++)
-                        ret |= info->mtd[i]->suspend(info->mtd[i]);
+        for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
+                ret |= info->mtd[i]->suspend(info->mtd[i]);
 
         return ret;
 }
@@ -214,9 +213,9 @@ static int physmap_flash_resume(struct platform_device *dev)
         struct physmap_flash_info *info = platform_get_drvdata(dev);
         int i;
 
-        if (info)
-                for (i = 0; i < MAX_RESOURCES; i++)
-                        info->mtd[i]->resume(info->mtd[i]);
+        for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
+                info->mtd[i]->resume(info->mtd[i]);
+
         return 0;
 }
 
@@ -225,8 +224,8 @@ static void physmap_flash_shutdown(struct platform_device *dev)
         struct physmap_flash_info *info = platform_get_drvdata(dev);
         int i;
 
-        for (i = 0; i < MAX_RESOURCES; i++)
-                if (info && info->mtd[i]->suspend(info->mtd[i]) == 0)
+        for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
+                if (info->mtd[i]->suspend(info->mtd[i]) == 0)
                         info->mtd[i]->resume(info->mtd[i]);
 }
 #else
diff --git a/drivers/mtd/nand/rtc_from4.c b/drivers/mtd/nand/rtc_from4.c
index 9189ec8f243e..0f6ac250f434 100644
--- a/drivers/mtd/nand/rtc_from4.c
+++ b/drivers/mtd/nand/rtc_from4.c
@@ -460,7 +460,7 @@ static int rtc_from4_errstat(struct mtd_info *mtd, struct nand_chip *this,
                         er_stat |= 1 << 1;
                 kfree(buf);
         }
-
+out:
         rtn = status;
         if (er_stat == 0) {     /* if ECC is available   */
                 rtn = (status & ~NAND_STATUS_FAIL);     /*   clear the error bit */