pcmcia: do not use win_req_t when calling pcmcia_request_window()

Instead of win_req_t, drivers are now requested to fill out
struct pcmcia_device *p_dev->resource[2,3,4,5] for up to four iomem
ranges. After a call to pcmcia_request_window(), the windows found there
are reserved and may be used until pcmcia_release_window() is called.

CC: netdev@vger.kernel.org
CC: linux-wireless@vger.kernel.org
CC: linux-mtd@lists.infradead.org
CC: Jiri Kosina <jkosina@suse.cz>
CC: linux-scsi@vger.kernel.org
Tested-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>

1 files changed, 29 insertions, 24 deletions

diff --git a/drivers/mtd/maps/pcmciamtd.c b/drivers/mtd/maps/pcmciamtd.c
index e9ca5ba7d9d2..fb3c5380aa84 100644
--- a/drivers/mtd/maps/pcmciamtd.c
+++ b/drivers/mtd/maps/pcmciamtd.c
@@ -101,7 +101,7 @@ MODULE_PARM_DESC(mem_type, "Set Memory type (0=Flash, 1=RAM, 2=ROM, default=0)")
 static caddr_t remap_window(struct map_info *map, unsigned long to)
 {
         struct pcmciamtd_dev *dev = (struct pcmciamtd_dev *)map->map_priv_1;
-        window_handle_t win = (window_handle_t)map->map_priv_2;
+        struct resource *win = (struct resource *) map->map_priv_2;
         unsigned int offset;
         int ret;
 
@@ -339,7 +339,7 @@ static void pcmciamtd_release(struct pcmcia_device *link)
 
         DEBUG(3, "link = 0x%p", link);
 
-        if (link->win) {
+        if (link->resource[2]->end) {
                 if(dev->win_base) {
                         iounmap(dev->win_base);
                         dev->win_base = NULL;
@@ -491,9 +491,8 @@ static int pcmciamtd_config(struct pcmcia_device *link)
 {
         struct pcmciamtd_dev *dev = link->priv;
         struct mtd_info *mtd = NULL;
-        win_req_t req;
         int ret;
-        int i;
+        int i, j = 0;
         static char *probes[] = { "jedec_probe", "cfi_probe" };
         int new_name = 0;
 
@@ -520,28 +519,34 @@ static int pcmciamtd_config(struct pcmcia_device *link)
          * smaller windows until we succeed
          */
 
-        req.Attributes =  WIN_MEMORY_TYPE_CM | WIN_ENABLE;
-        req.Attributes |= (dev->pcmcia_map.bankwidth == 1) ? WIN_DATA_WIDTH_8 : WIN_DATA_WIDTH_16;
-        req.Base = 0;
-        req.AccessSpeed = mem_speed;
-        link->win = (window_handle_t)link;
-        req.Size = (force_size) ? force_size << 20 : MAX_PCMCIA_ADDR;
+        link->resource[2]->flags |=  WIN_MEMORY_TYPE_CM | WIN_ENABLE;
+        link->resource[2]->flags |= (dev->pcmcia_map.bankwidth == 1) ?
+                                        WIN_DATA_WIDTH_8 : WIN_DATA_WIDTH_16;
+        link->resource[2]->start = 0;
+        link->resource[2]->end = (force_size) ? force_size << 20 :
+                                        MAX_PCMCIA_ADDR;
         dev->win_size = 0;
 
         do {
                 int ret;
-                DEBUG(2, "requesting window with size = %dKiB memspeed = %d",
-                      req.Size >> 10, req.AccessSpeed);
-                ret = pcmcia_request_window(link, &req, &link->win);
+                DEBUG(2, "requesting window with size = %luKiB memspeed = %d",
+                        (unsigned long) resource_size(link->resource[2]) >> 10,
+                        mem_speed);
+                ret = pcmcia_request_window(link, link->resource[2], mem_speed);
                 DEBUG(2, "ret = %d dev->win_size = %d", ret, dev->win_size);
                 if(ret) {
-                        req.Size >>= 1;
+                        j++;
+                        link->resource[2]->start = 0;
+                        link->resource[2]->end = (force_size) ?
+                                        force_size << 20 : MAX_PCMCIA_ADDR;
+                        link->resource[2]->end >>= j;
                 } else {
-                        DEBUG(2, "Got window of size %dKiB", req.Size >> 10);
-                        dev->win_size = req.Size;
+                        DEBUG(2, "Got window of size %luKiB", (unsigned long)
+                                resource_size(link->resource[2]) >> 10);
+                        dev->win_size = resource_size(link->resource[2]);
                         break;
                 }
-        } while(req.Size >= 0x1000);
+        } while (link->resource[2]->end >= 0x1000);
 
         DEBUG(2, "dev->win_size = %d", dev->win_size);
 
@@ -553,20 +558,20 @@ static int pcmciamtd_config(struct pcmcia_device *link)
         DEBUG(1, "Allocated a window of %dKiB", dev->win_size >> 10);
 
         /* Get write protect status */
-        DEBUG(2, "window handle = 0x%8.8lx", (unsigned long)link->win);
-        dev->win_base = ioremap(req.Base, req.Size);
+        dev->win_base = ioremap(link->resource[2]->start,
+                                resource_size(link->resource[2]));
         if(!dev->win_base) {
-                dev_err(&dev->p_dev->dev, "ioremap(%lu, %u) failed\n",
-                        req.Base, req.Size);
+                dev_err(&dev->p_dev->dev, "ioremap(%pR) failed\n",
+                        link->resource[2]);
                 pcmciamtd_release(link);
                 return -ENODEV;
         }
-        DEBUG(1, "mapped window dev = %p req.base = 0x%lx base = %p size = 0x%x",
-              dev, req.Base, dev->win_base, req.Size);
+        DEBUG(1, "mapped window dev = %p @ %pR, base = %p",
+              dev, link->resource[2], dev->win_base);
 
         dev->offset = 0;
         dev->pcmcia_map.map_priv_1 = (unsigned long)dev;
-        dev->pcmcia_map.map_priv_2 = (unsigned long)link->win;
+        dev->pcmcia_map.map_priv_2 = (unsigned long)link->resource[2];
 
         dev->vpp = (vpp) ? vpp : link->socket->socket.Vpp;
         link->conf.Attributes = 0;