UBI: Fix memory leak in ubi_attach_fastmap() error path

On error we have to free all three temporary lists.

Reported-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

1 files changed, 13 insertions, 0 deletions

diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index 05067f522476..4cfc8da27221 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -841,6 +841,19 @@ static int ubi_attach_fastmap(struct ubi_device *ubi,
 fail_bad:
         ret = UBI_BAD_FASTMAP;
 fail:
+        list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &used, u.list) {
+                kmem_cache_free(ai->aeb_slab_cache, tmp_aeb);
+                list_del(&tmp_aeb->u.list);
+        }
+        list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &eba_orphans, u.list) {
+                kmem_cache_free(ai->aeb_slab_cache, tmp_aeb);
+                list_del(&tmp_aeb->u.list);
+        }
+        list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &free, u.list) {
+                kmem_cache_free(ai->aeb_slab_cache, tmp_aeb);
+                list_del(&tmp_aeb->u.list);
+        }
+
         return ret;
 }