diff options
author | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2009-05-07 11:24:14 -0400 |
---|---|---|
committer | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2009-05-18 05:28:25 -0400 |
commit | e1cf7e6dd4ffd4391391e4e08b0fd44681b0e74d (patch) | |
tree | a80c1063b918485c037c4c1267296642ca6fabbf /drivers/mtd/ubi/kapi.c | |
parent | f089c0b28cdba1076aa8335dcaaaacc3dafc7d36 (diff) |
UBI: improve debugging messages
Various minor improvements to the debugging messages which
I found useful while hunting problems.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Diffstat (limited to 'drivers/mtd/ubi/kapi.c')
-rw-r--r-- | drivers/mtd/ubi/kapi.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c index 4abbe573fa40..2675207c5fe3 100644 --- a/drivers/mtd/ubi/kapi.c +++ b/drivers/mtd/ubi/kapi.c | |||
@@ -106,7 +106,7 @@ struct ubi_volume_desc *ubi_open_volume(int ubi_num, int vol_id, int mode) | |||
106 | struct ubi_device *ubi; | 106 | struct ubi_device *ubi; |
107 | struct ubi_volume *vol; | 107 | struct ubi_volume *vol; |
108 | 108 | ||
109 | dbg_gen("open device %d volume %d, mode %d", ubi_num, vol_id, mode); | 109 | dbg_gen("open device %d, volume %d, mode %d", ubi_num, vol_id, mode); |
110 | 110 | ||
111 | if (ubi_num < 0 || ubi_num >= UBI_MAX_DEVICES) | 111 | if (ubi_num < 0 || ubi_num >= UBI_MAX_DEVICES) |
112 | return ERR_PTR(-EINVAL); | 112 | return ERR_PTR(-EINVAL); |
@@ -196,6 +196,8 @@ out_free: | |||
196 | kfree(desc); | 196 | kfree(desc); |
197 | out_put_ubi: | 197 | out_put_ubi: |
198 | ubi_put_device(ubi); | 198 | ubi_put_device(ubi); |
199 | dbg_err("cannot open device %d, volume %d, error %d", | ||
200 | ubi_num, vol_id, err); | ||
199 | return ERR_PTR(err); | 201 | return ERR_PTR(err); |
200 | } | 202 | } |
201 | EXPORT_SYMBOL_GPL(ubi_open_volume); | 203 | EXPORT_SYMBOL_GPL(ubi_open_volume); |
@@ -215,7 +217,7 @@ struct ubi_volume_desc *ubi_open_volume_nm(int ubi_num, const char *name, | |||
215 | struct ubi_device *ubi; | 217 | struct ubi_device *ubi; |
216 | struct ubi_volume_desc *ret; | 218 | struct ubi_volume_desc *ret; |
217 | 219 | ||
218 | dbg_gen("open volume %s, mode %d", name, mode); | 220 | dbg_gen("open device %d, volume %s, mode %d", ubi_num, name, mode); |
219 | 221 | ||
220 | if (!name) | 222 | if (!name) |
221 | return ERR_PTR(-EINVAL); | 223 | return ERR_PTR(-EINVAL); |
@@ -266,7 +268,8 @@ void ubi_close_volume(struct ubi_volume_desc *desc) | |||
266 | struct ubi_volume *vol = desc->vol; | 268 | struct ubi_volume *vol = desc->vol; |
267 | struct ubi_device *ubi = vol->ubi; | 269 | struct ubi_device *ubi = vol->ubi; |
268 | 270 | ||
269 | dbg_gen("close volume %d, mode %d", vol->vol_id, desc->mode); | 271 | dbg_gen("close device %d, volume %d, mode %d", |
272 | ubi->ubi_num, vol->vol_id, desc->mode); | ||
270 | 273 | ||
271 | spin_lock(&ubi->volumes_lock); | 274 | spin_lock(&ubi->volumes_lock); |
272 | switch (desc->mode) { | 275 | switch (desc->mode) { |