diff options
author | Julia Lawall <julia@diku.dk> | 2010-05-13 16:03:15 -0400 |
---|---|---|
committer | David Woodhouse <David.Woodhouse@intel.com> | 2010-05-13 16:23:06 -0400 |
commit | 2bfefa4c9632fb09bfe3277cf7b690818b147654 (patch) | |
tree | 9ddbd55e57e266dfea47e38fa007f47731fed8fb /drivers/mtd/tests | |
parent | ecce2a6f9bdc7635838baeff8a09a76c9a70e7e0 (diff) |
drivers/mtd: Use kzalloc
Use kzalloc rather than the combination of kmalloc and memset.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,size,flags;
statement S;
@@
-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
if (x == NULL) S
-memset(x, 0, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd/tests')
-rw-r--r-- | drivers/mtd/tests/mtd_pagetest.c | 3 | ||||
-rw-r--r-- | drivers/mtd/tests/mtd_readtest.c | 3 | ||||
-rw-r--r-- | drivers/mtd/tests/mtd_speedtest.c | 3 | ||||
-rw-r--r-- | drivers/mtd/tests/mtd_stresstest.c | 3 | ||||
-rw-r--r-- | drivers/mtd/tests/mtd_subpagetest.c | 3 |
5 files changed, 5 insertions, 10 deletions
diff --git a/drivers/mtd/tests/mtd_pagetest.c b/drivers/mtd/tests/mtd_pagetest.c index 921a85df9196..6bc1b8276c62 100644 --- a/drivers/mtd/tests/mtd_pagetest.c +++ b/drivers/mtd/tests/mtd_pagetest.c | |||
@@ -480,12 +480,11 @@ static int scan_for_bad_eraseblocks(void) | |||
480 | { | 480 | { |
481 | int i, bad = 0; | 481 | int i, bad = 0; |
482 | 482 | ||
483 | bbt = kmalloc(ebcnt, GFP_KERNEL); | 483 | bbt = kzalloc(ebcnt, GFP_KERNEL); |
484 | if (!bbt) { | 484 | if (!bbt) { |
485 | printk(PRINT_PREF "error: cannot allocate memory\n"); | 485 | printk(PRINT_PREF "error: cannot allocate memory\n"); |
486 | return -ENOMEM; | 486 | return -ENOMEM; |
487 | } | 487 | } |
488 | memset(bbt, 0 , ebcnt); | ||
489 | 488 | ||
490 | printk(PRINT_PREF "scanning for bad eraseblocks\n"); | 489 | printk(PRINT_PREF "scanning for bad eraseblocks\n"); |
491 | for (i = 0; i < ebcnt; ++i) { | 490 | for (i = 0; i < ebcnt; ++i) { |
diff --git a/drivers/mtd/tests/mtd_readtest.c b/drivers/mtd/tests/mtd_readtest.c index 7107fccbc7de..afe71aa15c4b 100644 --- a/drivers/mtd/tests/mtd_readtest.c +++ b/drivers/mtd/tests/mtd_readtest.c | |||
@@ -141,12 +141,11 @@ static int scan_for_bad_eraseblocks(void) | |||
141 | { | 141 | { |
142 | int i, bad = 0; | 142 | int i, bad = 0; |
143 | 143 | ||
144 | bbt = kmalloc(ebcnt, GFP_KERNEL); | 144 | bbt = kzalloc(ebcnt, GFP_KERNEL); |
145 | if (!bbt) { | 145 | if (!bbt) { |
146 | printk(PRINT_PREF "error: cannot allocate memory\n"); | 146 | printk(PRINT_PREF "error: cannot allocate memory\n"); |
147 | return -ENOMEM; | 147 | return -ENOMEM; |
148 | } | 148 | } |
149 | memset(bbt, 0 , ebcnt); | ||
150 | 149 | ||
151 | /* NOR flash does not implement block_isbad */ | 150 | /* NOR flash does not implement block_isbad */ |
152 | if (mtd->block_isbad == NULL) | 151 | if (mtd->block_isbad == NULL) |
diff --git a/drivers/mtd/tests/mtd_speedtest.c b/drivers/mtd/tests/mtd_speedtest.c index 56ca62bb96bf..161feeb7b8b9 100644 --- a/drivers/mtd/tests/mtd_speedtest.c +++ b/drivers/mtd/tests/mtd_speedtest.c | |||
@@ -295,12 +295,11 @@ static int scan_for_bad_eraseblocks(void) | |||
295 | { | 295 | { |
296 | int i, bad = 0; | 296 | int i, bad = 0; |
297 | 297 | ||
298 | bbt = kmalloc(ebcnt, GFP_KERNEL); | 298 | bbt = kzalloc(ebcnt, GFP_KERNEL); |
299 | if (!bbt) { | 299 | if (!bbt) { |
300 | printk(PRINT_PREF "error: cannot allocate memory\n"); | 300 | printk(PRINT_PREF "error: cannot allocate memory\n"); |
301 | return -ENOMEM; | 301 | return -ENOMEM; |
302 | } | 302 | } |
303 | memset(bbt, 0 , ebcnt); | ||
304 | 303 | ||
305 | /* NOR flash does not implement block_isbad */ | 304 | /* NOR flash does not implement block_isbad */ |
306 | if (mtd->block_isbad == NULL) | 305 | if (mtd->block_isbad == NULL) |
diff --git a/drivers/mtd/tests/mtd_stresstest.c b/drivers/mtd/tests/mtd_stresstest.c index 3854afec56d0..531625fc9259 100644 --- a/drivers/mtd/tests/mtd_stresstest.c +++ b/drivers/mtd/tests/mtd_stresstest.c | |||
@@ -221,12 +221,11 @@ static int scan_for_bad_eraseblocks(void) | |||
221 | { | 221 | { |
222 | int i, bad = 0; | 222 | int i, bad = 0; |
223 | 223 | ||
224 | bbt = kmalloc(ebcnt, GFP_KERNEL); | 224 | bbt = kzalloc(ebcnt, GFP_KERNEL); |
225 | if (!bbt) { | 225 | if (!bbt) { |
226 | printk(PRINT_PREF "error: cannot allocate memory\n"); | 226 | printk(PRINT_PREF "error: cannot allocate memory\n"); |
227 | return -ENOMEM; | 227 | return -ENOMEM; |
228 | } | 228 | } |
229 | memset(bbt, 0 , ebcnt); | ||
230 | 229 | ||
231 | /* NOR flash does not implement block_isbad */ | 230 | /* NOR flash does not implement block_isbad */ |
232 | if (mtd->block_isbad == NULL) | 231 | if (mtd->block_isbad == NULL) |
diff --git a/drivers/mtd/tests/mtd_subpagetest.c b/drivers/mtd/tests/mtd_subpagetest.c index 700237a3d120..11204e8aab5f 100644 --- a/drivers/mtd/tests/mtd_subpagetest.c +++ b/drivers/mtd/tests/mtd_subpagetest.c | |||
@@ -354,12 +354,11 @@ static int scan_for_bad_eraseblocks(void) | |||
354 | { | 354 | { |
355 | int i, bad = 0; | 355 | int i, bad = 0; |
356 | 356 | ||
357 | bbt = kmalloc(ebcnt, GFP_KERNEL); | 357 | bbt = kzalloc(ebcnt, GFP_KERNEL); |
358 | if (!bbt) { | 358 | if (!bbt) { |
359 | printk(PRINT_PREF "error: cannot allocate memory\n"); | 359 | printk(PRINT_PREF "error: cannot allocate memory\n"); |
360 | return -ENOMEM; | 360 | return -ENOMEM; |
361 | } | 361 | } |
362 | memset(bbt, 0 , ebcnt); | ||
363 | 362 | ||
364 | printk(PRINT_PREF "scanning for bad eraseblocks\n"); | 363 | printk(PRINT_PREF "scanning for bad eraseblocks\n"); |
365 | for (i = 0; i < ebcnt; ++i) { | 364 | for (i = 0; i < ebcnt; ++i) { |