aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mtd/tests/mtd_nandecctest.c
diff options
context:
space:
mode:
authorAkinobu Mita <akinobu.mita@gmail.com>2012-09-03 09:00:00 -0400
committerDavid Woodhouse <David.Woodhouse@intel.com>2012-09-29 10:34:28 -0400
commitc5b8384abc11fd566a3633b7bd7d476ff04c31af (patch)
tree56300c4ddd9b4611757b3d1583dbc758feb8eb74 /drivers/mtd/tests/mtd_nandecctest.c
parentbb82477ebede3d0c37a502a899b68eb45fefca4f (diff)
mtd: mtd_nandecctest: improve message output
This includes the message related changes: - Use pr_* instead of printk - Print hexdump of ECC code if test fails - Change log level for hexdump of data from KERN_DEBUG to KERN_INFO - Factor out the hexdump code into a separate function Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd/tests/mtd_nandecctest.c')
-rw-r--r--drivers/mtd/tests/mtd_nandecctest.c48
1 files changed, 29 insertions, 19 deletions
diff --git a/drivers/mtd/tests/mtd_nandecctest.c b/drivers/mtd/tests/mtd_nandecctest.c
index 128547c5bd55..2b2d1a90417b 100644
--- a/drivers/mtd/tests/mtd_nandecctest.c
+++ b/drivers/mtd/tests/mtd_nandecctest.c
@@ -15,41 +15,51 @@ static void inject_single_bit_error(void *data, size_t size)
15 __change_bit(offset, data); 15 __change_bit(offset, data);
16} 16}
17 17
18static unsigned char data[512]; 18static void dump_data_ecc(void *error_data, void *error_ecc, void *correct_data,
19 void *correct_ecc, const size_t size)
20{
21 pr_info("hexdump of error data:\n");
22 print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 16, 4,
23 error_data, size, false);
24 print_hex_dump(KERN_INFO, "hexdump of error ecc: ",
25 DUMP_PREFIX_NONE, 16, 1, error_ecc, 3, false);
26
27 pr_info("hexdump of correct data:\n");
28 print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 16, 4,
29 correct_data, size, false);
30 print_hex_dump(KERN_INFO, "hexdump of correct ecc: ",
31 DUMP_PREFIX_NONE, 16, 1, correct_ecc, 3, false);
32}
33
34static unsigned char correct_data[512];
19static unsigned char error_data[512]; 35static unsigned char error_data[512];
20 36
21static int nand_ecc_test(const size_t size) 37static int nand_ecc_test(const size_t size)
22{ 38{
23 unsigned char code[3]; 39 unsigned char correct_ecc[3];
24 unsigned char error_code[3]; 40 unsigned char error_ecc[3];
25 char testname[30]; 41 char testname[30];
26 42
27 BUG_ON(sizeof(data) < size); 43 BUG_ON(sizeof(correct_data) < size);
28 44
29 sprintf(testname, "nand-ecc-%zu", size); 45 sprintf(testname, "nand-ecc-%zu", size);
30 46
31 get_random_bytes(data, size); 47 get_random_bytes(correct_data, size);
32 48
33 memcpy(error_data, data, size); 49 memcpy(error_data, correct_data, size);
34 inject_single_bit_error(error_data, size); 50 inject_single_bit_error(error_data, size);
35 51
36 __nand_calculate_ecc(data, size, code); 52 __nand_calculate_ecc(correct_data, size, correct_ecc);
37 __nand_calculate_ecc(error_data, size, error_code); 53 __nand_calculate_ecc(error_data, size, error_ecc);
38 __nand_correct_data(error_data, code, error_code, size); 54 __nand_correct_data(error_data, correct_ecc, error_ecc, size);
39 55
40 if (!memcmp(data, error_data, size)) { 56 if (!memcmp(correct_data, error_data, size)) {
41 printk(KERN_INFO "mtd_nandecctest: ok - %s\n", testname); 57 pr_info("mtd_nandecctest: ok - %s\n", testname);
42 return 0; 58 return 0;
43 } 59 }
44 60
45 printk(KERN_ERR "mtd_nandecctest: not ok - %s\n", testname); 61 pr_err("mtd_nandecctest: not ok - %s\n", testname);
46 62 dump_data_ecc(error_data, error_ecc, correct_data, correct_ecc, size);
47 printk(KERN_DEBUG "hexdump of data:\n");
48 print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 4,
49 data, size, false);
50 printk(KERN_DEBUG "hexdump of error data:\n");
51 print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 4,
52 error_data, size, false);
53 63
54 return -EINVAL; 64 return -EINVAL;
55} 65}