diff options
author | Roman Tereshonkov <roman.tereshonkov@nokia.com> | 2011-02-08 05:02:42 -0500 |
---|---|---|
committer | David Woodhouse <David.Woodhouse@intel.com> | 2011-03-11 09:22:45 -0500 |
commit | e6da85685b2dec1e69e58366c22d1f883d6da575 (patch) | |
tree | 32ff27bcf6b566098a4569e1f7c1a84b351ba5d7 /drivers/mtd/onenand | |
parent | b085058fe556328443f982d892c9657b3aff9d4a (diff) |
mtd: onenand_base: onenand_verify bugfix for writepage non-aligned address
In onenand_verify function the address can be writepage non-aligned.
When a page is read for comparing the right offset should be used
for "this->verify_buf" to get the right matching with compared
"buf" buffer.
Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd/onenand')
-rw-r--r-- | drivers/mtd/onenand/onenand_base.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 38e6d76bcc0e..4205b9423b89 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c | |||
@@ -1648,11 +1648,10 @@ static int onenand_verify(struct mtd_info *mtd, const u_char *buf, loff_t addr, | |||
1648 | int ret = 0; | 1648 | int ret = 0; |
1649 | int thislen, column; | 1649 | int thislen, column; |
1650 | 1650 | ||
1651 | column = addr & (this->writesize - 1); | ||
1652 | |||
1651 | while (len != 0) { | 1653 | while (len != 0) { |
1652 | thislen = min_t(int, this->writesize, len); | 1654 | thislen = min_t(int, this->writesize - column, len); |
1653 | column = addr & (this->writesize - 1); | ||
1654 | if (column + thislen > this->writesize) | ||
1655 | thislen = this->writesize - column; | ||
1656 | 1655 | ||
1657 | this->command(mtd, ONENAND_CMD_READ, addr, this->writesize); | 1656 | this->command(mtd, ONENAND_CMD_READ, addr, this->writesize); |
1658 | 1657 | ||
@@ -1666,12 +1665,13 @@ static int onenand_verify(struct mtd_info *mtd, const u_char *buf, loff_t addr, | |||
1666 | 1665 | ||
1667 | this->read_bufferram(mtd, ONENAND_DATARAM, this->verify_buf, 0, mtd->writesize); | 1666 | this->read_bufferram(mtd, ONENAND_DATARAM, this->verify_buf, 0, mtd->writesize); |
1668 | 1667 | ||
1669 | if (memcmp(buf, this->verify_buf, thislen)) | 1668 | if (memcmp(buf, this->verify_buf + column, thislen)) |
1670 | return -EBADMSG; | 1669 | return -EBADMSG; |
1671 | 1670 | ||
1672 | len -= thislen; | 1671 | len -= thislen; |
1673 | buf += thislen; | 1672 | buf += thislen; |
1674 | addr += thislen; | 1673 | addr += thislen; |
1674 | column = 0; | ||
1675 | } | 1675 | } |
1676 | 1676 | ||
1677 | return 0; | 1677 | return 0; |