mtd: do not duplicate length and offset checks in drivers

We already verify that offset and length are within the MTD device size
in the MTD API functions. Let's remove the duplicated checks in drivers.
This patch only affects the following API's:

'mtd_erase()'
'mtd_point()'
'mtd_unpoint()'
'mtd_get_unmapped_area()'
'mtd_read()'
'mtd_write()'
'mtd_panic_write()'
'mtd_lock()'
'mtd_unlock()'
'mtd_is_locked()'
'mtd_block_isbad()'
'mtd_block_markbad()'

This patch adds a bit of noise by removing too sparse empty lines, but this is
not too bad.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

1 files changed, 0 insertions, 28 deletions

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 13a56d3e8aec..dd182c8591a9 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -123,12 +123,6 @@ static int check_offs_len(struct mtd_info *mtd,
                 ret = -EINVAL;
         }
 
-        /* Do not allow past end of device */
-        if (ofs + len > mtd->size) {
-                pr_debug("%s: past end of device\n", __func__);
-                ret = -EINVAL;
-        }
-
         return ret;
 }
 
@@ -1620,25 +1614,17 @@ static int nand_read(struct mtd_info *mtd, loff_t from, size_t len,
         struct mtd_oob_ops ops;
         int ret;
 
-        /* Do not allow reads past end of device */
-        if ((from + len) > mtd->size)
-                return -EINVAL;
         if (!len)
                 return 0;
 
         nand_get_device(chip, mtd, FL_READING);
-
         ops.len = len;
         ops.datbuf = buf;
         ops.oobbuf = NULL;
         ops.mode = 0;
-
         ret = nand_do_read_ops(mtd, from, &ops);
-
         *retlen = ops.retlen;
-
         nand_release_device(mtd);
-
         return ret;
 }
 
@@ -2328,8 +2314,6 @@ static int panic_nand_write(struct mtd_info *mtd, loff_t to, size_t len,
         int ret;
 
         /* Do not allow reads past end of device */
-        if ((to + len) > mtd->size)
-                return -EINVAL;
         if (!len)
                 return 0;
 
@@ -2367,25 +2351,17 @@ static int nand_write(struct mtd_info *mtd, loff_t to, size_t len,
         struct mtd_oob_ops ops;
         int ret;
 
-        /* Do not allow reads past end of device */
-        if ((to + len) > mtd->size)
-                return -EINVAL;
         if (!len)
                 return 0;
 
         nand_get_device(chip, mtd, FL_WRITING);
-
         ops.len = len;
         ops.datbuf = (uint8_t *)buf;
         ops.oobbuf = NULL;
         ops.mode = 0;
-
         ret = nand_do_write_ops(mtd, to, &ops);
-
         *retlen = ops.retlen;
-
         nand_release_device(mtd);
-
         return ret;
 }
 
@@ -2749,10 +2725,6 @@ static void nand_sync(struct mtd_info *mtd)
  */
 static int nand_block_isbad(struct mtd_info *mtd, loff_t offs)
 {
-        /* Check for invalid offset */
-        if (offs > mtd->size)
-                return -EINVAL;
-
         return nand_block_checkbad(mtd, offs, 1, 0);
 }