diff options
author | Huang Shijie <shijie8@gmail.com> | 2012-08-14 22:38:45 -0400 |
---|---|---|
committer | David Woodhouse <David.Woodhouse@intel.com> | 2012-09-29 10:00:46 -0400 |
commit | 657f28f8811c92724db10d18bbbec70d540147d6 (patch) | |
tree | 1d8cb32d57eec27f46a74cad73a1ceff43f5e099 /drivers/mtd/nand/omap2.c | |
parent | 8da28681eb1430fb6715c7aef67001acfbbbcba5 (diff) |
mtd: kill MTD_NAND_VERIFY_WRITE
Just as Artem suggested:
"Both UBI and JFFS2 are able to read verify what they wrote already.
There are also MTD tests which do this verification. So I think there
is no reason to keep this in the NAND layer, let alone wasting RAM in
the driver to support this feature. Besides, it does not work for sub-pages
and many drivers have it broken. It hurts more than it provides benefits."
So kill MTD_NAND_VERIFY_WRITE entirely.
Signed-off-by: Huang Shijie <shijie8@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd/nand/omap2.c')
-rw-r--r-- | drivers/mtd/nand/omap2.c | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 1ede9fb43430..f47c422c7dfd 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c | |||
@@ -614,27 +614,6 @@ out_copy: | |||
614 | } | 614 | } |
615 | 615 | ||
616 | /** | 616 | /** |
617 | * omap_verify_buf - Verify chip data against buffer | ||
618 | * @mtd: MTD device structure | ||
619 | * @buf: buffer containing the data to compare | ||
620 | * @len: number of bytes to compare | ||
621 | */ | ||
622 | static int omap_verify_buf(struct mtd_info *mtd, const u_char * buf, int len) | ||
623 | { | ||
624 | struct omap_nand_info *info = container_of(mtd, struct omap_nand_info, | ||
625 | mtd); | ||
626 | u16 *p = (u16 *) buf; | ||
627 | |||
628 | len >>= 1; | ||
629 | while (len--) { | ||
630 | if (*p++ != cpu_to_le16(readw(info->nand.IO_ADDR_R))) | ||
631 | return -EFAULT; | ||
632 | } | ||
633 | |||
634 | return 0; | ||
635 | } | ||
636 | |||
637 | /** | ||
638 | * gen_true_ecc - This function will generate true ECC value | 617 | * gen_true_ecc - This function will generate true ECC value |
639 | * @ecc_buf: buffer to store ecc code | 618 | * @ecc_buf: buffer to store ecc code |
640 | * | 619 | * |
@@ -1285,8 +1264,6 @@ static int __devinit omap_nand_probe(struct platform_device *pdev) | |||
1285 | goto out_release_mem_region; | 1264 | goto out_release_mem_region; |
1286 | } | 1265 | } |
1287 | 1266 | ||
1288 | info->nand.verify_buf = omap_verify_buf; | ||
1289 | |||
1290 | /* select the ecc type */ | 1267 | /* select the ecc type */ |
1291 | if (pdata->ecc_opt == OMAP_ECC_HAMMING_CODE_DEFAULT) | 1268 | if (pdata->ecc_opt == OMAP_ECC_HAMMING_CODE_DEFAULT) |
1292 | info->nand.ecc.mode = NAND_ECC_SOFT; | 1269 | info->nand.ecc.mode = NAND_ECC_SOFT; |