aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mtd/nand/davinci_nand.c
diff options
context:
space:
mode:
authorIvan Khoronzhuk <ivan.khoronzhuk@ti.com>2013-12-17 08:33:50 -0500
committerBrian Norris <computersforpeace@gmail.com>2014-01-03 14:22:24 -0500
commiteaaa4a9af3f553dd07e1a21bbf857933ec9032f0 (patch)
tree62f7269f5aaef215959973411815509c888ebb2b /drivers/mtd/nand/davinci_nand.c
parenta1d7994e639c33926405448c50831d0b3e28dddc (diff)
mtd: nand: davinci: fix driver registration
When kernel is booted using DT, there is no guarantee that Davinci NAND device has been created already at the time when driver init function is executed. Therefore, platform_driver_probe() can't be used because this may result the Davinci NAND driver will never be probed. The driver probing has to be made with core mechanism. Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> Reviewed-by: Taras Kondratiuk <taras@ti.com> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'drivers/mtd/nand/davinci_nand.c')
-rw-r--r--drivers/mtd/nand/davinci_nand.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index b77a01efb483..584c1f4b6fce 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -487,7 +487,7 @@ static int nand_davinci_dev_ready(struct mtd_info *mtd)
487 * ten ECC bytes plus the manufacturer's bad block marker byte, and 487 * ten ECC bytes plus the manufacturer's bad block marker byte, and
488 * and not overlapping the default BBT markers. 488 * and not overlapping the default BBT markers.
489 */ 489 */
490static struct nand_ecclayout hwecc4_small __initconst = { 490static struct nand_ecclayout hwecc4_small = {
491 .eccbytes = 10, 491 .eccbytes = 10,
492 .eccpos = { 0, 1, 2, 3, 4, 492 .eccpos = { 0, 1, 2, 3, 4,
493 /* offset 5 holds the badblock marker */ 493 /* offset 5 holds the badblock marker */
@@ -503,7 +503,7 @@ static struct nand_ecclayout hwecc4_small __initconst = {
503 * storing ten ECC bytes plus the manufacturer's bad block marker byte, 503 * storing ten ECC bytes plus the manufacturer's bad block marker byte,
504 * and not overlapping the default BBT markers. 504 * and not overlapping the default BBT markers.
505 */ 505 */
506static struct nand_ecclayout hwecc4_2048 __initconst = { 506static struct nand_ecclayout hwecc4_2048 = {
507 .eccbytes = 40, 507 .eccbytes = 40,
508 .eccpos = { 508 .eccpos = {
509 /* at the end of spare sector */ 509 /* at the end of spare sector */
@@ -585,7 +585,7 @@ static struct davinci_nand_pdata
585} 585}
586#endif 586#endif
587 587
588static int __init nand_davinci_probe(struct platform_device *pdev) 588static int nand_davinci_probe(struct platform_device *pdev)
589{ 589{
590 struct davinci_nand_pdata *pdata; 590 struct davinci_nand_pdata *pdata;
591 struct davinci_nand_info *info; 591 struct davinci_nand_info *info;
@@ -860,7 +860,7 @@ err_nomem:
860 return ret; 860 return ret;
861} 861}
862 862
863static int __exit nand_davinci_remove(struct platform_device *pdev) 863static int nand_davinci_remove(struct platform_device *pdev)
864{ 864{
865 struct davinci_nand_info *info = platform_get_drvdata(pdev); 865 struct davinci_nand_info *info = platform_get_drvdata(pdev);
866 866
@@ -877,7 +877,8 @@ static int __exit nand_davinci_remove(struct platform_device *pdev)
877} 877}
878 878
879static struct platform_driver nand_davinci_driver = { 879static struct platform_driver nand_davinci_driver = {
880 .remove = __exit_p(nand_davinci_remove), 880 .probe = nand_davinci_probe,
881 .remove = nand_davinci_remove,
881 .driver = { 882 .driver = {
882 .name = "davinci_nand", 883 .name = "davinci_nand",
883 .owner = THIS_MODULE, 884 .owner = THIS_MODULE,
@@ -886,7 +887,7 @@ static struct platform_driver nand_davinci_driver = {
886}; 887};
887MODULE_ALIAS("platform:davinci_nand"); 888MODULE_ALIAS("platform:davinci_nand");
888 889
889module_platform_driver_probe(nand_davinci_driver, nand_davinci_probe); 890module_platform_driver(nand_davinci_driver);
890 891
891MODULE_LICENSE("GPL"); 892MODULE_LICENSE("GPL");
892MODULE_AUTHOR("Texas Instruments"); 893MODULE_AUTHOR("Texas Instruments");