[MTD] Rework the out of band handling completely

Hopefully the last iteration on this!

The handling of out of band data on NAND was accompanied by tons of fruitless
discussions and halfarsed patches to make it work for a particular
problem. Sufficiently annoyed by I all those "I know it better" mails and the
resonable amount of discarded "it solves my problem" patches, I finally decided
to go for the big rework. After removing the _ecc variants of mtd read/write
functions the solution to satisfy the various requirements was to refactor the
read/write _oob functions in mtd.

The major change is that read/write_oob now takes a pointer to an operation
descriptor structure "struct mtd_oob_ops".instead of having a function with at
least seven arguments.

read/write_oob which should probably renamed to a more descriptive name, can do
the following tasks:

- read/write out of band data
- read/write data content and out of band data
- read/write raw data content and out of band data (ecc disabled)

struct mtd_oob_ops has a mode field, which determines the oob handling mode.

Aside of the MTD_OOB_RAW mode, which is intended to be especially for
diagnostic purposes and some internal functions e.g. bad block table creation,
the other two modes are for mtd clients:

MTD_OOB_PLACE puts/gets the given oob data exactly to/from the place which is
described by the ooboffs and ooblen fields of the mtd_oob_ops strcuture. It's
up to the caller to make sure that the byte positions are not used by the ECC
placement algorithms.

MTD_OOB_AUTO puts/gets the given oob data automaticaly to/from the places in
the out of band area which are described by the oobfree tuples in the ecclayout
data structre which is associated to the devicee.

The decision whether data plus oob or oob only handling is done depends on the
setting of the datbuf member of the data structure. When datbuf == NULL then
the internal read/write_oob functions are selected, otherwise the read/write
data routines are invoked.

Tested on a few platforms with all variants. Please be aware of possible
regressions for your particular device / application scenario

Disclaimer: Any whining will be ignored from those who just contributed "hot
air blurb" and never sat down to tackle the underlying problem of the mess in
the NAND driver grown over time and the big chunk of work to fix up the
existing users. The problem was not the holiness of the existing MTD
interfaces. The problems was the lack of time to go for the big overhaul. It's
easy to add more mess to the existing one, but it takes alot of effort to go
for a real solution.

Improvements and bugfixes are welcome!

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

1 files changed, 39 insertions, 20 deletions

diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index b45e7747daa3..7522fc3a2827 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -408,8 +408,7 @@ static int mtd_ioctl(struct inode *inode, struct file *file,
         case MEMWRITEOOB:
         {
                 struct mtd_oob_buf buf;
-                void *databuf;
-                ssize_t retlen;
+                struct mtd_oob_ops ops;
 
                 if(!(file->f_mode & 2))
                         return -EPERM;
@@ -417,7 +416,7 @@ static int mtd_ioctl(struct inode *inode, struct file *file,
                 if (copy_from_user(&buf, argp, sizeof(struct mtd_oob_buf)))
                         return -EFAULT;
 
-                if (buf.length > 0x4096)
+                if (buf.length > 4096)
                         return -EINVAL;
 
                 if (!mtd->write_oob)
@@ -429,21 +428,32 @@ static int mtd_ioctl(struct inode *inode, struct file *file,
                 if (ret)
                         return ret;
 
-                databuf = kmalloc(buf.length, GFP_KERNEL);
-                if (!databuf)
+                ops.len = buf.length;
+                ops.ooblen = mtd->oobsize;
+                ops.ooboffs = buf.start & (mtd->oobsize - 1);
+                ops.datbuf = NULL;
+                ops.mode = MTD_OOB_PLACE;
+
+                if (ops.ooboffs && ops.len > (ops.ooblen - ops.ooboffs))
+                        return -EINVAL;
+
+                ops.oobbuf = kmalloc(buf.length, GFP_KERNEL);
+                if (!ops.oobbuf)
                         return -ENOMEM;
 
-                if (copy_from_user(databuf, buf.ptr, buf.length)) {
-                        kfree(databuf);
+                if (copy_from_user(ops.oobbuf, buf.ptr, buf.length)) {
+                        kfree(ops.oobbuf);
                         return -EFAULT;
                 }
 
-                ret = (mtd->write_oob)(mtd, buf.start, buf.length, &retlen, databuf);
+                buf.start &= ~(mtd->oobsize - 1);
+                ret = mtd->write_oob(mtd, buf.start, &ops);
 
-                if (copy_to_user(argp + sizeof(uint32_t), &retlen, sizeof(uint32_t)))
+                if (copy_to_user(argp + sizeof(uint32_t), &ops.retlen,
+                                 sizeof(uint32_t)))
                         ret = -EFAULT;
 
-                kfree(databuf);
+                kfree(ops.oobbuf);
                 break;
 
         }
@@ -451,13 +461,12 @@ static int mtd_ioctl(struct inode *inode, struct file *file,
         case MEMREADOOB:
         {
                 struct mtd_oob_buf buf;
-                void *databuf;
-                ssize_t retlen;
+                struct mtd_oob_ops ops;
 
                 if (copy_from_user(&buf, argp, sizeof(struct mtd_oob_buf)))
                         return -EFAULT;
 
-                if (buf.length > 0x4096)
+                if (buf.length > 4096)
                         return -EINVAL;
 
                 if (!mtd->read_oob)
@@ -465,22 +474,32 @@ static int mtd_ioctl(struct inode *inode, struct file *file,
                 else
                         ret = access_ok(VERIFY_WRITE, buf.ptr,
                                         buf.length) ? 0 : -EFAULT;
-
                 if (ret)
                         return ret;
 
-                databuf = kmalloc(buf.length, GFP_KERNEL);
-                if (!databuf)
+                ops.len = buf.length;
+                ops.ooblen = mtd->oobsize;
+                ops.ooboffs = buf.start & (mtd->oobsize - 1);
+                ops.datbuf = NULL;
+                ops.mode = MTD_OOB_PLACE;
+
+                if (ops.ooboffs && ops.len > (ops.ooblen - ops.ooboffs))
+                        return -EINVAL;
+
+                ops.oobbuf = kmalloc(buf.length, GFP_KERNEL);
+                if (!ops.oobbuf)
                         return -ENOMEM;
 
-                ret = (mtd->read_oob)(mtd, buf.start, buf.length, &retlen, databuf);
+                buf.start &= ~(mtd->oobsize - 1);
+                ret = mtd->read_oob(mtd, buf.start, &ops);
 
-                if (put_user(retlen, (uint32_t __user *)argp))
+                if (put_user(ops.retlen, (uint32_t __user *)argp))
                         ret = -EFAULT;
-                else if (retlen && copy_to_user(buf.ptr, databuf, retlen))
+                else if (ops.retlen && copy_to_user(buf.ptr, ops.oobbuf,
+                                                    ops.retlen))
                         ret = -EFAULT;
 
-                kfree(databuf);
+                kfree(ops.oobbuf);
                 break;
         }