diff options
author | Amol Lad <amol@verismonetworks.com> | 2006-09-21 08:42:43 -0400 |
---|---|---|
committer | David Woodhouse <dwmw2@infradead.org> | 2006-09-22 05:24:31 -0400 |
commit | 25f0c659fe64832d8ee06aa623fffaad708dcf8b (patch) | |
tree | b5740156ac2ce5e39aaaba32ddb21b03379abb48 /drivers/mtd/maps/ocotea.c | |
parent | dd8e9ed6ed544e2b924429d29cd2a6b55590109b (diff) |
ioremap balanced with iounmap for drivers/mtd subsystem
ioremap must be balanced by an iounmap and failing to do so can result
in a memory leak.
Tested (compilation only) with:
- allmodconfig
- Modifying drivers/mtd/maps/Kconfig and drivers/mtd/nand/Kconfig to
make sure that the changed file is compiling without warning
Signed-off-by: Amol Lad <amol@verismonetworks.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Diffstat (limited to 'drivers/mtd/maps/ocotea.c')
-rw-r--r-- | drivers/mtd/maps/ocotea.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/mtd/maps/ocotea.c b/drivers/mtd/maps/ocotea.c index 2f07602ba940..5522eac8c980 100644 --- a/drivers/mtd/maps/ocotea.c +++ b/drivers/mtd/maps/ocotea.c | |||
@@ -97,6 +97,7 @@ int __init init_ocotea(void) | |||
97 | ARRAY_SIZE(ocotea_small_partitions)); | 97 | ARRAY_SIZE(ocotea_small_partitions)); |
98 | } else { | 98 | } else { |
99 | printk("map probe failed for flash\n"); | 99 | printk("map probe failed for flash\n"); |
100 | iounmap(ocotea_small_map.virt); | ||
100 | return -ENXIO; | 101 | return -ENXIO; |
101 | } | 102 | } |
102 | 103 | ||
@@ -106,6 +107,7 @@ int __init init_ocotea(void) | |||
106 | 107 | ||
107 | if (!ocotea_large_map.virt) { | 108 | if (!ocotea_large_map.virt) { |
108 | printk("Failed to ioremap flash\n"); | 109 | printk("Failed to ioremap flash\n"); |
110 | iounmap(ocotea_small_map.virt); | ||
109 | return -EIO; | 111 | return -EIO; |
110 | } | 112 | } |
111 | 113 | ||
@@ -118,6 +120,8 @@ int __init init_ocotea(void) | |||
118 | ARRAY_SIZE(ocotea_large_partitions)); | 120 | ARRAY_SIZE(ocotea_large_partitions)); |
119 | } else { | 121 | } else { |
120 | printk("map probe failed for flash\n"); | 122 | printk("map probe failed for flash\n"); |
123 | iounmap(ocotea_small_map.virt); | ||
124 | iounmap(ocotea_large_map.virt); | ||
121 | return -ENXIO; | 125 | return -ENXIO; |
122 | } | 126 | } |
123 | 127 | ||