[MTD] Remove silly MTD_WRITE/READ macros

Most of those macros are unused and the used ones just obfuscate
the code. Remove them and fixup all users.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

1 files changed, 24 insertions, 19 deletions

diff --git a/drivers/mtd/inftlmount.c b/drivers/mtd/inftlmount.c
index f89a03795e76..b4cda7d0a52d 100644
--- a/drivers/mtd/inftlmount.c
+++ b/drivers/mtd/inftlmount.c
@@ -57,6 +57,7 @@ static int find_boot_record(struct INFTLrecord *inftl)
         unsigned int i, block;
         u8 buf[SECTORSIZE];
         struct INFTLMediaHeader *mh = &inftl->MediaHdr;
+        struct mtd_info *mtd = inftl->mbd.mtd;
         struct INFTLPartition *ip;
         size_t retlen;
 
@@ -80,8 +81,8 @@ static int find_boot_record(struct INFTLrecord *inftl)
                  * Check for BNAND header first. Then whinge if it's found
                  * but later checks fail.
                  */
-                ret = MTD_READ(inftl->mbd.mtd, block * inftl->EraseSize,
-                    SECTORSIZE, &retlen, buf);
+                ret = mtd->read(mtd, block * inftl->EraseSize,
+                                SECTORSIZE, &retlen, buf);
                 /* We ignore ret in case the ECC of the MediaHeader is invalid
                    (which is apparently acceptable) */
                 if (retlen != SECTORSIZE) {
@@ -106,8 +107,9 @@ static int find_boot_record(struct INFTLrecord *inftl)
                 }
 
                 /* To be safer with BIOS, also use erase mark as discriminant */
-                if ((ret = MTD_READOOB(inftl->mbd.mtd, block * inftl->EraseSize +
-                    SECTORSIZE + 8, 8, &retlen, (char *)&h1) < 0)) {
+                if ((ret = mtd->read_oob(mtd, block * inftl->EraseSize +
+                                         SECTORSIZE + 8, 8, &retlen,
+                                         (char *)&h1) < 0)) {
                         printk(KERN_WARNING "INFTL: ANAND header found at "
                                 "0x%x in mtd%d, but OOB data read failed "
                                 "(err %d)\n", block * inftl->EraseSize,
@@ -123,8 +125,8 @@ static int find_boot_record(struct INFTLrecord *inftl)
                 memcpy(mh, buf, sizeof(struct INFTLMediaHeader));
 
                 /* Read the spare media header at offset 4096 */
-                MTD_READ(inftl->mbd.mtd, block * inftl->EraseSize + 4096,
-                    SECTORSIZE, &retlen, buf);
+                mtd->read(mtd, block * inftl->EraseSize + 4096,
+                          SECTORSIZE, &retlen, buf);
                 if (retlen != SECTORSIZE) {
                         printk(KERN_WARNING "INFTL: Unable to read spare "
                                "Media Header\n");
@@ -233,7 +235,7 @@ static int find_boot_record(struct INFTLrecord *inftl)
                                  */
                                 instr->addr = ip->Reserved0 * inftl->EraseSize;
                                 instr->len = inftl->EraseSize;
-                                MTD_ERASE(inftl->mbd.mtd, instr);
+                                mtd->erase(mtd, instr);
                         }
                         if ((ip->lastUnit - ip->firstUnit + 1) < ip->virtualUnits) {
                                 printk(KERN_WARNING "INFTL: Media Header "
@@ -387,6 +389,7 @@ int INFTL_formatblock(struct INFTLrecord *inftl, int block)
         size_t retlen;
         struct inftl_unittail uci;
         struct erase_info *instr = &inftl->instr;
+        struct mtd_info *mtd = inftl->mbd.mtd;
         int physblock;
 
         DEBUG(MTD_DEBUG_LEVEL3, "INFTL: INFTL_formatblock(inftl=%p,"
@@ -404,8 +407,9 @@ int INFTL_formatblock(struct INFTLrecord *inftl, int block)
         /* Erase one physical eraseblock at a time, even though the NAND api
            allows us to group them.  This way we if we have a failure, we can
            mark only the failed block in the bbt. */
-        for (physblock = 0; physblock < inftl->EraseSize; physblock += instr->len, instr->addr += instr->len) {
-                MTD_ERASE(inftl->mbd.mtd, instr);
+        for (physblock = 0; physblock < inftl->EraseSize;
+             physblock += instr->len, instr->addr += instr->len) {
+                mtd->erase(inftl->mbd.mtd, instr);
 
                 if (instr->state == MTD_ERASE_FAILED) {
                         printk(KERN_WARNING "INFTL: error while formatting block %d\n",
@@ -414,10 +418,10 @@ int INFTL_formatblock(struct INFTLrecord *inftl, int block)
                 }
 
                 /*
-                * Check the "freeness" of Erase Unit before updating metadata.
-                * FixMe: is this check really necessary? Since we have check the
-                *        return code after the erase operation.
-                */
+                 * Check the "freeness" of Erase Unit before updating metadata.
+                 * FixMe: is this check really necessary? Since we have check
+                 * the return code after the erase operation.
+                 */
                 if (check_free_sectors(inftl, instr->addr, instr->len, 1) != 0)
                         goto fail;
         }
@@ -429,8 +433,7 @@ int INFTL_formatblock(struct INFTLrecord *inftl, int block)
         uci.Reserved[2] = 0;
         uci.Reserved[3] = 0;
         instr->addr = block * inftl->EraseSize + SECTORSIZE * 2;
-        if (MTD_WRITEOOB(inftl->mbd.mtd, instr->addr +
-            8, 8, &retlen, (char *)&uci) < 0)
+        if (mtd->write_oob(mtd, instr->addr + 8, 8, &retlen, (char *)&uci) < 0)
                 goto fail;
         return 0;
 fail:
@@ -549,6 +552,7 @@ void INFTL_dumpVUchains(struct INFTLrecord *s)
 
 int INFTL_mount(struct INFTLrecord *s)
 {
+        struct mtd_info *mtd = s->mbd.mtd;
         unsigned int block, first_block, prev_block, last_block;
         unsigned int first_logical_block, logical_block, erase_mark;
         int chain_length, do_format_chain;
@@ -607,10 +611,11 @@ int INFTL_mount(struct INFTLrecord *s)
                                 break;
                         }
 
-                        if (MTD_READOOB(s->mbd.mtd, block * s->EraseSize + 8,
-                            8, &retlen, (char *)&h0) < 0 ||
-                            MTD_READOOB(s->mbd.mtd, block * s->EraseSize +
-                            2 * SECTORSIZE + 8, 8, &retlen, (char *)&h1) < 0) {
+                        if (mtd->read_oob(mtd, block * s->EraseSize + 8,
+                                          8, &retlen, (char *)&h0) < 0 ||
+                            mtd->read_oob(mtd, block * s->EraseSize +
+                                          2 * SECTORSIZE + 8, 8, &retlen,
+                                          (char *)&h1) < 0) {
                                 /* Should never happen? */
                                 do_format_chain++;
                                 break;