mtd: replace DEBUG() with pr_debug()

Start moving away from the MTD_DEBUG_LEVEL messages. The dynamic
debugging feature is a generic kernel feature that provides more
flexibility.

(See Documentation/dynamic-debug-howto.txt)

Also fix some punctuation, indentation, and capitalization that went
along with the affected lines.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>

6 files changed, 39 insertions, 48 deletions

diff --git a/drivers/mtd/devices/doc2000.c b/drivers/mtd/devices/doc2000.c
index ed15447c392e..8c9703309496 100644
--- a/drivers/mtd/devices/doc2000.c
+++ b/drivers/mtd/devices/doc2000.c
@@ -82,8 +82,7 @@ static int _DoC_WaitReady(struct DiskOnChip *doc)
         void __iomem *docptr = doc->virtadr;
         unsigned long timeo = jiffies + (HZ * 10);
 
-        DEBUG(MTD_DEBUG_LEVEL3,
-              "_DoC_WaitReady called for out-of-line wait\n");
+        pr_debug("_DoC_WaitReady called for out-of-line wait\n");
 
         /* Out-of-line routine to wait for chip response */
         while (!(ReadDOC(docptr, CDSNControl) & CDSN_CTRL_FR_B)) {
@@ -92,7 +91,7 @@ static int _DoC_WaitReady(struct DiskOnChip *doc)
                 DoC_Delay(doc, 2);
 
                 if (time_after(jiffies, timeo)) {
-                        DEBUG(MTD_DEBUG_LEVEL2, "_DoC_WaitReady timed out.\n");
+                        pr_debug("_DoC_WaitReady timed out.\n");
                         return -EIO;
                 }
                 udelay(1);
@@ -323,8 +322,7 @@ static int DoC_IdentChip(struct DiskOnChip *doc, int floor, int chip)
 
         /* Reset the chip */
         if (DoC_Command(doc, NAND_CMD_RESET, CDSN_CTRL_WP)) {
-                DEBUG(MTD_DEBUG_LEVEL2,
-                      "DoC_Command (reset) for %d,%d returned true\n",
+                pr_debug("DoC_Command (reset) for %d,%d returned true\n",
                       floor, chip);
                 return 0;
         }
@@ -332,8 +330,7 @@ static int DoC_IdentChip(struct DiskOnChip *doc, int floor, int chip)
 
         /* Read the NAND chip ID: 1. Send ReadID command */
         if (DoC_Command(doc, NAND_CMD_READID, CDSN_CTRL_WP)) {
-                DEBUG(MTD_DEBUG_LEVEL2,
-                      "DoC_Command (ReadID) for %d,%d returned true\n",
+                pr_debug("DoC_Command (ReadID) for %d,%d returned true\n",
                       floor, chip);
                 return 0;
         }
diff --git a/drivers/mtd/devices/doc2001.c b/drivers/mtd/devices/doc2001.c
index c6ea8604a3c3..3d2b459cea92 100644
--- a/drivers/mtd/devices/doc2001.c
+++ b/drivers/mtd/devices/doc2001.c
@@ -55,15 +55,14 @@ static int _DoC_WaitReady(void __iomem * docptr)
 {
         unsigned short c = 0xffff;
 
-        DEBUG(MTD_DEBUG_LEVEL3,
-              "_DoC_WaitReady called for out-of-line wait\n");
+        pr_debug("_DoC_WaitReady called for out-of-line wait\n");
 
         /* Out-of-line routine to wait for chip response */
         while (!(ReadDOC(docptr, CDSNControl) & CDSN_CTRL_FR_B) && --c)
                 ;
 
         if (c == 0)
-                DEBUG(MTD_DEBUG_LEVEL2, "_DoC_WaitReady timed out.\n");
+                pr_debug("_DoC_WaitReady timed out.\n");
 
         return (c == 0);
 }
diff --git a/drivers/mtd/devices/doc2001plus.c b/drivers/mtd/devices/doc2001plus.c
index fe82fbfa155e..d28c9d99979f 100644
--- a/drivers/mtd/devices/doc2001plus.c
+++ b/drivers/mtd/devices/doc2001plus.c
@@ -61,15 +61,14 @@ static int _DoC_WaitReady(void __iomem * docptr)
 {
         unsigned int c = 0xffff;
 
-        DEBUG(MTD_DEBUG_LEVEL3,
-              "_DoC_WaitReady called for out-of-line wait\n");
+        pr_debug("_DoC_WaitReady called for out-of-line wait\n");
 
         /* Out-of-line routine to wait for chip response */
         while (((ReadDOC(docptr, Mplus_FlashControl) & CDSN_CTRL_FR_B_MASK) != CDSN_CTRL_FR_B_MASK) && --c)
                 ;
 
         if (c == 0)
-                DEBUG(MTD_DEBUG_LEVEL2, "_DoC_WaitReady timed out.\n");
+                pr_debug("_DoC_WaitReady timed out.\n");
 
         return (c == 0);
 }
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 66a3555f07d9..6417bd6b36ff 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -208,7 +208,7 @@ static int wait_till_ready(struct m25p *flash)
  */
 static int erase_chip(struct m25p *flash)
 {
-        DEBUG(MTD_DEBUG_LEVEL3, "%s: %s %lldKiB\n",
+        pr_debug("%s: %s %lldKiB\n",
               dev_name(&flash->spi->dev), __func__,
               (long long)(flash->mtd.size >> 10));
 
@@ -249,7 +249,7 @@ static int m25p_cmdsz(struct m25p *flash)
  */
 static int erase_sector(struct m25p *flash, u32 offset)
 {
-        DEBUG(MTD_DEBUG_LEVEL3, "%s: %s %dKiB at 0x%08x\n",
+        pr_debug("%s: %s %dKiB at 0x%08x\n",
                         dev_name(&flash->spi->dev), __func__,
                         flash->mtd.erasesize / 1024, offset);
 
@@ -285,7 +285,7 @@ static int m25p80_erase(struct mtd_info *mtd, struct erase_info *instr)
         u32 addr,len;
         uint32_t rem;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%llx, len %lld\n",
+        pr_debug("%s: %s %s 0x%llx, len %lld\n",
               dev_name(&flash->spi->dev), __func__, "at",
               (long long)instr->addr, (long long)instr->len);
 
@@ -347,7 +347,7 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len,
         struct spi_transfer t[2];
         struct spi_message m;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n",
+        pr_debug("%s: %s %s 0x%08x, len %zd\n",
                         dev_name(&flash->spi->dev), __func__, "from",
                         (u32)from, len);
 
@@ -416,7 +416,7 @@ static int m25p80_write(struct mtd_info *mtd, loff_t to, size_t len,
         struct spi_transfer t[2];
         struct spi_message m;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n",
+        pr_debug("%s: %s %s 0x%08x, len %zd\n",
                         dev_name(&flash->spi->dev), __func__, "to",
                         (u32)to, len);
 
@@ -509,7 +509,7 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
         size_t actual;
         int cmd_sz, ret;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n",
+        pr_debug("%s: %s %s 0x%08x, len %zd\n",
                         dev_name(&flash->spi->dev), __func__, "to",
                         (u32)to, len);
 
@@ -787,7 +787,7 @@ static const struct spi_device_id *__devinit jedec_probe(struct spi_device *spi)
          */
         tmp = spi_write_then_read(spi, &code, 1, id, 5);
         if (tmp < 0) {
-                DEBUG(MTD_DEBUG_LEVEL0, "%s: error %d reading JEDEC ID\n",
+                pr_debug("%s: error %d reading JEDEC ID\n",
                         dev_name(&spi->dev), tmp);
                 return ERR_PTR(tmp);
         }
@@ -944,8 +944,7 @@ static int __devinit m25p_probe(struct spi_device *spi)
         dev_info(&spi->dev, "%s (%lld Kbytes)\n", id->name,
                         (long long)flash->mtd.size >> 10);
 
-        DEBUG(MTD_DEBUG_LEVEL2,
-                "mtd .name = %s, .size = 0x%llx (%lldMiB) "
+        pr_debug("mtd .name = %s, .size = 0x%llx (%lldMiB) "
                         ".erasesize = 0x%.8x (%uKiB) .numeraseregions = %d\n",
                 flash->mtd.name,
                 (long long)flash->mtd.size, (long long)(flash->mtd.size >> 20),
@@ -954,8 +953,7 @@ static int __devinit m25p_probe(struct spi_device *spi)
 
         if (flash->mtd.numeraseregions)
                 for (i = 0; i < flash->mtd.numeraseregions; i++)
-                        DEBUG(MTD_DEBUG_LEVEL2,
-                                "mtd.eraseregions[%d] = { .offset = 0x%llx, "
+                        pr_debug("mtd.eraseregions[%d] = { .offset = 0x%llx, "
                                 ".erasesize = 0x%.8x (%uKiB), "
                                 ".numblocks = %d }\n",
                                 i, (long long)flash->mtd.eraseregions[i].offset,
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index c86fa573c303..f409aef58ed2 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -133,7 +133,7 @@ static int dataflash_waitready(struct spi_device *spi)
         for (;;) {
                 status = dataflash_status(spi);
                 if (status < 0) {
-                        DEBUG(MTD_DEBUG_LEVEL1, "%s: status %d?\n",
+                        pr_debug("%s: status %d?\n",
                                         dev_name(&spi->dev), status);
                         status = 0;
                 }
@@ -160,7 +160,7 @@ static int dataflash_erase(struct mtd_info *mtd, struct erase_info *instr)
         uint8_t                 *command;
         uint32_t                rem;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: erase addr=0x%llx len 0x%llx\n",
+        pr_debug("%s: erase addr=0x%llx len 0x%llx\n",
               dev_name(&spi->dev), (long long)instr->addr,
               (long long)instr->len);
 
@@ -198,7 +198,7 @@ static int dataflash_erase(struct mtd_info *mtd, struct erase_info *instr)
                 command[2] = (uint8_t)(pageaddr >> 8);
                 command[3] = 0;
 
-                DEBUG(MTD_DEBUG_LEVEL3, "ERASE %s: (%x) %x %x %x [%i]\n",
+                pr_debug("ERASE %s: (%x) %x %x %x [%i]\n",
                         do_block ? "block" : "page",
                         command[0], command[1], command[2], command[3],
                         pageaddr);
@@ -249,7 +249,7 @@ static int dataflash_read(struct mtd_info *mtd, loff_t from, size_t len,
         uint8_t                 *command;
         int                     status;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: read 0x%x..0x%x\n",
+        pr_debug("%s: read 0x%x..0x%x\n",
                 dev_name(&priv->spi->dev), (unsigned)from, (unsigned)(from + len));
 
         *retlen = 0;
@@ -266,7 +266,7 @@ static int dataflash_read(struct mtd_info *mtd, loff_t from, size_t len,
 
         command = priv->command;
 
-        DEBUG(MTD_DEBUG_LEVEL3, "READ: (%x) %x %x %x\n",
+        pr_debug("READ: (%x) %x %x %x\n",
                 command[0], command[1], command[2], command[3]);
 
         spi_message_init(&msg);
@@ -298,7 +298,7 @@ static int dataflash_read(struct mtd_info *mtd, loff_t from, size_t len,
                 *retlen = msg.actual_length - 8;
                 status = 0;
         } else
-                DEBUG(MTD_DEBUG_LEVEL1, "%s: read %x..%x --> %d\n",
+                pr_debug("%s: read %x..%x --> %d\n",
                         dev_name(&priv->spi->dev),
                         (unsigned)from, (unsigned)(from + len),
                         status);
@@ -325,7 +325,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
         int                     status = -EINVAL;
         uint8_t                 *command;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: write 0x%x..0x%x\n",
+        pr_debug("%s: write 0x%x..0x%x\n",
                 dev_name(&spi->dev), (unsigned)to, (unsigned)(to + len));
 
         *retlen = 0;
@@ -351,7 +351,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
 
         mutex_lock(&priv->lock);
         while (remaining > 0) {
-                DEBUG(MTD_DEBUG_LEVEL3, "write @ %i:%i len=%i\n",
+                pr_debug("write @ %i:%i len=%i\n",
                         pageaddr, offset, writelen);
 
                 /* REVISIT:
@@ -379,12 +379,12 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
                         command[2] = (addr & 0x0000FF00) >> 8;
                         command[3] = 0;
 
-                        DEBUG(MTD_DEBUG_LEVEL3, "TRANSFER: (%x) %x %x %x\n",
+                        pr_debug("TRANSFER: (%x) %x %x %x\n",
                                 command[0], command[1], command[2], command[3]);
 
                         status = spi_sync(spi, &msg);
                         if (status < 0)
-                                DEBUG(MTD_DEBUG_LEVEL1, "%s: xfer %u -> %d \n",
+                                pr_debug("%s: xfer %u -> %d \n",
                                         dev_name(&spi->dev), addr, status);
 
                         (void) dataflash_waitready(priv->spi);
@@ -397,7 +397,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
                 command[2] = (addr & 0x0000FF00) >> 8;
                 command[3] = (addr & 0x000000FF);
 
-                DEBUG(MTD_DEBUG_LEVEL3, "PROGRAM: (%x) %x %x %x\n",
+                pr_debug("PROGRAM: (%x) %x %x %x\n",
                         command[0], command[1], command[2], command[3]);
 
                 x[1].tx_buf = writebuf;
@@ -406,7 +406,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
                 status = spi_sync(spi, &msg);
                 spi_transfer_del(x + 1);
                 if (status < 0)
-                        DEBUG(MTD_DEBUG_LEVEL1, "%s: pgm %u/%u -> %d \n",
+                        pr_debug("%s: pgm %u/%u -> %d \n",
                                 dev_name(&spi->dev), addr, writelen, status);
 
                 (void) dataflash_waitready(priv->spi);
@@ -421,12 +421,12 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
                 command[2] = (addr & 0x0000FF00) >> 8;
                 command[3] = 0;
 
-                DEBUG(MTD_DEBUG_LEVEL3, "COMPARE: (%x) %x %x %x\n",
+                pr_debug("COMPARE: (%x) %x %x %x\n",
                         command[0], command[1], command[2], command[3]);
 
                 status = spi_sync(spi, &msg);
                 if (status < 0)
-                        DEBUG(MTD_DEBUG_LEVEL1, "%s: compare %u -> %d \n",
+                        pr_debug("%s: compare %u -> %d \n",
                                 dev_name(&spi->dev), addr, status);
 
                 status = dataflash_waitready(priv->spi);
@@ -780,7 +780,7 @@ static struct flash_info *__devinit jedec_probe(struct spi_device *spi)
          */
         tmp = spi_write_then_read(spi, &code, 1, id, 3);
         if (tmp < 0) {
-                DEBUG(MTD_DEBUG_LEVEL0, "%s: error %d reading JEDEC ID\n",
+                pr_debug("%s: error %d reading JEDEC ID\n",
                         dev_name(&spi->dev), tmp);
                 return ERR_PTR(tmp);
         }
@@ -797,7 +797,7 @@ static struct flash_info *__devinit jedec_probe(struct spi_device *spi)
                         tmp < ARRAY_SIZE(dataflash_data);
                         tmp++, info++) {
                 if (info->jedec_id == jedec) {
-                        DEBUG(MTD_DEBUG_LEVEL1, "%s: OTP, sector protect%s\n",
+                        pr_debug("%s: OTP, sector protect%s\n",
                                 dev_name(&spi->dev),
                                 (info->flags & SUP_POW2PS)
                                         ? ", binary pagesize" : ""
@@ -805,8 +805,7 @@ static struct flash_info *__devinit jedec_probe(struct spi_device *spi)
                         if (info->flags & SUP_POW2PS) {
                                 status = dataflash_status(spi);
                                 if (status < 0) {
-                                        DEBUG(MTD_DEBUG_LEVEL1,
-                                                "%s: status error %d\n",
+                                        pr_debug("%s: status error %d\n",
                                                 dev_name(&spi->dev), status);
                                         return ERR_PTR(status);
                                 }
@@ -871,7 +870,7 @@ static int __devinit dataflash_probe(struct spi_device *spi)
          */
         status = dataflash_status(spi);
         if (status <= 0 || status == 0xff) {
-                DEBUG(MTD_DEBUG_LEVEL1, "%s: status error %d\n",
+                pr_debug("%s: status error %d\n",
                                 dev_name(&spi->dev), status);
                 if (status == 0 || status == 0xff)
                         status = -ENODEV;
@@ -907,13 +906,13 @@ static int __devinit dataflash_probe(struct spi_device *spi)
                 break;
         /* obsolete AT45DB1282 not (yet?) supported */
         default:
-                DEBUG(MTD_DEBUG_LEVEL1, "%s: unsupported device (%x)\n",
+                pr_debug("%s: unsupported device (%x)\n",
                                 dev_name(&spi->dev), status & 0x3c);
                 status = -ENODEV;
         }
 
         if (status < 0)
-                DEBUG(MTD_DEBUG_LEVEL1, "%s: add_dataflash --> %d\n",
+                pr_debug("%s: add_dataflash --> %d\n",
                                 dev_name(&spi->dev), status);
 
         return status;
@@ -924,7 +923,7 @@ static int __devexit dataflash_remove(struct spi_device *spi)
         struct dataflash        *flash = dev_get_drvdata(&spi->dev);
         int                     status;
 
-        DEBUG(MTD_DEBUG_LEVEL1, "%s: remove\n", dev_name(&spi->dev));
+        pr_debug("%s: remove\n", dev_name(&spi->dev));
 
         status = mtd_device_unregister(&flash->mtd);
         if (status == 0) {
diff --git a/drivers/mtd/devices/sst25l.c b/drivers/mtd/devices/sst25l.c
index 44a8b408ed7b..d38ef3bffe8d 100644
--- a/drivers/mtd/devices/sst25l.c
+++ b/drivers/mtd/devices/sst25l.c
@@ -410,8 +410,7 @@ static int __devinit sst25l_probe(struct spi_device *spi)
         dev_info(&spi->dev, "%s (%lld KiB)\n", flash_info->name,
                  (long long)flash->mtd.size >> 10);
 
-        DEBUG(MTD_DEBUG_LEVEL2,
-              "mtd .name = %s, .size = 0x%llx (%lldMiB) "
+        pr_debug("mtd .name = %s, .size = 0x%llx (%lldMiB) "
               ".erasesize = 0x%.8x (%uKiB) .numeraseregions = %d\n",
               flash->mtd.name,
               (long long)flash->mtd.size, (long long)(flash->mtd.size >> 20),