aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mtd/devices/spear_smi.c
diff options
context:
space:
mode:
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2012-02-06 06:27:43 -0500
committerDavid Woodhouse <David.Woodhouse@intel.com>2012-03-26 19:32:19 -0400
commitbcb1d238716d138c9e16347fc32b3c1ae006339e (patch)
treeccb7a9aea7b77481fa3474124218521e0c32de82 /drivers/mtd/devices/spear_smi.c
parent0dd5235f51fb0eb0b8cef3fed35be39b8a06d7bd (diff)
mtd: move zero length verification to MTD API functions
In many places in drivers we verify for the zero length, but this is very inconsistent across drivers. This is obviously the right thing to do, though. This patch moves the check to the MTD API functions instead and removes a lot of duplication. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd/devices/spear_smi.c')
-rw-r--r--drivers/mtd/devices/spear_smi.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
index 2cdbcc65b39f..f45dd37b771e 100644
--- a/drivers/mtd/devices/spear_smi.c
+++ b/drivers/mtd/devices/spear_smi.c
@@ -563,9 +563,6 @@ static int spear_mtd_read(struct mtd_info *mtd, loff_t from, size_t len,
563 u32 ctrlreg1, val; 563 u32 ctrlreg1, val;
564 int ret; 564 int ret;
565 565
566 if (!len)
567 return 0;
568
569 if (!flash || !dev) 566 if (!flash || !dev)
570 return -ENODEV; 567 return -ENODEV;
571 568
@@ -662,9 +659,6 @@ static int spear_mtd_write(struct mtd_info *mtd, loff_t to, size_t len,
662 if (!flash || !dev) 659 if (!flash || !dev)
663 return -ENODEV; 660 return -ENODEV;
664 661
665 if (!len)
666 return 0;
667
668 if (flash->bank > dev->num_flashes - 1) { 662 if (flash->bank > dev->num_flashes - 1) {
669 dev_err(&dev->pdev->dev, "Invalid Bank Num"); 663 dev_err(&dev->pdev->dev, "Invalid Bank Num");
670 return -EINVAL; 664 return -EINVAL;