diff options
author | Sascha Hauer <s.hauer@pengutronix.de> | 2013-12-05 08:34:48 -0500 |
---|---|---|
committer | Chris Ball <chris@printf.net> | 2014-01-13 12:48:19 -0500 |
commit | a91fe279ae750d67d65039bb4ac2cc6ef51e7a2a (patch) | |
tree | 76f344ad9b8ec85de85c7e16fe4f1c2f44a6fcfd /drivers/mmc | |
parent | c5f4bc841cd1c59d91258c1268e4cbb29f14ee6a (diff) |
mmc: mxs: use standard flag for broken card detection
Use the standard MMC_CAP_NEEDS_POLL flag rather than a custom broken_cd
flag. The original code used to just return true in the card detection
function for broken card detection. The MMC_CAP_NEEDS_POLL works different,
but was introduced for the same purpose, so assume the code works correct
now.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Chris Ball <cjb@laptop.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r-- | drivers/mmc/host/mxs-mmc.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 374fca723607..02210ce8025e 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c | |||
@@ -72,7 +72,6 @@ struct mxs_mmc_host { | |||
72 | int wp_gpio; | 72 | int wp_gpio; |
73 | bool wp_inverted; | 73 | bool wp_inverted; |
74 | bool cd_inverted; | 74 | bool cd_inverted; |
75 | bool broken_cd; | ||
76 | }; | 75 | }; |
77 | 76 | ||
78 | static int mxs_mmc_get_ro(struct mmc_host *mmc) | 77 | static int mxs_mmc_get_ro(struct mmc_host *mmc) |
@@ -96,8 +95,7 @@ static int mxs_mmc_get_cd(struct mmc_host *mmc) | |||
96 | struct mxs_mmc_host *host = mmc_priv(mmc); | 95 | struct mxs_mmc_host *host = mmc_priv(mmc); |
97 | struct mxs_ssp *ssp = &host->ssp; | 96 | struct mxs_ssp *ssp = &host->ssp; |
98 | 97 | ||
99 | return host->broken_cd || | 98 | return !(readl(ssp->base + HW_SSP_STATUS(ssp)) & |
100 | !(readl(ssp->base + HW_SSP_STATUS(ssp)) & | ||
101 | BM_SSP_STATUS_CARD_DETECT) ^ host->cd_inverted; | 99 | BM_SSP_STATUS_CARD_DETECT) ^ host->cd_inverted; |
102 | } | 100 | } |
103 | 101 | ||
@@ -652,7 +650,8 @@ static int mxs_mmc_probe(struct platform_device *pdev) | |||
652 | mmc->caps |= MMC_CAP_4_BIT_DATA; | 650 | mmc->caps |= MMC_CAP_4_BIT_DATA; |
653 | else if (bus_width == 8) | 651 | else if (bus_width == 8) |
654 | mmc->caps |= MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA; | 652 | mmc->caps |= MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA; |
655 | host->broken_cd = of_property_read_bool(np, "broken-cd"); | 653 | if (of_property_read_bool(np, "broken-cd")) |
654 | mmc->caps |= MMC_CAP_NEEDS_POLL; | ||
656 | if (of_property_read_bool(np, "non-removable")) | 655 | if (of_property_read_bool(np, "non-removable")) |
657 | mmc->caps |= MMC_CAP_NONREMOVABLE; | 656 | mmc->caps |= MMC_CAP_NONREMOVABLE; |
658 | host->wp_gpio = of_get_named_gpio_flags(np, "wp-gpios", 0, &flags); | 657 | host->wp_gpio = of_get_named_gpio_flags(np, "wp-gpios", 0, &flags); |