diff options
author | Wei WANG <wei_wang@realsil.com.cn> | 2013-07-17 02:21:10 -0400 |
---|---|---|
committer | Chris Ball <cjb@laptop.org> | 2013-08-24 22:53:30 -0400 |
commit | 7fca96758e977497c67a424006c60aaf2d3db212 (patch) | |
tree | 24d59d1530a6d580008efe3b70d2e0fe712f71b3 /drivers/mmc | |
parent | 0506bc57f5f48200d00c153c403dc340eb092e4e (diff) |
mmc: core: free mmc_card if cmd 3,9,7 fails in mmc_sd_init_card
In function mmc_sd_init_card, if command 3/9/7 got failed, mmc_card
allocated just before won't be freed. This would cause memory leak.
Signed-off-by: Wei WANG <wei_wang@realsil.com.cn>
Signed-off-by: Chris Ball <cjb@laptop.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r-- | drivers/mmc/core/sd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index 176d125f5b57..1240a85a9aa2 100644 --- a/drivers/mmc/core/sd.c +++ b/drivers/mmc/core/sd.c | |||
@@ -942,13 +942,13 @@ static int mmc_sd_init_card(struct mmc_host *host, u32 ocr, | |||
942 | if (!mmc_host_is_spi(host)) { | 942 | if (!mmc_host_is_spi(host)) { |
943 | err = mmc_send_relative_addr(host, &card->rca); | 943 | err = mmc_send_relative_addr(host, &card->rca); |
944 | if (err) | 944 | if (err) |
945 | return err; | 945 | goto free_card; |
946 | } | 946 | } |
947 | 947 | ||
948 | if (!oldcard) { | 948 | if (!oldcard) { |
949 | err = mmc_sd_get_csd(host, card); | 949 | err = mmc_sd_get_csd(host, card); |
950 | if (err) | 950 | if (err) |
951 | return err; | 951 | goto free_card; |
952 | 952 | ||
953 | mmc_decode_cid(card); | 953 | mmc_decode_cid(card); |
954 | } | 954 | } |
@@ -959,7 +959,7 @@ static int mmc_sd_init_card(struct mmc_host *host, u32 ocr, | |||
959 | if (!mmc_host_is_spi(host)) { | 959 | if (!mmc_host_is_spi(host)) { |
960 | err = mmc_select_card(card); | 960 | err = mmc_select_card(card); |
961 | if (err) | 961 | if (err) |
962 | return err; | 962 | goto free_card; |
963 | } | 963 | } |
964 | 964 | ||
965 | err = mmc_sd_setup_card(host, card, oldcard != NULL); | 965 | err = mmc_sd_setup_card(host, card, oldcard != NULL); |