diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
commit | 90ab5ee94171b3e28de6bb42ee30b527014e0be7 (patch) | |
tree | fcf89889f6e881f2b231d3d20287c08174ce4b54 /drivers/mmc | |
parent | 476bc0015bf09dad39d36a8b19f76f0c181d1ec9 (diff) |
module_param: make bool parameters really bool (drivers & misc)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/mmc')
-rw-r--r-- | drivers/mmc/core/core.c | 6 | ||||
-rw-r--r-- | drivers/mmc/core/core.h | 2 | ||||
-rw-r--r-- | drivers/mmc/host/tifm_sd.c | 4 | ||||
-rw-r--r-- | drivers/mmc/host/vub300.c | 10 |
4 files changed, 11 insertions, 11 deletions
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 950b97d7412a..75d7d7e17366 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c | |||
@@ -48,7 +48,7 @@ static struct workqueue_struct *workqueue; | |||
48 | * performance cost, and for other reasons may not always be desired. | 48 | * performance cost, and for other reasons may not always be desired. |
49 | * So we allow it it to be disabled. | 49 | * So we allow it it to be disabled. |
50 | */ | 50 | */ |
51 | int use_spi_crc = 1; | 51 | bool use_spi_crc = 1; |
52 | module_param(use_spi_crc, bool, 0); | 52 | module_param(use_spi_crc, bool, 0); |
53 | 53 | ||
54 | /* | 54 | /* |
@@ -58,9 +58,9 @@ module_param(use_spi_crc, bool, 0); | |||
58 | * overridden if necessary. | 58 | * overridden if necessary. |
59 | */ | 59 | */ |
60 | #ifdef CONFIG_MMC_UNSAFE_RESUME | 60 | #ifdef CONFIG_MMC_UNSAFE_RESUME |
61 | int mmc_assume_removable; | 61 | bool mmc_assume_removable; |
62 | #else | 62 | #else |
63 | int mmc_assume_removable = 1; | 63 | bool mmc_assume_removable = 1; |
64 | #endif | 64 | #endif |
65 | EXPORT_SYMBOL(mmc_assume_removable); | 65 | EXPORT_SYMBOL(mmc_assume_removable); |
66 | module_param_named(removable, mmc_assume_removable, bool, 0644); | 66 | module_param_named(removable, mmc_assume_removable, bool, 0644); |
diff --git a/drivers/mmc/core/core.h b/drivers/mmc/core/core.h index 14664f1fb16f..afa6bd2b7b70 100644 --- a/drivers/mmc/core/core.h +++ b/drivers/mmc/core/core.h | |||
@@ -64,7 +64,7 @@ int mmc_attach_sd(struct mmc_host *host); | |||
64 | int mmc_attach_sdio(struct mmc_host *host); | 64 | int mmc_attach_sdio(struct mmc_host *host); |
65 | 65 | ||
66 | /* Module parameters */ | 66 | /* Module parameters */ |
67 | extern int use_spi_crc; | 67 | extern bool use_spi_crc; |
68 | 68 | ||
69 | /* Debugfs information for hosts and cards */ | 69 | /* Debugfs information for hosts and cards */ |
70 | void mmc_add_host_debugfs(struct mmc_host *host); | 70 | void mmc_add_host_debugfs(struct mmc_host *host); |
diff --git a/drivers/mmc/host/tifm_sd.c b/drivers/mmc/host/tifm_sd.c index f70d04664cac..69d249f51d6a 100644 --- a/drivers/mmc/host/tifm_sd.c +++ b/drivers/mmc/host/tifm_sd.c | |||
@@ -22,8 +22,8 @@ | |||
22 | #define DRIVER_NAME "tifm_sd" | 22 | #define DRIVER_NAME "tifm_sd" |
23 | #define DRIVER_VERSION "0.8" | 23 | #define DRIVER_VERSION "0.8" |
24 | 24 | ||
25 | static int no_dma = 0; | 25 | static bool no_dma = 0; |
26 | static int fixed_timeout = 0; | 26 | static bool fixed_timeout = 0; |
27 | module_param(no_dma, bool, 0644); | 27 | module_param(no_dma, bool, 0644); |
28 | module_param(fixed_timeout, bool, 0644); | 28 | module_param(fixed_timeout, bool, 0644); |
29 | 29 | ||
diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c index 2ec978bc32ba..3135a1a5d75d 100644 --- a/drivers/mmc/host/vub300.c +++ b/drivers/mmc/host/vub300.c | |||
@@ -223,25 +223,25 @@ enum SD_RESPONSE_TYPE { | |||
223 | #define FUN(c) (0x000007 & (c->arg>>28)) | 223 | #define FUN(c) (0x000007 & (c->arg>>28)) |
224 | #define REG(c) (0x01FFFF & (c->arg>>9)) | 224 | #define REG(c) (0x01FFFF & (c->arg>>9)) |
225 | 225 | ||
226 | static int limit_speed_to_24_MHz; | 226 | static bool limit_speed_to_24_MHz; |
227 | module_param(limit_speed_to_24_MHz, bool, 0644); | 227 | module_param(limit_speed_to_24_MHz, bool, 0644); |
228 | MODULE_PARM_DESC(limit_speed_to_24_MHz, "Limit Max SDIO Clock Speed to 24 MHz"); | 228 | MODULE_PARM_DESC(limit_speed_to_24_MHz, "Limit Max SDIO Clock Speed to 24 MHz"); |
229 | 229 | ||
230 | static int pad_input_to_usb_pkt; | 230 | static bool pad_input_to_usb_pkt; |
231 | module_param(pad_input_to_usb_pkt, bool, 0644); | 231 | module_param(pad_input_to_usb_pkt, bool, 0644); |
232 | MODULE_PARM_DESC(pad_input_to_usb_pkt, | 232 | MODULE_PARM_DESC(pad_input_to_usb_pkt, |
233 | "Pad USB data input transfers to whole USB Packet"); | 233 | "Pad USB data input transfers to whole USB Packet"); |
234 | 234 | ||
235 | static int disable_offload_processing; | 235 | static bool disable_offload_processing; |
236 | module_param(disable_offload_processing, bool, 0644); | 236 | module_param(disable_offload_processing, bool, 0644); |
237 | MODULE_PARM_DESC(disable_offload_processing, "Disable Offload Processing"); | 237 | MODULE_PARM_DESC(disable_offload_processing, "Disable Offload Processing"); |
238 | 238 | ||
239 | static int force_1_bit_data_xfers; | 239 | static bool force_1_bit_data_xfers; |
240 | module_param(force_1_bit_data_xfers, bool, 0644); | 240 | module_param(force_1_bit_data_xfers, bool, 0644); |
241 | MODULE_PARM_DESC(force_1_bit_data_xfers, | 241 | MODULE_PARM_DESC(force_1_bit_data_xfers, |
242 | "Force SDIO Data Transfers to 1-bit Mode"); | 242 | "Force SDIO Data Transfers to 1-bit Mode"); |
243 | 243 | ||
244 | static int force_polling_for_irqs; | 244 | static bool force_polling_for_irqs; |
245 | module_param(force_polling_for_irqs, bool, 0644); | 245 | module_param(force_polling_for_irqs, bool, 0644); |
246 | MODULE_PARM_DESC(force_polling_for_irqs, "Force Polling for SDIO interrupts"); | 246 | MODULE_PARM_DESC(force_polling_for_irqs, "Force Polling for SDIO interrupts"); |
247 | 247 | ||