diff options
author | Linus Walleij <triad@df.lth.se> | 2008-10-24 16:17:50 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2008-10-27 20:00:42 -0400 |
commit | 9e9430213f85ebdaf40026ec790295420efd0f91 (patch) | |
tree | f1e2ee98fade8b1c66c129f4b92dd00e9e06207e /drivers/mmc | |
parent | f8d56f1771e4867acc461146764b4feeb5245669 (diff) |
[ARM] 5322/1: Fix fastpath issue in mmci.c
Fix fastpath issues
Since mmci_request() can be called from a non-interrupt
context, and does, during kernel init, causing a host
of debug messages during boot if you enable spinlock debugging,
we need to use the spinlock calls that save IRQ flags and
restore them.
Signed-off-by: Linus Walleij <triad@df.lth.se>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'drivers/mmc')
-rw-r--r-- | drivers/mmc/host/mmci.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index 696cf3647ceb..2fadf323c696 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c | |||
@@ -391,6 +391,7 @@ static irqreturn_t mmci_irq(int irq, void *dev_id) | |||
391 | static void mmci_request(struct mmc_host *mmc, struct mmc_request *mrq) | 391 | static void mmci_request(struct mmc_host *mmc, struct mmc_request *mrq) |
392 | { | 392 | { |
393 | struct mmci_host *host = mmc_priv(mmc); | 393 | struct mmci_host *host = mmc_priv(mmc); |
394 | unsigned long flags; | ||
394 | 395 | ||
395 | WARN_ON(host->mrq != NULL); | 396 | WARN_ON(host->mrq != NULL); |
396 | 397 | ||
@@ -402,7 +403,7 @@ static void mmci_request(struct mmc_host *mmc, struct mmc_request *mrq) | |||
402 | return; | 403 | return; |
403 | } | 404 | } |
404 | 405 | ||
405 | spin_lock_irq(&host->lock); | 406 | spin_lock_irqsave(&host->lock, flags); |
406 | 407 | ||
407 | host->mrq = mrq; | 408 | host->mrq = mrq; |
408 | 409 | ||
@@ -411,7 +412,7 @@ static void mmci_request(struct mmc_host *mmc, struct mmc_request *mrq) | |||
411 | 412 | ||
412 | mmci_start_command(host, mrq->cmd, 0); | 413 | mmci_start_command(host, mrq->cmd, 0); |
413 | 414 | ||
414 | spin_unlock_irq(&host->lock); | 415 | spin_unlock_irqrestore(&host->lock, flags); |
415 | } | 416 | } |
416 | 417 | ||
417 | static void mmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) | 418 | static void mmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) |