diff options
author | Jingoo Han <jg1.han@samsung.com> | 2013-07-19 03:02:43 -0400 |
---|---|---|
committer | Chris Ball <cjb@laptop.org> | 2013-08-24 23:19:05 -0400 |
commit | 4be7085f744be070d327ed258d6ceb79b7323f6d (patch) | |
tree | 7973091b30cb453a2ff8180b64965c51d6c9f60c /drivers/mmc | |
parent | b3894f267d96146ef2bc5fa21437cb9be4e18254 (diff) |
mmc: mmc_test: replace strict_strtol() with kstrtol_from_user()
The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtol() should be used.
Also, both kstrtol() and copy_from_user() can be replaced
with kstrtol_from_user() to make the code simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r-- | drivers/mmc/card/mmc_test.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c index a69df5216274..0c0fc52d42c5 100644 --- a/drivers/mmc/card/mmc_test.c +++ b/drivers/mmc/card/mmc_test.c | |||
@@ -2849,18 +2849,12 @@ static ssize_t mtf_test_write(struct file *file, const char __user *buf, | |||
2849 | struct seq_file *sf = (struct seq_file *)file->private_data; | 2849 | struct seq_file *sf = (struct seq_file *)file->private_data; |
2850 | struct mmc_card *card = (struct mmc_card *)sf->private; | 2850 | struct mmc_card *card = (struct mmc_card *)sf->private; |
2851 | struct mmc_test_card *test; | 2851 | struct mmc_test_card *test; |
2852 | char lbuf[12]; | ||
2853 | long testcase; | 2852 | long testcase; |
2853 | int ret; | ||
2854 | 2854 | ||
2855 | if (count >= sizeof(lbuf)) | 2855 | ret = kstrtol_from_user(buf, count, 10, &testcase); |
2856 | return -EINVAL; | 2856 | if (ret) |
2857 | 2857 | return ret; | |
2858 | if (copy_from_user(lbuf, buf, count)) | ||
2859 | return -EFAULT; | ||
2860 | lbuf[count] = '\0'; | ||
2861 | |||
2862 | if (strict_strtol(lbuf, 10, &testcase)) | ||
2863 | return -EINVAL; | ||
2864 | 2858 | ||
2865 | test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL); | 2859 | test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL); |
2866 | if (!test) | 2860 | if (!test) |