aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mmc
diff options
context:
space:
mode:
authorPierre Ossman <drzeus@drzeus.cx>2007-02-09 02:29:19 -0500
committerPierre Ossman <drzeus@drzeus.cx>2007-02-09 02:29:19 -0500
commitacf1da4522add3771f4851c09c7fe6bcf1dd6636 (patch)
tree5be8b1b433cdd40c05fd1bce37032c79f84757da /drivers/mmc
parent52fbf9c976b36654e08e94c3107ddbaac7e2da33 (diff)
mmc: sdhci: Stop asking for mail
We get enough error reports without having to ask for it. Remove notices about mailing the development list. Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
Diffstat (limited to 'drivers/mmc')
-rw-r--r--drivers/mmc/sdhci.c35
1 files changed, 11 insertions, 24 deletions
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
index 38f0f820af68..7522f76b15ec 100644
--- a/drivers/mmc/sdhci.c
+++ b/drivers/mmc/sdhci.c
@@ -23,8 +23,6 @@
23 23
24#define DRIVER_NAME "sdhci" 24#define DRIVER_NAME "sdhci"
25 25
26#define BUGMAIL "<sdhci-devel@list.drzeus.cx>"
27
28#define DBG(f, x...) \ 26#define DBG(f, x...) \
29 pr_debug(DRIVER_NAME " [%s()]: " f, __func__,## x) 27 pr_debug(DRIVER_NAME " [%s()]: " f, __func__,## x)
30 28
@@ -153,8 +151,7 @@ static void sdhci_reset(struct sdhci_host *host, u8 mask)
153 /* hw clears the bit when it's done */ 151 /* hw clears the bit when it's done */
154 while (readb(host->ioaddr + SDHCI_SOFTWARE_RESET) & mask) { 152 while (readb(host->ioaddr + SDHCI_SOFTWARE_RESET) & mask) {
155 if (timeout == 0) { 153 if (timeout == 0) {
156 printk(KERN_ERR "%s: Reset 0x%x never completed. " 154 printk(KERN_ERR "%s: Reset 0x%x never completed.\n",
157 "Please report this to " BUGMAIL ".\n",
158 mmc_hostname(host->mmc), (int)mask); 155 mmc_hostname(host->mmc), (int)mask);
159 sdhci_dumpregs(host); 156 sdhci_dumpregs(host);
160 return; 157 return;
@@ -473,12 +470,11 @@ static void sdhci_finish_data(struct sdhci_host *host)
473 470
474 if ((data->error == MMC_ERR_NONE) && blocks) { 471 if ((data->error == MMC_ERR_NONE) && blocks) {
475 printk(KERN_ERR "%s: Controller signalled completion even " 472 printk(KERN_ERR "%s: Controller signalled completion even "
476 "though there were blocks left. Please report this " 473 "though there were blocks left.\n",
477 "to " BUGMAIL ".\n", mmc_hostname(host->mmc)); 474 mmc_hostname(host->mmc));
478 data->error = MMC_ERR_FAILED; 475 data->error = MMC_ERR_FAILED;
479 } else if (host->size != 0) { 476 } else if (host->size != 0) {
480 printk(KERN_ERR "%s: %d bytes were left untransferred. " 477 printk(KERN_ERR "%s: %d bytes were left untransferred.\n",
481 "Please report this to " BUGMAIL ".\n",
482 mmc_hostname(host->mmc), host->size); 478 mmc_hostname(host->mmc), host->size);
483 data->error = MMC_ERR_FAILED; 479 data->error = MMC_ERR_FAILED;
484 } 480 }
@@ -525,8 +521,7 @@ static void sdhci_send_command(struct sdhci_host *host, struct mmc_command *cmd)
525 while (readl(host->ioaddr + SDHCI_PRESENT_STATE) & mask) { 521 while (readl(host->ioaddr + SDHCI_PRESENT_STATE) & mask) {
526 if (timeout == 0) { 522 if (timeout == 0) {
527 printk(KERN_ERR "%s: Controller never released " 523 printk(KERN_ERR "%s: Controller never released "
528 "inhibit bit(s). Please report this to " 524 "inhibit bit(s).\n", mmc_hostname(host->mmc));
529 BUGMAIL ".\n", mmc_hostname(host->mmc));
530 sdhci_dumpregs(host); 525 sdhci_dumpregs(host);
531 cmd->error = MMC_ERR_FAILED; 526 cmd->error = MMC_ERR_FAILED;
532 tasklet_schedule(&host->finish_tasklet); 527 tasklet_schedule(&host->finish_tasklet);
@@ -547,8 +542,7 @@ static void sdhci_send_command(struct sdhci_host *host, struct mmc_command *cmd)
547 sdhci_set_transfer_mode(host, cmd->data); 542 sdhci_set_transfer_mode(host, cmd->data);
548 543
549 if ((cmd->flags & MMC_RSP_136) && (cmd->flags & MMC_RSP_BUSY)) { 544 if ((cmd->flags & MMC_RSP_136) && (cmd->flags & MMC_RSP_BUSY)) {
550 printk(KERN_ERR "%s: Unsupported response type! " 545 printk(KERN_ERR "%s: Unsupported response type!\n",
551 "Please report this to " BUGMAIL ".\n",
552 mmc_hostname(host->mmc)); 546 mmc_hostname(host->mmc));
553 cmd->error = MMC_ERR_INVALID; 547 cmd->error = MMC_ERR_INVALID;
554 tasklet_schedule(&host->finish_tasklet); 548 tasklet_schedule(&host->finish_tasklet);
@@ -646,9 +640,8 @@ static void sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
646 while (!((clk = readw(host->ioaddr + SDHCI_CLOCK_CONTROL)) 640 while (!((clk = readw(host->ioaddr + SDHCI_CLOCK_CONTROL))
647 & SDHCI_CLOCK_INT_STABLE)) { 641 & SDHCI_CLOCK_INT_STABLE)) {
648 if (timeout == 0) { 642 if (timeout == 0) {
649 printk(KERN_ERR "%s: Internal clock never stabilised. " 643 printk(KERN_ERR "%s: Internal clock never "
650 "Please report this to " BUGMAIL ".\n", 644 "stabilised.\n", mmc_hostname(host->mmc));
651 mmc_hostname(host->mmc));
652 sdhci_dumpregs(host); 645 sdhci_dumpregs(host);
653 return; 646 return;
654 } 647 }
@@ -898,9 +891,8 @@ static void sdhci_timeout_timer(unsigned long data)
898 spin_lock_irqsave(&host->lock, flags); 891 spin_lock_irqsave(&host->lock, flags);
899 892
900 if (host->mrq) { 893 if (host->mrq) {
901 printk(KERN_ERR "%s: Timeout waiting for hardware interrupt. " 894 printk(KERN_ERR "%s: Timeout waiting for hardware "
902 "Please report this to " BUGMAIL ".\n", 895 "interrupt.\n", mmc_hostname(host->mmc));
903 mmc_hostname(host->mmc));
904 sdhci_dumpregs(host); 896 sdhci_dumpregs(host);
905 897
906 if (host->data) { 898 if (host->data) {
@@ -934,8 +926,6 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask)
934 printk(KERN_ERR "%s: Got command interrupt even though no " 926 printk(KERN_ERR "%s: Got command interrupt even though no "
935 "command operation was in progress.\n", 927 "command operation was in progress.\n",
936 mmc_hostname(host->mmc)); 928 mmc_hostname(host->mmc));
937 printk(KERN_ERR "%s: Please report this to " BUGMAIL ".\n",
938 mmc_hostname(host->mmc));
939 sdhci_dumpregs(host); 929 sdhci_dumpregs(host);
940 return; 930 return;
941 } 931 }
@@ -971,8 +961,6 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
971 printk(KERN_ERR "%s: Got data interrupt even though no " 961 printk(KERN_ERR "%s: Got data interrupt even though no "
972 "data operation was in progress.\n", 962 "data operation was in progress.\n",
973 mmc_hostname(host->mmc)); 963 mmc_hostname(host->mmc));
974 printk(KERN_ERR "%s: Please report this to " BUGMAIL ".\n",
975 mmc_hostname(host->mmc));
976 sdhci_dumpregs(host); 964 sdhci_dumpregs(host);
977 965
978 return; 966 return;
@@ -1044,8 +1032,7 @@ static irqreturn_t sdhci_irq(int irq, void *dev_id)
1044 intmask &= SDHCI_INT_BUS_POWER; 1032 intmask &= SDHCI_INT_BUS_POWER;
1045 1033
1046 if (intmask) { 1034 if (intmask) {
1047 printk(KERN_ERR "%s: Unexpected interrupt 0x%08x. Please " 1035 printk(KERN_ERR "%s: Unexpected interrupt 0x%08x.\n",
1048 "report this to " BUGMAIL ".\n",
1049 mmc_hostname(host->mmc), intmask); 1036 mmc_hostname(host->mmc), intmask);
1050 sdhci_dumpregs(host); 1037 sdhci_dumpregs(host);
1051 1038