diff options
author | Guennadi Liakhovetski <g.liakhovetski@gmx.de> | 2011-07-14 12:39:10 -0400 |
---|---|---|
committer | Chris Ball <cjb@laptop.org> | 2011-07-21 10:35:07 -0400 |
commit | 162f43e31c5a376ec16336e5d0ac973373d54c89 (patch) | |
tree | 366ce758f78683291ca7db913276611ffaca00fb /drivers/mmc/host/tmio_mmc_pio.c | |
parent | 332bdb506f800d177f6657247347a253dd5b5be8 (diff) |
mmc: tmio: fix a deadlock
Currently the tmio-mmc driver contains a recursive runtime PM method
invocation, which leads to a deadlock on a mutex. Avoid it by taking
care not to request DMA too early.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Chris Ball <cjb@laptop.org>
Diffstat (limited to 'drivers/mmc/host/tmio_mmc_pio.c')
-rw-r--r-- | drivers/mmc/host/tmio_mmc_pio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c index 221ffb71c7a3..1f16357e7301 100644 --- a/drivers/mmc/host/tmio_mmc_pio.c +++ b/drivers/mmc/host/tmio_mmc_pio.c | |||
@@ -984,7 +984,7 @@ int tmio_mmc_host_resume(struct device *dev) | |||
984 | if (host->pm_global) { | 984 | if (host->pm_global) { |
985 | /* Runtime PM resume callback didn't run */ | 985 | /* Runtime PM resume callback didn't run */ |
986 | tmio_mmc_reset(host); | 986 | tmio_mmc_reset(host); |
987 | tmio_mmc_request_dma(host, host->pdata); | 987 | tmio_mmc_enable_dma(host, true); |
988 | host->pm_global = false; | 988 | host->pm_global = false; |
989 | } | 989 | } |
990 | 990 | ||
@@ -1007,7 +1007,7 @@ int tmio_mmc_host_runtime_resume(struct device *dev) | |||
1007 | struct tmio_mmc_data *pdata = host->pdata; | 1007 | struct tmio_mmc_data *pdata = host->pdata; |
1008 | 1008 | ||
1009 | tmio_mmc_reset(host); | 1009 | tmio_mmc_reset(host); |
1010 | tmio_mmc_request_dma(host, host->pdata); | 1010 | tmio_mmc_enable_dma(host, true); |
1011 | 1011 | ||
1012 | if (pdata->power) { | 1012 | if (pdata->power) { |
1013 | /* Only entered after a card-insert interrupt */ | 1013 | /* Only entered after a card-insert interrupt */ |