diff options
author | Jack Steiner <steiner@sgi.com> | 2008-07-30 01:34:02 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-30 12:41:48 -0400 |
commit | 9ca8e40c130c906c1060d105e63628410c860261 (patch) | |
tree | f43ec77a814039d2317c3012810b049c221e14ec /drivers/misc/sgi-gru/gruprocfs.c | |
parent | 3d919e5f6b440bb0cc7996eb7628b29be09e6343 (diff) |
GRU Driver V3: fixes to resolve code review comments
Fixes problems identified in a code review:
- add comment with high level dscription of the GRU
- prepend "gru_" to all global names
- delete unused function
- couple of trivial bug fixes
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Jack Steiner <steiner@sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/misc/sgi-gru/gruprocfs.c')
-rw-r--r-- | drivers/misc/sgi-gru/gruprocfs.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/misc/sgi-gru/gruprocfs.c b/drivers/misc/sgi-gru/gruprocfs.c index bdb1ad83bbfb..533923f83f1a 100644 --- a/drivers/misc/sgi-gru/gruprocfs.c +++ b/drivers/misc/sgi-gru/gruprocfs.c | |||
@@ -122,7 +122,7 @@ static ssize_t statistics_write(struct file *file, const char __user *userbuf, | |||
122 | 122 | ||
123 | static int options_show(struct seq_file *s, void *p) | 123 | static int options_show(struct seq_file *s, void *p) |
124 | { | 124 | { |
125 | seq_printf(s, "0x%lx\n", options); | 125 | seq_printf(s, "0x%lx\n", gru_options); |
126 | return 0; | 126 | return 0; |
127 | } | 127 | } |
128 | 128 | ||
@@ -136,7 +136,7 @@ static ssize_t options_write(struct file *file, const char __user *userbuf, | |||
136 | (buf, userbuf, count < sizeof(buf) ? count : sizeof(buf))) | 136 | (buf, userbuf, count < sizeof(buf) ? count : sizeof(buf))) |
137 | return -EFAULT; | 137 | return -EFAULT; |
138 | if (!strict_strtoul(buf, 10, &val)) | 138 | if (!strict_strtoul(buf, 10, &val)) |
139 | options = val; | 139 | gru_options = val; |
140 | 140 | ||
141 | return count; | 141 | return count; |
142 | } | 142 | } |