TTY: remove re-assignments to tty_driver members

All num, magic and owner are set by alloc_tty_driver. No need to
re-set them on each allocation site.

pti driver sets something different to what it passes to
alloc_tty_driver. It is not a bug, since we don't use the lines
parameter in any way. Anyway this is fixed, and now we do the right
thing.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 1 insertions, 4 deletions

diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
index 9a35db3d27fc..383133b201a1 100644
--- a/drivers/misc/pti.c
+++ b/drivers/misc/pti.c
@@ -907,20 +907,17 @@ static int __init pti_init(void)
 
         /* First register module as tty device */
 
-        pti_tty_driver = alloc_tty_driver(1);
+        pti_tty_driver = alloc_tty_driver(PTITTY_MINOR_NUM);
         if (pti_tty_driver == NULL) {
                 pr_err("%s(%d): Memory allocation failed for ptiTTY driver\n",
                         __func__, __LINE__);
                 return -ENOMEM;
         }
 
-        pti_tty_driver->owner                   = THIS_MODULE;
-        pti_tty_driver->magic                   = TTY_DRIVER_MAGIC;
         pti_tty_driver->driver_name             = DRIVERNAME;
         pti_tty_driver->name                    = TTYNAME;
         pti_tty_driver->major                   = 0;
         pti_tty_driver->minor_start             = PTITTY_MINOR_START;
-        pti_tty_driver->num                     = PTITTY_MINOR_NUM;
         pti_tty_driver->type                    = TTY_DRIVER_TYPE_SYSTEM;
         pti_tty_driver->subtype                 = SYSTEM_TYPE_SYSCONS;
         pti_tty_driver->flags                   = TTY_DRIVER_REAL_RAW |