diff options
author | Tomas Winkler <tomas.winkler@intel.com> | 2012-10-09 10:50:20 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-10-24 18:37:08 -0400 |
commit | 601a1efa630aab0ca72bf8d638c441a09654b250 (patch) | |
tree | 2beea982a0652921138ae5295c5c14fd6ae47526 /drivers/misc/mei/interrupt.c | |
parent | fb601adb350f82738210c0a1dc6af928a15391db (diff) |
mei: rename mei_free_cb_private to mei_io_cb_free
1. cb_private was an old name that we depriacated in earlier
cleanups
2. we also group the funcion declaration with other _io_
functions
3. Don't check cb for NULL as mei_io_cb_free is NULL safe
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/mei/interrupt.c')
-rw-r--r-- | drivers/misc/mei/interrupt.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c index 54d6f1a1dbc9..5c65bac2fdec 100644 --- a/drivers/misc/mei/interrupt.c +++ b/drivers/misc/mei/interrupt.c | |||
@@ -58,7 +58,7 @@ irqreturn_t mei_interrupt_quick_handler(int irq, void *dev_id) | |||
58 | static void _mei_cmpl(struct mei_cl *cl, struct mei_cl_cb *cb_pos) | 58 | static void _mei_cmpl(struct mei_cl *cl, struct mei_cl_cb *cb_pos) |
59 | { | 59 | { |
60 | if (cb_pos->major_file_operations == MEI_WRITE) { | 60 | if (cb_pos->major_file_operations == MEI_WRITE) { |
61 | mei_free_cb_private(cb_pos); | 61 | mei_io_cb_free(cb_pos); |
62 | cb_pos = NULL; | 62 | cb_pos = NULL; |
63 | cl->writing_state = MEI_WRITE_COMPLETE; | 63 | cl->writing_state = MEI_WRITE_COMPLETE; |
64 | if (waitqueue_active(&cl->tx_wait)) | 64 | if (waitqueue_active(&cl->tx_wait)) |
@@ -1368,11 +1368,10 @@ void mei_timer(struct work_struct *work) | |||
1368 | dev->iamthif_state = MEI_IAMTHIF_IDLE; | 1368 | dev->iamthif_state = MEI_IAMTHIF_IDLE; |
1369 | dev->iamthif_timer = 0; | 1369 | dev->iamthif_timer = 0; |
1370 | 1370 | ||
1371 | if (dev->iamthif_current_cb) | 1371 | mei_io_cb_free(dev->iamthif_current_cb); |
1372 | mei_free_cb_private(dev->iamthif_current_cb); | 1372 | dev->iamthif_current_cb = NULL; |
1373 | 1373 | ||
1374 | dev->iamthif_file_object = NULL; | 1374 | dev->iamthif_file_object = NULL; |
1375 | dev->iamthif_current_cb = NULL; | ||
1376 | mei_run_next_iamthif_cmd(dev); | 1375 | mei_run_next_iamthif_cmd(dev); |
1377 | } | 1376 | } |
1378 | } | 1377 | } |
@@ -1404,12 +1403,11 @@ void mei_timer(struct work_struct *work) | |||
1404 | if (cl_pos == &dev->iamthif_cl) | 1403 | if (cl_pos == &dev->iamthif_cl) |
1405 | list_del(&cb_pos->list); | 1404 | list_del(&cb_pos->list); |
1406 | } | 1405 | } |
1407 | if (dev->iamthif_current_cb) | 1406 | mei_io_cb_free(dev->iamthif_current_cb); |
1408 | mei_free_cb_private(dev->iamthif_current_cb); | 1407 | dev->iamthif_current_cb = NULL; |
1409 | 1408 | ||
1410 | dev->iamthif_file_object->private_data = NULL; | 1409 | dev->iamthif_file_object->private_data = NULL; |
1411 | dev->iamthif_file_object = NULL; | 1410 | dev->iamthif_file_object = NULL; |
1412 | dev->iamthif_current_cb = NULL; | ||
1413 | dev->iamthif_timer = 0; | 1411 | dev->iamthif_timer = 0; |
1414 | mei_run_next_iamthif_cmd(dev); | 1412 | mei_run_next_iamthif_cmd(dev); |
1415 | 1413 | ||