diff options
author | Cyrill Gorcunov <gorcunov@gmail.com> | 2007-10-02 16:30:07 -0400 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2007-10-02 22:02:44 -0400 |
commit | 5f725fe92cc2e75892b237e863d5f695fb634bb2 (patch) | |
tree | 6905d531858c0b3716220734540e25e75b16fe68 /drivers/misc/hdpuftrs | |
parent | 7472fd36a87e84c2819066543224285a6ab79ffc (diff) |
[POWERPC] Sky Cpu and Nexus: check for create_proc_entry ret code
Adds checking of create_proc_entry call to prevent possible NULL
pointer usage.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: Brian Waite <waite@skycomputers.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'drivers/misc/hdpuftrs')
-rw-r--r-- | drivers/misc/hdpuftrs/hdpu_nexus.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/drivers/misc/hdpuftrs/hdpu_nexus.c b/drivers/misc/hdpuftrs/hdpu_nexus.c index 01bc9179603b..cc818532c7ec 100644 --- a/drivers/misc/hdpuftrs/hdpu_nexus.c +++ b/drivers/misc/hdpuftrs/hdpu_nexus.c | |||
@@ -78,10 +78,20 @@ static int hdpu_nexus_probe(struct platform_device *pdev) | |||
78 | } | 78 | } |
79 | 79 | ||
80 | hdpu_slot_id = create_proc_entry("sky_slot_id", 0666, &proc_root); | 80 | hdpu_slot_id = create_proc_entry("sky_slot_id", 0666, &proc_root); |
81 | hdpu_slot_id->read_proc = hdpu_slot_id_read; | 81 | if (!hdpu_slot_id) { |
82 | printk(KERN_WARNING "sky_nexus: " | ||
83 | "Unable to create proc dir entry: sky_slot_id\n"); | ||
84 | } else { | ||
85 | hdpu_slot_id->read_proc = hdpu_slot_id_read; | ||
86 | } | ||
82 | 87 | ||
83 | hdpu_chassis_id = create_proc_entry("sky_chassis_id", 0666, &proc_root); | 88 | hdpu_chassis_id = create_proc_entry("sky_chassis_id", 0666, &proc_root); |
84 | hdpu_chassis_id->read_proc = hdpu_chassis_id_read; | 89 | if (!hdpu_chassis_id) { |
90 | printk(KERN_WARNING "sky_nexus: " | ||
91 | "Unable to create proc dir entry: sky_chassis_id\n"); | ||
92 | } else { | ||
93 | hdpu_chassis_id->read_proc = hdpu_chassis_id_read; | ||
94 | } | ||
85 | 95 | ||
86 | return 0; | 96 | return 0; |
87 | } | 97 | } |