diff options
| author | Axel Lin <axel.lin@gmail.com> | 2010-10-12 22:44:39 -0400 |
|---|---|---|
| committer | Samuel Ortiz <sameo@linux.intel.com> | 2010-10-28 18:30:29 -0400 |
| commit | a8d6aa08dd3e004df6a6e63a61698d834a191ad3 (patch) | |
| tree | aaad867dccdf9d2b7e04c6bd73834882428b5a41 /drivers/mfd | |
| parent | 7745cc8c3b977203c1b7483c09d05b58c8e88728 (diff) | |
mfd: Fix off-by-one value range checking for tps6507x
If bytes == (TPS6507X_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/mfd')
| -rw-r--r-- | drivers/mfd/tps6507x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c index fc0197649281..33ba7723c967 100644 --- a/drivers/mfd/tps6507x.c +++ b/drivers/mfd/tps6507x.c | |||
| @@ -68,7 +68,7 @@ static int tps6507x_i2c_write_device(struct tps6507x_dev *tps6507x, char reg, | |||
| 68 | u8 msg[TPS6507X_MAX_REGISTER + 1]; | 68 | u8 msg[TPS6507X_MAX_REGISTER + 1]; |
| 69 | int ret; | 69 | int ret; |
| 70 | 70 | ||
| 71 | if (bytes > (TPS6507X_MAX_REGISTER + 1)) | 71 | if (bytes > TPS6507X_MAX_REGISTER) |
| 72 | return -EINVAL; | 72 | return -EINVAL; |
| 73 | 73 | ||
| 74 | msg[0] = reg; | 74 | msg[0] = reg; |