aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mfd
diff options
context:
space:
mode:
authorMark Brown <broonie@opensource.wolfsonmicro.com>2009-11-04 11:10:52 -0500
committerSamuel Ortiz <sameo@linux.intel.com>2009-12-13 13:21:40 -0500
commit6a6127462eb9096419fd4b3115ec5971d83a600f (patch)
tree8d7050226d8bcdbbe98f13c3ec90d62c4969879a /drivers/mfd
parent5a65edbc12b6b34ef912114f1fc8215786f85b25 (diff)
mfd: Mask and unmask wm8350 IRQs on request and free
Bring the WM8350 IRQ API more in line with the generic IRQ API by masking and unmasking interrupts as they are requested and freed. This is mostly just a case of deleting the mask and unmask calls from the individual drivers. The RTC driver is changed to mask the periodic IRQ after requesting it rather than only unmasking the alarm IRQ. If the periodic IRQ fires in the period where it is reqested then there will be a spurious notification but there should be no serious consequences from this. The CODEC drive is changed to explicitly disable headphone jack detection prior to requesting the IRQs. This will avoid the IRQ firing with no jack set up. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/mfd')
-rw-r--r--drivers/mfd/wm8350-irq.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/mfd/wm8350-irq.c b/drivers/mfd/wm8350-irq.c
index 2ea2b8b4c72a..c8df547c4747 100644
--- a/drivers/mfd/wm8350-irq.c
+++ b/drivers/mfd/wm8350-irq.c
@@ -445,6 +445,8 @@ int wm8350_register_irq(struct wm8350 *wm8350, int irq,
445 wm8350->irq[irq].data = data; 445 wm8350->irq[irq].data = data;
446 mutex_unlock(&wm8350->irq_mutex); 446 mutex_unlock(&wm8350->irq_mutex);
447 447
448 wm8350_unmask_irq(wm8350, irq);
449
448 return 0; 450 return 0;
449} 451}
450EXPORT_SYMBOL_GPL(wm8350_register_irq); 452EXPORT_SYMBOL_GPL(wm8350_register_irq);
@@ -454,6 +456,8 @@ int wm8350_free_irq(struct wm8350 *wm8350, int irq)
454 if (irq < 0 || irq > WM8350_NUM_IRQ) 456 if (irq < 0 || irq > WM8350_NUM_IRQ)
455 return -EINVAL; 457 return -EINVAL;
456 458
459 wm8350_mask_irq(wm8350, irq);
460
457 mutex_lock(&wm8350->irq_mutex); 461 mutex_lock(&wm8350->irq_mutex);
458 wm8350->irq[irq].handler = NULL; 462 wm8350->irq[irq].handler = NULL;
459 mutex_unlock(&wm8350->irq_mutex); 463 mutex_unlock(&wm8350->irq_mutex);