diff options
author | Bill Richardson <wfrichar@chromium.org> | 2014-06-18 14:14:00 -0400 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2014-07-09 09:58:16 -0400 |
commit | 7e6cb5b4dbbc4b1d98289c88d0bc4092cac328be (patch) | |
tree | e24bd8e98cd4e9125a74ca629dbf3dfbd6c930c2 /drivers/mfd | |
parent | 2ce701ae4e351d9407ec0b30f5f9dd56b6de4292 (diff) |
mfd: cros_ec: Tweak struct cros_ec_device for clarity
The members of struct cros_ec_device were improperly commented, and
intermixed the private and public sections. This is just cleanup to make it
more obvious what goes with what.
[dianders: left lock in the structure but gave it the name that will
eventually be used.]
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Signed-off-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
-rw-r--r-- | drivers/mfd/cros_ec.c | 2 | ||||
-rw-r--r-- | drivers/mfd/cros_ec_i2c.c | 4 | ||||
-rw-r--r-- | drivers/mfd/cros_ec_spi.c | 10 |
3 files changed, 8 insertions, 8 deletions
diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index 38fe9bf0d169..04e053c71cc6 100644 --- a/drivers/mfd/cros_ec.c +++ b/drivers/mfd/cros_ec.c | |||
@@ -57,7 +57,7 @@ static int cros_ec_command_sendrecv(struct cros_ec_device *ec_dev, | |||
57 | msg.in_buf = in_buf; | 57 | msg.in_buf = in_buf; |
58 | msg.in_len = in_len; | 58 | msg.in_len = in_len; |
59 | 59 | ||
60 | return ec_dev->command_xfer(ec_dev, &msg); | 60 | return ec_dev->cmd_xfer(ec_dev, &msg); |
61 | } | 61 | } |
62 | 62 | ||
63 | static int cros_ec_command_recv(struct cros_ec_device *ec_dev, | 63 | static int cros_ec_command_recv(struct cros_ec_device *ec_dev, |
diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c index 4f71be99a183..777e529abb16 100644 --- a/drivers/mfd/cros_ec_i2c.c +++ b/drivers/mfd/cros_ec_i2c.c | |||
@@ -29,7 +29,7 @@ static inline struct cros_ec_device *to_ec_dev(struct device *dev) | |||
29 | return i2c_get_clientdata(client); | 29 | return i2c_get_clientdata(client); |
30 | } | 30 | } |
31 | 31 | ||
32 | static int cros_ec_command_xfer(struct cros_ec_device *ec_dev, | 32 | static int cros_ec_cmd_xfer_i2c(struct cros_ec_device *ec_dev, |
33 | struct cros_ec_msg *msg) | 33 | struct cros_ec_msg *msg) |
34 | { | 34 | { |
35 | struct i2c_client *client = ec_dev->priv; | 35 | struct i2c_client *client = ec_dev->priv; |
@@ -136,7 +136,7 @@ static int cros_ec_i2c_probe(struct i2c_client *client, | |||
136 | ec_dev->dev = dev; | 136 | ec_dev->dev = dev; |
137 | ec_dev->priv = client; | 137 | ec_dev->priv = client; |
138 | ec_dev->irq = client->irq; | 138 | ec_dev->irq = client->irq; |
139 | ec_dev->command_xfer = cros_ec_command_xfer; | 139 | ec_dev->cmd_xfer = cros_ec_cmd_xfer_i2c; |
140 | ec_dev->ec_name = client->name; | 140 | ec_dev->ec_name = client->name; |
141 | ec_dev->phys_name = client->adapter->name; | 141 | ec_dev->phys_name = client->adapter->name; |
142 | ec_dev->parent = &client->dev; | 142 | ec_dev->parent = &client->dev; |
diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c index 1fcc65ecad0e..6c3075fb5dc7 100644 --- a/drivers/mfd/cros_ec_spi.c +++ b/drivers/mfd/cros_ec_spi.c | |||
@@ -73,7 +73,7 @@ | |||
73 | * if no record | 73 | * if no record |
74 | * @end_of_msg_delay: used to set the delay_usecs on the spi_transfer that | 74 | * @end_of_msg_delay: used to set the delay_usecs on the spi_transfer that |
75 | * is sent when we want to turn off CS at the end of a transaction. | 75 | * is sent when we want to turn off CS at the end of a transaction. |
76 | * @lock: mutex to ensure only one user of cros_ec_command_spi_xfer at a time | 76 | * @lock: mutex to ensure only one user of cros_ec_cmd_xfer_spi at a time |
77 | */ | 77 | */ |
78 | struct cros_ec_spi { | 78 | struct cros_ec_spi { |
79 | struct spi_device *spi; | 79 | struct spi_device *spi; |
@@ -210,13 +210,13 @@ static int cros_ec_spi_receive_response(struct cros_ec_device *ec_dev, | |||
210 | } | 210 | } |
211 | 211 | ||
212 | /** | 212 | /** |
213 | * cros_ec_command_spi_xfer - Transfer a message over SPI and receive the reply | 213 | * cros_ec_cmd_xfer_spi - Transfer a message over SPI and receive the reply |
214 | * | 214 | * |
215 | * @ec_dev: ChromeOS EC device | 215 | * @ec_dev: ChromeOS EC device |
216 | * @ec_msg: Message to transfer | 216 | * @ec_msg: Message to transfer |
217 | */ | 217 | */ |
218 | static int cros_ec_command_spi_xfer(struct cros_ec_device *ec_dev, | 218 | static int cros_ec_cmd_xfer_spi(struct cros_ec_device *ec_dev, |
219 | struct cros_ec_msg *ec_msg) | 219 | struct cros_ec_msg *ec_msg) |
220 | { | 220 | { |
221 | struct cros_ec_spi *ec_spi = ec_dev->priv; | 221 | struct cros_ec_spi *ec_spi = ec_dev->priv; |
222 | struct spi_transfer trans; | 222 | struct spi_transfer trans; |
@@ -368,7 +368,7 @@ static int cros_ec_spi_probe(struct spi_device *spi) | |||
368 | ec_dev->dev = dev; | 368 | ec_dev->dev = dev; |
369 | ec_dev->priv = ec_spi; | 369 | ec_dev->priv = ec_spi; |
370 | ec_dev->irq = spi->irq; | 370 | ec_dev->irq = spi->irq; |
371 | ec_dev->command_xfer = cros_ec_command_spi_xfer; | 371 | ec_dev->cmd_xfer = cros_ec_cmd_xfer_spi; |
372 | ec_dev->ec_name = ec_spi->spi->modalias; | 372 | ec_dev->ec_name = ec_spi->spi->modalias; |
373 | ec_dev->phys_name = dev_name(&ec_spi->spi->dev); | 373 | ec_dev->phys_name = dev_name(&ec_spi->spi->dev); |
374 | ec_dev->parent = &ec_spi->spi->dev; | 374 | ec_dev->parent = &ec_spi->spi->dev; |