diff options
author | Wolfram Sang <w.sang@pengutronix.de> | 2010-03-20 10:12:54 -0400 |
---|---|---|
committer | Samuel Ortiz <sameo@linux.intel.com> | 2010-05-27 19:37:28 -0400 |
commit | f322d5f0097333343bfd92b47258ee997c889263 (patch) | |
tree | d6f0d4b0e0f6e6a8fa778a73c740916ca5616dd2 /drivers/mfd/wm8350-i2c.c | |
parent | d84027bc4d176a0c06e8f62a9f7a002bdd444012 (diff) |
mfd: Fix dangling pointers
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/mfd/wm8350-i2c.c')
-rw-r--r-- | drivers/mfd/wm8350-i2c.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mfd/wm8350-i2c.c b/drivers/mfd/wm8350-i2c.c index 65830f57c093..aa3ba0974ee5 100644 --- a/drivers/mfd/wm8350-i2c.c +++ b/drivers/mfd/wm8350-i2c.c | |||
@@ -82,6 +82,7 @@ static int wm8350_i2c_probe(struct i2c_client *i2c, | |||
82 | return ret; | 82 | return ret; |
83 | 83 | ||
84 | err: | 84 | err: |
85 | i2c_set_clientdata(i2c, NULL); | ||
85 | kfree(wm8350); | 86 | kfree(wm8350); |
86 | return ret; | 87 | return ret; |
87 | } | 88 | } |
@@ -91,6 +92,7 @@ static int wm8350_i2c_remove(struct i2c_client *i2c) | |||
91 | struct wm8350 *wm8350 = i2c_get_clientdata(i2c); | 92 | struct wm8350 *wm8350 = i2c_get_clientdata(i2c); |
92 | 93 | ||
93 | wm8350_device_exit(wm8350); | 94 | wm8350_device_exit(wm8350); |
95 | i2c_set_clientdata(i2c, NULL); | ||
94 | kfree(wm8350); | 96 | kfree(wm8350); |
95 | 97 | ||
96 | return 0; | 98 | return 0; |