diff options
author | Lee Jones <lee.jones@linaro.org> | 2014-08-18 11:03:14 -0400 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2014-09-26 03:15:34 -0400 |
commit | 8a012ff9d8723fdf7ea242f0f41703eed7365b79 (patch) | |
tree | d881ea9fcaf85a5d2729ac3ddbf8afd1920c06d6 /drivers/mfd/twl4030-irq.c | |
parent | cddc11412d604ad673709e91e7a35e9f10c68b39 (diff) |
mfd: twl4030-irq: Check return value from twl_i2c_write() - warn() on failure
In the original code a return value variable was provided, but it
was never checked and the user was never informed of failure. Now
it is and they are.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/twl4030-irq.c')
-rw-r--r-- | drivers/mfd/twl4030-irq.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index b1dabba763cf..1b772ef761cb 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c | |||
@@ -396,13 +396,17 @@ static int twl4030_init_sih_modules(unsigned line) | |||
396 | status = twl_i2c_read(sih->module, rxbuf, | 396 | status = twl_i2c_read(sih->module, rxbuf, |
397 | sih->mask[line].isr_offset, sih->bytes_ixr); | 397 | sih->mask[line].isr_offset, sih->bytes_ixr); |
398 | if (status < 0) | 398 | if (status < 0) |
399 | pr_err("twl4030: err %d initializing %s %s\n", | 399 | pr_warn("twl4030: err %d initializing %s %s\n", |
400 | status, sih->name, "ISR"); | 400 | status, sih->name, "ISR"); |
401 | 401 | ||
402 | if (!sih->set_cor) | 402 | if (!sih->set_cor) { |
403 | status = twl_i2c_write(sih->module, buf, | 403 | status = twl_i2c_write(sih->module, buf, |
404 | sih->mask[line].isr_offset, | 404 | sih->mask[line].isr_offset, |
405 | sih->bytes_ixr); | 405 | sih->bytes_ixr); |
406 | if (status < 0) | ||
407 | pr_warn("twl4030: write failed: %d\n", | ||
408 | status); | ||
409 | } | ||
406 | /* | 410 | /* |
407 | * else COR=1 means read sufficed. | 411 | * else COR=1 means read sufficed. |
408 | * (for most SIH modules...) | 412 | * (for most SIH modules...) |