diff options
author | Linus Walleij <linus.walleij@linaro.org> | 2013-04-12 11:02:09 -0400 |
---|---|---|
committer | Samuel Ortiz <sameo@linux.intel.com> | 2013-05-16 18:42:31 -0400 |
commit | 6999181eecb11863b78030c68037a9f851522735 (patch) | |
tree | fb0efde78f52e36a6493ab71cb0f387e85997a97 /drivers/mfd/ab8500-debugfs.c | |
parent | 33a0d1907fb442cd59b8e2eb83be79c4ab1cb791 (diff) |
mfd: ab8500: Pass AB8500 IRQ to debugfs code by resource
The AB8500 debug code which was merged in parallell with the
multiplatform work incidentally introduced a new instance using
the <mach/irqs.h> header which is now deleted, causing this
build regression:
drivers/mfd/ab8500-debugfs.c:95:23:
fatal error: mach/irqs.h: No such file or directory
compilation terminated.
make[4]: *** [drivers/mfd/ab8500-debugfs.o] Error 1
The code most certainly never worked with device tree either
since that does not rely on this kind of hard-coded interrupt
numbers.
Fix the problem at the root by passing it as a named resource
from the ab8500-core driver. Use an untyped resource to
stop the MFD core from remapping this IRQ relative to the
AB8500 irqdomain.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/mfd/ab8500-debugfs.c')
-rw-r--r-- | drivers/mfd/ab8500-debugfs.c | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index b88bbbc15f1e..37b7ce4c7c3b 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c | |||
@@ -91,12 +91,10 @@ | |||
91 | #include <linux/ctype.h> | 91 | #include <linux/ctype.h> |
92 | #endif | 92 | #endif |
93 | 93 | ||
94 | /* TODO: this file should not reference IRQ_DB8500_AB8500! */ | ||
95 | #include <mach/irqs.h> | ||
96 | |||
97 | static u32 debug_bank; | 94 | static u32 debug_bank; |
98 | static u32 debug_address; | 95 | static u32 debug_address; |
99 | 96 | ||
97 | static int irq_ab8500; | ||
100 | static int irq_first; | 98 | static int irq_first; |
101 | static int irq_last; | 99 | static int irq_last; |
102 | static u32 *irq_count; | 100 | static u32 *irq_count; |
@@ -1589,7 +1587,7 @@ void ab8500_debug_register_interrupt(int line) | |||
1589 | { | 1587 | { |
1590 | if (line < num_interrupt_lines) { | 1588 | if (line < num_interrupt_lines) { |
1591 | num_interrupts[line]++; | 1589 | num_interrupts[line]++; |
1592 | if (suspend_test_wake_cause_interrupt_is_mine(IRQ_DB8500_AB8500)) | 1590 | if (suspend_test_wake_cause_interrupt_is_mine(irq_ab8500)) |
1593 | num_wake_interrupts[line]++; | 1591 | num_wake_interrupts[line]++; |
1594 | } | 1592 | } |
1595 | } | 1593 | } |
@@ -2941,6 +2939,7 @@ static int ab8500_debug_probe(struct platform_device *plf) | |||
2941 | struct dentry *file; | 2939 | struct dentry *file; |
2942 | int ret = -ENOMEM; | 2940 | int ret = -ENOMEM; |
2943 | struct ab8500 *ab8500; | 2941 | struct ab8500 *ab8500; |
2942 | struct resource *res; | ||
2944 | debug_bank = AB8500_MISC; | 2943 | debug_bank = AB8500_MISC; |
2945 | debug_address = AB8500_REV_REG & 0x00FF; | 2944 | debug_address = AB8500_REV_REG & 0x00FF; |
2946 | 2945 | ||
@@ -2959,6 +2958,15 @@ static int ab8500_debug_probe(struct platform_device *plf) | |||
2959 | if (!event_name) | 2958 | if (!event_name) |
2960 | goto out_freedev_attr; | 2959 | goto out_freedev_attr; |
2961 | 2960 | ||
2961 | res = platform_get_resource_byname(plf, 0, "IRQ_AB8500"); | ||
2962 | if (!res) { | ||
2963 | dev_err(&plf->dev, "AB8500 irq not found, err %d\n", | ||
2964 | irq_first); | ||
2965 | ret = -ENXIO; | ||
2966 | goto out_freeevent_name; | ||
2967 | } | ||
2968 | irq_ab8500 = res->start; | ||
2969 | |||
2962 | irq_first = platform_get_irq_byname(plf, "IRQ_FIRST"); | 2970 | irq_first = platform_get_irq_byname(plf, "IRQ_FIRST"); |
2963 | if (irq_first < 0) { | 2971 | if (irq_first < 0) { |
2964 | dev_err(&plf->dev, "First irq not found, err %d\n", | 2972 | dev_err(&plf->dev, "First irq not found, err %d\n", |