diff options
author | Deepak Saxena <dsaxena@plexity.net> | 2005-09-21 12:55:35 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-09-21 13:11:54 -0400 |
commit | 8b20f6da20d874a58becc7a08b130c4382ea7325 (patch) | |
tree | 351214ad8719c6d46291d21b212996db46aef0dd /drivers/message/i2o | |
parent | 40da47e1159b89f2df5c718d2d5e269ced72b541 (diff) |
[PATCH] Fix I2O config-osm init to return proper error
We currently unregister the config-osm driver if initialization of the
legacy ioctl() handlers failed but still return success. We should be
returning -EBUSY in this case.
Signed-off-by: Deepak Saxena <dsaxena@plexity.net>
Cc: Markus Lidel <Markus.Lidel@shadowconnect.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/message/i2o')
-rw-r--r-- | drivers/message/i2o/config-osm.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/message/i2o/config-osm.c b/drivers/message/i2o/config-osm.c index af32ab4e90cd..10432f665201 100644 --- a/drivers/message/i2o/config-osm.c +++ b/drivers/message/i2o/config-osm.c | |||
@@ -56,8 +56,11 @@ static int __init i2o_config_init(void) | |||
56 | return -EBUSY; | 56 | return -EBUSY; |
57 | } | 57 | } |
58 | #ifdef CONFIG_I2O_CONFIG_OLD_IOCTL | 58 | #ifdef CONFIG_I2O_CONFIG_OLD_IOCTL |
59 | if (i2o_config_old_init()) | 59 | if (i2o_config_old_init()) { |
60 | osm_err("old config handler initialization failed\n"); | ||
60 | i2o_driver_unregister(&i2o_config_driver); | 61 | i2o_driver_unregister(&i2o_config_driver); |
62 | return -EBUSY; | ||
63 | } | ||
61 | #endif | 64 | #endif |
62 | 65 | ||
63 | return 0; | 66 | return 0; |