diff options
author | Markus Lidel <Markus.Lidel@shadowconnect.com> | 2005-06-24 01:02:21 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-06-24 03:05:29 -0400 |
commit | 9e87545f06930c1d294423a8091d1077e7444a47 (patch) | |
tree | ef05fca1becfa0e1584f234ddf9b1a430b7d018e /drivers/message/i2o/debug.c | |
parent | b2aaee33fbb354a2f08121aa1c1be55841102761 (diff) |
[PATCH] I2O: second code cleanup of sparse warnings and unneeded syncronization
Changes:
- Added header "core.h" for i2o_core.ko internal definitions
- More sparse fixes
- Changed display of TID's in sysfs attributes from XXX to 0xXXX
- Use the right functions for accessing I/O and normal memory
- Removed error handling of SCSI device errors and let the SCSI layer
take care of it
- Added new device / removed device handling to SCSI-OSM
- Make status access volatile
- Cleaned up activation of I2O controller
- Removed unnecessary wmb() and rmb() calls
- Use own struct i2o_io for I/O memory instead of struct i2o_dma
Signed-off-by: Markus Lidel <Markus.Lidel@shadowconnect.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/message/i2o/debug.c')
-rw-r--r-- | drivers/message/i2o/debug.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/message/i2o/debug.c b/drivers/message/i2o/debug.c index 2a5d478fc60e..018ca887ca85 100644 --- a/drivers/message/i2o/debug.c +++ b/drivers/message/i2o/debug.c | |||
@@ -4,8 +4,6 @@ | |||
4 | #include <linux/pci.h> | 4 | #include <linux/pci.h> |
5 | #include <linux/i2o.h> | 5 | #include <linux/i2o.h> |
6 | 6 | ||
7 | extern struct i2o_driver **i2o_drivers; | ||
8 | extern unsigned int i2o_max_drivers; | ||
9 | static void i2o_report_util_cmd(u8 cmd); | 7 | static void i2o_report_util_cmd(u8 cmd); |
10 | static void i2o_report_exec_cmd(u8 cmd); | 8 | static void i2o_report_exec_cmd(u8 cmd); |
11 | static void i2o_report_fail_status(u8 req_status, u32 * msg); | 9 | static void i2o_report_fail_status(u8 req_status, u32 * msg); |
@@ -23,7 +21,6 @@ void i2o_report_status(const char *severity, const char *str, | |||
23 | u8 cmd = (msg[1] >> 24) & 0xFF; | 21 | u8 cmd = (msg[1] >> 24) & 0xFF; |
24 | u8 req_status = (msg[4] >> 24) & 0xFF; | 22 | u8 req_status = (msg[4] >> 24) & 0xFF; |
25 | u16 detailed_status = msg[4] & 0xFFFF; | 23 | u16 detailed_status = msg[4] & 0xFFFF; |
26 | //struct i2o_driver *h = i2o_drivers[msg[2] & (i2o_max_drivers-1)]; | ||
27 | 24 | ||
28 | if (cmd == I2O_CMD_UTIL_EVT_REGISTER) | 25 | if (cmd == I2O_CMD_UTIL_EVT_REGISTER) |
29 | return; // No status in this reply | 26 | return; // No status in this reply |