diff options
author | Masanari Iida <standby24x7@gmail.com> | 2014-01-17 11:38:00 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-02-04 03:43:53 -0500 |
commit | 1ba6c90161ac058f580e6ceb5ccc14dcd86365d1 (patch) | |
tree | c78403a862d45fb4939398375380be5b7c6828f5 /drivers/media | |
parent | f2e4c5e004691dfe37d0e4b363296f28abdb9bc7 (diff) |
[media] hdpvr: Fix memory leak in debug
cppcheck reported memory leak in device_authorizatio()
within hdpvr-core.c.
When the debug option is specified and the code jump to
"unlock:" label, print_buf was not freed.
Confirm the module succesfully compiled without error.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media')
-rw-r--r-- | drivers/media/usb/hdpvr/hdpvr-core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/media/usb/hdpvr/hdpvr-core.c b/drivers/media/usb/hdpvr/hdpvr-core.c index 2f0c89cbac76..c5638964c3f2 100644 --- a/drivers/media/usb/hdpvr/hdpvr-core.c +++ b/drivers/media/usb/hdpvr/hdpvr-core.c | |||
@@ -198,7 +198,6 @@ static int device_authorization(struct hdpvr_device *dev) | |||
198 | hex_dump_to_buffer(response, 8, 16, 1, print_buf, 5*buf_size+1, 0); | 198 | hex_dump_to_buffer(response, 8, 16, 1, print_buf, 5*buf_size+1, 0); |
199 | v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev, " response: %s\n", | 199 | v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev, " response: %s\n", |
200 | print_buf); | 200 | print_buf); |
201 | kfree(print_buf); | ||
202 | #endif | 201 | #endif |
203 | 202 | ||
204 | msleep(100); | 203 | msleep(100); |
@@ -214,6 +213,9 @@ static int device_authorization(struct hdpvr_device *dev) | |||
214 | retval = ret != 8; | 213 | retval = ret != 8; |
215 | unlock: | 214 | unlock: |
216 | mutex_unlock(&dev->usbc_mutex); | 215 | mutex_unlock(&dev->usbc_mutex); |
216 | #ifdef HDPVR_DEBUG | ||
217 | kfree(print_buf); | ||
218 | #endif | ||
217 | return retval; | 219 | return retval; |
218 | } | 220 | } |
219 | 221 | ||