diff options
author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-20 05:44:20 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2014-11-25 10:30:43 -0500 |
commit | 332b295d107466df8b05a99a914adbe21401449b (patch) | |
tree | 5fb1ce77fa151d66cbdf143512e4eccbdd26c59f /drivers/media | |
parent | 3dd94f00f07f013259dc221d6307ef699661f7ea (diff) |
[media] platform: Deletion of unnecessary checks before two function calls
The functions i2c_put_adapter() and release_firmware() test whether their
argument is NULL and then return immediately. Thus the test around the call
is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media')
-rw-r--r-- | drivers/media/platform/exynos4-is/fimc-is.c | 6 | ||||
-rw-r--r-- | drivers/media/platform/s3c-camif/camif-core.c | 3 |
2 files changed, 3 insertions, 6 deletions
diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c index 3d49ce03b176..2a0cbeff0324 100644 --- a/drivers/media/platform/exynos4-is/fimc-is.c +++ b/drivers/media/platform/exynos4-is/fimc-is.c | |||
@@ -428,8 +428,7 @@ static void fimc_is_load_firmware(const struct firmware *fw, void *context) | |||
428 | * needed around for copying to the IS working memory every | 428 | * needed around for copying to the IS working memory every |
429 | * time before the Cortex-A5 is restarted. | 429 | * time before the Cortex-A5 is restarted. |
430 | */ | 430 | */ |
431 | if (is->fw.f_w) | 431 | release_firmware(is->fw.f_w); |
432 | release_firmware(is->fw.f_w); | ||
433 | is->fw.f_w = fw; | 432 | is->fw.f_w = fw; |
434 | done: | 433 | done: |
435 | mutex_unlock(&is->lock); | 434 | mutex_unlock(&is->lock); |
@@ -937,8 +936,7 @@ static int fimc_is_remove(struct platform_device *pdev) | |||
937 | vb2_dma_contig_cleanup_ctx(is->alloc_ctx); | 936 | vb2_dma_contig_cleanup_ctx(is->alloc_ctx); |
938 | fimc_is_put_clocks(is); | 937 | fimc_is_put_clocks(is); |
939 | fimc_is_debugfs_remove(is); | 938 | fimc_is_debugfs_remove(is); |
940 | if (is->fw.f_w) | 939 | release_firmware(is->fw.f_w); |
941 | release_firmware(is->fw.f_w); | ||
942 | fimc_is_free_cpu_memory(is); | 940 | fimc_is_free_cpu_memory(is); |
943 | 941 | ||
944 | return 0; | 942 | return 0; |
diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c index b38574702fe9..3b09b5b6ad51 100644 --- a/drivers/media/platform/s3c-camif/camif-core.c +++ b/drivers/media/platform/s3c-camif/camif-core.c | |||
@@ -256,8 +256,7 @@ static void camif_unregister_sensor(struct camif_dev *camif) | |||
256 | v4l2_device_unregister_subdev(sd); | 256 | v4l2_device_unregister_subdev(sd); |
257 | camif->sensor.sd = NULL; | 257 | camif->sensor.sd = NULL; |
258 | i2c_unregister_device(client); | 258 | i2c_unregister_device(client); |
259 | if (adapter) | 259 | i2c_put_adapter(adapter); |
260 | i2c_put_adapter(adapter); | ||
261 | } | 260 | } |
262 | 261 | ||
263 | static int camif_create_media_links(struct camif_dev *camif) | 262 | static int camif_create_media_links(struct camif_dev *camif) |