WorkStruct: make allyesconfig

Fix up for make allyesconfig.

Signed-Off-By: David Howells <dhowells@redhat.com>

11 files changed, 74 insertions, 41 deletions

diff --git a/drivers/media/dvb/b2c2/flexcop-pci.c b/drivers/media/dvb/b2c2/flexcop-pci.c
index 06893243f3d4..6e166801505d 100644
--- a/drivers/media/dvb/b2c2/flexcop-pci.c
+++ b/drivers/media/dvb/b2c2/flexcop-pci.c
@@ -63,7 +63,7 @@ struct flexcop_pci {
 
         unsigned long last_irq;
 
-        struct work_struct irq_check_work;
+        struct delayed_work irq_check_work;
 
         struct flexcop_device *fc_dev;
 };
@@ -97,9 +97,10 @@ static int flexcop_pci_write_ibi_reg(struct flexcop_device *fc, flexcop_ibi_regi
         return 0;
 }
 
-static void flexcop_pci_irq_check_work(void *data)
+static void flexcop_pci_irq_check_work(struct work_struct *work)
 {
-        struct flexcop_pci *fc_pci = data;
+        struct flexcop_pci *fc_pci =
+                container_of(work, struct flexcop_pci, irq_check_work.work);
         struct flexcop_device *fc = fc_pci->fc_dev;
 
         flexcop_ibi_value v = fc->read_ibi_reg(fc,sram_dest_reg_714);
@@ -371,7 +372,7 @@ static int flexcop_pci_probe(struct pci_dev *pdev, const struct pci_device_id *e
         if ((ret = flexcop_pci_dma_init(fc_pci)) != 0)
                 goto err_fc_exit;
 
-        INIT_WORK(&fc_pci->irq_check_work, flexcop_pci_irq_check_work, fc_pci);
+        INIT_DELAYED_WORK(&fc_pci->irq_check_work, flexcop_pci_irq_check_work);
 
         return ret;
 
diff --git a/drivers/media/dvb/cinergyT2/cinergyT2.c b/drivers/media/dvb/cinergyT2/cinergyT2.c
index ff7d4f56ced3..dd0bcbe140bd 100644
--- a/drivers/media/dvb/cinergyT2/cinergyT2.c
+++ b/drivers/media/dvb/cinergyT2/cinergyT2.c
@@ -127,7 +127,7 @@ struct cinergyt2 {
 
         struct dvbt_set_parameters_msg param;
         struct dvbt_get_status_msg status;
-        struct work_struct query_work;
+        struct delayed_work query_work;
 
         wait_queue_head_t poll_wq;
         int pending_fe_events;
@@ -141,7 +141,7 @@ struct cinergyt2 {
 #ifdef ENABLE_RC
         struct input_dev *rc_input_dev;
         char phys[64];
-        struct work_struct rc_query_work;
+        struct delayed_work rc_query_work;
         int rc_input_event;
         u32 rc_last_code;
         unsigned long last_event_jiffies;
@@ -724,9 +724,10 @@ static struct dvb_device cinergyt2_fe_template = {
 
 #ifdef ENABLE_RC
 
-static void cinergyt2_query_rc (void *data)
+static void cinergyt2_query_rc (struct work_struct *work)
 {
-        struct cinergyt2 *cinergyt2 = data;
+        struct cinergyt2 *cinergyt2 =
+                container_of(work, struct cinergyt2, rc_query_work.work);
         char buf[1] = { CINERGYT2_EP1_GET_RC_EVENTS };
         struct cinergyt2_rc_event rc_events[12];
         int n, len, i;
@@ -807,7 +808,7 @@ static int cinergyt2_register_rc(struct cinergyt2 *cinergyt2)
         strlcat(cinergyt2->phys, "/input0", sizeof(cinergyt2->phys));
         cinergyt2->rc_input_event = KEY_MAX;
         cinergyt2->rc_last_code = ~0;
-        INIT_WORK(&cinergyt2->rc_query_work, cinergyt2_query_rc, cinergyt2);
+        INIT_DELAYED_WORK(&cinergyt2->rc_query_work, cinergyt2_query_rc);
 
         input_dev->name = DRIVER_NAME " remote control";
         input_dev->phys = cinergyt2->phys;
@@ -848,9 +849,10 @@ static inline void cinergyt2_resume_rc(struct cinergyt2 *cinergyt2) { }
 
 #endif /* ENABLE_RC */
 
-static void cinergyt2_query (void *data)
+static void cinergyt2_query (struct work_struct *work)
 {
-        struct cinergyt2 *cinergyt2 = (struct cinergyt2 *) data;
+        struct cinergyt2 *cinergyt2 =
+                container_of(work, struct cinergyt2, query_work.work);
         char cmd [] = { CINERGYT2_EP1_GET_TUNER_STATUS };
         struct dvbt_get_status_msg *s = &cinergyt2->status;
         uint8_t lock_bits;
@@ -894,7 +896,7 @@ static int cinergyt2_probe (struct usb_interface *intf,
 
         mutex_init(&cinergyt2->sem);
         init_waitqueue_head (&cinergyt2->poll_wq);
-        INIT_WORK(&cinergyt2->query_work, cinergyt2_query, cinergyt2);
+        INIT_DELAYED_WORK(&cinergyt2->query_work, cinergyt2_query);
 
         cinergyt2->udev = interface_to_usbdev(intf);
         cinergyt2->param.cmd = CINERGYT2_EP1_SET_TUNER_PARAMETERS;
diff --git a/drivers/media/dvb/dvb-core/dvb_net.c b/drivers/media/dvb/dvb-core/dvb_net.c
index 8859ab74f0fe..ebf4dc5190f6 100644
--- a/drivers/media/dvb/dvb-core/dvb_net.c
+++ b/drivers/media/dvb/dvb-core/dvb_net.c
@@ -127,6 +127,7 @@ struct dvb_net_priv {
         int in_use;
         struct net_device_stats stats;
         u16 pid;
+        struct net_device *net;
         struct dvb_net *host;
         struct dmx_demux *demux;
         struct dmx_section_feed *secfeed;
@@ -1123,10 +1124,11 @@ static int dvb_set_mc_filter (struct net_device *dev, struct dev_mc_list *mc)
 }
 
 
-static void wq_set_multicast_list (void *data)
+static void wq_set_multicast_list (struct work_struct *work)
 {
-        struct net_device *dev = data;
-        struct dvb_net_priv *priv = dev->priv;
+        struct dvb_net_priv *priv =
+                container_of(work, struct dvb_net_priv, set_multicast_list_wq);
+        struct net_device *dev = priv->net;
 
         dvb_net_feed_stop(dev);
         priv->rx_mode = RX_MODE_UNI;
@@ -1167,9 +1169,11 @@ static void dvb_net_set_multicast_list (struct net_device *dev)
 }
 
 
-static void wq_restart_net_feed (void *data)
+static void wq_restart_net_feed (struct work_struct *work)
 {
-        struct net_device *dev = data;
+        struct dvb_net_priv *priv =
+                container_of(work, struct dvb_net_priv, restart_net_feed_wq);
+        struct net_device *dev = priv->net;
 
         if (netif_running(dev)) {
                 dvb_net_feed_stop(dev);
@@ -1276,6 +1280,7 @@ static int dvb_net_add_if(struct dvb_net *dvbnet, u16 pid, u8 feedtype)
         dvbnet->device[if_num] = net;
 
         priv = net->priv;
+        priv->net = net;
         priv->demux = dvbnet->demux;
         priv->pid = pid;
         priv->rx_mode = RX_MODE_UNI;
@@ -1284,8 +1289,8 @@ static int dvb_net_add_if(struct dvb_net *dvbnet, u16 pid, u8 feedtype)
         priv->feedtype = feedtype;
         reset_ule(priv);
 
-        INIT_WORK(&priv->set_multicast_list_wq, wq_set_multicast_list, net);
-        INIT_WORK(&priv->restart_net_feed_wq, wq_restart_net_feed, net);
+        INIT_WORK(&priv->set_multicast_list_wq, wq_set_multicast_list);
+        INIT_WORK(&priv->restart_net_feed_wq, wq_restart_net_feed);
         mutex_init(&priv->mutex);
 
         net->base_addr = pid;
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-remote.c b/drivers/media/dvb/dvb-usb/dvb-usb-remote.c
index 0a3a0b6c2350..794e4471561c 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-remote.c
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-remote.c
@@ -13,9 +13,10 @@
  *
  * TODO: Fix the repeat rate of the input device.
  */
-static void dvb_usb_read_remote_control(void *data)
+static void dvb_usb_read_remote_control(struct work_struct *work)
 {
-        struct dvb_usb_device *d = data;
+        struct dvb_usb_device *d =
+                container_of(work, struct dvb_usb_device, rc_query_work.work);
         u32 event;
         int state;
 
@@ -128,7 +129,7 @@ int dvb_usb_remote_init(struct dvb_usb_device *d)
 
         input_register_device(d->rc_input_dev);
 
-        INIT_WORK(&d->rc_query_work, dvb_usb_read_remote_control, d);
+        INIT_DELAYED_WORK(&d->rc_query_work, dvb_usb_read_remote_control);
 
         info("schedule remote query interval to %d msecs.", d->props.rc_interval);
         schedule_delayed_work(&d->rc_query_work,msecs_to_jiffies(d->props.rc_interval));
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb.h b/drivers/media/dvb/dvb-usb/dvb-usb.h
index 376c45a8e779..0d721731a524 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb.h
@@ -369,7 +369,7 @@ struct dvb_usb_device {
         /* remote control */
         struct input_dev *rc_input_dev;
         char rc_phys[64];
-        struct work_struct rc_query_work;
+        struct delayed_work rc_query_work;
         u32 last_event;
         int last_state;
 
diff --git a/drivers/media/video/cpia_pp.c b/drivers/media/video/cpia_pp.c
index 41f4b8d17559..b12cec94f4cc 100644
--- a/drivers/media/video/cpia_pp.c
+++ b/drivers/media/video/cpia_pp.c
@@ -82,6 +82,8 @@ struct pp_cam_entry {
         struct pardevice *pdev;
         struct parport *port;
         struct work_struct cb_task;
+        void (*cb_func)(void *cbdata);
+        void *cb_data;
         int open_count;
         wait_queue_head_t wq_stream;
         /* image state flags */
@@ -130,6 +132,20 @@ static void cpia_parport_disable_irq( struct parport *port ) {
 #define PARPORT_CHUNK_SIZE      PAGE_SIZE
 
 
+static void cpia_pp_run_callback(struct work_struct *work)
+{
+        void (*cb_func)(void *cbdata);
+        void *cb_data;
+        struct pp_cam_entry *cam;
+
+        cam = container_of(work, struct pp_cam_entry, cb_task);
+        cb_func = cam->cb_func;
+        cb_data = cam->cb_data;
+        work_release(work);
+
+        cb_func(cb_data);
+}
+
 /****************************************************************************
  *
  *  CPiA-specific  low-level parport functions for nibble uploads
@@ -664,7 +680,9 @@ static int cpia_pp_registerCallback(void *privdata, void (*cb)(void *cbdata), vo
         int retval = 0;
 
         if(cam->port->irq != PARPORT_IRQ_NONE) {
-                INIT_WORK(&cam->cb_task, cb, cbdata);
+                cam->cb_func = cb;
+                cam->cb_data = cbdata;
+                INIT_WORK_NAR(&cam->cb_task, cpia_pp_run_callback);
         } else {
                 retval = -1;
         }
diff --git a/drivers/media/video/cx88/cx88-input.c b/drivers/media/video/cx88/cx88-input.c
index 57e1c024a547..e60a0a52e4b2 100644
--- a/drivers/media/video/cx88/cx88-input.c
+++ b/drivers/media/video/cx88/cx88-input.c
@@ -145,9 +145,9 @@ static void ir_timer(unsigned long data)
         schedule_work(&ir->work);
 }
 
-static void cx88_ir_work(void *data)
+static void cx88_ir_work(struct work_struct *work)
 {
-        struct cx88_IR *ir = data;
+        struct cx88_IR *ir = container_of(work, struct cx88_IR, work);
         unsigned long timeout;
 
         cx88_ir_handle_key(ir);
@@ -308,7 +308,7 @@ int cx88_ir_init(struct cx88_core *core, struct pci_dev *pci)
         core->ir = ir;
 
         if (ir->polling) {
-                INIT_WORK(&ir->work, cx88_ir_work, ir);
+                INIT_WORK(&ir->work, cx88_ir_work);
                 init_timer(&ir->timer);
                 ir->timer.function = ir_timer;
                 ir->timer.data = (unsigned long)ir;
diff --git a/drivers/media/video/ir-kbd-i2c.c b/drivers/media/video/ir-kbd-i2c.c
index 1457b1602221..ab87e7bfe84f 100644
--- a/drivers/media/video/ir-kbd-i2c.c
+++ b/drivers/media/video/ir-kbd-i2c.c
@@ -268,9 +268,9 @@ static void ir_timer(unsigned long data)
         schedule_work(&ir->work);
 }
 
-static void ir_work(void *data)
+static void ir_work(struct work_struct *work)
 {
-        struct IR_i2c *ir = data;
+        struct IR_i2c *ir = container_of(work, struct IR_i2c, work);
         ir_key_poll(ir);
         mod_timer(&ir->timer, jiffies+HZ/10);
 }
@@ -400,7 +400,7 @@ static int ir_attach(struct i2c_adapter *adap, int addr,
                ir->input->name,ir->input->phys,adap->name);
 
         /* start polling via eventd */
-        INIT_WORK(&ir->work, ir_work, ir);
+        INIT_WORK(&ir->work, ir_work);
         init_timer(&ir->timer);
         ir->timer.function = ir_timer;
         ir->timer.data     = (unsigned long)ir;
diff --git a/drivers/media/video/pvrusb2/pvrusb2-context.c b/drivers/media/video/pvrusb2/pvrusb2-context.c
index f129f316d20e..cf129746205d 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-context.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-context.c
@@ -45,16 +45,21 @@ static void pvr2_context_trigger_poll(struct pvr2_context *mp)
 }
 
 
-static void pvr2_context_poll(struct pvr2_context *mp)
+static void pvr2_context_poll(struct work_struct *work)
 {
+        struct pvr2_context *mp =
+                container_of(work, struct pvr2_context, workpoll);
         pvr2_context_enter(mp); do {
                 pvr2_hdw_poll(mp->hdw);
         } while (0); pvr2_context_exit(mp);
 }
 
 
-static void pvr2_context_setup(struct pvr2_context *mp)
+static void pvr2_context_setup(struct work_struct *work)
 {
+        struct pvr2_context *mp =
+                container_of(work, struct pvr2_context, workinit);
+
         pvr2_context_enter(mp); do {
                 if (!pvr2_hdw_dev_ok(mp->hdw)) break;
                 pvr2_hdw_setup(mp->hdw);
@@ -92,8 +97,8 @@ struct pvr2_context *pvr2_context_create(
         }
 
         mp->workqueue = create_singlethread_workqueue("pvrusb2");
-        INIT_WORK(&mp->workinit,(void (*)(void*))pvr2_context_setup,mp);
-        INIT_WORK(&mp->workpoll,(void (*)(void*))pvr2_context_poll,mp);
+        INIT_WORK(&mp->workinit, pvr2_context_setup);
+        INIT_WORK(&mp->workpoll, pvr2_context_poll);
         queue_work(mp->workqueue,&mp->workinit);
  done:
         return mp;
diff --git a/drivers/media/video/saa6588.c b/drivers/media/video/saa6588.c
index a81285ca7d5b..8ba05c214ca7 100644
--- a/drivers/media/video/saa6588.c
+++ b/drivers/media/video/saa6588.c
@@ -322,9 +322,9 @@ static void saa6588_timer(unsigned long data)
         schedule_work(&s->work);
 }
 
-static void saa6588_work(void *data)
+static void saa6588_work(struct work_struct *work)
 {
-        struct saa6588 *s = (struct saa6588 *)data;
+        struct saa6588 *s = container_of(work, struct saa6588, work);
 
         saa6588_i2c_poll(s);
         mod_timer(&s->timer, jiffies + msecs_to_jiffies(20));
@@ -417,7 +417,7 @@ static int saa6588_attach(struct i2c_adapter *adap, int addr, int kind)
         saa6588_configure(s);
 
         /* start polling via eventd */
-        INIT_WORK(&s->work, saa6588_work, s);
+        INIT_WORK(&s->work, saa6588_work);
         init_timer(&s->timer);
         s->timer.function = saa6588_timer;
         s->timer.data = (unsigned long)s;
diff --git a/drivers/media/video/saa7134/saa7134-empress.c b/drivers/media/video/saa7134/saa7134-empress.c
index 65d044086ce9..daaae870a2c4 100644
--- a/drivers/media/video/saa7134/saa7134-empress.c
+++ b/drivers/media/video/saa7134/saa7134-empress.c
@@ -343,9 +343,10 @@ static struct video_device saa7134_empress_template =
         .minor         = -1,
 };
 
-static void empress_signal_update(void* data)
+static void empress_signal_update(struct work_struct *work)
 {
-        struct saa7134_dev* dev = (struct saa7134_dev*) data;
+        struct saa7134_dev* dev =
+                container_of(work, struct saa7134_dev, empress_workqueue);
 
         if (dev->nosignal) {
                 dprintk("no video signal\n");
@@ -378,7 +379,7 @@ static int empress_init(struct saa7134_dev *dev)
                  "%s empress (%s)", dev->name,
                  saa7134_boards[dev->board].name);
 
-        INIT_WORK(&dev->empress_workqueue, empress_signal_update, (void*) dev);
+        INIT_WORK(&dev->empress_workqueue, empress_signal_update);
 
         err = video_register_device(dev->empress_dev,VFL_TYPE_GRABBER,
                                     empress_nr[dev->nr]);
@@ -399,7 +400,7 @@ static int empress_init(struct saa7134_dev *dev)
                             sizeof(struct saa7134_buf),
                             dev);
 
-        empress_signal_update(dev);
+        empress_signal_update(&dev->empress_workqueue);
         return 0;
 }