diff options
author | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-02-15 16:41:06 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-02-18 10:18:28 -0500 |
commit | 6165894fb6293072848e5699f3fcbe88b7c60815 (patch) | |
tree | e45c1c41a94683b25a3e7eb0250df836c92b8403 /drivers/media/video | |
parent | ea35e3a754b2ba5f712c3f4df55e426ae2e4d60a (diff) |
V4L/DVB (7219): zoran: Fix namespace conflicts with Zoran 'GPIO_MAX' enum
Thanks to Martin Michlmayr <tbm@cyrius.com> for reporting this issue:
The zoran driver fails to compile on the ARM Orion platform with:
In file included from drivers/media/video/zoran_procfs.c:50:
drivers/media/video/zoran.h:232: error: expected identifier before numeric
constant
The reason is that drivers/media/video/zoran.h defines an enum with
GPIO_MAX in it, but Orion contains a #define GPIO_MAX 32 in
include/asm-arm/arch-orion/orion.h
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video')
-rw-r--r-- | drivers/media/video/zoran.h | 22 | ||||
-rw-r--r-- | drivers/media/video/zoran_device.c | 12 |
2 files changed, 17 insertions, 17 deletions
diff --git a/drivers/media/video/zoran.h b/drivers/media/video/zoran.h index 937c4a616c0e..498a43c1f2b1 100644 --- a/drivers/media/video/zoran.h +++ b/drivers/media/video/zoran.h | |||
@@ -221,15 +221,15 @@ enum zoran_map_mode { | |||
221 | }; | 221 | }; |
222 | 222 | ||
223 | enum gpio_type { | 223 | enum gpio_type { |
224 | GPIO_JPEG_SLEEP = 0, | 224 | ZR_GPIO_JPEG_SLEEP = 0, |
225 | GPIO_JPEG_RESET, | 225 | ZR_GPIO_JPEG_RESET, |
226 | GPIO_JPEG_FRAME, | 226 | ZR_GPIO_JPEG_FRAME, |
227 | GPIO_VID_DIR, | 227 | ZR_GPIO_VID_DIR, |
228 | GPIO_VID_EN, | 228 | ZR_GPIO_VID_EN, |
229 | GPIO_VID_RESET, | 229 | ZR_GPIO_VID_RESET, |
230 | GPIO_CLK_SEL1, | 230 | ZR_GPIO_CLK_SEL1, |
231 | GPIO_CLK_SEL2, | 231 | ZR_GPIO_CLK_SEL2, |
232 | GPIO_MAX, | 232 | ZR_GPIO_MAX, |
233 | }; | 233 | }; |
234 | 234 | ||
235 | enum gpcs_type { | 235 | enum gpcs_type { |
@@ -378,11 +378,11 @@ struct card_info { | |||
378 | 378 | ||
379 | u32 jpeg_int; /* JPEG interrupt */ | 379 | u32 jpeg_int; /* JPEG interrupt */ |
380 | u32 vsync_int; /* VSYNC interrupt */ | 380 | u32 vsync_int; /* VSYNC interrupt */ |
381 | s8 gpio[GPIO_MAX]; | 381 | s8 gpio[ZR_GPIO_MAX]; |
382 | u8 gpcs[GPCS_MAX]; | 382 | u8 gpcs[GPCS_MAX]; |
383 | 383 | ||
384 | struct vfe_polarity vfe_pol; | 384 | struct vfe_polarity vfe_pol; |
385 | u8 gpio_pol[GPIO_MAX]; | 385 | u8 gpio_pol[ZR_GPIO_MAX]; |
386 | 386 | ||
387 | /* is the /GWS line conected? */ | 387 | /* is the /GWS line conected? */ |
388 | u8 gws_not_connected; | 388 | u8 gws_not_connected; |
diff --git a/drivers/media/video/zoran_device.c b/drivers/media/video/zoran_device.c index 68c7c505587e..f97c20692057 100644 --- a/drivers/media/video/zoran_device.c +++ b/drivers/media/video/zoran_device.c | |||
@@ -250,7 +250,7 @@ void | |||
250 | jpeg_codec_sleep (struct zoran *zr, | 250 | jpeg_codec_sleep (struct zoran *zr, |
251 | int sleep) | 251 | int sleep) |
252 | { | 252 | { |
253 | GPIO(zr, zr->card.gpio[GPIO_JPEG_SLEEP], !sleep); | 253 | GPIO(zr, zr->card.gpio[ZR_GPIO_JPEG_SLEEP], !sleep); |
254 | if (!sleep) { | 254 | if (!sleep) { |
255 | dprintk(3, | 255 | dprintk(3, |
256 | KERN_DEBUG | 256 | KERN_DEBUG |
@@ -277,9 +277,9 @@ jpeg_codec_reset (struct zoran *zr) | |||
277 | 0); | 277 | 0); |
278 | udelay(2); | 278 | udelay(2); |
279 | } else { | 279 | } else { |
280 | GPIO(zr, zr->card.gpio[GPIO_JPEG_RESET], 0); | 280 | GPIO(zr, zr->card.gpio[ZR_GPIO_JPEG_RESET], 0); |
281 | udelay(2); | 281 | udelay(2); |
282 | GPIO(zr, zr->card.gpio[GPIO_JPEG_RESET], 1); | 282 | GPIO(zr, zr->card.gpio[ZR_GPIO_JPEG_RESET], 1); |
283 | udelay(2); | 283 | udelay(2); |
284 | } | 284 | } |
285 | 285 | ||
@@ -688,7 +688,7 @@ static inline void | |||
688 | set_frame (struct zoran *zr, | 688 | set_frame (struct zoran *zr, |
689 | int val) | 689 | int val) |
690 | { | 690 | { |
691 | GPIO(zr, zr->card.gpio[GPIO_JPEG_FRAME], val); | 691 | GPIO(zr, zr->card.gpio[ZR_GPIO_JPEG_FRAME], val); |
692 | } | 692 | } |
693 | 693 | ||
694 | static void | 694 | static void |
@@ -704,8 +704,8 @@ set_videobus_dir (struct zoran *zr, | |||
704 | GPIO(zr, 5, 1); | 704 | GPIO(zr, 5, 1); |
705 | break; | 705 | break; |
706 | default: | 706 | default: |
707 | GPIO(zr, zr->card.gpio[GPIO_VID_DIR], | 707 | GPIO(zr, zr->card.gpio[ZR_GPIO_VID_DIR], |
708 | zr->card.gpio_pol[GPIO_VID_DIR] ? !val : val); | 708 | zr->card.gpio_pol[ZR_GPIO_VID_DIR] ? !val : val); |
709 | break; | 709 | break; |
710 | } | 710 | } |
711 | } | 711 | } |