diff options
author | Sachin Kamat <sachin.kamat@linaro.org> | 2012-07-26 01:23:32 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-08-13 21:10:57 -0400 |
commit | dc9c94cd339dc74b73ca7ef0943ea610d02f8e3e (patch) | |
tree | 8d73553452b0539795d845531573b4e890ddcdee /drivers/media/video | |
parent | b08deebebe13c73b35701d180a4689dfb34db519 (diff) |
[media] s5k6aa: Use devm_kzalloc function
devm_kzalloc() eliminates the need to free explicitly thereby
making the code a bit simpler.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video')
-rw-r--r-- | drivers/media/video/s5k6aa.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/media/video/s5k6aa.c b/drivers/media/video/s5k6aa.c index decb64808346..045ca7f4f6ca 100644 --- a/drivers/media/video/s5k6aa.c +++ b/drivers/media/video/s5k6aa.c | |||
@@ -1568,7 +1568,7 @@ static int s5k6aa_probe(struct i2c_client *client, | |||
1568 | return -EINVAL; | 1568 | return -EINVAL; |
1569 | } | 1569 | } |
1570 | 1570 | ||
1571 | s5k6aa = kzalloc(sizeof(*s5k6aa), GFP_KERNEL); | 1571 | s5k6aa = devm_kzalloc(&client->dev, sizeof(*s5k6aa), GFP_KERNEL); |
1572 | if (!s5k6aa) | 1572 | if (!s5k6aa) |
1573 | return -ENOMEM; | 1573 | return -ENOMEM; |
1574 | 1574 | ||
@@ -1592,7 +1592,7 @@ static int s5k6aa_probe(struct i2c_client *client, | |||
1592 | sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; | 1592 | sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; |
1593 | ret = media_entity_init(&sd->entity, 1, &s5k6aa->pad, 0); | 1593 | ret = media_entity_init(&sd->entity, 1, &s5k6aa->pad, 0); |
1594 | if (ret) | 1594 | if (ret) |
1595 | goto out_err1; | 1595 | return ret; |
1596 | 1596 | ||
1597 | ret = s5k6aa_configure_gpios(s5k6aa, pdata); | 1597 | ret = s5k6aa_configure_gpios(s5k6aa, pdata); |
1598 | if (ret) | 1598 | if (ret) |
@@ -1627,8 +1627,6 @@ out_err3: | |||
1627 | s5k6aa_free_gpios(s5k6aa); | 1627 | s5k6aa_free_gpios(s5k6aa); |
1628 | out_err2: | 1628 | out_err2: |
1629 | media_entity_cleanup(&s5k6aa->sd.entity); | 1629 | media_entity_cleanup(&s5k6aa->sd.entity); |
1630 | out_err1: | ||
1631 | kfree(s5k6aa); | ||
1632 | return ret; | 1630 | return ret; |
1633 | } | 1631 | } |
1634 | 1632 | ||
@@ -1642,7 +1640,6 @@ static int s5k6aa_remove(struct i2c_client *client) | |||
1642 | media_entity_cleanup(&sd->entity); | 1640 | media_entity_cleanup(&sd->entity); |
1643 | regulator_bulk_free(S5K6AA_NUM_SUPPLIES, s5k6aa->supplies); | 1641 | regulator_bulk_free(S5K6AA_NUM_SUPPLIES, s5k6aa->supplies); |
1644 | s5k6aa_free_gpios(s5k6aa); | 1642 | s5k6aa_free_gpios(s5k6aa); |
1645 | kfree(s5k6aa); | ||
1646 | 1643 | ||
1647 | return 0; | 1644 | return 0; |
1648 | } | 1645 | } |