diff options
author | Yoann Padioleau <padator@wanadoo.fr> | 2007-07-19 04:49:03 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-19 13:04:50 -0400 |
commit | dd00cc486ab1c17049a535413d1751ef3482141c (patch) | |
tree | d90ff69ea06792b9284f2f2665c96624f121b88a /drivers/media/video | |
parent | 3b5ad0797c0e4049001f961a8b58f1d0ce532072 (diff) |
some kmalloc/memset ->kzalloc (tree wide)
Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).
Here is a short excerpt of the semantic patch performing
this transformation:
@@
type T2;
expression x;
identifier f,fld;
expression E;
expression E1,E2;
expression e1,e2,e3,y;
statement S;
@@
x =
- kmalloc
+ kzalloc
(E1,E2)
... when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
- memset((T2)x,0,E1);
@@
expression E1,E2,E3;
@@
- kzalloc(E1 * E2,E3)
+ kcalloc(E1,E2,E3)
[akpm@linux-foundation.org: get kcalloc args the right way around]
Signed-off-by: Yoann Padioleau <padator@wanadoo.fr>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Acked-by: Russell King <rmk@arm.linux.org.uk>
Cc: Bryan Wu <bryan.wu@analog.com>
Acked-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Dave Airlie <airlied@linux.ie>
Acked-by: Roland Dreier <rolandd@cisco.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Acked-by: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: "David S. Miller" <davem@davemloft.net>
Acked-by: Greg KH <greg@kroah.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/media/video')
-rw-r--r-- | drivers/media/video/cpia2/cpia2_core.c | 4 | ||||
-rw-r--r-- | drivers/media/video/msp3400-driver.c | 3 | ||||
-rw-r--r-- | drivers/media/video/planb.c | 3 | ||||
-rw-r--r-- | drivers/media/video/usbvideo/vicam.c | 3 |
4 files changed, 4 insertions, 9 deletions
diff --git a/drivers/media/video/cpia2/cpia2_core.c b/drivers/media/video/cpia2/cpia2_core.c index 55aab8d38880..a76bd786cf13 100644 --- a/drivers/media/video/cpia2/cpia2_core.c +++ b/drivers/media/video/cpia2/cpia2_core.c | |||
@@ -2224,15 +2224,13 @@ struct camera_data *cpia2_init_camera_struct(void) | |||
2224 | { | 2224 | { |
2225 | struct camera_data *cam; | 2225 | struct camera_data *cam; |
2226 | 2226 | ||
2227 | cam = kmalloc(sizeof(*cam), GFP_KERNEL); | 2227 | cam = kzalloc(sizeof(*cam), GFP_KERNEL); |
2228 | 2228 | ||
2229 | if (!cam) { | 2229 | if (!cam) { |
2230 | ERR("couldn't kmalloc cpia2 struct\n"); | 2230 | ERR("couldn't kmalloc cpia2 struct\n"); |
2231 | return NULL; | 2231 | return NULL; |
2232 | } | 2232 | } |
2233 | 2233 | ||
2234 | /* Default everything to 0 */ | ||
2235 | memset(cam, 0, sizeof(struct camera_data)); | ||
2236 | 2234 | ||
2237 | cam->present = 1; | 2235 | cam->present = 1; |
2238 | mutex_init(&cam->busy_lock); | 2236 | mutex_init(&cam->busy_lock); |
diff --git a/drivers/media/video/msp3400-driver.c b/drivers/media/video/msp3400-driver.c index 507b1d4260ed..11cfcf18ec34 100644 --- a/drivers/media/video/msp3400-driver.c +++ b/drivers/media/video/msp3400-driver.c | |||
@@ -812,10 +812,9 @@ static int msp_attach(struct i2c_adapter *adapter, int address, int kind) | |||
812 | int msp_product, msp_prod_hi, msp_prod_lo; | 812 | int msp_product, msp_prod_hi, msp_prod_lo; |
813 | int msp_rom; | 813 | int msp_rom; |
814 | 814 | ||
815 | client = kmalloc(sizeof(*client), GFP_KERNEL); | 815 | client = kzalloc(sizeof(*client), GFP_KERNEL); |
816 | if (client == NULL) | 816 | if (client == NULL) |
817 | return -ENOMEM; | 817 | return -ENOMEM; |
818 | memset(client, 0, sizeof(*client)); | ||
819 | client->addr = address; | 818 | client->addr = address; |
820 | client->adapter = adapter; | 819 | client->adapter = adapter; |
821 | client->driver = &i2c_driver; | 820 | client->driver = &i2c_driver; |
diff --git a/drivers/media/video/planb.c b/drivers/media/video/planb.c index 1455a8f4e930..4ab1af74a970 100644 --- a/drivers/media/video/planb.c +++ b/drivers/media/video/planb.c | |||
@@ -353,9 +353,8 @@ static int planb_prepare_open(struct planb *pb) | |||
353 | * PLANB_DUMMY)*sizeof(struct dbdma_cmd) | 353 | * PLANB_DUMMY)*sizeof(struct dbdma_cmd) |
354 | +(PLANB_MAXLINES*((PLANB_MAXPIXELS+7)& ~7))/8 | 354 | +(PLANB_MAXLINES*((PLANB_MAXPIXELS+7)& ~7))/8 |
355 | +MAX_GBUFFERS*sizeof(unsigned int); | 355 | +MAX_GBUFFERS*sizeof(unsigned int); |
356 | if ((pb->priv_space = kmalloc (size, GFP_KERNEL)) == 0) | 356 | if ((pb->priv_space = kzalloc (size, GFP_KERNEL)) == 0) |
357 | return -ENOMEM; | 357 | return -ENOMEM; |
358 | memset ((void *) pb->priv_space, 0, size); | ||
359 | pb->overlay_last1 = pb->ch1_cmd = (volatile struct dbdma_cmd *) | 358 | pb->overlay_last1 = pb->ch1_cmd = (volatile struct dbdma_cmd *) |
360 | DBDMA_ALIGN (pb->priv_space); | 359 | DBDMA_ALIGN (pb->priv_space); |
361 | pb->overlay_last2 = pb->ch2_cmd = pb->ch1_cmd + pb->tab_size; | 360 | pb->overlay_last2 = pb->ch2_cmd = pb->ch1_cmd + pb->tab_size; |
diff --git a/drivers/media/video/usbvideo/vicam.c b/drivers/media/video/usbvideo/vicam.c index 2d9c0dd3b733..ff555129c82f 100644 --- a/drivers/media/video/usbvideo/vicam.c +++ b/drivers/media/video/usbvideo/vicam.c | |||
@@ -1130,13 +1130,12 @@ vicam_probe( struct usb_interface *intf, const struct usb_device_id *id) | |||
1130 | } | 1130 | } |
1131 | 1131 | ||
1132 | if ((cam = | 1132 | if ((cam = |
1133 | kmalloc(sizeof (struct vicam_camera), GFP_KERNEL)) == NULL) { | 1133 | kzalloc(sizeof (struct vicam_camera), GFP_KERNEL)) == NULL) { |
1134 | printk(KERN_WARNING | 1134 | printk(KERN_WARNING |
1135 | "could not allocate kernel memory for vicam_camera struct\n"); | 1135 | "could not allocate kernel memory for vicam_camera struct\n"); |
1136 | return -ENOMEM; | 1136 | return -ENOMEM; |
1137 | } | 1137 | } |
1138 | 1138 | ||
1139 | memset(cam, 0, sizeof (struct vicam_camera)); | ||
1140 | 1139 | ||
1141 | cam->shutter_speed = 15; | 1140 | cam->shutter_speed = 15; |
1142 | 1141 | ||