aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video
diff options
context:
space:
mode:
authorGuennadi Liakhovetski <g.liakhovetski@gmx.de>2009-04-24 11:53:51 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2009-06-16 17:20:43 -0400
commit594bb46dbc63934bc65fa95743f83204bd26a641 (patch)
tree7901c5c70a18777d74276784219848b4e32abb80 /drivers/media/video
parent84d728c3df9931d1937e4a76324838ce065c521e (diff)
V4L/DVB (11607): soc-camera: add a free_bus method to struct soc_camera_link
Currently pcm990 camera bus-width management functions request a GPIO and never free it again. With this approach the GPIO extender driver cannot be unloaded once camera drivers have been loaded, also unloading theb i2c-pxa bus driver produces errors, because the GPIO extender driver cannot unregister properly. Another problem is, that if camera drivers are once loaded before the GPIO extender driver, the platform code marks the GPIO unavailable and only a reboot helps to recover. Adding an explicit free_bus method and using it in mt9m001 and mt9v022 drivers fixes these problems. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Acked-by: Eric Miao <eric.miao@marvell.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video')
-rw-r--r--drivers/media/video/mt9m001.c3
-rw-r--r--drivers/media/video/mt9v022.c3
2 files changed, 6 insertions, 0 deletions
diff --git a/drivers/media/video/mt9m001.c b/drivers/media/video/mt9m001.c
index 684f62fa7897..3838ff77381b 100644
--- a/drivers/media/video/mt9m001.c
+++ b/drivers/media/video/mt9m001.c
@@ -604,10 +604,13 @@ ei2c:
604static void mt9m001_video_remove(struct soc_camera_device *icd) 604static void mt9m001_video_remove(struct soc_camera_device *icd)
605{ 605{
606 struct mt9m001 *mt9m001 = container_of(icd, struct mt9m001, icd); 606 struct mt9m001 *mt9m001 = container_of(icd, struct mt9m001, icd);
607 struct soc_camera_link *icl = mt9m001->client->dev.platform_data;
607 608
608 dev_dbg(&icd->dev, "Video %x removed: %p, %p\n", mt9m001->client->addr, 609 dev_dbg(&icd->dev, "Video %x removed: %p, %p\n", mt9m001->client->addr,
609 icd->dev.parent, icd->vdev); 610 icd->dev.parent, icd->vdev);
610 soc_camera_video_stop(icd); 611 soc_camera_video_stop(icd);
612 if (icl->free_bus)
613 icl->free_bus(icl);
611} 614}
612 615
613static int mt9m001_probe(struct i2c_client *client, 616static int mt9m001_probe(struct i2c_client *client,
diff --git a/drivers/media/video/mt9v022.c b/drivers/media/video/mt9v022.c
index 4d3b4813c322..412b399baca4 100644
--- a/drivers/media/video/mt9v022.c
+++ b/drivers/media/video/mt9v022.c
@@ -735,10 +735,13 @@ ei2c:
735static void mt9v022_video_remove(struct soc_camera_device *icd) 735static void mt9v022_video_remove(struct soc_camera_device *icd)
736{ 736{
737 struct mt9v022 *mt9v022 = container_of(icd, struct mt9v022, icd); 737 struct mt9v022 *mt9v022 = container_of(icd, struct mt9v022, icd);
738 struct soc_camera_link *icl = mt9v022->client->dev.platform_data;
738 739
739 dev_dbg(&icd->dev, "Video %x removed: %p, %p\n", mt9v022->client->addr, 740 dev_dbg(&icd->dev, "Video %x removed: %p, %p\n", mt9v022->client->addr,
740 icd->dev.parent, icd->vdev); 741 icd->dev.parent, icd->vdev);
741 soc_camera_video_stop(icd); 742 soc_camera_video_stop(icd);
743 if (icl->free_bus)
744 icl->free_bus(icl);
742} 745}
743 746
744static int mt9v022_probe(struct i2c_client *client, 747static int mt9v022_probe(struct i2c_client *client,