diff options
author | Mauro Carvalho Chehab <mchehab@infradead.org> | 2007-01-14 06:33:24 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2007-02-21 10:34:21 -0500 |
commit | 0b600512860cab5a0bb4647f5f726a91bce2633c (patch) | |
tree | 5529e311a32d5581c6fc152d7eab1c4b9768b5d2 /drivers/media/video/vivi.c | |
parent | df3a710458462aa9427cdeec947bf71af257e8dd (diff) |
V4L/DVB (5074): Some fixes at stream waitqueue on vivi
There are several potential troubles on vivi waitqueue code:
- Watchdog timer should be reset at every received frame;
- Watchdog timer should be reset at the beginning of vivi_thread();
- Checks for errors when creating a newer thread with kernel_thread();
- Wake up vivi_thread() after creating it.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video/vivi.c')
-rw-r--r-- | drivers/media/video/vivi.c | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index 119cfd5ce312..178441922738 100644 --- a/drivers/media/video/vivi.c +++ b/drivers/media/video/vivi.c | |||
@@ -471,11 +471,12 @@ static void vivi_thread_tick(struct vivi_dmaqueue *dma_q) | |||
471 | 471 | ||
472 | /* Fill buffer */ | 472 | /* Fill buffer */ |
473 | vivi_fillbuff(dev,buf); | 473 | vivi_fillbuff(dev,buf); |
474 | } | 474 | |
475 | if (list_empty(&dma_q->active)) { | 475 | if (list_empty(&dma_q->active)) { |
476 | del_timer(&dma_q->timeout); | 476 | del_timer(&dma_q->timeout); |
477 | } else { | 477 | } else { |
478 | mod_timer(&dma_q->timeout, jiffies+BUFFER_TIMEOUT); | 478 | mod_timer(&dma_q->timeout, jiffies+BUFFER_TIMEOUT); |
479 | } | ||
479 | } | 480 | } |
480 | if (bc != 1) | 481 | if (bc != 1) |
481 | dprintk(1,"%s: %d buffers handled (should be 1)\n",__FUNCTION__,bc); | 482 | dprintk(1,"%s: %d buffers handled (should be 1)\n",__FUNCTION__,bc); |
@@ -522,6 +523,8 @@ static int vivi_thread(void *data) | |||
522 | 523 | ||
523 | dprintk(1,"thread started\n"); | 524 | dprintk(1,"thread started\n"); |
524 | 525 | ||
526 | mod_timer(&dma_q->timeout, jiffies+BUFFER_TIMEOUT); | ||
527 | |||
525 | for (;;) { | 528 | for (;;) { |
526 | vivi_sleep(dma_q); | 529 | vivi_sleep(dma_q); |
527 | 530 | ||
@@ -545,6 +548,9 @@ static int vivi_start_thread(struct vivi_dmaqueue *dma_q) | |||
545 | printk(KERN_ERR "vivi: kernel_thread() failed\n"); | 548 | printk(KERN_ERR "vivi: kernel_thread() failed\n"); |
546 | return PTR_ERR(dma_q->kthread); | 549 | return PTR_ERR(dma_q->kthread); |
547 | } | 550 | } |
551 | /* Wakes thread */ | ||
552 | wake_up_interruptible(&dma_q->wq); | ||
553 | |||
548 | dprintk(1,"returning from %s\n",__FUNCTION__); | 554 | dprintk(1,"returning from %s\n",__FUNCTION__); |
549 | return 0; | 555 | return 0; |
550 | } | 556 | } |